Re: Review Request 70453: HIVE-21584 Java 11 preparation: system class loader is not URLClassLoader

2019-04-23 Thread Zoltan Matyus via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70453/
---

(Updated April 23, 2019, 9:51 a.m.)


Review request for hive, Zoltan Haindrich, Laszlo Pinter, and Adam Szita.


Changes
---

Addressed review comments.


Bugs: HIVE-21584
https://issues.apache.org/jira/browse/HIVE-21584


Repository: hive-git


Description
---

HIVE-21584 Java 11 preparation: system class loader is not URLClassLoader


Diffs (updated)
-

  beeline/src/java/org/apache/hive/beeline/Commands.java 
f4dd586e1127e3dad56de856b91ba00a0f777ac2 
  common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 
c011cd1626d608d5a3c8c950eddf96b46473d796 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/FunctionLocalizer.java
 2a6ef3a2461fb4e4331da678ac8521135f304018 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AddToClassPathAction.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
36bc08f34e0aa24af68377181ccfb91c8635ddc5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 
01dd93c5273caed17931d057e6d844ce17a511c5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java 
91868a46670f2f27dcd8f944df7c1cfca2faff32 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java 
e106bc9149832d8e7b1f0ecf5a9c0fdc172c7413 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java 
f7ea212cfb9f0f1c2eb1895223fba147acd18cb8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/RecordProcessor.java 
0ec7a04ce7a219f3a48a38f16d4626e8f2fc87b3 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 
de5cd8b992c1d1fcc52611484cd6aa787c469bee 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestAddToClassPathAction.java 
PRE-CREATION 
  
spark-client/src/main/java/org/apache/hive/spark/client/SparkClientUtilities.java
 b434d8f7b7a3b585183cd842bd9893d00a85da1b 
  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
 0642b39f58966b15d07e4163900919f1fad360cb 


Diff: https://reviews.apache.org/r/70453/diff/2/

Changes: https://reviews.apache.org/r/70453/diff/1-2/


Testing (updated)
---

Patches 6 and 7 of 
[HIVE-21584](https://issues.apache.org/jira/browse/HIVE-21584) are identical to 
each other and to this review. They both contain test failures, but different 
ones and unrelated to this change. (Patch 6 has only one.)


Thanks,

Zoltan Matyus

Re: Review Request 70453: HIVE-21584 Java 11 preparation: system class loader is not URLClassLoader

2019-04-12 Thread Adam Szita via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70453/#review214635
---




ql/src/java/org/apache/hadoop/hive/ql/exec/AddToClassPathAction.java
Lines 31 (patched)


do the _same_ vs do the _save_



ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
Lines 2104 (patched)


Is it an expected scenario? Should we log a warning in this case or even 
throw an Exception instead?



ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java
Lines 81 (patched)


Can we refactor this method into a public static method in hive-common or 
even inside ql (within a utility class or something) as it is repeated 3 times.


- Adam Szita


On April 12, 2019, 9:50 a.m., Zoltan Matyus wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70453/
> ---
> 
> (Updated April 12, 2019, 9:50 a.m.)
> 
> 
> Review request for hive, Zoltan Haindrich, Laszlo Pinter, and Adam Szita.
> 
> 
> Bugs: HIVE-21584
> https://issues.apache.org/jira/browse/HIVE-21584
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-21584 Java 11 preparation: system class loader is not URLClassLoader
> 
> 
> Diffs
> -
> 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 
> f4dd586e1127e3dad56de856b91ba00a0f777ac2 
>   common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 
> c011cd1626d608d5a3c8c950eddf96b46473d796 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/FunctionLocalizer.java
>  2a6ef3a2461fb4e4331da678ac8521135f304018 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/AddToClassPathAction.java 
> PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
> 36bc08f34e0aa24af68377181ccfb91c8635ddc5 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 
> 01dd93c5273caed17931d057e6d844ce17a511c5 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java 
> 91868a46670f2f27dcd8f944df7c1cfca2faff32 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java 
> e106bc9149832d8e7b1f0ecf5a9c0fdc172c7413 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java 
> f7ea212cfb9f0f1c2eb1895223fba147acd18cb8 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/RecordProcessor.java 
> 0ec7a04ce7a219f3a48a38f16d4626e8f2fc87b3 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 
> de5cd8b992c1d1fcc52611484cd6aa787c469bee 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestAddToClassPathAction.java 
> PRE-CREATION 
>   
> spark-client/src/main/java/org/apache/hive/spark/client/SparkClientUtilities.java
>  b434d8f7b7a3b585183cd842bd9893d00a85da1b 
>   
> standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
>  0642b39f58966b15d07e4163900919f1fad360cb 
> 
> 
> Diff: https://reviews.apache.org/r/70453/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zoltan Matyus
> 
>

Review Request 70453: HIVE-21584 Java 11 preparation: system class loader is not URLClassLoader

2019-04-11 Thread Zoltan Matyus via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70453/
---

Review request for hive.


Bugs: HIVE-21584
https://issues.apache.org/jira/browse/HIVE-21584


Repository: hive-git


Description
---

HIVE-21584 Java 11 preparation: system class loader is not URLClassLoader


Diffs
-

  beeline/src/java/org/apache/hive/beeline/Commands.java 
f4dd586e1127e3dad56de856b91ba00a0f777ac2 
  common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 
c011cd1626d608d5a3c8c950eddf96b46473d796 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/FunctionLocalizer.java
 2a6ef3a2461fb4e4331da678ac8521135f304018 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AddToClassPathAction.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
36bc08f34e0aa24af68377181ccfb91c8635ddc5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 
01dd93c5273caed17931d057e6d844ce17a511c5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecMapper.java 
91868a46670f2f27dcd8f944df7c1cfca2faff32 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java 
e106bc9149832d8e7b1f0ecf5a9c0fdc172c7413 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkRecordHandler.java 
f7ea212cfb9f0f1c2eb1895223fba147acd18cb8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/RecordProcessor.java 
0ec7a04ce7a219f3a48a38f16d4626e8f2fc87b3 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 
de5cd8b992c1d1fcc52611484cd6aa787c469bee 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestAddToClassPathAction.java 
PRE-CREATION 
  
spark-client/src/main/java/org/apache/hive/spark/client/SparkClientUtilities.java
 b434d8f7b7a3b585183cd842bd9893d00a85da1b 
  
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
 0642b39f58966b15d07e4163900919f1fad360cb 


Diff: https://reviews.apache.org/r/70453/diff/1/


Testing
---


Thanks,

Zoltan Matyus