Re: Review Request 71011: HIVE:21957: Create temporary table like should omit transactional properties.

2019-07-25 Thread Marta Kuczora via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71011/#review216850
---


Ship it!




Ship It!

- Marta Kuczora


On July 4, 2019, 1:52 p.m., Laszlo Pinter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71011/
> ---
> 
> (Updated July 4, 2019, 1:52 p.m.)
> 
> 
> Review request for hive, Marta Kuczora and Thejas Nair.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE:21957: Create temporary table like should omit transactional properties.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> e09fc379f5e0127367e73ed4c4556522de9838a8 
> 
> 
> Diff: https://reviews.apache.org/r/71011/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Laszlo Pinter
> 
>



Re: Review Request 71011: HIVE:21957: Create temporary table like should omit transactional properties.

2019-07-25 Thread Marta Kuczora via Review Board


> On July 18, 2019, noon, Marta Kuczora wrote:
> > Thanks a lot for the patch!
> > Just one question: could you add a test about the fixed use-case?
> 
> Laszlo Pinter wrote:
> I will add test in a separate patch.

Ok, thanks!


- Marta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71011/#review216720
---


On July 4, 2019, 1:52 p.m., Laszlo Pinter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71011/
> ---
> 
> (Updated July 4, 2019, 1:52 p.m.)
> 
> 
> Review request for hive, Marta Kuczora and Thejas Nair.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE:21957: Create temporary table like should omit transactional properties.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> e09fc379f5e0127367e73ed4c4556522de9838a8 
> 
> 
> Diff: https://reviews.apache.org/r/71011/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Laszlo Pinter
> 
>



Re: Review Request 71011: HIVE:21957: Create temporary table like should omit transactional properties.

2019-07-25 Thread Laszlo Pinter via Review Board


> On July 18, 2019, noon, Marta Kuczora wrote:
> > Thanks a lot for the patch!
> > Just one question: could you add a test about the fixed use-case?

I will add test in a separate patch.


- Laszlo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71011/#review216720
---


On July 4, 2019, 1:52 p.m., Laszlo Pinter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71011/
> ---
> 
> (Updated July 4, 2019, 1:52 p.m.)
> 
> 
> Review request for hive, Marta Kuczora and Thejas Nair.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE:21957: Create temporary table like should omit transactional properties.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> e09fc379f5e0127367e73ed4c4556522de9838a8 
> 
> 
> Diff: https://reviews.apache.org/r/71011/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Laszlo Pinter
> 
>



Re: Review Request 71011: HIVE:21957: Create temporary table like should omit transactional properties.

2019-07-18 Thread Marta Kuczora via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71011/#review216720
---



Thanks a lot for the patch!
Just one question: could you add a test about the fixed use-case?

- Marta Kuczora


On July 4, 2019, 1:52 p.m., Laszlo Pinter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71011/
> ---
> 
> (Updated July 4, 2019, 1:52 p.m.)
> 
> 
> Review request for hive, Marta Kuczora and Thejas Nair.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE:21957: Create temporary table like should omit transactional properties.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> e09fc379f5e0127367e73ed4c4556522de9838a8 
> 
> 
> Diff: https://reviews.apache.org/r/71011/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Laszlo Pinter
> 
>



Review Request 71011: HIVE:21957: Create temporary table like should omit transactional properties.

2019-07-04 Thread Laszlo Pinter via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71011/
---

Review request for hive, Marta Kuczora and Thejas Nair.


Repository: hive-git


Description
---

HIVE:21957: Create temporary table like should omit transactional properties.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
e09fc379f5e0127367e73ed4c4556522de9838a8 


Diff: https://reviews.apache.org/r/71011/diff/1/


Testing
---


Thanks,

Laszlo Pinter