Re: Review Request 72081: HIVE-22805 Vectorization with conditional array or map is not implemented and throws an error

2020-02-04 Thread Ramesh Kumar Thangarajan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72081/#review219493
---


Ship it!




Looks good to me.

- Ramesh Kumar Thangarajan


On Feb. 4, 2020, 11:25 a.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72081/
> ---
> 
> (Updated Feb. 4, 2020, 11:25 a.m.)
> 
> 
> Review request for hive and Ramesh Kumar Thangarajan.
> 
> 
> Bugs: HIVE-22805
> https://issues.apache.org/jira/browse/HIVE-22805
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Implemented the copySelected and shallowCopyTo methods
> 
> 
> Diffs
> -
> 
>   ql/src/test/queries/clientpositive/vectorization_multi_value.q PRE-CREATION 
>   ql/src/test/results/clientpositive/vectorization_multi_value.q.out 
> PRE-CREATION 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/ListColumnVector.java
>  8cbcc029a5 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/MapColumnVector.java
>  3143a44ec8 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/MultiValuedColumnVector.java
>  028084cfc7 
> 
> 
> Diff: https://reviews.apache.org/r/72081/diff/1/
> 
> 
> Testing
> ---
> 
> query tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>



Review Request 72081: HIVE-22805 Vectorization with conditional array or map is not implemented and throws an error

2020-02-04 Thread Peter Vary via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72081/
---

Review request for hive and Ramesh Kumar Thangarajan.


Bugs: HIVE-22805
https://issues.apache.org/jira/browse/HIVE-22805


Repository: hive-git


Description
---

Implemented the copySelected and shallowCopyTo methods


Diffs
-

  ql/src/test/queries/clientpositive/vectorization_multi_value.q PRE-CREATION 
  ql/src/test/results/clientpositive/vectorization_multi_value.q.out 
PRE-CREATION 
  
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/ListColumnVector.java
 8cbcc029a5 
  
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/MapColumnVector.java 
3143a44ec8 
  
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/MultiValuedColumnVector.java
 028084cfc7 


Diff: https://reviews.apache.org/r/72081/diff/1/


Testing
---

query tests


Thanks,

Peter Vary