Re: Review Request 72113: DML execution on TEZ always outputs the message 'No rows affected'
> On Feb. 14, 2020, 3:23 p.m., Panos Garefalakis wrote: > > +1 from me as well > > As discussed the extra 0s in the query out are caused by the > > counters.findCounter() that initializes an empty counter when reading a non > > existent counter -- then all HIVE_COUNTERS are printed by > > PostExecTezSummaryPrinter > > Laszlo Bodor wrote: > I like this patch, and I would be happy to see a simple unit test (which > would be an integration test actually) which is about doing a simple update > and checking the improved output, I believe we have similar unit tests already +1 with the new testcase (which fails without the patch for me locally, LGTM) - Laszlo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72113/#review219591 --- On Feb. 13, 2020, 3:40 p.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72113/ > --- > > (Updated Feb. 13, 2020, 3:40 p.m.) > > > Review request for hive, Laszlo Bodor, Mustafa Iman, Panos Garefalakis, and > Ramesh Kumar Thangarajan. > > > Bugs: HIVE-22870 > https://issues.apache.org/jira/browse/HIVE-22870 > > > Repository: hive-git > > > Description > --- > > Executing an update or insert statement in beeline doesn't show the actual > rows inserted/updated. > > > Diffs > - > > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java > 04dd0ddad2e > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 25dd970a9b1 > ql/src/test/results/clientpositive/llap/orc_llap_counters.q.out 9c5695ae603 > ql/src/test/results/clientpositive/llap/orc_llap_counters1.q.out > f9b5f8f0d4d > ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out 9ad0a9b7faf > ql/src/test/results/clientpositive/llap/orc_ppd_schema_evol_3a.q.out > 3e99e0ee627 > ql/src/test/results/clientpositive/llap/retry_failure_reorder.q.out > baeac434d79 > ql/src/test/results/clientpositive/llap/tez_input_counters.q.out > 885cb0a9cba > > > Diff: https://reviews.apache.org/r/72113/diff/3/ > > > Testing > --- > > with insert and updates > > > Thanks, > > Attila Magyar > >
Re: Review Request 72113: DML execution on TEZ always outputs the message 'No rows affected'
> On Feb. 14, 2020, 3:23 p.m., Panos Garefalakis wrote: > > +1 from me as well > > As discussed the extra 0s in the query out are caused by the > > counters.findCounter() that initializes an empty counter when reading a non > > existent counter -- then all HIVE_COUNTERS are printed by > > PostExecTezSummaryPrinter I like this patch, and I would be happy to see a simple unit test (which would be an integration test actually) which is about doing a simple update and checking the improved output, I believe we have similar unit tests already - Laszlo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72113/#review219591 --- On Feb. 13, 2020, 3:40 p.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72113/ > --- > > (Updated Feb. 13, 2020, 3:40 p.m.) > > > Review request for hive, Laszlo Bodor, Mustafa Iman, Panos Garefalakis, and > Ramesh Kumar Thangarajan. > > > Bugs: HIVE-22870 > https://issues.apache.org/jira/browse/HIVE-22870 > > > Repository: hive-git > > > Description > --- > > Executing an update or insert statement in beeline doesn't show the actual > rows inserted/updated. > > > Diffs > - > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 25dd970a9b1 > ql/src/test/results/clientpositive/llap/orc_llap_counters.q.out 9c5695ae603 > ql/src/test/results/clientpositive/llap/orc_llap_counters1.q.out > f9b5f8f0d4d > ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out 9ad0a9b7faf > ql/src/test/results/clientpositive/llap/orc_ppd_schema_evol_3a.q.out > 3e99e0ee627 > ql/src/test/results/clientpositive/llap/retry_failure_reorder.q.out > baeac434d79 > ql/src/test/results/clientpositive/llap/tez_input_counters.q.out > 885cb0a9cba > > > Diff: https://reviews.apache.org/r/72113/diff/2/ > > > Testing > --- > > with insert and updates > > > Thanks, > > Attila Magyar > >
Re: Review Request 72113: DML execution on TEZ always outputs the message 'No rows affected'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72113/#review219591 --- Ship it! +1 from me as well As discussed the extra 0s in the query out are caused by the counters.findCounter() that initializes an empty counter when reading a non existent counter -- then all HIVE_COUNTERS are printed by PostExecTezSummaryPrinter - Panos Garefalakis On Feb. 13, 2020, 3:40 p.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72113/ > --- > > (Updated Feb. 13, 2020, 3:40 p.m.) > > > Review request for hive, Laszlo Bodor, Mustafa Iman, Panos Garefalakis, and > Ramesh Kumar Thangarajan. > > > Bugs: HIVE-22870 > https://issues.apache.org/jira/browse/HIVE-22870 > > > Repository: hive-git > > > Description > --- > > Executing an update or insert statement in beeline doesn't show the actual > rows inserted/updated. > > > Diffs > - > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 25dd970a9b1 > ql/src/test/results/clientpositive/llap/orc_llap_counters.q.out 9c5695ae603 > ql/src/test/results/clientpositive/llap/orc_llap_counters1.q.out > f9b5f8f0d4d > ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out 9ad0a9b7faf > ql/src/test/results/clientpositive/llap/orc_ppd_schema_evol_3a.q.out > 3e99e0ee627 > ql/src/test/results/clientpositive/llap/retry_failure_reorder.q.out > baeac434d79 > ql/src/test/results/clientpositive/llap/tez_input_counters.q.out > 885cb0a9cba > > > Diff: https://reviews.apache.org/r/72113/diff/2/ > > > Testing > --- > > with insert and updates > > > Thanks, > > Attila Magyar > >
Re: Review Request 72113: DML execution on TEZ always outputs the message 'No rows affected'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72113/ --- (Updated Feb. 13, 2020, 3:40 p.m.) Review request for hive, Laszlo Bodor, Mustafa Iman, Panos Garefalakis, and Ramesh Kumar Thangarajan. Bugs: HIVE-22870 https://issues.apache.org/jira/browse/HIVE-22870 Repository: hive-git Description --- Executing an update or insert statement in beeline doesn't show the actual rows inserted/updated. Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 25dd970a9b1 ql/src/test/results/clientpositive/llap/orc_llap_counters.q.out 9c5695ae603 ql/src/test/results/clientpositive/llap/orc_llap_counters1.q.out f9b5f8f0d4d ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out 9ad0a9b7faf ql/src/test/results/clientpositive/llap/orc_ppd_schema_evol_3a.q.out 3e99e0ee627 ql/src/test/results/clientpositive/llap/retry_failure_reorder.q.out baeac434d79 ql/src/test/results/clientpositive/llap/tez_input_counters.q.out 885cb0a9cba Diff: https://reviews.apache.org/r/72113/diff/2/ Changes: https://reviews.apache.org/r/72113/diff/1-2/ Testing --- with insert and updates Thanks, Attila Magyar
Re: Review Request 72113: DML execution on TEZ always outputs the message 'No rows affected'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72113/#review219553 --- +1 - Mustafa Iman On Feb. 11, 2020, 8:01 a.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72113/ > --- > > (Updated Feb. 11, 2020, 8:01 a.m.) > > > Review request for hive, Laszlo Bodor, Mustafa Iman, Panos Garefalakis, and > Ramesh Kumar Thangarajan. > > > Bugs: HIVE-22870 > https://issues.apache.org/jira/browse/HIVE-22870 > > > Repository: hive-git > > > Description > --- > > Executing an update or insert statement in beeline doesn't show the actual > rows inserted/updated. > > > Diffs > - > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 25dd970a9b1 > > > Diff: https://reviews.apache.org/r/72113/diff/1/ > > > Testing > --- > > with insert and updates > > > Thanks, > > Attila Magyar > >
Review Request 72113: DML execution on TEZ always outputs the message 'No rows affected'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72113/ --- Review request for hive, Laszlo Bodor, Mustafa Iman, Panos Garefalakis, and Ramesh Kumar Thangarajan. Bugs: HIVE-22870 https://issues.apache.org/jira/browse/HIVE-22870 Repository: hive-git Description --- Executing an update or insert statement in beeline doesn't show the actual rows inserted/updated. Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java 25dd970a9b1 Diff: https://reviews.apache.org/r/72113/diff/1/ Testing --- with insert and updates Thanks, Attila Magyar
