Re: Why isn't itests/ listed as submodule of root pom.xml?

2014-03-14 Thread Navis류승우
Should we write this on wiki? :)

2014-03-12 8:46 GMT+09:00 Brock Noland br...@cloudera.com:
 Hopefully this is the last time I have to say this :)

 The qfile tests in itests require the packaging phase. The maven test phase
 is after compile and before packaging. We could change the qfile tests to
 run during the integration-test phase using the failsafe plugin but the
 failsafe plugin is different than surefire and IMO is hard to use.

 If you'd like to give that a try, by all means, go ahead.


 On Tue, Mar 11, 2014 at 6:37 PM, Jason Dere jd...@hortonworks.com wrote:

 Noticed this since internally we set the version number to something
 different than simply 0.13.0, and mvn version:set doesn't really work
 correctly with itests because itests isn't listed as one of the root POM's
 submodules.  Is there a particular reason for it not being listed as a
 submodule when the mavenization was done?

 Having it as a submodule also allows you to run the qfile tests from root
 directory, so we could simplify the instructions for testing.

 Jason
 --
 CONFIDENTIALITY NOTICE
 NOTICE: This message is intended for the use of the individual or entity to
 which it is addressed and may contain information that is confidential,
 privileged and exempt from disclosure under applicable law. If the reader
 of this message is not the intended recipient, you are hereby notified that
 any printing, copying, dissemination, distribution, disclosure or
 forwarding of this communication is strictly prohibited. If you have
 received this communication in error, please contact the sender immediately
 and delete it from your system. Thank You.



Re: Why isn't itests/ listed as submodule of root pom.xml?

2014-03-14 Thread Brock Noland
Good idea:

https://cwiki.apache.org/confluence/display/Hive/HiveDeveloperFAQ#HiveDeveloperFAQ-Whyisn'ttheitestspomconnectedtotherootpom
?


On Fri, Mar 14, 2014 at 3:58 AM, Navis류승우 navis@nexr.com wrote:

 Should we write this on wiki? :)

 2014-03-12 8:46 GMT+09:00 Brock Noland br...@cloudera.com:
  Hopefully this is the last time I have to say this :)
 
  The qfile tests in itests require the packaging phase. The maven test
 phase
  is after compile and before packaging. We could change the qfile tests to
  run during the integration-test phase using the failsafe plugin but the
  failsafe plugin is different than surefire and IMO is hard to use.
 
  If you'd like to give that a try, by all means, go ahead.
 
 
  On Tue, Mar 11, 2014 at 6:37 PM, Jason Dere jd...@hortonworks.com
 wrote:
 
  Noticed this since internally we set the version number to something
  different than simply 0.13.0, and mvn version:set doesn't really work
  correctly with itests because itests isn't listed as one of the root
 POM's
  submodules.  Is there a particular reason for it not being listed as a
  submodule when the mavenization was done?
 
  Having it as a submodule also allows you to run the qfile tests from
 root
  directory, so we could simplify the instructions for testing.
 
  Jason
  --
  CONFIDENTIALITY NOTICE
  NOTICE: This message is intended for the use of the individual or
 entity to
  which it is addressed and may contain information that is confidential,
  privileged and exempt from disclosure under applicable law. If the
 reader
  of this message is not the intended recipient, you are hereby notified
 that
  any printing, copying, dissemination, distribution, disclosure or
  forwarding of this communication is strictly prohibited. If you have
  received this communication in error, please contact the sender
 immediately
  and delete it from your system. Thank You.
 



Re: Why isn't itests/ listed as submodule of root pom.xml?

2014-03-11 Thread Brock Noland
Hopefully this is the last time I have to say this :)

The qfile tests in itests require the packaging phase. The maven test phase
is after compile and before packaging. We could change the qfile tests to
run during the integration-test phase using the failsafe plugin but the
failsafe plugin is different than surefire and IMO is hard to use.

If you'd like to give that a try, by all means, go ahead.


On Tue, Mar 11, 2014 at 6:37 PM, Jason Dere jd...@hortonworks.com wrote:

 Noticed this since internally we set the version number to something
 different than simply 0.13.0, and mvn version:set doesn't really work
 correctly with itests because itests isn't listed as one of the root POM's
 submodules.  Is there a particular reason for it not being listed as a
 submodule when the mavenization was done?

 Having it as a submodule also allows you to run the qfile tests from root
 directory, so we could simplify the instructions for testing.

 Jason
 --
 CONFIDENTIALITY NOTICE
 NOTICE: This message is intended for the use of the individual or entity to
 which it is addressed and may contain information that is confidential,
 privileged and exempt from disclosure under applicable law. If the reader
 of this message is not the intended recipient, you are hereby notified that
 any printing, copying, dissemination, distribution, disclosure or
 forwarding of this communication is strictly prohibited. If you have
 received this communication in error, please contact the sender immediately
 and delete it from your system. Thank You.



Why isn't itests/ listed as submodule of root pom.xml?

2014-03-11 Thread Jason Dere
Noticed this since internally we set the version number to something different 
than simply 0.13.0, and mvn version:set doesn't really work correctly with 
itests because itests isn't listed as one of the root POM's submodules.  Is 
there a particular reason for it not being listed as a submodule when the 
mavenization was done?

Having it as a submodule also allows you to run the qfile tests from root 
directory, so we could simplify the instructions for testing. 

Jason
-- 
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to 
which it is addressed and may contain information that is confidential, 
privileged and exempt from disclosure under applicable law. If the reader 
of this message is not the intended recipient, you are hereby notified that 
any printing, copying, dissemination, distribution, disclosure or 
forwarding of this communication is strictly prohibited. If you have 
received this communication in error, please contact the sender immediately 
and delete it from your system. Thank You.