Re: [VOTE] HTrace 4.0 Release Candidate 0

[Lewis John Mcgibbney]

Hi Masatake,

On Wed, Sep 9, 2015 at 12:44 AM, <
dev-digest-h...@htrace.incubator.apache.org> wrote:

>
> HTRACE-234 was filed for this. Which version of Maven are you using?
>
>
lmcgibbn@LMC-032857 /usr/local(master) $ mvn -version
Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06;
2015-04-22T04:57:37-07:00)
Maven home: /usr/local/apache-maven-3.3.3
Java version: 1.7.0_79, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.7.0_79.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.9.5", arch: "x86_64", family: "mac"

Re: [VOTE] HTrace 4.0 Release Candidate 0

[Colin P. McCabe]

Quick reminder that the vote closes in 4 hours.  Check it out.

Lewis, check out my NOTICE.txt explanation as well.

You can take a look at my public key at
http://people.apache.org/~cmccabe/htrace/releases/KEYS.  Stack signed when
we met up in San Francisco.

I also checked the key into
https://dist.apache.org/repos/dist/release/incubator/htrace


r10450 | cmccabe | 2015-09-08 18:41:03 + (Tue, 08 Sep 2015) | 1 line

Add public key for cmcc...@apache.org


I'm not sure why it hasn't shown up on
http://archive.apache.org/dist/incubator/htrace/KEYS ... is there something
I need to do to "publish" it from the svn repo?

best,
Colin

On Fri, Sep 4, 2015 at 4:02 PM, Colin P. McCabe  wrote:

> I've posted the first release candidate here:
>
> http://people.apache.org/~cmccabe/htrace/releases/4.0.0/rc0
>
> The jars have been staged here:
>
> https://repository.apache.org/content/repositories/orgapachehtrace-1017
>
> There's a lot of great stuff in this release, including a new web UI,
> many bug fixes, API improvements and enlargement of span IDs to 128
> bits to avoid conflicts.
>
> The vote will run for 5 days.
>
> cheers,
> Colin
>
> Release Notes - HTrace - Version 4.0
>
> ** Sub-task
> * [HTRACE-208] - Remove deprecated addKVAnnotation(byte[], byte[])
> method
> * [HTRACE-209] - Make span ID 128 bit to avoid collisions
> * [HTRACE-210] - Remove TrueIfTracingSampler
> * [HTRACE-211] - Move htrace-core classes to the
> org.apache.htrace.core namespace
> * [HTRACE-212] - Change version to 4.0
> * [HTRACE-214] - De-globalize Tracer.java
> * [HTRACE-215] - Simplify the Sampler type
> * [HTRACE-216] - SpanReceivers should not fill in ProcessId
> * [HTRACE-217] - Rename ProcessId to TracerId
> * [HTRACE-222] - Add SpanReceiverPool
> * [HTRACE-228] - Fix subprojects to refer to new
> org.apache.htrace.core namespace
> * [HTRACE-229] - htrace-webapp needs to be updated to refer to
> "tracerid" not "processid"
> ** Bug
> * [HTRACE-159] - libhtrace.so: use HRPC endpoint of htraced
> * [HTRACE-164] - htrace hrpc: use msgpack for serialization
> * [HTRACE-166] - Add tabbed view
> * [HTRACE-167] - Update go build instructions in BUILDING.txt
> * [HTRACE-171] - htraced godeps should use
> github.com/ugorji/go/codec rather than github.com/ugorji/go
> * [HTRACE-174] - Refactor GUI
> * [HTRACE-177] - htrace-zipkin: shade all dependencies
> * [HTRACE-182] - htraced: add rpm build via -Prpm
> * [HTRACE-189] - gui: fix error handling in a few places
> * [HTRACE-190] - htraced: allow querying by process ID
> * [HTRACE-191] - gui: add "duration" to span details, filter out
> "selected"
> * [HTRACE-192] - gui: when expanding parents or children, sort the
> spans by begin time
> * [HTRACE-193] - gui: avoid doing multiple redraws when
> spanResults is updated
> * [HTRACE-196] - gui: add scrolling for spans view
> * [HTRACE-201] - htrace-web: URL-Encode query JSON
> * [HTRACE-202] - htrace-web: fix "converting circular object to
> JSON" error when pressing "clear" button
> * [HTRACE-218] - Fix issues with finding json-c includes and librt
> in the native library
> * [HTRACE-219] - Add -Dleveldb.prefix and -Djsonc.prefix build options
> * [HTRACE-220] - htraced: should be able to set log.path to the
> empty string via "-Dlog.path=" on the command line
> * [HTRACE-223] - gobuild.sh: fix issue where maven succeeds if go
> build fails
> * [HTRACE-224] - htrace C client: htrace_conf_get_u64,
> htrace_conf_get_double can't handle spaces at the end of strings
> * [HTRACE-230] - Make TracerBuilder like all other Builders; an
> internal rather than adjacent class
> * [HTRACE-233] - htrace-zipkin should explicitly include slf4j-api
> to avoid ClassNotFoundException
> * [HTRACE-234] - Add workaround to prevent htrace-hbase from
> getting in an infinite loop while creating the dependency-reduced pom
> ** Improvement
> * [HTRACE-29] - add javascript web UI for htraced
> * [HTRACE-160] - htraced: support continuing a query from where
> the client left it off by sending a previous span
> * [HTRACE-162] - htraced hrpc: some logging improvements
> * [HTRACE-170] - Optimize use of Random in htrace-core by using
> ThreadLocalRandom
> * [HTRACE-172] - Move minJdk to 1.7 (JDK 7)
> * [HTRACE-175] - Add Trace#addKVAnnotation convenience method
> * [HTRACE-176] - Expose ZipkinSpanReceiver configuration keys
> externally
> * [HTRACE-180] - Move the GUI to a top-level subproject
> * [HTRACE-184] - Expose PROCESS_ID_KEY configuration key
> * [HTRACE-186] - gui: support finding the parents and children of
> spans, add owl
> * [HTRACE-194] - gui: support multiple selections, zooming to fit
> a group of spans, 

Re: [VOTE] HTrace 4.0 Release Candidate 0

[Stack]

+1

Checked signature and hashes. Ran RAT check. It built and all unit tests
passed.

(I have not spent the time to verify that the new API is good and that it
integrates well in a running system).

St.Ack


On Fri, Sep 4, 2015 at 4:02 PM, Colin P. McCabe  wrote:

> I've posted the first release candidate here:
>
> http://people.apache.org/~cmccabe/htrace/releases/4.0.0/rc0
>
> The jars have been staged here:
>
> https://repository.apache.org/content/repositories/orgapachehtrace-1017
>
> There's a lot of great stuff in this release, including a new web UI,
> many bug fixes, API improvements and enlargement of span IDs to 128
> bits to avoid conflicts.
>
> The vote will run for 5 days.
>
> cheers,
> Colin
>
> Release Notes - HTrace - Version 4.0
>
> ** Sub-task
> * [HTRACE-208] - Remove deprecated addKVAnnotation(byte[], byte[])
> method
> * [HTRACE-209] - Make span ID 128 bit to avoid collisions
> * [HTRACE-210] - Remove TrueIfTracingSampler
> * [HTRACE-211] - Move htrace-core classes to the
> org.apache.htrace.core namespace
> * [HTRACE-212] - Change version to 4.0
> * [HTRACE-214] - De-globalize Tracer.java
> * [HTRACE-215] - Simplify the Sampler type
> * [HTRACE-216] - SpanReceivers should not fill in ProcessId
> * [HTRACE-217] - Rename ProcessId to TracerId
> * [HTRACE-222] - Add SpanReceiverPool
> * [HTRACE-228] - Fix subprojects to refer to new
> org.apache.htrace.core namespace
> * [HTRACE-229] - htrace-webapp needs to be updated to refer to
> "tracerid" not "processid"
> ** Bug
> * [HTRACE-159] - libhtrace.so: use HRPC endpoint of htraced
> * [HTRACE-164] - htrace hrpc: use msgpack for serialization
> * [HTRACE-166] - Add tabbed view
> * [HTRACE-167] - Update go build instructions in BUILDING.txt
> * [HTRACE-171] - htraced godeps should use
> github.com/ugorji/go/codec rather than github.com/ugorji/go
> * [HTRACE-174] - Refactor GUI
> * [HTRACE-177] - htrace-zipkin: shade all dependencies
> * [HTRACE-182] - htraced: add rpm build via -Prpm
> * [HTRACE-189] - gui: fix error handling in a few places
> * [HTRACE-190] - htraced: allow querying by process ID
> * [HTRACE-191] - gui: add "duration" to span details, filter out
> "selected"
> * [HTRACE-192] - gui: when expanding parents or children, sort the
> spans by begin time
> * [HTRACE-193] - gui: avoid doing multiple redraws when
> spanResults is updated
> * [HTRACE-196] - gui: add scrolling for spans view
> * [HTRACE-201] - htrace-web: URL-Encode query JSON
> * [HTRACE-202] - htrace-web: fix "converting circular object to
> JSON" error when pressing "clear" button
> * [HTRACE-218] - Fix issues with finding json-c includes and librt
> in the native library
> * [HTRACE-219] - Add -Dleveldb.prefix and -Djsonc.prefix build options
> * [HTRACE-220] - htraced: should be able to set log.path to the
> empty string via "-Dlog.path=" on the command line
> * [HTRACE-223] - gobuild.sh: fix issue where maven succeeds if go
> build fails
> * [HTRACE-224] - htrace C client: htrace_conf_get_u64,
> htrace_conf_get_double can't handle spaces at the end of strings
> * [HTRACE-230] - Make TracerBuilder like all other Builders; an
> internal rather than adjacent class
> * [HTRACE-233] - htrace-zipkin should explicitly include slf4j-api
> to avoid ClassNotFoundException
> * [HTRACE-234] - Add workaround to prevent htrace-hbase from
> getting in an infinite loop while creating the dependency-reduced pom
> ** Improvement
> * [HTRACE-29] - add javascript web UI for htraced
> * [HTRACE-160] - htraced: support continuing a query from where
> the client left it off by sending a previous span
> * [HTRACE-162] - htraced hrpc: some logging improvements
> * [HTRACE-170] - Optimize use of Random in htrace-core by using
> ThreadLocalRandom
> * [HTRACE-172] - Move minJdk to 1.7 (JDK 7)
> * [HTRACE-175] - Add Trace#addKVAnnotation convenience method
> * [HTRACE-176] - Expose ZipkinSpanReceiver configuration keys
> externally
> * [HTRACE-180] - Move the GUI to a top-level subproject
> * [HTRACE-184] - Expose PROCESS_ID_KEY configuration key
> * [HTRACE-186] - gui: support finding the parents and children of
> spans, add owl
> * [HTRACE-194] - gui: support multiple selections, zooming to fit
> a group of spans, deleting a group of spans
> * [HTRACE-197] - htraced build: set RUNPATH if possible
> * [HTRACE-199] - gui: Double clicking on spans should bring up span
> details
> * [HTRACE-203] - htrace-web: pressing enter should dismiss the
> modal dialog box
> * [HTRACE-204] - htrace-web: add draggable bar which allows more
> or less visual space for process name in search view
> * [HTRACE-205] - htrace-web: Width of SearchResultsView should be
> uppdated along with resizing of browser window
> * [HTRACE-206] - htrace-web: when the canvas has focus, the delete
> 

Re: [VOTE] HTrace 4.0 Release Candidate 0

[Colin P. McCabe]

On Mon, Sep 7, 2015 at 8:47 AM, Lewis John Mcgibbney
 wrote:
> Hi Colin,
> Nice work in getting the release candidate prepared and available for
> review.
> Where is the KEYS file?
> I tried the one here
>

Good call.  I'll append my key to the KEYS file.  My public key is
here: http://pgp.mit.edu/pks/lookup?op=get=0xDE78987A9CD4D9D3

> It does not contain your sig so I cannot verify the release sigs.
> Moving on,
>
> Notes Binaries Archives Standards Apache Generated Unknown 0 0 0 116 92 0 15
> Unapproved licenses are as follows
>
> bootstrap-theme.css
> bootstrap-theme.min.css
> bootstrap.css
> bootstrap.min.css
> backbone-1.1.2.js
> bootstrap.js
> bootstrap.min.js
> d3.min.js
> jquery-2.1.4.js
> moment-2.10.3.js
> npm.js
> underscore-1.7.0.js
> SpanProtos.java
> dependency-reduced-pom.xml
>
> None of the above libraries are declared within NOTICE.txt

bootstrap-theme.css, bootstrap-theme.min.css, bootstrap.css,
bootstrap.min.css, bootstrap.js, bootstrap.min.js, and
bootstrap-3.3.1/js/npm.js are described in LICENSE.txt as:

> Bootstrap, an html, css, and javascript framework, is
> Copyright (c) 2011-2015 Twitter, Inc and MIT licensed:
> https://github.com/twbs/bootstrap/blob/master/LICENSE

backbone-1.1.2.js is described in LICENSE.txt as:

> backbone, is a javascript library, that is Copyright (c) 2010-2014
> Jeremy Ashkenas, DocumentCloud. It is MIT licensed:
> https://github.com/jashkenas/backbone/blob/master/LICENSE

d3.min.js is described in LICENSE.txt as:

> D3, a javascript library for manipulating data, used by htrace-hbase
> is Copyright 2010-2014, Michael Bostock and BSD licensed:
> https://github.com/mbostock/d3/blob/master/LICENSE

jquery-2.1.4.js is described in LICENSE.txt as:

> jquery, a javascript library, is Copyright jQuery Foundation and other
> contributors, https://jquery.org/. The software consists of
> voluntary contributions made by many individuals. For exact
> contribution history, see the revision history
> available at https://github.com/jquery/jquery
> It is MIT licensed:
> https://github.com/jquery/jquery/blob/master/LICENSE.txt

moment-2.10.3.js is described in LICENSE.txt as:

> moment.js is a front end time conversion project.
> It is (c) 2011-2014 Tim Wood, Iskren Chernev, Moment.js contributors
> and shared under the MIT license:
> https://github.com/moment/moment/blob/develop/LICENSE

underscore-1.7.0.js is described in LICENSE.txt as:

> underscore, a javascript library of functional programming helpers, is
> (c) 2009-2014 Jeremy Ashkenas, DocumentCloud and Investigative Reporters
> & Editors and an MIT license:
> https://github.com/jashkenas/underscore/blob/master/LICENSE

According to http://www.apache.org/dev/licensing-howto.html:

> Bundling a dependency which is issued under one of the following
> licenses is straightforward, assuming that said license applies
> uniformly to all files within the dependency:
> 1. BSD (without advertising clause)
> 2. MIT/X11
> In LICENSE, add a pointer to the dependency's license within the source tree
> and a short note summarizing its licensing...
> Under normal circumstances, there is no need to modify NOTICE.

Since these are all BSD or MIT licensed, I would interpret this to
mean there is no need for us to modify NOTICE.  Does that make sense?

SpanProtos.java and dependency-reduced-pom.xml are generated files.
According to 
http://incubator.apache.org/guides/releasemanagement.html#notes-license-headers
:

> The issue of licenses on generated documentation is a little controversial.
> Copyright may not subsist in a document which is generated by an 
> transformation
> from an original. In which case, the license header may be unnecessary. 
> License
> headers should always be present in the original. Where it is reasonable to 
> do so,
> the templates should also add the license header to the generated documents.

I looked at how Apache Hadoop is handling this, and they do not have
license headers on their protobuf-generated files.  So I think this is
fine.  (From a technical point of view, I think the PB compiler also
provides no way to do this, as far as I know.)  The situation for
dependency-reduced-pom.xml is the same-- it is a file generated by
Maven.  This is similar to jar files, which are also generated by the
build process, and do not contain a license header.

Also, I believe all these library and generated  files were in the
last release we did (although they moved around a bit).

>
> I navigate to the decompressed RC directory and try mvn clean install... it
> enters into a loop!

As Masatake commented, this is HTRACE-236.  There is a note about it
in the README.md.  For a workaround, you can use the solution
described in HTRACE-234 to get the build to run on your version of
Maven (which I assume is 3.3)...

Thanks for trying out the release-- I will take a look at updating
KEYS tomorrow.  So far I haven't seen anything that would need a
respin (please let me know if I missed 

Re: [VOTE] HTrace 4.0 Release Candidate 0

[Masatake Iwasaki]

Thanks for putting this up, Colin.

- verified mds and signature
- ran "mvn install" without test failure
- ran "mvn package -Pnative" without test failure in htrace-c
- built src tarball by running "mvn clean install -DskipTests 
assembly:single -Pdist"
- launched htraced and sent test tracing spans by HTracedRESTReceiver 
and checked the spans by Web-UI


I'm +1 if the issue about NOTICE.txt Lewis pointed out is not critical 
for release.


Masatake Iwasaki

On 9/5/15 08:02, Colin P. McCabe wrote:

I've posted the first release candidate here:

http://people.apache.org/~cmccabe/htrace/releases/4.0.0/rc0

The jars have been staged here:

https://repository.apache.org/content/repositories/orgapachehtrace-1017

There's a lot of great stuff in this release, including a new web UI,
many bug fixes, API improvements and enlargement of span IDs to 128
bits to avoid conflicts.

The vote will run for 5 days.

cheers,
Colin

Release Notes - HTrace - Version 4.0

** Sub-task
 * [HTRACE-208] - Remove deprecated addKVAnnotation(byte[], byte[]) method
 * [HTRACE-209] - Make span ID 128 bit to avoid collisions
 * [HTRACE-210] - Remove TrueIfTracingSampler
 * [HTRACE-211] - Move htrace-core classes to the
org.apache.htrace.core namespace
 * [HTRACE-212] - Change version to 4.0
 * [HTRACE-214] - De-globalize Tracer.java
 * [HTRACE-215] - Simplify the Sampler type
 * [HTRACE-216] - SpanReceivers should not fill in ProcessId
 * [HTRACE-217] - Rename ProcessId to TracerId
 * [HTRACE-222] - Add SpanReceiverPool
 * [HTRACE-228] - Fix subprojects to refer to new
org.apache.htrace.core namespace
 * [HTRACE-229] - htrace-webapp needs to be updated to refer to
"tracerid" not "processid"
** Bug
 * [HTRACE-159] - libhtrace.so: use HRPC endpoint of htraced
 * [HTRACE-164] - htrace hrpc: use msgpack for serialization
 * [HTRACE-166] - Add tabbed view
 * [HTRACE-167] - Update go build instructions in BUILDING.txt
 * [HTRACE-171] - htraced godeps should use
github.com/ugorji/go/codec rather than github.com/ugorji/go
 * [HTRACE-174] - Refactor GUI
 * [HTRACE-177] - htrace-zipkin: shade all dependencies
 * [HTRACE-182] - htraced: add rpm build via -Prpm
 * [HTRACE-189] - gui: fix error handling in a few places
 * [HTRACE-190] - htraced: allow querying by process ID
 * [HTRACE-191] - gui: add "duration" to span details, filter out "selected"
 * [HTRACE-192] - gui: when expanding parents or children, sort the
spans by begin time
 * [HTRACE-193] - gui: avoid doing multiple redraws when
spanResults is updated
 * [HTRACE-196] - gui: add scrolling for spans view
 * [HTRACE-201] - htrace-web: URL-Encode query JSON
 * [HTRACE-202] - htrace-web: fix "converting circular object to
JSON" error when pressing "clear" button
 * [HTRACE-218] - Fix issues with finding json-c includes and librt
in the native library
 * [HTRACE-219] - Add -Dleveldb.prefix and -Djsonc.prefix build options
 * [HTRACE-220] - htraced: should be able to set log.path to the
empty string via "-Dlog.path=" on the command line
 * [HTRACE-223] - gobuild.sh: fix issue where maven succeeds if go
build fails
 * [HTRACE-224] - htrace C client: htrace_conf_get_u64,
htrace_conf_get_double can't handle spaces at the end of strings
 * [HTRACE-230] - Make TracerBuilder like all other Builders; an
internal rather than adjacent class
 * [HTRACE-233] - htrace-zipkin should explicitly include slf4j-api
to avoid ClassNotFoundException
 * [HTRACE-234] - Add workaround to prevent htrace-hbase from
getting in an infinite loop while creating the dependency-reduced pom
** Improvement
 * [HTRACE-29] - add javascript web UI for htraced
 * [HTRACE-160] - htraced: support continuing a query from where
the client left it off by sending a previous span
 * [HTRACE-162] - htraced hrpc: some logging improvements
 * [HTRACE-170] - Optimize use of Random in htrace-core by using
ThreadLocalRandom
 * [HTRACE-172] - Move minJdk to 1.7 (JDK 7)
 * [HTRACE-175] - Add Trace#addKVAnnotation convenience method
 * [HTRACE-176] - Expose ZipkinSpanReceiver configuration keys externally
 * [HTRACE-180] - Move the GUI to a top-level subproject
 * [HTRACE-184] - Expose PROCESS_ID_KEY configuration key
 * [HTRACE-186] - gui: support finding the parents and children of
spans, add owl
 * [HTRACE-194] - gui: support multiple selections, zooming to fit
a group of spans, deleting a group of spans
 * [HTRACE-197] - htraced build: set RUNPATH if possible
 * [HTRACE-199] - gui: Double clicking on spans should bring up span details
 * [HTRACE-203] - htrace-web: pressing enter should dismiss the
modal dialog box
 * [HTRACE-204] - htrace-web: add draggable bar which allows more
or less visual space for process name in search view
 * [HTRACE-205] - htrace-web: Width of SearchResultsView should be
uppdated along with resizing of 

Re: [VOTE] HTrace 4.0 Release Candidate 0

[Colin P. McCabe]

Thanks for looking at this, Masatake and Lewis!  Lewis, is my
explanation of NOTICE.txt correct, or did I miss something?

Remember to vote... the vote will be open until tomorrow.

Here is my +1. ;)

cheers,
Colin

On Tue, Sep 8, 2015 at 6:32 PM, Masatake Iwasaki
 wrote:
> Thanks for putting this up, Colin.
>
> - verified mds and signature
> - ran "mvn install" without test failure
> - ran "mvn package -Pnative" without test failure in htrace-c
> - built src tarball by running "mvn clean install -DskipTests
> assembly:single -Pdist"
> - launched htraced and sent test tracing spans by HTracedRESTReceiver and
> checked the spans by Web-UI
>
> I'm +1 if the issue about NOTICE.txt Lewis pointed out is not critical for
> release.
>
> Masatake Iwasaki
>
>
> On 9/5/15 08:02, Colin P. McCabe wrote:
>>
>> I've posted the first release candidate here:
>>
>> http://people.apache.org/~cmccabe/htrace/releases/4.0.0/rc0
>>
>> The jars have been staged here:
>>
>> https://repository.apache.org/content/repositories/orgapachehtrace-1017
>>
>> There's a lot of great stuff in this release, including a new web UI,
>> many bug fixes, API improvements and enlargement of span IDs to 128
>> bits to avoid conflicts.
>>
>> The vote will run for 5 days.
>>
>> cheers,
>> Colin
>>
>> Release Notes - HTrace - Version 4.0
>>
>> ** Sub-task
>>  * [HTRACE-208] - Remove deprecated addKVAnnotation(byte[], byte[])
>> method
>>  * [HTRACE-209] - Make span ID 128 bit to avoid collisions
>>  * [HTRACE-210] - Remove TrueIfTracingSampler
>>  * [HTRACE-211] - Move htrace-core classes to the
>> org.apache.htrace.core namespace
>>  * [HTRACE-212] - Change version to 4.0
>>  * [HTRACE-214] - De-globalize Tracer.java
>>  * [HTRACE-215] - Simplify the Sampler type
>>  * [HTRACE-216] - SpanReceivers should not fill in ProcessId
>>  * [HTRACE-217] - Rename ProcessId to TracerId
>>  * [HTRACE-222] - Add SpanReceiverPool
>>  * [HTRACE-228] - Fix subprojects to refer to new
>> org.apache.htrace.core namespace
>>  * [HTRACE-229] - htrace-webapp needs to be updated to refer to
>> "tracerid" not "processid"
>> ** Bug
>>  * [HTRACE-159] - libhtrace.so: use HRPC endpoint of htraced
>>  * [HTRACE-164] - htrace hrpc: use msgpack for serialization
>>  * [HTRACE-166] - Add tabbed view
>>  * [HTRACE-167] - Update go build instructions in BUILDING.txt
>>  * [HTRACE-171] - htraced godeps should use
>> github.com/ugorji/go/codec rather than github.com/ugorji/go
>>  * [HTRACE-174] - Refactor GUI
>>  * [HTRACE-177] - htrace-zipkin: shade all dependencies
>>  * [HTRACE-182] - htraced: add rpm build via -Prpm
>>  * [HTRACE-189] - gui: fix error handling in a few places
>>  * [HTRACE-190] - htraced: allow querying by process ID
>>  * [HTRACE-191] - gui: add "duration" to span details, filter out
>> "selected"
>>  * [HTRACE-192] - gui: when expanding parents or children, sort the
>> spans by begin time
>>  * [HTRACE-193] - gui: avoid doing multiple redraws when
>> spanResults is updated
>>  * [HTRACE-196] - gui: add scrolling for spans view
>>  * [HTRACE-201] - htrace-web: URL-Encode query JSON
>>  * [HTRACE-202] - htrace-web: fix "converting circular object to
>> JSON" error when pressing "clear" button
>>  * [HTRACE-218] - Fix issues with finding json-c includes and librt
>> in the native library
>>  * [HTRACE-219] - Add -Dleveldb.prefix and -Djsonc.prefix build
>> options
>>  * [HTRACE-220] - htraced: should be able to set log.path to the
>> empty string via "-Dlog.path=" on the command line
>>  * [HTRACE-223] - gobuild.sh: fix issue where maven succeeds if go
>> build fails
>>  * [HTRACE-224] - htrace C client: htrace_conf_get_u64,
>> htrace_conf_get_double can't handle spaces at the end of strings
>>  * [HTRACE-230] - Make TracerBuilder like all other Builders; an
>> internal rather than adjacent class
>>  * [HTRACE-233] - htrace-zipkin should explicitly include slf4j-api
>> to avoid ClassNotFoundException
>>  * [HTRACE-234] - Add workaround to prevent htrace-hbase from
>> getting in an infinite loop while creating the dependency-reduced pom
>> ** Improvement
>>  * [HTRACE-29] - add javascript web UI for htraced
>>  * [HTRACE-160] - htraced: support continuing a query from where
>> the client left it off by sending a previous span
>>  * [HTRACE-162] - htraced hrpc: some logging improvements
>>  * [HTRACE-170] - Optimize use of Random in htrace-core by using
>> ThreadLocalRandom
>>  * [HTRACE-172] - Move minJdk to 1.7 (JDK 7)
>>  * [HTRACE-175] - Add Trace#addKVAnnotation convenience method
>>  * [HTRACE-176] - Expose ZipkinSpanReceiver configuration keys
>> externally
>>  * [HTRACE-180] - Move the GUI to a top-level subproject
>>  * [HTRACE-184] - Expose PROCESS_ID_KEY configuration key
>>  * [HTRACE-186] - gui: support finding the parents and children of
>> 

Re: [VOTE] HTrace 4.0 Release Candidate 0

[Masatake Iwasaki]

> I navigate to the decompressed RC directory and try mvn clean 
install... it

> enters into a loop!
>
> ...
> [INFO] Dependency-reduced POM written at:
> 
/usr/local/htrace_4/htrace-4.0.0-incubating/htrace-hbase/dependency-reduced-pom.xml

> [INFO] Dependency-reduced POM written at:
> 
/usr/local/htrace_4/htrace-4.0.0-incubating/htrace-hbase/dependency-reduced-pom.xml


HTRACE-234 was filed for this. Which version of Maven are you using?

Thanks,
Masatake Iwasaki


On 9/8/15 00:47, Lewis John Mcgibbney wrote:

Hi Colin,
Nice work in getting the release candidate prepared and available for
review.
Where is the KEYS file?
I tried the one here
http://archive.apache.org/dist/incubator/htrace/KEYS
It does not contain your sig so I cannot verify the release sigs.
Moving on,

Notes Binaries Archives Standards Apache Generated Unknown 0 0 0 116 92 0 15
Unapproved licenses are as follows

bootstrap-theme.css
bootstrap-theme.min.css
bootstrap.css
bootstrap.min.css
backbone-1.1.2.js
bootstrap.js
bootstrap.min.js
d3.min.js
jquery-2.1.4.js
moment-2.10.3.js
npm.js
underscore-1.7.0.js
SpanProtos.java
dependency-reduced-pom.xml

None of the above libraries are declared within NOTICE.txt

I navigate to the decompressed RC directory and try mvn clean install... it
enters into a loop!

...
[INFO] Dependency-reduced POM written at:
/usr/local/htrace_4/htrace-4.0.0-incubating/htrace-hbase/dependency-reduced-pom.xml
[INFO] Dependency-reduced POM written at:
/usr/local/htrace_4/htrace-4.0.0-incubating/htrace-hbase/dependency-reduced-pom.xml
[INFO] Dependency-reduced POM written at:
/usr/local/htrace_4/htrace-4.0.0-incubating/htrace-hbase/dependency-reduced-pom.xml
[INFO] Dependency-reduced POM written at:
/usr/local/htrace_4/htrace-4.0.0-incubating/htrace-hbase/dependency-reduced-pom.xml
[INFO] Dependency-reduced POM written at:
/usr/local/htrace_4/htrace-4.0.0-incubating/htrace-hbase/dependency-reduced-pom.xml

I try mvn clean install -DskipTests with same result

...
[INFO] Dependency-reduced POM written at:
/usr/local/htrace_4/htrace-4.0.0-incubating/htrace-hbase/dependency-reduced-pom.xml
[INFO] Dependency-reduced POM written at:
/usr/local/htrace_4/htrace-4.0.0-incubating/htrace-hbase/dependency-reduced-pom.xml
[INFO] Dependency-reduced POM written at:
/usr/local/htrace_4/htrace-4.0.0-incubating/htrace-hbase/dependency-reduced-pom.xml
[INFO] Dependency-reduced POM written at:
/usr/local/htrace_4/htrace-4.0.0-incubating/htrace-hbase/dependency-reduced-pom.xml
[INFO] Dependency-reduced POM written at:
/usr/local/htrace_4/htrace-4.0.0-incubating/htrace-hbase/dependency-reduced-pom.xml

Any ideas what is going on?
Thanks
Lewis

On Mon, Sep 7, 2015 at 10:15 AM, <
dev-digest-h...@htrace.incubator.apache.org> wrote:


I've posted the first release candidate here:

http://people.apache.org/~cmccabe/htrace/releases/4.0.0/rc0

The jars have been staged here:

https://repository.apache.org/content/repositories/orgapachehtrace-1017

There's a lot of great stuff in this release, including a new web UI,
many bug fixes, API improvements and enlargement of span IDs to 128
bits to avoid conflicts.

The vote will run for 5 days.

[VOTE] HTrace 4.0 Release Candidate 0

[Colin P. McCabe]

I've posted the first release candidate here:

http://people.apache.org/~cmccabe/htrace/releases/4.0.0/rc0

The jars have been staged here:

https://repository.apache.org/content/repositories/orgapachehtrace-1017

There's a lot of great stuff in this release, including a new web UI,
many bug fixes, API improvements and enlargement of span IDs to 128
bits to avoid conflicts.

The vote will run for 5 days.

cheers,
Colin

Release Notes - HTrace - Version 4.0

** Sub-task
* [HTRACE-208] - Remove deprecated addKVAnnotation(byte[], byte[]) method
* [HTRACE-209] - Make span ID 128 bit to avoid collisions
* [HTRACE-210] - Remove TrueIfTracingSampler
* [HTRACE-211] - Move htrace-core classes to the
org.apache.htrace.core namespace
* [HTRACE-212] - Change version to 4.0
* [HTRACE-214] - De-globalize Tracer.java
* [HTRACE-215] - Simplify the Sampler type
* [HTRACE-216] - SpanReceivers should not fill in ProcessId
* [HTRACE-217] - Rename ProcessId to TracerId
* [HTRACE-222] - Add SpanReceiverPool
* [HTRACE-228] - Fix subprojects to refer to new
org.apache.htrace.core namespace
* [HTRACE-229] - htrace-webapp needs to be updated to refer to
"tracerid" not "processid"
** Bug
* [HTRACE-159] - libhtrace.so: use HRPC endpoint of htraced
* [HTRACE-164] - htrace hrpc: use msgpack for serialization
* [HTRACE-166] - Add tabbed view
* [HTRACE-167] - Update go build instructions in BUILDING.txt
* [HTRACE-171] - htraced godeps should use
github.com/ugorji/go/codec rather than github.com/ugorji/go
* [HTRACE-174] - Refactor GUI
* [HTRACE-177] - htrace-zipkin: shade all dependencies
* [HTRACE-182] - htraced: add rpm build via -Prpm
* [HTRACE-189] - gui: fix error handling in a few places
* [HTRACE-190] - htraced: allow querying by process ID
* [HTRACE-191] - gui: add "duration" to span details, filter out "selected"
* [HTRACE-192] - gui: when expanding parents or children, sort the
spans by begin time
* [HTRACE-193] - gui: avoid doing multiple redraws when
spanResults is updated
* [HTRACE-196] - gui: add scrolling for spans view
* [HTRACE-201] - htrace-web: URL-Encode query JSON
* [HTRACE-202] - htrace-web: fix "converting circular object to
JSON" error when pressing "clear" button
* [HTRACE-218] - Fix issues with finding json-c includes and librt
in the native library
* [HTRACE-219] - Add -Dleveldb.prefix and -Djsonc.prefix build options
* [HTRACE-220] - htraced: should be able to set log.path to the
empty string via "-Dlog.path=" on the command line
* [HTRACE-223] - gobuild.sh: fix issue where maven succeeds if go
build fails
* [HTRACE-224] - htrace C client: htrace_conf_get_u64,
htrace_conf_get_double can't handle spaces at the end of strings
* [HTRACE-230] - Make TracerBuilder like all other Builders; an
internal rather than adjacent class
* [HTRACE-233] - htrace-zipkin should explicitly include slf4j-api
to avoid ClassNotFoundException
* [HTRACE-234] - Add workaround to prevent htrace-hbase from
getting in an infinite loop while creating the dependency-reduced pom
** Improvement
* [HTRACE-29] - add javascript web UI for htraced
* [HTRACE-160] - htraced: support continuing a query from where
the client left it off by sending a previous span
* [HTRACE-162] - htraced hrpc: some logging improvements
* [HTRACE-170] - Optimize use of Random in htrace-core by using
ThreadLocalRandom
* [HTRACE-172] - Move minJdk to 1.7 (JDK 7)
* [HTRACE-175] - Add Trace#addKVAnnotation convenience method
* [HTRACE-176] - Expose ZipkinSpanReceiver configuration keys externally
* [HTRACE-180] - Move the GUI to a top-level subproject
* [HTRACE-184] - Expose PROCESS_ID_KEY configuration key
* [HTRACE-186] - gui: support finding the parents and children of
spans, add owl
* [HTRACE-194] - gui: support multiple selections, zooming to fit
a group of spans, deleting a group of spans
* [HTRACE-197] - htraced build: set RUNPATH if possible
* [HTRACE-199] - gui: Double clicking on spans should bring up span details
* [HTRACE-203] - htrace-web: pressing enter should dismiss the
modal dialog box
* [HTRACE-204] - htrace-web: add draggable bar which allows more
or less visual space for process name in search view
* [HTRACE-205] - htrace-web: Width of SearchResultsView should be
uppdated along with resizing of browser window
* [HTRACE-206] - htrace-web: when the canvas has focus, the delete
key should clear, z key should zoom
* [HTRACE-221] - htraced: search /etc/htraced/conf for the htraced
configuration by default
* [HTRACE-227] - Remove dependency to non-public API of
hadoop-common from htrace-hbase
** New Feature
* [HTRACE-143] - htraced search GUI enhancements
** Task
* [HTRACE-183] - htraced: move src/go directory to go
** Test
* [HTRACE-213] - Add test for ZipkinSpanReceiver