Re: HTrace 3.2+ zipkin namespace issues

2015-06-02 Thread Lewis John Mcgibbney
Ho Daniel,
Thanks for taking the time to write here.
The preferred method is to log an issue in Jira at
https://issues.apache.org/jira/browse/htrace
You can then work on a patch(ES) and attach it there or alternatively
create a pull request In a new branch against the Github mirror at

https://github.com/apache/incubator-htrace

Thanks
Lewis
On Sunday, May 31, 2015, Daniel Lee dan...@slice.com wrote:

 Hi,

 I recently became aware of htrace and have begun testing it but ran
 into an issue pretty quickly when moving from 3.1 to 3.2. In commit
 f425e63 (HTRACE-90) the maven shade plugin is introduced to the build
 process. As a result, the jar artifacts available have a bunch of
 dependencies pulled into the global namespace which is causing clashes
 and compile/runtime errors.

 Downloading the jar from maven central we can see that there are many
 things in there including org/apache/http/ and org/slf4j/.

 wget
 http://central.maven.org/maven2/org/apache/htrace/htrace-zipkin/3.2.0-incubating/htrace-zipkin-3.2.0-incubating.jar
 jar tf htrace-zipkin-3.2.0-incubating.jar | sed s:/[^/]*\.[^.]*:/: |
 sort | uniq

 Currently I'm just modifying the pom to shade all the extra
 dependencies but I was wonder what were the long term plans for this.

 I've also been updating the Trace class with missing Span setX
 functionality and was wondering if the preferred way to submit patches
 was through bug reports of through posts to the mailing list.

 Daniel



-- 
*Lewis*


HTrace 3.2+ zipkin namespace issues

2015-05-31 Thread Daniel Lee
Hi,

I recently became aware of htrace and have begun testing it but ran
into an issue pretty quickly when moving from 3.1 to 3.2. In commit
f425e63 (HTRACE-90) the maven shade plugin is introduced to the build
process. As a result, the jar artifacts available have a bunch of
dependencies pulled into the global namespace which is causing clashes
and compile/runtime errors.

Downloading the jar from maven central we can see that there are many
things in there including org/apache/http/ and org/slf4j/.

wget 
http://central.maven.org/maven2/org/apache/htrace/htrace-zipkin/3.2.0-incubating/htrace-zipkin-3.2.0-incubating.jar
jar tf htrace-zipkin-3.2.0-incubating.jar | sed s:/[^/]*\.[^.]*:/: |
sort | uniq

Currently I'm just modifying the pom to shade all the extra
dependencies but I was wonder what were the long term plans for this.

I've also been updating the Trace class with missing Span setX
functionality and was wondering if the preferred way to submit patches
was through bug reports of through posts to the mailing list.

Daniel