Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-21 Thread Philip M. Gollucci
Philip M. Gollucci wrote:
 Randy Kobes wrote:
 [Thu Jul 20 23:45:45 2006] [error] [client 127.0.0.1]
 (OS 80)The file exists.  :
  apreq_brigade_concat failed; TempDir problem?

 which is coming from about line 288 of
 module/apache2/filter.c. The file exists message
 I think comes from the fact that, when the test
 fails, there's old temp files left over from
 a previous run. So perhaps the cleanup discussed
 in library/util.c at around line 797 is failing
 occasionally?
You are absolutely correct. I can force duplicate on FBSD.
I changed this (dropped the ) so I could predict the temp file name
and yanked out all the tests not for tempname in t/apreq/upload.t

  rc = apr_filepath_merge(tmpl, path, apreq,
APR_FILEPATH_NOTRELATIVE, pool);

touch /tmp/apreq

t/error_log
[Fri Jul 21 04:02:42 2006] [error] [client 127.0.0.1] 
$param-upload_tempname($req): can't make spool bucket at
/usr/home/pgollucci/dev/repos/asf/httpd/apreq/trunk/glue/perl/t/response/TestApReq/upload.pm
 line 33.

Which means
  apr_pool_cleanup_register(pool, data,
  apreq_file_cleanup, apreq_file_cleanup);

which calls apr_file_remove() which on Win32 is way out of my league :(
I'm guessing this is failing, but silently. or less likely the cleanup is 
just not being run ?

Question, are you both ASCII or UNICODE ?


-- 

Philip M. Gollucci ([EMAIL PROTECTED]) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F  6A47 D55A 7172 A799 97F

In all that I've done wrong I know I must have done something right to
deserve a hug every morning and butterfly kisses at night.


Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

2006-07-21 Thread Philip M. Gollucci
Philip M. Gollucci wrote:
 Philip M. Gollucci wrote:
 Randy Kobes wrote:
 Which means
   apr_pool_cleanup_register(pool, data,
   apreq_file_cleanup, apreq_file_cleanup);
 
Contrary to the comment in library/util.c
 data = apr_palloc(pool, sizeof *data);
/* cleanups are LIFO, so this one will run just after
   the cleanup set by mktemp */
apr_pool_cleanup_register(pool, data,
  apreq_file_cleanup, apreq_file_cleanup);

rc = apr_file_mktemp(fp, tmpl, /* NO APR_DELONCLOSE! see comment above */
   APR_CREATE | APR_READ | APR_WRITE
   | APR_EXCL | APR_BINARY, pool);

Win32 doesn't have mktemp, so thats not *strictly* true.

FYI,
http://svn.apache.org/viewvc/apr/apr/trunk/file_io/unix/mktemp.c?r1=62405r2=62404pathrev=62405

The cleanup on Win32 was removed from apr here... I'll bet that's it!


-- 

Philip M. Gollucci ([EMAIL PROTECTED]) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F  6A47 D55A 7172 A799 97F

In all that I've done wrong I know I must have done something right to
deserve a hug every morning and butterfly kisses at night.


Re: svn commit: r423444 - in /httpd/httpd/branches/httpd-proxy-scoreboard/modules/mem: ./ Makefile.in config5.m4 mod_plainmem.c mod_scoreboard.c mod_sharedmem.c slotmem.h

2006-07-21 Thread Brian Akins

Jean-frederic Clere wrote:


Do you mean the proxy back-end connections?


I am thinking of a more general purpose slotmem not particularly tied 
to proxy.  Maybe have some wrapper functions that create a slotmem 
based on threads x procs and can be access using r-connection. 
(internally slotmem could use r-connection-id).


--
Brian Akins
Chief Operations Engineer
Turner Digital Media Technologies


Re: svn commit: r423444 - in /httpd/httpd/branches/httpd-proxy-scoreboard/modules/mem:

2006-07-21 Thread Jim Jagielski
Brian Akins wrote:
 
 Jean-frederic Clere wrote:
 
  Do you mean the proxy back-end connections?
 
 I am thinking of a more general purpose slotmem not particularly tied 
 to proxy.
 

++1. Making it proxy specific really doesn't allow for the
kind of abstraction and usage that would make it worthwhile.

-- 
===
   Jim Jagielski   [|]   [EMAIL PROTECTED]   [|]   http://www.jaguNET.com/
If you can dodge a wrench, you can dodge a ball.


Re: [PATCH] setenvif filter

2006-07-21 Thread Christian Lete

Anyone else care to vote on this so it can get, possibly, committed?


Its been really helpful to me this patch and is working well on
production servers, Id like to vote so this would be commited if
possible.

Thanks
Christian


Francois Pesce wrote:

These patches may fix the r-content_type behaviour. Are you OK with it ?

--
*Francois Pesce*

2006/5/31, Brian Akins [EMAIL PROTECTED]:
  Francois PESCE wrote:
   I've discussed about a patch for mod_setenvif 2 years ago, and have
   coded it at that time, it is successfully used on various host in
   production since.
 
 
  You need to handle content type specially by checking r-content_type.
  For some reason, just doing apr_table_get(r-headers_out,
  Content-type) would be null, but content_type would be set.
 
  See the patch I posted a few days ago.
 
 
  +1 in concept
 
  --
  Brian Akins
  Lead Systems Engineer
  CNN Internet Technologies
 




--
Brian Akins
Lead Systems Engineer
CNN Internet Technologies


Re: svn commit: r423444 - in /httpd/httpd/branches/httpd-proxy-scoreboard/modules/mem: ./ Makefile.in config5.m4 mod_plainmem.c mod_scoreboard.c mod_sharedmem.c slotmem.h

2006-07-21 Thread Jean-frederic Clere

Brian Akins wrote:


Jean-frederic Clere wrote:


Do you mean the proxy back-end connections?



I am thinking of a more general purpose slotmem not particularly 
tied to proxy.  Maybe have some wrapper functions that create a 
slotmem based on threads x procs and can be access using 
r-connection. (internally slotmem could use r-connection-id).


Yes the slotmen could be used for that.

Cheers

Jean-Frederic



Re: apache 2.2 crashes at the start time in mod_dbd.c then preparing AuthDBDUserPWQuery

2006-07-21 Thread Chris Darroch

Anton Golubev wrote:


It's the same, but I don't agree it is Virtual Host specific, as you
said.

This configuration (almost taken from documentation) also crashes the
server:



ServerRoot /usr/local/apache

Listen 80

User nobody
Group nobody

DocumentRoot /home/ivc2/public_html

DBDriver mysql
DBDParams dbname=Users user=auther passreplace=xx
DBDMin 1
DBDKeep 2
DBDMax 10
DBDExptime 60

Directory /home/ivc2/public_html

AuthType Basic
AuthName 'ADMIN ZONE'
AuthBasicProvider dbd
AuthDBDUserPWQuery select PASS from Users where LOGIN= %s
require valid-user

/Directory


  Yes, it seems to be caused by the Directory ... specifically,
authn_dbd_prepare(), which is called to handle the AuthDBDUserPWQuery
directive, calls ap_dbd_prepare() and passes cmd-server as the
server_rec *s argument.  Then ap_dbd_prepare() does:

   ap_get_module_config(s-module_config, dbd_module);

and that returns NULL.  I quickly also tried running:

   ap_get_module_config(cmd-server-module_config, authn_dbd_module);

inside authn_dbd_prepare(), and it too returns NULL.  And yet I feel
sure I'm seeing things that do effectively the same thing in other
directive handlers, like cmd_rewritelog() for mod_rewrite:

   ap_get_module_config(cmd-server-module_config, rewrite_module);

Maybe something about that's being RSRC_CONF vs. ACCESS_CONF for
mod_authn_dbd?  I can't grok it tonight; maybe I'll catch some
time over the weekend.

Chris.

--
GPG Key ID: 366A375B
GPG Key Fingerprint: 485E 5041 17E1 E2BB C263  E4DE C8E3 FA36 366A 375B