Subversion trunk (3.3) currently hangs on tests.

2006-08-01 Thread Graham Dumpleton

FYI. The change I made for memory leak described in:

  https://issues.apache.org/jira/browse/MODPYTHON-181

has caused a problem with other changes I made for:

  https://issues.apache.org/jira/browse/MODPYTHON-155

This is causing test suite to hang on the tests:

  test_req_handler
  test_accesshandler_add_handler_to_empty_hl

The specific problem is caused by code which uses req.add_handler().
If you are using 3.3 from trunk, as long as you aren't using that method
you should be okay.

I'll try and work out an alternate way of doing what I needed. :-(

Graham


Re: [RELEASE CANDIDATE] libapreq2 2.08-RC3

2006-08-01 Thread Issac Goldstand
Sorry this took me so long to get back to - it did catch aprutil-1.lib
after using SVN mod_perl.

I'll try to build RC4.

  Issac

Randy Kobes wrote:
 On Wed, 12 Jul 2006, Randy Kobes wrote:
 
 On Tue, 11 Jul 2006, Issac Goldstand wrote:

 I wanted to test the build, since Randy said he couldn't, but ran into
 troubles compiling mod_perl (my gut feeling is that it's related to
 all
 the apr-1.lib files, and the version of apxs, et al, (at least the
 one I
 have), seems to be giving the wrong lib names) - and haven't had
 time to
 really look at that.  It's odd because I don't think libapreq has this
 issue, as it builds the C library quite nicely.

 I know that I had trouble with lib names in earlier RC's, but Randy
 sorted out the problems with changes to various components.

 Make sure you are using the latest mod_perl sources from SVN and you
 must get the latest apxs from http://perl.apache.org/dist/win32-bin/
 (version 0.4).


 That helped.  It builds cleanly now.  First seuite of tests runs OK:
C:\Perl\bin\perl.exe -MExtUtils::Command::MM -e
 test_harness() library\t\cookie.t library\t\parsers.t
 library\t\params.t library\t\version.t
 library\t\cookie.ok
 library\t\params.ok
 library\t\parsersok
 library\t\versionok
 All tests successful.
 Files=4, Tests=648,  9 wallclock secs ( 0.00 cusr +  0.00 csys = 
 0.00 CPU)

 However, I seem to have another apxs-related issue...
 mod_apreq_access_test.c seems to be linking against the old APR-0.x
 libraries:
 (hope formatting doesn't get too mutilated)

 C:\apache2\bin\apxs.bat -I../../../apache2
 -I../../../../include -lD:\cpp\libapreq2-2.08\win32\libs\libapreq2.lib
 -lD:\cpp\libapreq2-2.08\win32\libs\mod_apreq2.lib -llibhttpd -D APACHE2
 -p -ID:\cpp\libapreq2-2.08\module\t\c-modules
 -c mod_apreq_access_test.c
 cl  /nologo /MD /W3 /O2 /D WIN32 /D _WINDOWS /D NDEBUG
 -IC:\apache2\include  /I../../../apache2  /I../../../../include
 /ID:\cpp\libapreq2-2.08\module\t\c-modules  /D APACHE2  /c
 /Fomod_apreq_access_test.lo mod_apreq_access_test.c
 mod_apreq_access_test.c
 link kernel32.lib /nologo /subsystem:windows /dll /machine:I386
 /libpath:C:\apache2\lib /out:mod_apreq_access_test.so
 D:\cpp\libapreq2-2.08\win32\libs\libapreq2.lib
 D:\cpp\libapreq2-2.08\win32\libs\mod_apreq2.lib libhttpd.lib C:\apache2\
 lib\libaprutil.lib C:\apache2\lib\libapr.lib  mod_apreq_access_test.lo
 LINK : fatal error LNK1181: cannot open input file
 'C:\apache2\lib\libaprutil.lib'
 apxs:Error: Command failed with rc=10289152.
 NMAKE : fatal error U1077: 'C:\apache2\bin\apxs.bat' : return code '0x1'
 Stop.

 Will try keep you posted...
  Issac

 Thanks for pointing that out - I'll take a look at it early
 next week, when I get back.
 
 That problem (with using the wrong libaprutil.lib name with
 Apache-2.2) doesn't arise for me. I'm wondering if it's
 picking up an old Apache installation and/or is getting
 confused with a previous build? Can you try reinstalling
 apxs from
http://perl.apache.org/dist/win32-bin/,
 rebuild and reinstall mod_perl2 from the svn sources, and then rebuild
 libapreq2 from clean sources? Does
 that help?
 


Re: svn commit: r427172 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c

2006-08-01 Thread Plüm , Rüdiger , VF EITO


 -Ursprüngliche Nachricht-
 Von: Ruediger Pluem 
 
 BTW: Don't we need to reset checked_standby and 
 checking_standby to zero in
  the outer while loop?

What about this? I guess we don't enter the inner while loop a second time
because checked_standby  0 once we have checked for the standby workers
during the first time.

Regards

Rüdiger



Re: svn commit: r427172 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c

2006-08-01 Thread Jim Jagielski
=?iso-8859-1?Q?Pl=FCm=2C_R=FCdiger=2C_VF_EITO?= wrote:
 
 
 
  -Urspr=FCngliche Nachricht-
  Von: Ruediger Pluem=20
 =20
  BTW: Don't we need to reset checked_standby and=20
  checking_standby to zero in
   the outer while loop?
 
 What about this? I guess we don't enter the inner while loop a second =
 time
 because checked_standby  0 once we have checked for the standby workers
 during the first time.
 

That's right. We are guaranteed to go through the full list as least
once, and it's during that time that we determine what the
max lbset was/is.

-- 
===
   Jim Jagielski   [|]   [EMAIL PROTECTED]   [|]   http://www.jaguNET.com/
If you can dodge a wrench, you can dodge a ball.


add_member creates 2 workers

2006-08-01 Thread Jean-frederic Clere

Hi,

add_member() creates 2 workers when the worker is not already existing 
(it creates an extra worker if the worker is already existing).

That is because of ap_proxy_add_worker_to_balancer():
+++
   runtime-id = proxy_lb_workers;
   /* Increase the total runtime count */
   proxy_lb_workers++;
+++

I think that is wrong: The balancer does not need a worker it just needs 
a reference to a worker.


Comments?

Cheers

Jean-Frederic


Re: svn commit: r427780 - in /httpd/httpd/trunk: docs/manual/mod/mod_authz_core.xml modules/aaa/mod_auth.h modules/aaa/mod_authz_core.c

2006-08-01 Thread Joshua Slive

On 8/1/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:

Author: bnicholes
Date: Tue Aug  1 15:54:38 2006
New Revision: 427780

URL: http://svn.apache.org/viewvc?rev=427780view=rev
Log:
Converted the reject directive to be definitive and enabled directory_merge to 
merge all of the authorization rules and logic.


Can you explain how you do something like the following:

Allow access from anywhere except IPs starting 10.2, but also allow
access from the specific subnet 10.2.1.

Joshua.