Re: [VOTE] Release Apache httpd 2.4.5 as GA
On Thursday 11 July 2013, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go [ ] +0: meh [ ] -1: Danger Will Robinson. And why. Vote will last the normal 72 hrs. +1, tested on Debian sid
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On 7/11/2013 11:54 AM, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go [ ] +0: meh [ ] -1: Danger Will Robinson. And why. Vote will last the normal 72 hrs. +1 x86: XP Vista x64: Server 2003 2012
intermittent shutdown hang on Windows in 2.4
On 2.4 w/ trace enabled, I see an occasional shutdown hang:
000cdc88 7690149d 0030
ntdll_76f4!ZwWaitForSingleObject+0x15
000cdcf4 74a01194 0030
KERNELBASE!WaitForSingleObjectEx+0x98
000cdd0c 74a01148 0030
kernel32!WaitForSingleObjectExImplementation+0x75
000cdd20 6eec7329 0030 000cdd50 kernel32!WaitForSingleObject+0x12
000cdd30 6eec61a9 0071e968 000cde0c 006edf40 libapr_1!apr_thread_mutex_lock+0x29
000cdd50 6eec64b4 006edf40 000cdda0 000cdd70 libapr_1!apr_file_write+0x189
000cdd68 6ff15b5a 006b 006edf40 6ff49f10 libapr_1!apr_file_puts+0x24
000cdd7c 6ff15713 000cdda0 0069 006edf40 libhttpd!write_logline+0x3a
000cfdf8 6ff1533e 6ff49d6c 01a7 libhttpd!log_error_core+0x3c3
000cfe2c 6ff2e16c 6ff49d6c 01a7 libhttpd!ap_log_error_+0x2e
000cfe58 6ff2e138 0071c8d0 6eec8dd8 libhttpd!end_gen+0x2c
000cfe60 6eec8dd8 005aa630 000cfe94 libhttpd!ap_mpm_end_gen_helper+0x68
000cfe70 6eec808b 005aa608 6ff04320 005a8628 libapr_1!run_cleanups+0x18
000cfe94 6eec807b 005aa5f8 6ff04320 libapr_1!apr_pool_destroy+0x3b
000cfeb8 00401e67 005a85f0 000cff14 00401be8 libapr_1!apr_pool_destroy+0x2b
000cfec4 00401be8 005a8710 httpd!destroy_and_exit_process+0x27
000cff14 00402773 0003 005a14f0 005a1790 httpd!main+0xbe8
000cff88 74a033aa 7efde000 000cffd4 76f79ef2 httpd!mainCRTStartup+0xe3
000cff94 76f79ef2 7efde000 7a7b5d63 kernel32!BaseThreadInitThunk+0xe
000cffd4 76f79ec5 00402690 7efde000
ntdll_76f4!__RtlUserThreadStart+0x70
000cffec 00402690 7efde000
ntdll_76f4!_RtlUserThreadStart+0x1b
Removing the one TRACE message in end_gen() makes it go away. I have
not backtracked to figure out if the mutex is somehow cleaned up
already, but sharing early in case it makes sense to anyone.
I also noticed that the service.c code will wait forever, would a cap
on that + an error make sense? While the stack above was trying to
exit, the -k stop proc was here:
739: do {
740: Sleep(1000);
741: if (!QueryServiceStatus(schService, globdat.ssStatus))
742: return FALSE;
743: } while (globdat.ssStatus.dwCurrentState == pending);
744:
745: return (globdat.ssStatus.dwCurrentState == complete);
746: }
747:
748:
--
Eric Covener
cove...@gmail.com
Re: svn commit: r1455225 - in /httpd/httpd/branches/2.4.x: ./ docs/manual/ docs/manual/howto/ docs/manual/mod/ include/ modules/filters/ modules/generators/ modules/slotmem/ os/unix/ server/ support/
On Mon, Mar 11, 2013 at 12:38 PM, j...@apache.org wrote: Author: jim Date: Mon Mar 11 16:38:39 2013 New Revision: 1455225 URL: http://svn.apache.org/r1455225 Log: Merge r1442865, r1442759, r1442326, r1442309, r1448171, r1418556, r1448453, r1425771, r1425772, r1425775 from trunk: Change bzero/bcopy into memset/memcpy PR 54346 Can't figure out why we allocate len+2 bytes here. Len+1 should be enough. Fix valgrind warning about uninitialized memory in argument to semctl PR: 53690 Submitted by: Mikhail T. mi+apache aldan algebra com fix valgrind warnings about uninitialized memory in syscall arguments This is useful info for mod_status ;) Add some __attribute__ for automatic format checking. Correct one catch in sed0.c. Correct some spelling. Replace strdup by ap_malloc to ensure a proper error message if out-of-memory. While there, only allocate memory for the string part we actually use. PR: 54345 Exit with error message if out of mem htdbm, htpasswd: print error message if out of memory PR: 54345 Submitted by: jailletc36, sf, sf, jim, jailletc36, minfrin, sf, sf, sf Reviewed/backported by: jim Modified: httpd/httpd/branches/2.4.x/ (props changed) httpd/httpd/branches/2.4.x/STATUS httpd/httpd/branches/2.4.x/docs/manual/ (props changed) httpd/httpd/branches/2.4.x/docs/manual/howto/ (props changed) httpd/httpd/branches/2.4.x/docs/manual/mod/ (props changed) httpd/httpd/branches/2.4.x/include/httpd.h httpd/httpd/branches/2.4.x/include/util_filter.h httpd/httpd/branches/2.4.x/modules/filters/regexp.h httpd/httpd/branches/2.4.x/modules/filters/sed0.c httpd/httpd/branches/2.4.x/modules/generators/mod_status.c httpd/httpd/branches/2.4.x/modules/slotmem/mod_slotmem_shm.c httpd/httpd/branches/2.4.x/os/unix/unixd.c httpd/httpd/branches/2.4.x/server/config.c httpd/httpd/branches/2.4.x/server/util.c httpd/httpd/branches/2.4.x/support/htdbm.c httpd/httpd/branches/2.4.x/support/htpasswd.c httpd/httpd/branches/2.4.x/support/passwd_common.c httpd/httpd/branches/2.4.x/support/passwd_common.h httpd/httpd/branches/2.4.x/support/suexec.c httpd/httpd/branches/2.4.x/test/test_limits.c Propchange: httpd/httpd/branches/2.4.x/ -- Merged /httpd/httpd/trunk:r1418556,1425771-1425772,1425775,1442309,1442326,1442759,1442865,1448171,1448453 Modified: httpd/httpd/branches/2.4.x/STATUS URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1455225r1=1455224r2=1455225view=diff == --- httpd/httpd/branches/2.4.x/STATUS (original) +++ httpd/httpd/branches/2.4.x/STATUS Mon Mar 11 16:38:39 2013 @@ -90,39 +90,11 @@ RELEASE SHOWSTOPPERS: PATCHES ACCEPTED TO BACKPORT FROM TRUNK: [ start all new proposals below, under PATCHES PROPOSED. ] - - * Set of easy patches to keep 2.4.x in line with trunk - 1442865: Change bzero/bcopy into memset/memcpy (PR 54346) - 1442759: Can't figure out why we allocate len+2 bytes here. Len+1 should be enough. - 1442326: Fix valgrind warning about uninitialized memory in argument to semctl (PR 53690) - 1442309: fix valgrind warnings about uninitialized memory in syscall arguments - 1448171: This is useful info for mod_status ;) - 1418556: Add some __attribute__ for automatic format checking. - 1448453: Correct some spelling. - 1425771: Replace strdup by ap_malloc to ensure a proper error message if out-of-memory. (PR 54345) - 1425772: Exit with error message if out of mem (PR 54345) - 1425775: htdbm, htpasswd: print error message if out of memory (PR 54345) -trunk patches: - http://svn.apache.org/viewvc?view=revisionrevision=1442865 - http://svn.apache.org/viewvc?view=revisionrevision=1442759 - http://svn.apache.org/viewvc?view=revisionrevision=1442326 - http://svn.apache.org/viewvc?view=revisionrevision=1442309 - http://svn.apache.org/viewvc?view=revisionrevision=1448171 - http://svn.apache.org/viewvc?view=revisionrevision=1418556 - http://svn.apache.org/viewvc?view=revisionrevision=1448453 - http://svn.apache.org/viewvc?view=revisionrevision=1425771 - http://svn.apache.org/viewvc?view=revisionrevision=1425772 - http://svn.apache.org/viewvc?view=revisionrevision=1425775 -2.4.x patch: trunk patches apply (minus CHANGES for 1448171) -2.4.x cumulative patch: http://people.apache.org/~jailletc36/backport5.patch (minus CHANGES for 1448171) -+1: jailletc36, igalic, jim - * mod_cache_disk: fix merge of min/max file size by setting corresponding _set trunk patch: http://svn.apache.org/r1453604 2.4.x patch: trunk patch works +1: humbedooh, jim, covener - PATCHES PROPOSED TO BACKPORT FROM
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On Thu, Jul 11, 2013 at 2:54 PM, Jim Jagielski j...@jagunet.com wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ [X] +1: Good to go Tested with event on FreeBSD 9 (amd64). The only regression I see w.r.t. 2.4.4 is this new warning (discussed on the commit e-mail thread): mod_negotiation.c: In function 'handle_map_file': mod_negotiation.c:3053: warning: null format string -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: [VOTE] Release Apache httpd 2.4.5 as GA
Hi Jeff, On 14.07.2013 03:46, Jeff Trawick wrote: Tested with event on FreeBSD 9 (amd64). I'm running the test suite on an ASF FreeBSD 9 system as well. There I get two observations: - long (several minutes) hanging in t/apache/limits.t Failed test 8 in t/apache/limits.t at line 141 (Read timeout) - unterminated hanging in t/protocol/nntp-like.t It seems the mod_nntp_like_ssl tests work, and the mod_nntp_like tests fail somewhere after the first one. Since I don't have any comparable results for 2.4.4 (yet) or earlier: do you see something similar? It could be a client thing, I'm using perl 5.14.2 from the ports and yesterdays versions of Apache::Bundle, test framework etc. Regards, Rainer
