Re: svn commit: r1729873 - in /httpd/httpd/branches/2.4.x: ./ STATUS modules/ssl/ssl_engine_kernel.c

2016-02-14 Thread Christophe JAILLET

Le 11/02/2016 20:03, j...@apache.org a écrit :

Author: jim
Date: Thu Feb 11 19:03:04 2016
New Revision: 1729873

URL: http://svn.apache.org/viewvc?rev=1729873=rev
Log:
Merge r1717816 from trunk:

Fix missing Upgrade headers on OPTION * requests, PR58688
Submitted by: wrowe
Reviewed/backported by: jim

Modified:
 httpd/httpd/branches/2.4.x/   (props changed)
 httpd/httpd/branches/2.4.x/STATUS
 httpd/httpd/branches/2.4.x/modules/ssl/ssl_engine_kernel.c




Maybe this one should have a CHANGE entry?

Best regards,
CJ


Re: svn commit: r1729495 [2/2] - in /httpd/httpd/branches/2.4.x: ./ modules/aaa/ modules/arch/win32/ modules/core/ modules/examples/ modules/filters/ modules/http2/ modules/loggers/ modules/lua/ modul

2016-02-14 Thread Christophe JAILLET

Le 10/02/2016 00:09, rj...@apache.org a écrit :

Modified: httpd/httpd/branches/2.4.x/server/mpm/event/event.c
URL: 
http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/server/mpm/event/event.c?rev=1729495=1729494=1729495=diff
@@ -3245,7 +3247,7 @@ static int event_check_config(apr_pool_t
  ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, 
APLOGNO(00497)
   "WARNING: ServerLimit of %d exceeds compile-time "
   "limit of", server_limit);
-ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL,
+ap_log_error(APLOG_MARK, APLOG_WARNING | APLOG_STARTUP, 0, NULL, 
APLOGNO(03105)
   " %d servers, decreasing to %d.",
   MAX_SERVER_LIMIT, MAX_SERVER_LIMIT);
  } else {



Should we really add an APLOGNO here? It looks like a multi-line log 
message.


This is the same for APLOGNO(03105) --> APLOGNO(03116) in event.c. 
Similar code can also be found in other MPM.


Best regards,
CJ



Re: [Update] Support for OpenSSL 1.1.0

2016-02-14 Thread Rainer Jung
The nice people at OpenSSL have already committed the two patches 
(renegotiation with ECDHE ciphers, detecting HTTP-on-HTTPS) and I think 
I found an easy way to trigger renegotiation without polling (using 
SSL_peek).


The current code runs the test suite with 1.0.2 and with 1.1.0 without 
any ssl related failures.


I'll let it settle a bit and test again once OpenSSL 1.1.0pre3 is out 
before suggesting backport to 2.4. I also need to set up the test suite 
environment for 2.4 with support for OpenSSL 0.9.8 to check against 
regressions.


Regards,

Rainer


Re: [PATCH 58985] Add 451 status code

2016-02-14 Thread Jim Jagielski
Thx. Will review asap.

> On Feb 13, 2016, at 8:01 PM, Yehuda Katz  wrote:
> 
> Hello all,
> I looked into the missing 451 status code because someone asked about it on 
> the users list. It seems like a simple enough patch - since it is just 
> copying an existing feature.
> I am looking at possible contributing more and I am interested in feedback.
> 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=58985
> 
> - Y



Re: Proposal for a new mod_event documentation page

2016-02-14 Thread Luca Toscano
I changed the AsyncRequestWorkerFactor section with my understanding and
with some calculations showed by Rainer in previous threads:

https://httpd.apache.org/docs/trunk/mod/event.html

Let me know if you like it and if what I've written is sound, I'd like some
confirmation before back-porting to 2.4.

Thank!

Luca



2016-02-10 12:20 GMT+01:00 Luca Toscano :

> Hi Stefan,
>
> thanks a lot for all the suggestions and help for this change! I am
> planning to add more info about AsyncRequestWorkerFactor as second step
> with another commit, I believe that a more detailed explanation would help
> a lot too.
>
> Luca
>
> 2016-02-10 10:43 GMT+01:00 Stefan Eissing :
>
>> I like it. Good explanation and also the pointer to mod_status and how to
>> see what the effect of event is, helps people.
>>
>> One point: do we have any data or counseling on AsyncRequestWorkerFactor?
>> Smaller is safe, sure, but what about higher values?
>>
>> -Stefan
>>
>> > Am 09.02.2016 um 22:38 schrieb Luca Toscano :
>> >
>> > After some feedbacks I updated the trunk documentation:
>> >
>> > https://httpd.apache.org/docs/trunk/mod/event.html
>> >
>> > Please let me know if you like the new page and the new information
>> contained. In case, I'll backport the change to 2.4.x, otherwise I'll
>> revert.
>> >
>> > Thanks!
>> >
>> > Luca
>> >
>> >
>> > 2016-02-08 15:32 GMT+01:00 Luca Toscano :
>> > +dev for visibility
>> >
>> > -- Messaggio inoltrato --
>> > Da: "Luca Toscano" 
>> > Data: 06 feb 2016 15:10
>> > Oggetto: Proposal for a new mod_event documentation page
>> > A: 
>> > Cc:
>> >
>> > Hi Apache Devs!
>> >
>> > I started an email thread some days ago on the dev mailing list to
>> gather information about mod_event, getting tons of interesting things to
>> read. I attached to this email a draft of how the new page should look like
>> in my opinion, please let me know your thoughts!
>> >
>> > Notes about the changes:
>> >
>> > - clear statement that event shares all the configuration directives
>> with worker, together with the fact that the number of threads is regulated
>> by processes multiplied by threads per child.
>> >
>> > - explanation of the new async connections fields in mod_status.
>> >
>> > - tried to add all the information about keep alives, writing and
>> closing connections that I've gathered so far. I added a disclaimer for the
>> writing ones and a big section called "limitations", but I have probably
>> failed to describe all the closing ones (not only lingering closes I
>> suppose, but I wasn't sure).
>> >
>> > - clear logic connection between how it works and the
>> "AsyncRequestWorkerFactor" directive section (I am referring to the
>> sentence "The event MPM handles some connections in an asynchronous way").
>> >
>> > Apologies for technical inaccuracies and/or typos!
>> >
>> > Luca
>> >
>>
>>
>


Re: balancer-manager docs

2016-02-14 Thread Luca Toscano
I like the how-to a lot!

Would it be useful to add a "logging" section explaining best practices
about how to enable logging of the various modules?
A lot of people ask for instruction about how to track what mod_proxy does
in the background, plus I think it would be really useful to have a history
of the status of each BalancerMember over time (for example to correlate
when a backend server was put out of the Balancer set due to health check
failures with access/error/etc.. logs after an outage - a balancer-manager
history written down somewhere).

Hope that this make sense!

Luca

2016-02-12 10:04 GMT+01:00 Daniel :

> Looks very nice indeed! For being a "rough" version looks quite complete.
> Also the diagram is a cool addition to help people understand how reverse
> proxying works.
>
> I think the examples may need some adjusting with the matching slashes:
>
> ProxyPass "/" "http://www.example.com;
> should be:
> ProxyPass / http://www.example.com/
> (I removed the quotes because they are not necessary)
>
> and
> ProxyPass "/images" "http://www.example.com;
> should be:
> ProxyPass /images/ http://www.example.com/
>
>
> Cheers!
>
>
>
>
> El vie., 12 feb. 2016 a las 9:48, Stefan Eissing (<
> stefan.eiss...@greenbytes.de>) escribió:
>
>> Very nice!
>>
>> > Am 11.02.2016 um 18:46 schrieb Jim Jagielski :
>> >
>> > A rough and very brief framework of such a guide is now available...
>> >
>> >http://httpd.apache.org/docs/trunk/howto/reverse_proxy.html
>> >
>> > On 2016-02-10 06:21, Luca Toscano  wrote:
>> >> 2016-02-10 10:33 GMT+01:00 Stefan Eissing <
>> stefan.eiss...@greenbytes.de>:
>> >>
>> >>> If you write one, I write one for http2! :-)
>> >>>
>> >>>
>> >> +1+1+1+1 :)
>> >>
>> > --
>> > Sent via Pony Mail for dev@httpd.apache.org.
>> > View this email online at:
>> > https://pony-poc.apache.org/list.html?dev@httpd.apache.org
>>
>>