Re: [PATCH] Return HTTP 431 (Request Header Fields Too Large) for requests with large headers
On Tue, 27 Aug 2019 at 19:04, Roy T. Fielding wrote: > > > On Aug 27, 2019, at 5:19 AM, Ivan Zhakov wrote: > > > > On Wed, 14 Mar 2018 at 10:05, Ivan Zhakov wrote: > >> > >> Hi, > >> > >> Please find patch that changes HTTPD to return HTTP 431 (Request > >> Header Fields Too Large) for requests with large headers. This status > >> code is defined by RFC 6585 [1]. Currently HTTPD returns generic HTTP > >> 400 (Bad Request) status code for requests with large headers. > >> > >> [1] https://tools.ietf.org/html/rfc6585#section-5 > >> > > Hey folks, > > > > Is there any feedback on the proposed patch? > > > > I believe that using the custom status code would be more appropriate > > in these cases. > > I missed the patch, but +1 to the idea. We should always use a specific code > when available. > The patch is available at the beginning of this thread: https://lists.apache.org/thread.html/6d709e8882cd5bfa59c5e48bf3011fe914efa5c586b7d5a4e1f1b887@%3Cdev.httpd.apache.org%3E -- Ivan Zhakov
Re: [PATCH] Return HTTP 431 (Request Header Fields Too Large) for requests with large headers
> On Aug 27, 2019, at 5:19 AM, Ivan Zhakov wrote: > > On Wed, 14 Mar 2018 at 10:05, Ivan Zhakov wrote: >> >> Hi, >> >> Please find patch that changes HTTPD to return HTTP 431 (Request >> Header Fields Too Large) for requests with large headers. This status >> code is defined by RFC 6585 [1]. Currently HTTPD returns generic HTTP >> 400 (Bad Request) status code for requests with large headers. >> >> [1] https://tools.ietf.org/html/rfc6585#section-5 >> > Hey folks, > > Is there any feedback on the proposed patch? > > I believe that using the custom status code would be more appropriate > in these cases. I missed the patch, but +1 to the idea. We should always use a specific code when available. Roy
[no subject]
Re: [PATCH] Return HTTP 431 (Request Header Fields Too Large) for requests with large headers
On Wed, 14 Mar 2018 at 10:05, Ivan Zhakov wrote: > > Hi, > > Please find patch that changes HTTPD to return HTTP 431 (Request > Header Fields Too Large) for requests with large headers. This status > code is defined by RFC 6585 [1]. Currently HTTPD returns generic HTTP > 400 (Bad Request) status code for requests with large headers. > > [1] https://tools.ietf.org/html/rfc6585#section-5 > Hey folks, Is there any feedback on the proposed patch? I believe that using the custom status code would be more appropriate in these cases. Thanks! -- Ivan Zhakov
