Re: [VOTE] Release httpd-2.4.54-rc3 as httpd-2.4.54

2022-06-08 Thread Petr Gajdos
On Mon, Jun 06, 2022 at 04:25:31PM +0200, Stefan Eissing wrote:
[x] +1: It's not just good, it's good enough!

SLE 15sp4, openSUSE 15.4,Tumbleweed

-- 
Have a lot of fun!


Re: [VOTE] Release httpd-2.4.33

2018-03-20 Thread Petr Gajdos
On Sat, Mar 17, 2018 at 06:43:15PM -0500, Daniel Ruggeri wrote:
> Hi, all;
>Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/

Hi,

works for me

https://build.opensuse.org/package/show/Apache:Test/apache-test

Petr


Re: [VOTE] Release Apache httpd 2.4.29 as GA

2017-10-18 Thread Petr Gajdos
On Tue, Oct 17, 2017 at 03:00:36PM -0400, Jim Jagielski wrote:
> The pre-release test tarballs for Apache httpd
> version 2.4.29 can be found at the usual place:
> 
>   http://httpd.apache.org/dev/dist/
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.29 GA.
> 
> [ ] +1: Good to go
> [ ] +0: meh
> [ ] -1: Danger Will Robinson. And why.

+1 here
https://build.opensuse.org/package/live_build_log/Apache:Test/apache-test/Apache_Tumbleweed/x86_64

Petr


Re: httpd test suite breakage

2016-11-29 Thread Petr Gajdos
On Tue, Nov 29, 2016 at 01:09:25PM +, Joe Orton wrote:
> On Mon, Nov 28, 2016 at 05:16:12PM -0600, William A Rowe Jr wrote:
> > httpd: Syntax error on line 295 of
> > /home/wrowe/dev/test/test24-apr16-ossl102/t/conf/httpd.conf: Cannot load
> > /home/wrowe/dev/test/test24-apr16-ossl102/c-modules/test_session/.libs/mod_test_session.so
> > into server:
> > /home/wrowe/dev/test/test24-apr16-ossl102/c-modules/test_session/.libs/mod_test_session.so:
> > undefined symbol: ap_hook_session_save
> > 
> > Does anyone have an uncommitted test framework patch
> > up their sleeve to remedy?
> 
> Modules using the session API can't be loaded if mod_session isn't 
> loaded.
> 
> To make this "work" in the test framework we'd need to surround the 
> generated LoadModule for mod_test_session with  
> or something.  I don't know if that can be done without hacking around 
> inside Apache::Test.

I was thinking about text file along each c-module which would express
the required modules which would be translated to .

Petr



Re: failing t/php/strings2.t

2016-11-03 Thread Petr Gajdos
On Wed, Nov 02, 2016 at 06:33:18PM -0500, William A Rowe Jr wrote:
> Committed all three patches in r1767800, thanks Petr

Thank you.

Petr


failing t/php/cfunctions.t

2016-11-02 Thread Petr Gajdos
Hello,

the cause is missing call_user_method() function in php7:

http://php.net/manual/en/function.call-user-method.php

The same page suggest to use call_user_func() instead [1]. Tested with
php 7.0 down to 5.2 and it seems to work everywhere.

Petr

[1]
https://build.opensuse.org/package/view_file/Apache:Test/apache-test/apache-test-php-missing-call_user_method.patch


failing t/php/strings4.t

2016-11-02 Thread Petr Gajdos
Hello,

another of few tests that are failing for me. The cause seem to be
encoding of the php test script. The reason is behind changing
default value of encoding parameter in different php versions.

http://php.net/manual/en/function.htmlspecialchars.php
(similarly for htmlentities())

If you decide to leave the test, I would propose following change in
attached patch. If I tested correctly, it works for php 7.0 and down
to php 5.2.

Petr

Index: httpd-framework/t/htdocs/php/strings4.php
===
--- httpd-framework.orig/t/htdocs/php/strings4.php	2016-10-25 14:30:54.470711221 +0200
+++ httpd-framework/t/htdocs/php/strings4.php	2016-11-02 11:27:56.084010115 +0100
@@ -1,5 +1,5 @@
 \"&åÄ\n");
-echo htmlentities ("<>\"&åÄ\n");
+echo htmlspecialchars ("<>\"&åÄ\n", ENT_COMPAT, "ISO-8859-1");
+echo htmlentities ("<>\"&åÄ\n", ENT_COMPAT, "ISO-8859-1");
 ?>


Re: failing t/php/strings2.t

2016-11-01 Thread Petr Gajdos
On Tue, Nov 01, 2016 at 10:12:31AM -0500, William A Rowe Jr wrote:
> On Tue, Nov 1, 2016 at 8:22 AM, Petr Gajdos <pgaj...@suse.cz> wrote:
> $ php -r 'var_dump(rawurlencode("~"));'
> string(1) "~"
> $
> 
> http://php.net/manual/en/function.rawurlencode.php
> 
> Following patch is perhaps needed:
> https://build.opensuse.org/package/view_file/Apache:Test/apache-test/
> apache-test-php-rawurlencode-tilde.patch
> 
> 
> Silly follow-up question, why %7E out of urlencode() a few lines further down?
> 
> The canonical form of '~' is '~', not '%7E', as the character is not reserved.

Not that I can answer this question, but urlencode() seem to convert
it so:

http://php.net/manual/en/function.urlencode.php

$ php -r 'var_dump(urlencode("~"));'
string(3) "%7E"
$ php --version
PHP 7.0.12 (cli) ( NTS )
[..]
$

Petr



failing t/php/strings2.t

2016-11-01 Thread Petr Gajdos
Hi,

php 5.2 rawurlencode() converts tilde to %7E, this is not true from php
5.3 on, though:

$ php -r 'var_dump(rawurlencode("~"));'
string(1) "~"
$

http://php.net/manual/en/function.rawurlencode.php

Following patch is perhaps needed:
https://build.opensuse.org/package/view_file/Apache:Test/apache-test/apache-test-php-rawurlencode-tilde.patch

Petr