Re: PATCH: mod_log_config, CookieLog

2011-09-19 Thread Graham Leggett 

On 19 Sep 2011, at 1:28 AM, Rich Bowen wrote:

The CookieLog directive has been documented as deprecated since  
mod_log_config was introduced, back in the 1.2 days. Any objection  
to axing it?


Axe it, +1.

Regards,
Graham
--



smime.p7s
Description: S/MIME cryptographic signature

Re: PATCH: mod_log_config, CookieLog

2011-09-19 Thread Jim Jagielski 
bye bye :)

On Sep 18, 2011, at 7:28 PM, Rich Bowen wrote:

 The CookieLog directive has been documented as deprecated since 
 mod_log_config was introduced, back in the 1.2 days. Any objection to axing 
 it?
 
 
 
 
 Index: docs/manual/mod/mod_log_config.xml
 ===
 --- docs/manual/mod/mod_log_config.xml(revision 1172391)
 +++ docs/manual/mod/mod_log_config.xml(working copy)
 @@ -361,23 +361,6 @@
 /directivesynopsis
 
 directivesynopsis
 -nameCookieLog/name
 -descriptionSets filename for the logging of cookies/description
 -syntaxCookieLog varfilename/var/syntax
 -contextlistcontextserver config/contextcontextvirtual host/context
 -/contextlist
 -compatibilityThis directive is deprecated./compatibility
 -
 -usage
 -pThe directiveCookieLog/directive directive sets the 
 -filename for logging of cookies. The filename is relative to the
 -directive module=coreServerRoot/directive. This directive is
 -included only for compatibility with codemod_cookies/code,
 -and is deprecated./p
 -/usage
 -/directivesynopsis
 -
 -directivesynopsis
 nameCustomLog/name
 descriptionSets filename and format of log file/description
 syntaxCustomLog  varfile/var|varpipe/var
 Index: modules/loggers/mod_log_config.c
 ===
 --- modules/loggers/mod_log_config.c  (revision 1172391)
 +++ modules/loggers/mod_log_config.c  (working copy)
 @@ -31,9 +31,6 @@
  *Log to file fn with format given by the format
  *argument
  *
 - *CookieLog fnFor backwards compatability with old Cookie
 - *logging module - now deprecated.
 - *
  * There can be any number of TransferLog and CustomLog
  * commands. Each request will be logged to _ALL_ the
  * named files, in the appropriate format.
 @@ -1284,11 +1281,6 @@
 return add_custom_log(cmd, dummy, fn, NULL, NULL);
 }
 
 -static const char *set_cookie_log(cmd_parms *cmd, void *dummy, const char 
 *fn)
 -{
 -return add_custom_log(cmd, dummy, fn, %{Cookie}n \%r\ %t, NULL);
 -}
 -
 static const char *set_buffered_logs_on(cmd_parms *parms, void *dummy, int 
 flag)
 {
 buffered_logs = flag;
 @@ -1311,8 +1303,6 @@
  the filename of the access log),
 AP_INIT_TAKE12(LogFormat, log_format, NULL, RSRC_CONF,
  a log format string (see docs) and an optional format name),
 -AP_INIT_TAKE1(CookieLog, set_cookie_log, NULL, RSRC_CONF,
 - the filename of the cookie log),
 AP_INIT_FLAG(BufferedLogs, set_buffered_logs_on, NULL, RSRC_CONF,
  Enable Buffered Logging (experimental)),
 {NULL}
 
 
 
 --
 Rich Bowen
 rbo...@rcbowen.com
 rbo...@apache.org

PATCH: mod_log_config, CookieLog

2011-09-18 Thread Rich Bowen 
The CookieLog directive has been documented as deprecated since mod_log_config 
was introduced, back in the 1.2 days. Any objection to axing it?




Index: docs/manual/mod/mod_log_config.xml
===
--- docs/manual/mod/mod_log_config.xml  (revision 1172391)
+++ docs/manual/mod/mod_log_config.xml  (working copy)
@@ -361,23 +361,6 @@
 /directivesynopsis
 
 directivesynopsis
-nameCookieLog/name
-descriptionSets filename for the logging of cookies/description
-syntaxCookieLog varfilename/var/syntax
-contextlistcontextserver config/contextcontextvirtual host/context
-/contextlist
-compatibilityThis directive is deprecated./compatibility
-
-usage
-pThe directiveCookieLog/directive directive sets the 
-filename for logging of cookies. The filename is relative to the
-directive module=coreServerRoot/directive. This directive is
-included only for compatibility with codemod_cookies/code,
-and is deprecated./p
-/usage
-/directivesynopsis
-
-directivesynopsis
 nameCustomLog/name
 descriptionSets filename and format of log file/description
 syntaxCustomLog  varfile/var|varpipe/var
Index: modules/loggers/mod_log_config.c
===
--- modules/loggers/mod_log_config.c(revision 1172391)
+++ modules/loggers/mod_log_config.c(working copy)
@@ -31,9 +31,6 @@
  *Log to file fn with format given by the format
  *argument
  *
- *CookieLog fnFor backwards compatability with old Cookie
- *logging module - now deprecated.
- *
  * There can be any number of TransferLog and CustomLog
  * commands. Each request will be logged to _ALL_ the
  * named files, in the appropriate format.
@@ -1284,11 +1281,6 @@
 return add_custom_log(cmd, dummy, fn, NULL, NULL);
 }
 
-static const char *set_cookie_log(cmd_parms *cmd, void *dummy, const char *fn)
-{
-return add_custom_log(cmd, dummy, fn, %{Cookie}n \%r\ %t, NULL);
-}
-
 static const char *set_buffered_logs_on(cmd_parms *parms, void *dummy, int 
flag)
 {
 buffered_logs = flag;
@@ -1311,8 +1303,6 @@
  the filename of the access log),
 AP_INIT_TAKE12(LogFormat, log_format, NULL, RSRC_CONF,
  a log format string (see docs) and an optional format name),
-AP_INIT_TAKE1(CookieLog, set_cookie_log, NULL, RSRC_CONF,
- the filename of the cookie log),
 AP_INIT_FLAG(BufferedLogs, set_buffered_logs_on, NULL, RSRC_CONF,
  Enable Buffered Logging (experimental)),
 {NULL}



--
Rich Bowen
rbo...@rcbowen.com
rbo...@apache.org