Re: [VOTE] Release Apache httpd 2.4.5 as GA
On Mon, Jul 15, 2013 at 1:43 PM, Jim Jagielski j...@jagunet.com wrote: On Jul 14, 2013, at 5:40 PM, Rainer Jung rainer.j...@kippdata.de wrote: I need to create a more simple config for reproduction and follow what happens in the above code change. If you can, we should also add it to the test framework as well. Tried and got bogged down in Apache-Test not parsing multiple address-spec's in each virtulahost. Will try to come back to it.
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On Sun, 2013-07-14 at 23:40 +0200, Rainer Jung wrote: On 14.07.2013 23:05, Rainer Jung wrote: On 11.07.2013 20:54, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go [ ] +0: meh [X] -1: Danger Will Robinson. And why. I have to revert my +1. The patch applied for PR54948 breaks vhost mapping. ouch, confirmed, big -1 signature.asc Description: This is a digitally signed message part
RELEASE CANCELED (Re: [VOTE] Release Apache httpd 2.4.5 as GA )
The vote for, and release of, 2.4.5 as GA has been recalled and canceled. On Jul 11, 2013, at 2:54 PM, Jim Jagielski j...@jagunet.com wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go [ ] +0: meh [ ] -1: Danger Will Robinson. And why. Vote will last the normal 72 hrs.
Re: [VOTE] Release Apache httpd 2.4.5 as GA
I would propose that we remove the broken backport and release 2.4.6 with the old 2.4.4 broken behavior. On Jul 15, 2013, at 5:23 AM, Noel Butler noel.but...@ausics.net wrote: On Sun, 2013-07-14 at 23:40 +0200, Rainer Jung wrote: On 14.07.2013 23:05, Rainer Jung wrote: On 11.07.2013 20:54, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go [ ] +0: meh [X] -1: Danger Will Robinson. And why. I have to revert my +1. The patch applied for PR54948 breaks vhost mapping. ouch, confirmed, big -1
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On Jul 14, 2013, at 5:40 PM, Rainer Jung rainer.j...@kippdata.de wrote: I need to create a more simple config for reproduction and follow what happens in the above code change. If you can, we should also add it to the test framework as well.
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On Sat, Jul 13, 2013 at 10:40 PM, Rainer Jung rainer.j...@kippdata.dewrote: Hi Jeff, On 14.07.2013 03:46, Jeff Trawick wrote: Tested with event on FreeBSD 9 (amd64). I'm running the test suite on an ASF FreeBSD 9 system as well. Mine is a VMware VM with 4 CPUs enabled. My original summary: All tests successful. Files=109, Tests=5017, 150 wallclock secs ( 3.30 usr 1.90 sys + 27.27 cusr 62.27 csys = 94.73 CPU) Result: PASS There I get two observations: - long (several minutes) hanging in t/apache/limits.t Failed test 8 in t/apache/limits.t at line 141 (Read timeout) - unterminated hanging in t/protocol/nntp-like.t It seems the mod_nntp_like_ssl tests work, and the mod_nntp_like tests fail somewhere after the first one. Since I don't have any comparable results for 2.4.4 (yet) or earlier: do you see something similar? I didn't originally see any problem with those tests. But I realized that I was getting the accept filter error on startup and after enabling the kernel accept filter module I see the hang with limits.t and nttp-like.t: t/apache/limits.t ... 8/12 # Failed test 8 in t/apache/limits.t at line 141 t/prototocol/nntp-like.thangs very long/forever It could be a client thing, I'm using perl 5.14.2 from the ports and yesterdays versions of Apache::Bundle, test framework etc. perl 5.12.4 from base system, extra perl libraries installed a few weeks ago Retesting 2.4.4 now that the kernel accept filter module is loaded: t/apache/limits.t ... 8/12 # Failed test 8 in t/apache/limits.t at line 141 t/protocol/nntp-like.t hangs very long/forever No regression, but nastier than I thought :( Regards, Rainer -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On 11.07.2013 20:54, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [X] +1: Good to go [ ] +0: meh [ ] -1: Danger Will Robinson. And why. Vote will last the normal 72 hrs. +1 to release, thanks for RM. Detailed report: - Sigs and hashes OK - contents of tarballs identical - contents of tag and tarballs identical except for expected deltas (we could cleanup some m4 files in apr-util/xml/expat/conftools at the end of buildconf, no regression) Built on - Solaris 8+10 Sparc as 32 Bit Binaries - SLES 10 (32/64 Bits) - SLES 11 (64 Bits) - RHEL 5 and 6 (64 Bits) - FreeBSD 9 64 Bits - with default (shared) and static modules - FreeBSD only shared - with module sets none, few, most, all, reallyall and default (always mod_privileges disabled, FreeBSD only all) - using --enable-load-all-modules (except FreeBSD) - against included APR/APU from later removed deps tarball, external APR/APU 1.4.8/1.5.2 (FreeBSD only bundled) - using external libraries - expat 2.1.0 (FreeBSD 2.0.1) - pcre 8.33 (FreeBSD 8.32) - openssl 1.0.1e (plus a few patches) - lua 5.2.2 (not on FreeBSD) - distcache 1.5.1 (not on FreeBSD) - libxml2 2.9.1 (FreeBSD 2.8.0) - Tool chain: - platform gcc except for Solaris (gcc 4.1.2 for Solaris 8 and 4.8.1 for Solaris 10) - CFLAGS: -O2 -g -Wall -fno-strict-aliasing (and -mpcu=v9 on Solaris) All builds succeeded except for - RHEL 6 64 Bits one of 20 builds crashed with a segfault in ksh. Tested for - Solaris 8+10 (32), SLES 10 (32/64), SLES 11 (64), RHEL 5+6 (64), FreeBSD 9 (64) - MPMs prefork, worker, event (except for Solaris 8 - no event) - default (shared) and static modules (FreeBSD only shared) - log levels info, debug and trace8 - module set reallyall (121 modules plus MPMs), FreeBSD all - tests for all, most, few, none and default module sets still running, but reallyall has best coverage All Tests passed with the following exceptions (a-c not on FreeBSD): a Test 5 in t/modules/dav.t: 12 out of 680 runs had the created time after the modified time. This seems to be a system issue, all tests done on NFS, many tested on virtualized guests. Not a regression. b Test 8 in t/ssl/pr12355.t: 6 out of 680 runs failed this test, (4 RHEL 5, 1 on SLES 10 32 Bits, 1 64 Bits, mixture of static and shared builds). 6 bytes were posted, but only between 40KB and 45KB bytes received. Not reproducible, very rare. PR 12355 is: POST incompatible w/ renegotiate https: connection Not a regression. c Various tests in t/apache/expr_string.t: 116 out of 680 runs failed this test, (all on Linux). The failure is mostly on line 68 plus 2 times on line 82 of the tests, where the error_log contents are checked. Inspecting the file after the test shows all needed lines are there but again it seems to be an NFS problem, that the test script can not see the contents quickly enough. Adding a 0.1 seconds sleep before reading the file fixes the problem. Not a regression. d Only on FreeBSD: Failed test 8 in t/apache/limits.t at line 141 Some read timeout if the kernel accept filter is activated. Not a regression. e Only on FreeBSD: hanging in t/protocol/nntp-like.t Not a regression. FreeBSD problem seems to be related to the use of accept filter. Jeff can reproduce and he doesn't get it when the accept filter is not in place. My test system has them activated. Some more test failures were due to insufficient need declarations in the test files, so the test failed when running e.g. with the few module set. I fixed those now: - apache/server_name_port.t - t/modules/alias.t Plus t/modules/include.t had a problem when TZ was not set. I hope I fixed that now (Use of uninitialized value in line 346). Regards, Rainer
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On 11.07.2013 20:54, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go [ ] +0: meh [ ] -1: Danger Will Robinson. And why. I found a problem in a real world scenario: Using the same configuration 2.4.5 resolves HTTPS to another vhost than 2.4.4. Currently I don't understand why it is using that other vhost. Will investigate further. The problem can already be seen using httpd -S, which for 2.4.4 produces a long list of ssl vhost, most of which are missing for 2.4.5. Jim, could you hold the vote open for a few hours more? Regards, Rainer
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On Jul 14, 2013, at 5:05 PM, Rainer Jung rainer.j...@kippdata.de wrote: On 11.07.2013 20:54, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go [ ] +0: meh [ ] -1: Danger Will Robinson. And why. I found a problem in a real world scenario: Using the same configuration 2.4.5 resolves HTTPS to another vhost than 2.4.4. Currently I don't understand why it is using that other vhost. Will investigate further. The problem can already be seen using httpd -S, which for 2.4.4 produces a long list of ssl vhost, most of which are missing for 2.4.5. Jim, could you hold the vote open for a few hours more? No prob.
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On 14.07.2013 23:05, Rainer Jung wrote: On 11.07.2013 20:54, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go [ ] +0: meh [X] -1: Danger Will Robinson. And why. I have to revert my +1. The patch applied for PR54948 breaks vhost mapping. It is http://svn.apache.org/viewvc?view=revisionrevision=1485675 backported from http://svn.apache.org/viewvc?view=revisionrevision=1481306 The change was not applied to 2.2. The config in question has a default vhost plus a wildcard vhost plus lots of specific vhosts (all for the same 443 port) and version 2.4.5 only shows the default and the wild card vhost in the -S output and the config works the same way, so the more specific vhosts are hidden. Using 2.4.4 or undoing the single commit for 2.4.5 shows the expected behavior. I need to create a more simple config for reproduction and follow what happens in the above code change. Regards, Rainer
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On 14.07.2013 23:40, Rainer Jung wrote: On 14.07.2013 23:05, Rainer Jung wrote: On 11.07.2013 20:54, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go [ ] +0: meh [X] -1: Danger Will Robinson. And why. I have to revert my +1. The patch applied for PR54948 breaks vhost mapping. It is http://svn.apache.org/viewvc?view=revisionrevision=1485675 backported from http://svn.apache.org/viewvc?view=revisionrevision=1481306 The change was not applied to 2.2. The config in question has a default vhost plus a wildcard vhost plus lots of specific vhosts (all for the same 443 port) and version 2.4.5 only shows the default and the wild card vhost in the -S output and the config works the same way, so the more specific vhosts are hidden. Using 2.4.4 or undoing the single commit for 2.4.5 shows the expected behavior. I need to create a more simple config for reproduction and follow what happens in the above code change. I propose the following patch: http://people.apache.org/~rjung/patches/vhost-pr54948-part2.patch Caution: I did not really understand that code, but tracked what happened during digesting the broken config using additional log output. The original patch for PR54948 not only removed the unwanted internal duplicates but also dropped the 443 part from any :80 :443 VirtualHost. Someone knowing this code better should confirm, whether my addition is correct or whether PR54948 should be fixed in a different way. IMHO the current 2.4.5 code is really broken and we should either release the code with r1485675 reverted or an additional fix on top. The config that was broken is our ASF www.apache.org config. Version 2.4.5 ignored the 443 part of most of the :80 :443 vhosts, more precisely all except for the default vhost and the first internally processed one. Since the first processed one was the last declared one, which was originally meant as a fall through catch all, that vhost now handled all 443 traffic. Regards, Rainer P.S.: It is getting late here, so I will unfortunately soon go offline.
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On Sun, Jul 14, 2013 at 6:50 PM, Rainer Jung rainer.j...@kippdata.de wrote: On 14.07.2013 23:40, Rainer Jung wrote: On 14.07.2013 23:05, Rainer Jung wrote: On 11.07.2013 20:54, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go [ ] +0: meh [X] -1: Danger Will Robinson. And why. I have to revert my +1. The patch applied for PR54948 breaks vhost mapping. It is http://svn.apache.org/viewvc?view=revisionrevision=1485675 backported from http://svn.apache.org/viewvc?view=revisionrevision=1481306 The change was not applied to 2.2. The config in question has a default vhost plus a wildcard vhost plus lots of specific vhosts (all for the same 443 port) and version 2.4.5 only shows the default and the wild card vhost in the -S output and the config works the same way, so the more specific vhosts are hidden. Using 2.4.4 or undoing the single commit for 2.4.5 shows the expected behavior. I need to create a more simple config for reproduction and follow what happens in the above code change. I propose the following patch: http://people.apache.org/~rjung/patches/vhost-pr54948-part2.patch Caution: I did not really understand that code, but tracked what happened during digesting the broken config using additional log output. The original patch for PR54948 not only removed the unwanted internal duplicates but also dropped the 443 part from any :80 :443 VirtualHost. Sorry all. My bugzilla comment implies VH *:80 results in two server_addr_recs (ipv4 and ipv6 flavors of INADDR_ANY?) I think your followup patch makes sense assuming that premise even makes sense (maybe you saw that in your recent debug?), but I do not remember the original debug.
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On Thursday 11 July 2013, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go [ ] +0: meh [ ] -1: Danger Will Robinson. And why. Vote will last the normal 72 hrs. +1, tested on Debian sid
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On 7/11/2013 11:54 AM, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go [ ] +0: meh [ ] -1: Danger Will Robinson. And why. Vote will last the normal 72 hrs. +1 x86: XP Vista x64: Server 2003 2012
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On Thu, Jul 11, 2013 at 2:54 PM, Jim Jagielski j...@jagunet.com wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ [X] +1: Good to go Tested with event on FreeBSD 9 (amd64). The only regression I see w.r.t. 2.4.4 is this new warning (discussed on the commit e-mail thread): mod_negotiation.c: In function 'handle_map_file': mod_negotiation.c:3053: warning: null format string -- Born in Roswell... married an alien... http://emptyhammock.com/
Re: [VOTE] Release Apache httpd 2.4.5 as GA
Hi Jeff, On 14.07.2013 03:46, Jeff Trawick wrote: Tested with event on FreeBSD 9 (amd64). I'm running the test suite on an ASF FreeBSD 9 system as well. There I get two observations: - long (several minutes) hanging in t/apache/limits.t Failed test 8 in t/apache/limits.t at line 141 (Read timeout) - unterminated hanging in t/protocol/nntp-like.t It seems the mod_nntp_like_ssl tests work, and the mod_nntp_like tests fail somewhere after the first one. Since I don't have any comparable results for 2.4.4 (yet) or earlier: do you see something similar? It could be a client thing, I'm using perl 5.14.2 from the ports and yesterdays versions of Apache::Bundle, test framework etc. Regards, Rainer
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On 11 July 2013 20:54, Jim Jagielski j...@jagunet.com wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [x] +1: Good to go [ ] +0: meh [ ] -1: Danger Will Robinson. And why. Debian 8.1 x64 with PHP over mod_fcgid
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On 11.07.2013 20:54, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go [ ] +0: meh [ ] -1: Danger Will Robinson. And why. +1 for NetWare. Gün.
Re: [VOTE] Release Apache httpd 2.4.5 as GA
All fine on Windows. Only a new build warning: mod_cache.c(1175): warning C4003: not enough actual parameters for macro 'APLOGNO' Steffen
Re: [VOTE] Release Apache httpd 2.4.5 as GA
Am 11.07.2013 20:54, schrieb Jim Jagielski: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go [ ] +0: meh [ ] -1: Danger Will Robinson. And why. Vote will last the normal 72 hrs +1 Fedora 18 x86_64 with mod_security / PHP 5.4.17 __ Apache Benchmark to our inhouse CMS: Concurrency Level: 50 Time taken for tests: 34.810 seconds Complete requests: 2 Failed requests:0 Write errors: 0 Total transferred: 678755642 bytes HTML transferred: 668615642 bytes Requests per second:574.55 [#/sec] (mean) Time per request: 87.024 [ms] (mean) Time per request: 1.740 [ms] (mean, across all concurrent requests) Transfer rate: 19041.98 [Kbytes/sec] received signature.asc Description: OpenPGP digital signature
Re: [VOTE] Release Apache httpd 2.4.5 as GA
On Jul 11, 2013, at 2:54 PM, Jim Jagielski j...@jagunet.com wrote: The pre-release test tarballs for Apache httpd 2.4.5 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. [ ] +1: Good to go +1: OSX 10.8.4 (Xcode 4.6.3), Fed18 (x86_64), CentOS5 (x86_64), Fed16 (ppc64), FreeBSD 8.3 (amd64)
Re: [VOTE] Release Apache httpd 2.4.5 as GA
I'm calling a VOTE on releasing these as Apache httpd 2.4.5 GA. NOTE: The -deps tarballs are included here *only* to make life easier for the tester. They will not be, and are not, part of the official release. +1 AIX/xlc/ppc64 --enable-mods-shared --enable-maintainer-mode httpd-framework runs 100%
