Re: [VOTE] Release httpd-2.4.33

2018-03-21 Thread William A Rowe Jr 
On Tue, Mar 20, 2018 at 1:39 PM, William A Rowe Jr  wrote:
> On Sat, Mar 17, 2018 at 6:43 PM, Daniel Ruggeri  wrote:
>> Hi, all;
>>Please find below the proposed release tarball and signatures:
>> https://dist.apache.org/repos/dist/dev/httpd/
>>
>> I would like to call a VOTE over the next few days to release this candidate
>> tarball as 2.4.33:
>
> CentOS 7 is having trouble building mod_md against system
> jansson plus custom curl/openssl, which I am investigating.

This was from installing/uninstalling the dependency so often, I left
it in a absent state. No issues with jansson 2.10 as in RHEL/CentOS 7.

> Ubuntu 16.04 isn't building mod_lua against system lua, which I'm
> investigating. Not a regression.

No issues once I switched from lua5.3 to liblua5.3-dev as shipped in 16.04.

Sorry for the false positives. One question remaining, we have a
group of tests "not fixed yet?" that seem to behave correctly in 2.4.33,
did we forget to toggle these in backport?

Test Summary Report
---
t/apache/server_name_port.t   (Wstat: 0 Tests: 84 Failed: 0)
  TODO passed:   32, 35, 56, 59, 80, 83
t/modules/rewrite.t   (Wstat: 0 Tests: 47 Failed: 0)
  TODO passed:   26

> Still working through the perl framework module dependency matrix
> for Windows, so that's a thing. But sounds like Windows is no worse
> off than back in 2.4.29 timeframe, so that much is good.
>
> In short, nothing I've found suggests less than a +1, yet.

Re: [VOTE] Release httpd-2.4.33

2018-03-21 Thread Daniel Ruggeri 


On 2018/03/17 23:43:15, "Daniel Ruggeri"  wrote: 
> ...
> [ ] +1: It's not just good, it's good enough!
> ...
> 

+1 for the following test:

system:
  kernel:
name: Linux
release: 3.16.0-4-amd64
version: #1 SMP Debian 3.16.39-1 (2016-12-30)
machine: x86_64

  libraries:
openssl: "1.1.0g"
openldap: "2.4.45"
apr: "1.6.3"
apr-util: "1.6.1"
iconv: "1.2.2"
brotli: "1.0.3"
nghttp2: "1.31.0"
zlib: "1.2.11"
pcre: "8.41"
libxml2: "2.9.8"
php: "5.6.34"
lua: "5.3.4"
curl: "7.58.0"

-- 
Daniel Ruggeri

Re: [VOTE] Release httpd-2.4.33

2018-03-20 Thread Noel Butler 
On 18/03/2018 09:43, Daniel Ruggeri wrote:

> Hi, all;
> Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this candidate
> tarball as 2.4.33:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
> 
> The computed digests of the tarball up for vote are:
> md5: e983c251062872e5caf87372776c04c0 *httpd-2.4.33.tar.gz
> sha1: 9a5b95800ec8869cde6c1744dd2ec870c39d43e3 *httpd-2.4.33.tar.gz
> sha256: cd34636caf03c9a897ddfc928fc866c965f23d909b9612880563a7ad0d1a7e5b
> *httpd-2.4.33.tar.gz

+1 all good to go  slackware  13.37 -> -current  w/apr-1.6.3 + apr-util
1.6.1 

-- 
Kind Regards, 

Noel Butler 

This Email, including any attachments, may contain legally 
privileged
information, therefore remains confidential and subject to copyright
protected under international law. You may not disseminate, discuss, or
reveal, any part, to anyone, without the authors express written
authority to do so. If you are not the intended recipient, please notify
the sender then delete all copies of this message including attachments,
immediately. Confidentiality, copyright, and legal privilege are not
waived or lost by reason of the mistaken delivery of this message. Only
PDF [1] and ODF [2] documents accepted, please do not send proprietary
formatted documents 

 

Links:
--
[1] http://www.adobe.com/
[2] http://en.wikipedia.org/wiki/OpenDocument

Re: [VOTE] Release httpd-2.4.33

2018-03-20 Thread Yann Ylavic 
On Tue, Mar 20, 2018 at 10:53 PM, Rainer Jung  wrote:
>
> - compiler warnings:
>
>   - modules/core/mod_watchdog.c:436: warning: 'rv' may be used
> uninitialized in this function
>   -> only on SLES 11, warning is correct but not critical (debug log);
>  not a regression

I don't see where rv can be used unitialzed there.

>
>   on RHEL 6 and SLES 11 due to older GCC versions:
>
>   - modules/md/md_json.c:31: warning: expected [error|warning|ignored] after
> '#pragma GCC diagnostic'
>
>   - modules/md/md_json.c:45: warning: expected [error|warning|ignored] after
> '#pragma GCC diagnostic'

r1827372 ?

>
>   - several "defined but not used" in dependency jansson.h due to strange
> jansson dependency library header files (see my 2.4.32 vote mail for
> details)

r1827373 ?

>
>   and only on Solaris (gcc 7.3.0)
>
>   - modules/ldap/util_ldap_cache_mgr.c:728:32: warning: format '%ld' expects
> argument of type 'long int', but argument 6 has type 'long long int'
> [-Wformat=]
>
>   - modules/ldap/util_ldap_cache.c:111:20: warning: format '%ld' expects
> argument of type 'long int', but argument 8 has type 'long long int'
> [-Wformat=]

r1827366 (hopefully).


Regards,
Yann.

Re: [VOTE] Release httpd-2.4.33

2018-03-20 Thread Rainer Jung 

Am 18.03.2018 um 00:43 schrieb Daniel Ruggeri:

Hi, all;
Please find below the proposed release tarball and signatures:
https://dist.apache.org/repos/dist/dev/httpd/

I would like to call a VOTE over the next few days to release this candidate
tarball as 2.4.33:
[X] +1: It's not just good, it's good enough!
[ ] +0: Let's have a talk.
[ ] -1: There's trouble in paradise. Here's what's wrong.

The computed digests of the tarball up for vote are:
md5: e983c251062872e5caf87372776c04c0 *httpd-2.4.33.tar.gz
sha1: 9a5b95800ec8869cde6c1744dd2ec870c39d43e3 *httpd-2.4.33.tar.gz
sha256: cd34636caf03c9a897ddfc928fc866c965f23d909b9612880563a7ad0d1a7e5b
*httpd-2.4.33.tar.gz


+1 to release and thank for RM!

Detailed report:

- Sigs and hashes OK
- contents of tarballs identical
- contents of tag and tarballs identical
  except for expected deltas
- deps convenience tarball contains latest APR/APU 1.6.3/1.6.1

Built on

- Solaris 10 Sparc as 32 Bit Binaries
- SLES 11+12 (64 Bits)
- RHEL 6+7 (64 Bits)

For all platforms built

- with default (shared), static and explicit shared modules
- with module sets reallyall, all, most, few, none and default
- using --enable-load-all-modules
- against "included" APR/APU from deps tarball,
  plus two types of external APR/APU 1.6.3/1.6.1 plus 1.5.2/1.5.4

- using external libraries
  - expat 2.2.5
  - pcre 8.41
  - openssl 1.0.2n plus patches
  - lua 5.3.4 (compiled with LUA_COMPAT_MODULE)
  - distcache 1.5.1
  - libxml2 2.9.8
  - libnghttp2 1.31.0
  - brotli 1.0.3
  - curl 7.59.0
  - jansson 2.11

- Tool chain:
- platform gcc except on Solaris
  (gcc 7.3.0 Solaris 10, only older APR/APU 1.5.x compiled with 
older gcc 4.9.2)

- CFLAGS: -O2 -g -Wall -fno-strict-aliasing
  - on Solaris additionally -mpcu=v9, -D_XOPEN_SOURCE,
-D_XOPEN_SOURCE_EXTENDED=1, -D__EXTENSIONS__
and -D_XPG6

All 280 builds succeeded.

- compiler warnings:

  - modules/core/mod_watchdog.c:436: warning: 'rv' may be used
uninitialized in this function
  -> only on SLES 11, warning is correct but not critical (debug log);
 not a regression

  on RHEL 6 and SLES 11 due to older GCC versions:

  - modules/md/md_json.c:31: warning: expected [error|warning|ignored] 
after '#pragma GCC diagnostic'


  - modules/md/md_json.c:45: warning: expected [error|warning|ignored] 
after '#pragma GCC diagnostic'


  - several "defined but not used" in dependency jansson.h due to 
strange jansson dependency library header files (see my 2.4.32 vote mail 
for details)


  and only on Solaris (gcc 7.3.0)

  - modules/ldap/util_ldap_cache_mgr.c:728:32: warning: format '%ld' 
expects argument of type 'long int', but argument 6 has type 'long long 
int' [-Wformat=]


  - modules/ldap/util_ldap_cache.c:111:20: warning: format '%ld' 
expects argument of type 'long int', but argument 8 has type 'long long 
int' [-Wformat=]


  - srclib/apr-util/xlate/xlate.c:120:38: warning: passing argument 2 of
'iconv' from incompatible pointer type
[-Wincompatible-pointer-types]

  - srclib/apr-util/xlate/xlate.c:343:42: warning: passing argument 2 of
'iconv' from incompatible pointer type
[-Wincompatible-pointer-types]


Tested for

- Solaris 10, SLES 11+12, RHEL 6+7
- MPMs prefork, worker, event
  - prefork skipped on Solaris due to the accept lock problem that
leads to timeouts and thus excessive testing times in the proxy
- default, shared and static module builds
- log levels info, debug and trace8
- module sets reallyall, all, most, few, none and default
  - for "reallyall" 128 modules plus MPMs, less for other module sets
- in total 2352 combinations

- 2 test runs failed due to core dumps during building the test modules, 
probably due to resource shortage in the VMs.


- 1 test run failed due to core dumps from the perl test framework, 
again probably due to resource shortage in the VMs.


- module set "none" always fails due to "User" directive in default
  config not supported (no mod_unixd)
  AH00526: Syntax error on line 30 of .../t/conf/httpd.conf:
  Invalid command 'User'
  not a regression

The following test failures were seen:

a t/ab/base.t tests 4 and 5 fail for module set "few"
  These are the ssl tests and "few" does not include mod_ssl.
  It seems the check for "is ssl available" in the test file
  does not really work. So this is a test design error.

b Test 59 of t/modules/include.t only and always on
  Solaris.
  Not a regression
  Old analysis was:
  This is due to a bug in the test, which uses strftime()
  with a "%s" pattern that is not supported on Solaris.
  Until recently the server and the test client both returned
  verbatim "%s" and the test succeeded. After updating some
  Perl modules for the http2 tests, the perl client even
  on Solaris now supports "%s" in strftime and the test starts
  to fail. It seems we have to fix the test.

c Various tests in t/apache/expr_string.t
  Not a regression.
  Test numbers : 6, 11, 14, 17, 20, 23, 26, 29
  Happens for

Re: [VOTE] Release httpd-2.4.33

2018-03-20 Thread William A Rowe Jr 
On Sat, Mar 17, 2018 at 6:43 PM, Daniel Ruggeri  wrote:
> Hi, all;
>Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
>
> I would like to call a VOTE over the next few days to release this candidate
> tarball as 2.4.33:
> [ ] +1: It's not just good, it's good enough!

Not quite ready to check the box, but expecting I will be happy
by end of my day here. No regressions observed.

CentOS 7 is having trouble building mod_md against system
jansson plus custom curl/openssl, which I am investigating. Not a
fully supported module yet, so not uncomfortable releasing as-is.

Ubuntu 16.04 isn't building mod_lua against system lua, which I'm
investigating. Not a regression.

Still working through the perl framework module dependency matrix
for Windows, so that's a thing. But sounds like Windows is no worse
off than back in 2.4.29 timeframe, so that much is good.

In short, nothing I've found suggests less than a +1, yet.

Re: [VOTE] Release httpd-2.4.33

2018-03-20 Thread Steffen 

+1 Builds and Runs fine on Windows.

Nothing serious has popped up from the AL community, only a extra 
feature request for mod_md and a watchdog loop

with mod_md which has resolved itself after a few days.


On 18-3-2018 00:43, Daniel Ruggeri wrote:

Hi, all;
Please find below the proposed release tarball and signatures:
https://dist.apache.org/repos/dist/dev/httpd/

I would like to call a VOTE over the next few days to release this candidate
tarball as 2.4.33:
[ ] +1: It's not just good, it's good enough!
[ ] +0: Let's have a talk.
[ ] -1: There's trouble in paradise. Here's what's wrong.

The computed digests of the tarball up for vote are:
md5: e983c251062872e5caf87372776c04c0 *httpd-2.4.33.tar.gz
sha1: 9a5b95800ec8869cde6c1744dd2ec870c39d43e3 *httpd-2.4.33.tar.gz
sha256: cd34636caf03c9a897ddfc928fc866c965f23d909b9612880563a7ad0d1a7e5b
*httpd-2.4.33.tar.gz

Re: [VOTE] Release httpd-2.4.33

2018-03-20 Thread Stefan Eissing 
+1 
 - MacOS 10.13.3
 - Ubuntu 16.04 LTS

> Am 18.03.2018 um 00:43 schrieb Daniel Ruggeri :
> 
> Hi, all;
>   Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this candidate
> tarball as 2.4.33:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
> 
> The computed digests of the tarball up for vote are:
> md5: e983c251062872e5caf87372776c04c0 *httpd-2.4.33.tar.gz
> sha1: 9a5b95800ec8869cde6c1744dd2ec870c39d43e3 *httpd-2.4.33.tar.gz
> sha256: cd34636caf03c9a897ddfc928fc866c965f23d909b9612880563a7ad0d1a7e5b
> *httpd-2.4.33.tar.gz
> 
> -- 
> Daniel Ruggeri
> 
>

Re: [VOTE] Release httpd-2.4.33

2018-03-20 Thread Eric Covener 
On Sat, Mar 17, 2018 at 7:43 PM, Daniel Ruggeri  wrote:
> Hi, all;
>Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
>
> I would like to call a VOTE over the next few days to release this candidate
> tarball as 2.4.33:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
>

+1 aix/xlc/ppc64

 - Using a test fix from openssl for my atexit SIGILL which worked

A few understood / familiar failures on this system.

Thanks Daniel!

Re: [VOTE] Release httpd-2.4.33

2018-03-20 Thread Jacob Perkins 
I love me some OBS. cPanel will likely pull these tests down into our test 
suites as well.

Thanks Petr! 

—
Jacob Perkins
Product Owner
cPanel Inc.

jacob.perk...@cpanel.net 
Office:  713-529-0800 x 4046
Cell:  713-560-8655

> On Mar 20, 2018, at 8:51 AM, Petr Gajdos  wrote:
> 
> On Sat, Mar 17, 2018 at 06:43:15PM -0500, Daniel Ruggeri wrote:
>> Hi, all;
>>   Please find below the proposed release tarball and signatures:
>> https://dist.apache.org/repos/dist/dev/httpd/
> 
> Hi,
> 
> works for me
> 
> https://build.opensuse.org/package/show/Apache:Test/apache-test
> 
> Petr

Re: [VOTE] Release httpd-2.4.33

2018-03-20 Thread Petr Gajdos 
On Sat, Mar 17, 2018 at 06:43:15PM -0500, Daniel Ruggeri wrote:
> Hi, all;
>Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/

Hi,

works for me

https://build.opensuse.org/package/show/Apache:Test/apache-test

Petr

Re: [VOTE] Release httpd-2.4.33

2018-03-20 Thread Jim Jagielski 


> On Mar 17, 2018, at 7:43 PM, Daniel Ruggeri  wrote:
> 
> Hi, all;
>   Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this candidate
> tarball as 2.4.33:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
> 

+1: macOS 10.13.3, Xcode 9.2
CentOS 6.x, 64 and 32bit
Ubuntu 14.04, 64bit

Re: [VOTE] Release httpd-2.4.33

2018-03-20 Thread Yann Ylavic 
On Sun, Mar 18, 2018 at 12:43 AM, Daniel Ruggeri  wrote:
> Hi, all;
>Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
>
> I would like to call a VOTE over the next few days to release this candidate
> tarball as 2.4.33:

+1: It's not just good, it's good enough!

Still good on Debian(s), thanks Daniel!

Re: [VOTE] Release httpd-2.4.33

2018-03-18 Thread Steffen 


±0

Made it available for the AL community.

When some pop's up I try redirect to Bugzilla.



On Sunday 18/03/2018 at 00:43, Daniel Ruggeri  wrote:

Hi, all;
 Please find below the proposed release tarball and signatures:
https://dist.apache.org/repos/dist/dev/httpd/

I would like to call a VOTE over the next few days to release this 
candidate

tarball as 2.4.33:
[ ] +1: It's not just good, it's good enough!
[ ] +0: Let's have a talk.
[ ] -1: There's trouble in paradise. Here's what's wrong.

The computed digests of the tarball up for vote are:
md5: e983c251062872e5caf87372776c04c0 *httpd-2.4.33.tar.gz
sha1: 9a5b95800ec8869cde6c1744dd2ec870c39d43e3 *httpd-2.4.33.tar.gz
sha256: 
cd34636caf03c9a897ddfc928fc866c965f23d909b9612880563a7ad0d1a7e5b

*httpd-2.4.33.tar.gz

--
Daniel Ruggeri