Re: Patch (against trunk) for bug #41960
Hello, Congratulations on the new release 2.2.6. Would there be any possiblity of applying (or reviewing) my outstanding patch? request.c hasn't evolved since I did the patch against trunk. I had also submitted a new test procedure for the test suite. It hasn't yet been commited, although it reproduces the faulty behavior that my patch is intended to fix. I don't know what else to do to be able to submit a valid bug report and potential patch to you: patch against trunk, new test for the perl framework, ... chocolate-chip cookies? I may be missing something in the Apache procedure for submitting this. I would have expected someone to point it out to me since I first submitted the bug report late March. Thanks, -jose
Re: Patch (against trunk) for bug #41960
Jose Kahan wrote: I had also submitted a new test procedure for the test suite. It hasn't yet been commited, although it reproduces the faulty behavior that my patch is intended to fix. Fantasic :) I don't know what else to do to be able to submit a valid bug report and potential patch to you: patch against trunk, new test for the perl framework, ... chocolate-chip cookies? Cookies are good :) Seriously, I'll look, the patch is very easy to follow, the possible side effects aren't so trivial. (I post this as one recently bitten by such side-effects, heh.) I may be missing something in the Apache procedure for submitting this. I would have expected someone to point it out to me since I first submitted the bug report late March. Yes - we have a limited number of voulenteer committers. The best thing to do is to ping the list once every month or so if you want to champion your patch. Eventually, someone's cycles will free up. There's a reason for that exclusion originally and that has to be reviewed before we jump on it, but in principal I'd agree to consider that patch. Bill
Re: Patch (against trunk) for bug #41960
Thanks for the bug report and patch(es). We'll review them after this release... On Aug 10, 2007, at 10:48 AM, Jose Kahan wrote: Hi folks, Just a short messsage to tell you that I just uploaded the patch against svn trunk that fixes this bug. Yes, the patch is still needed as the bug is unfortunately still around :-/. Is there any hope of seeing this patch committed? Our internal production server has been working with it since some months with no side effects. Earlier today I contributed to this list some tests against your svn perl-framework that allows to reproduce the bug. This can be useful if you want to resolve this bug differently. Feel free to contact me if you need further tests or changes to the patch. Best regards and thanks for all your hard work, -jose [1] http://issues.apache.org/bugzilla/show_bug.cgi?id=41960
