Re: svn commit: r1913936 - /httpd/httpd/branches/2.4.x/STATUS

2023-11-18 Thread Graham Leggett via dev 
On 18 Nov 2023, at 14:43, Yann Ylavic  wrote:

> Do we need an MMN bump for some ap_proxy_ functions added to
> proxy_util.h (non public header), though AP_PROXY_DECLARE()d because
> they need to be accessible from several proxy modules SSOs?

I double checked, thought proxy_util.h was public when it isn’t, looks fine 
without the bump.

Regards,
Graham
—

Re: svn commit: r1913936 - /httpd/httpd/branches/2.4.x/STATUS

2023-11-18 Thread Yann Ylavic 
On Sat, Nov 18, 2023 at 3:43 PM Yann Ylavic  wrote:
>
> On Sat, Nov 18, 2023 at 3:17 PM  wrote:
> >
> > Author: minfrin
> > Date: Sat Nov 18 14:17:11 2023
> > New Revision: 1913936
> >
> > URL: http://svn.apache.org/viewvc?rev=1913936=rev
> > Log:
> > Update vote, note need for mmn bump.
> >
> > Modified:
> > httpd/httpd/branches/2.4.x/STATUS
> >
> > Modified: httpd/httpd/branches/2.4.x/STATUS
> > URL: 
> > http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1913936=1913935=1913936=diff
> > ==
> > --- httpd/httpd/branches/2.4.x/STATUS (original)
> > +++ httpd/httpd/branches/2.4.x/STATUS Sat Nov 18 14:17:11 2023
> > @@ -174,10 +174,13 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
> >*) mod_proxy: prevent bad busy values and problems with bybusyness
> >   Trunk version of patch:
> > https://svn.apache.org/r1912245
> > +   https://svn.apache.org/r1913930
> >  svn merge -c 1912245 ^/httpd/httpd/trunk .
> > - +1: jfclere, minfrin
> > +svn merge -c 1913930 ^/httpd/httpd/trunk .
> > + +1: minfrin, ylavic
> >   ylavic: +1 with r1913930, we can't provide exported functions w/o an
> >   ap_[proxy_] prefix.
> > + minfrin: r1913930 added, votes reset, mmn bump needed
>
> Do we need an MMN bump for some ap_proxy_ functions added to
> proxy_util.h (non public header), though AP_PROXY_DECLARE()d because
> they need to be accessible from several proxy modules SSOs?

I meant DSOs here..

>
>
> Regards;
> Yann.

Re: svn commit: r1913936 - /httpd/httpd/branches/2.4.x/STATUS

2023-11-18 Thread Yann Ylavic 
On Sat, Nov 18, 2023 at 3:17 PM  wrote:
>
> Author: minfrin
> Date: Sat Nov 18 14:17:11 2023
> New Revision: 1913936
>
> URL: http://svn.apache.org/viewvc?rev=1913936=rev
> Log:
> Update vote, note need for mmn bump.
>
> Modified:
> httpd/httpd/branches/2.4.x/STATUS
>
> Modified: httpd/httpd/branches/2.4.x/STATUS
> URL: 
> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1913936=1913935=1913936=diff
> ==
> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Sat Nov 18 14:17:11 2023
> @@ -174,10 +174,13 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>*) mod_proxy: prevent bad busy values and problems with bybusyness
>   Trunk version of patch:
> https://svn.apache.org/r1912245
> +   https://svn.apache.org/r1913930
>  svn merge -c 1912245 ^/httpd/httpd/trunk .
> - +1: jfclere, minfrin
> +svn merge -c 1913930 ^/httpd/httpd/trunk .
> + +1: minfrin, ylavic
>   ylavic: +1 with r1913930, we can't provide exported functions w/o an
>   ap_[proxy_] prefix.
> + minfrin: r1913930 added, votes reset, mmn bump needed

Do we need an MMN bump for some ap_proxy_ functions added to
proxy_util.h (non public header), though AP_PROXY_DECLARE()d because
they need to be accessible from several proxy modules SSOs?


Regards;
Yann.