Re: Trunk :: crashes libhttpd.dll (scoreboard.c)

2020-05-25 Thread Ruediger Pluem 
Committed as r1878092.

Regards

Rüdiger

On 5/21/20 2:32 PM, Steffen wrote:
> No crashes seen anymore. Thanks!
> 
> Regards 
> 
> Steffen
> 
>> Op 20 mei 2020 om 16:38 heeft Ruediger Pluem  het 
>> volgende geschreven:
>>
>> 
>>
> On 5/20/20 4:20 PM, Steffen Land wrote:
>>> Running production. Get crashes, mostly few times a day:
>>> Error log:
>>> [mpm_winnt:notice] [pid 11936:tid 744] AH00428: Parent: child process 4980 
>>> exited with status 3221225477 -- Restarting
>>> The thread tried to read from or write to a virtual address for which it 
>>> does not have the appropriate access.
>>
>> Thanks for the details. Does the following patch make them go away?
>>
>> Index: server/scoreboard.c
>> ===
>> --- server/scoreboard.c(revision 1877790)
>> +++ server/scoreboard.c(working copy)
>> @@ -381,7 +381,7 @@
>>   if (pfn_ap_logio_get_last_bytes != NULL) {
>>   bytes = pfn_ap_logio_get_last_bytes(r->connection);
>>   }
>> -else if (r->method_number == M_GET && r->method[0] == 'H') {
>> +else if (r->method_number == M_GET && r->method && r->method[0] == 'H') 
>> {
>>   bytes = 0;
>>   }
>>   else {
>>
>>
>> Regards
>>
>> Rüdiger
> 
>

Re: Trunk :: crashes libhttpd.dll (scoreboard.c)

2020-05-21 Thread Steffen 
No crashes seen anymore. Thanks!

Regards 

Steffen

> Op 20 mei 2020 om 16:38 heeft Ruediger Pluem  het volgende 
> geschreven:
> 
> 
> 
 On 5/20/20 4:20 PM, Steffen Land wrote:
>> Running production. Get crashes, mostly few times a day:
>> Error log:
>> [mpm_winnt:notice] [pid 11936:tid 744] AH00428: Parent: child process 4980 
>> exited with status 3221225477 -- Restarting
>> The thread tried to read from or write to a virtual address for which it 
>> does not have the appropriate access.
> 
> Thanks for the details. Does the following patch make them go away?
> 
> Index: server/scoreboard.c
> ===
> --- server/scoreboard.c(revision 1877790)
> +++ server/scoreboard.c(working copy)
> @@ -381,7 +381,7 @@
>   if (pfn_ap_logio_get_last_bytes != NULL) {
>   bytes = pfn_ap_logio_get_last_bytes(r->connection);
>   }
> -else if (r->method_number == M_GET && r->method[0] == 'H') {
> +else if (r->method_number == M_GET && r->method && r->method[0] == 'H') {
>   bytes = 0;
>   }
>   else {
> 
> 
> Regards
> 
> Rüdiger

Re: Trunk :: crashes libhttpd.dll (scoreboard.c)

2020-05-20 Thread Ruediger Pluem 



On 5/20/20 4:20 PM, Steffen Land wrote:
> 
> Running production. Get crashes, mostly few times a day:
> 
> Error log:
> [mpm_winnt:notice] [pid 11936:tid 744] AH00428: Parent: child process 4980 
> exited with status 3221225477 -- Restarting
> 
> The thread tried to read from or write to a virtual address for which it does 
> not have the appropriate access.

Thanks for the details. Does the following patch make them go away?

Index: server/scoreboard.c
===
--- server/scoreboard.c (revision 1877790)
+++ server/scoreboard.c (working copy)
@@ -381,7 +381,7 @@
 if (pfn_ap_logio_get_last_bytes != NULL) {
 bytes = pfn_ap_logio_get_last_bytes(r->connection);
 }
-else if (r->method_number == M_GET && r->method[0] == 'H') {
+else if (r->method_number == M_GET && r->method && r->method[0] == 'H') {
 bytes = 0;
 }
 else {


Regards

Rüdiger

Trunk :: crashes libhttpd.dll (scoreboard.c)

2020-05-20 Thread Steffen Land 


Running production. Get crashes, mostly few times a day:

Error log:
[mpm_winnt:notice] [pid 11936:tid 744] AH00428: Parent: child process 
4980 exited with status 3221225477 -- Restarting


The thread tried to read from or write to a virtual address for which 
it does not have the appropriate access.


Attached

scoreboard.png
callstack.png
locals.png


Steffen