Re: async filters still borked (was Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis)
On 20 Mar 2020, at 15:46, Joe Orton wrote: >> Anyone found time to check >> >> https://github.com/apache/httpd/pull/88 >> >> regarding the async filter bug? > > [crickets] > > We are two months on since discussing this first. It seems quite > worrying that the async filters stuff was introduced with apparently > nasty bugs and yet is already bitrotting on trunk with not enough people > to review and fix it. Can we move the code to a branch until it is > ready? First time I've seen this thread - can you be more specific, what nasty bugs are you referring to? I see http://svn.apache.org/viewvc?view=revision&revision=1874775 refers to "The async filter bug”, but there is no PR, or any indication of what the bug is? Regards, Graham — smime.p7s Description: S/MIME cryptographic signature
Re: async filters still borked (was Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis)
On Fri, Mar 20, 2020 at 2:46 PM Joe Orton wrote: > > [crickets] > > We are two months on since discussing this first. It seems quite > worrying that the async filters stuff was introduced with apparently > nasty bugs and yet is already bitrotting on trunk with not enough people > to review and fix it. Sorry for not being able to work on this so far, just proposed a new patch in the original thread. > Can we move the code to a branch until it is > ready? This probably wouldn't be easy, there are some further changes (on trunk) that depend on the async filters, like ap_proxy_transfer_between_connections() shared by several proxy modules now, plus mpm_event obviously. But if we can't make async filters work with reasonable changes, sure let's move it out of trunk. Regards, Yann.
Re: async filters still borked (was Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis)
On 3/20/20 2:46 PM, Joe Orton wrote: > On Fri, Mar 06, 2020 at 09:30:41AM +0100, Ruediger Pluem wrote: >> On 3/4/20 9:23 AM, jor...@apache.org wrote: >>> Author: jorton >>> Date: Wed Mar 4 08:23:55 2020 >>> New Revision: 1874775 >>> >>> URL: http://svn.apache.org/viewvc?rev=1874775&view=rev >>> Log: >>> Update docs. The expr_string.t failure has not been seen since >>> the workaround was added AFAICT. The async filter bug >>> is still breaking the tests regularly. [skip ci]. >> >> Anyone found time to check >> >> https://github.com/apache/httpd/pull/88 >> >> regarding the async filter bug? > > [crickets] > > We are two months on since discussing this first. It seems quite > worrying that the async filters stuff was introduced with apparently > nasty bugs and yet is already bitrotting on trunk with not enough people > to review and fix it. Can we move the code to a branch until it is > ready? Maybe better, yes. So +1. Regards Rüdiger
Re: async filters still borked (was Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis)
+1 from me. > On Mar 20, 2020, at 9:46 AM, Joe Orton wrote: > > On Fri, Mar 06, 2020 at 09:30:41AM +0100, Ruediger Pluem wrote: >> On 3/4/20 9:23 AM, jor...@apache.org wrote: >>> Author: jorton >>> Date: Wed Mar 4 08:23:55 2020 >>> New Revision: 1874775 >>> >>> URL: http://svn.apache.org/viewvc?rev=1874775&view=rev >>> Log: >>> Update docs. The expr_string.t failure has not been seen since >>> the workaround was added AFAICT. The async filter bug >>> is still breaking the tests regularly. [skip ci]. >> >> Anyone found time to check >> >> https://github.com/apache/httpd/pull/88 >> >> regarding the async filter bug? > > [crickets] > > We are two months on since discussing this first. It seems quite > worrying that the async filters stuff was introduced with apparently > nasty bugs and yet is already bitrotting on trunk with not enough people > to review and fix it. Can we move the code to a branch until it is > ready? > > Regards, Joe >
async filters still borked (was Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis)
On Fri, Mar 06, 2020 at 09:30:41AM +0100, Ruediger Pluem wrote: > On 3/4/20 9:23 AM, jor...@apache.org wrote: > > Author: jorton > > Date: Wed Mar 4 08:23:55 2020 > > New Revision: 1874775 > > > > URL: http://svn.apache.org/viewvc?rev=1874775&view=rev > > Log: > > Update docs. The expr_string.t failure has not been seen since > > the workaround was added AFAICT. The async filter bug > > is still breaking the tests regularly. [skip ci]. > > Anyone found time to check > > https://github.com/apache/httpd/pull/88 > > regarding the async filter bug? [crickets] We are two months on since discussing this first. It seems quite worrying that the async filters stuff was introduced with apparently nasty bugs and yet is already bitrotting on trunk with not enough people to review and fix it. Can we move the code to a branch until it is ready? Regards, Joe
