Re: mod_deflate was Re: [VOTE] Release Apache httpd 2.4.13 as GA
On Fri, Jun 5, 2015 at 1:05 AM, William A Rowe Jr wr...@rowe-clan.net wrote: On Fri, Jun 5, 2015 at 12:42 AM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: This has been fixed in trunk in r1619453. ( APLOGNO(02805) ) Would you propose the backport? TIA! And... I see you did :) Thanks again.
Re: mod_deflate was Re: [VOTE] Release Apache httpd 2.4.13 as GA
On Fri, Jun 5, 2015 at 12:42 AM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: This has been fixed in trunk in r1619453. ( APLOGNO(02805) ) Would you propose the backport? TIA!
Re: mod_deflate was Re: [VOTE] Release Apache httpd 2.4.13 as GA
I'm not compiling -Wall... so /opt/apr15/build-1/libtool --silent --mode=compile gcc -std=gnu99 -I/usr/include/libxml2 -g -O2 -pthread -DLINUX -D_REENTRANT -D_GNU_SOURCE -I. -I/home/wrowe/dev/httpd-2.4/os/unix -I/home/wrowe/dev/httpd-2.4/include -I/opt/apr15/include/apr-1 -I/usr/local/ssl/include -I/usr/local/include -I/home/wrowe/dev/httpd-2.4/modules/aaa -I/home/wrowe/dev/httpd-2.4/modules/cache -I/home/wrowe/dev/httpd-2.4/modules/core -I/home/wrowe/dev/httpd-2.4/modules/database -I/home/wrowe/dev/httpd-2.4/modules/filters -I/home/wrowe/dev/httpd-2.4/modules/ldap -I/home/wrowe/dev/httpd-2.4/server -I/home/wrowe/dev/httpd-2.4/modules/loggers -I/home/wrowe/dev/httpd-2.4/modules/lua -I/home/wrowe/dev/httpd-2.4/modules/proxy -I/home/wrowe/dev/httpd-2.4/modules/session -I/home/wrowe/dev/httpd-2.4/modules/ssl -I/home/wrowe/dev/httpd-2.4/modules/test -I/home/wrowe/dev/httpd-2.4/server -I/home/wrowe/dev/httpd-2.4/modules/arch/unix -I/home/wrowe/dev/httpd-2.4/modules/dav/main -I/home/wrowe/dev/httpd-2.4/modules/generators -I/home/wrowe/dev/httpd-2.4/modules/mappers -prefer-pic -c mod_deflate.c touch mod_deflate.slo /opt/apr15/build-1/libtool --silent --mode=link gcc -std=gnu99 -I/usr/include/libxml2 -g -O2 -pthread -L/usr/local/ssl/lib -o mod_deflate.la -rpath /opt/apache24/modules -module -avoid-version mod_deflate.lo -lz no noise on compilation. I'm not debating it isn't there, just that my compiler settings did not throw it at me. On Fri, Jun 5, 2015 at 12:11 AM, Gregg Smith g...@gknw.net wrote: On 6/4/2015 10:01 PM, William A Rowe Jr wrote: On Thu, Jun 4, 2015 at 10:47 PM, Gregg Smithg...@gknw.net wrote: This is new, not quite sure how I didn't see it a few weeks ago as it's 9 weeks old. Who forgot to fill in the number? mod_deflate.c(1283) : warning C4003: not enough actual parameters for macro 'APLOGNO' I just rechecked my compilation from near-trunk 6 hours ago, I don't see this. More background, please? gcc or other compiler rev? OS? Revision? It avoids a lot of needless speculation. It's not a compiler thing, doesn't matter what OS. Sorry I didn't mention it's r1669555, my bad! You have the line number in the posted compiler output. However, it's pretty hard to miss as it's in the first stanza of the merge and practically hops in your lap. http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/filters/mod_deflate.c?r1=1661845r2=1669555
Re: mod_deflate was Re: [VOTE] Release Apache httpd 2.4.13 as GA
On 06/05/2015 07:01 AM, William A Rowe Jr wrote: On Thu, Jun 4, 2015 at 10:47 PM, Gregg Smith g...@gknw.net mailto:g...@gknw.net wrote: This is new, not quite sure how I didn't see it a few weeks ago as it's 9 weeks old. Who forgot to fill in the number? mod_deflate.c(1283) : warning C4003: not enough actual parameters for macro 'APLOGNO' I just rechecked my compilation from near-trunk 6 hours ago, I don't see this. More background, please? gcc or other compiler rev? OS? Revision? I see APLOGNO() in the code. It has been added in http://svn.apache.org/r1669555. Regards, Jan Kaluza It avoids a lot of needless speculation.
Re: mod_deflate was Re: [VOTE] Release Apache httpd 2.4.13 as GA
On 6/4/2015 10:01 PM, William A Rowe Jr wrote: On Thu, Jun 4, 2015 at 10:47 PM, Gregg Smithg...@gknw.net wrote: This is new, not quite sure how I didn't see it a few weeks ago as it's 9 weeks old. Who forgot to fill in the number? mod_deflate.c(1283) : warning C4003: not enough actual parameters for macro 'APLOGNO' I just rechecked my compilation from near-trunk 6 hours ago, I don't see this. More background, please? gcc or other compiler rev? OS? Revision? It avoids a lot of needless speculation. It's not a compiler thing, doesn't matter what OS. Sorry I didn't mention it's r1669555, my bad! You have the line number in the posted compiler output. However, it's pretty hard to miss as it's in the first stanza of the merge and practically hops in your lap. http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/filters/mod_deflate.c?r1=1661845r2=1669555
mod_deflate was Re: [VOTE] Release Apache httpd 2.4.13 as GA
This is new, not quite sure how I didn't see it a few weeks ago as it's 9 weeks old. Who forgot to fill in the number? mod_deflate.c(1283) : warning C4003: not enough actual parameters for macro 'APLOGNO'
Re: mod_deflate was Re: [VOTE] Release Apache httpd 2.4.13 as GA
On Thu, Jun 4, 2015 at 10:47 PM, Gregg Smith g...@gknw.net wrote: This is new, not quite sure how I didn't see it a few weeks ago as it's 9 weeks old. Who forgot to fill in the number? mod_deflate.c(1283) : warning C4003: not enough actual parameters for macro 'APLOGNO' I just rechecked my compilation from near-trunk 6 hours ago, I don't see this. More background, please? gcc or other compiler rev? OS? Revision? It avoids a lot of needless speculation.
Re: mod_deflate was Re: [VOTE] Release Apache httpd 2.4.13 as GA
Le 05/06/2015 07:11, Gregg Smith a écrit : On 6/4/2015 10:01 PM, William A Rowe Jr wrote: On Thu, Jun 4, 2015 at 10:47 PM, Gregg Smithg...@gknw.net wrote: This is new, not quite sure how I didn't see it a few weeks ago as it's 9 weeks old. Who forgot to fill in the number? mod_deflate.c(1283) : warning C4003: not enough actual parameters for macro 'APLOGNO' I just rechecked my compilation from near-trunk 6 hours ago, I don't see this. More background, please? gcc or other compiler rev? OS? Revision? It avoids a lot of needless speculation. It's not a compiler thing, doesn't matter what OS. Sorry I didn't mention it's r1669555, my bad! You have the line number in the posted compiler output. However, it's pretty hard to miss as it's in the first stanza of the merge and practically hops in your lap. http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/filters/mod_deflate.c?r1=1661845r2=1669555 This has been fixed in trunk in r1619453. ( APLOGNO(02805) ) CJ
