Re: svn commit: r1844047 - in /httpd/httpd/branches/2.4.x: ./ STATUS modules/ssl/ssl_engine_io.c

2018-10-17 Thread Daniel Ruggeri
Thank you so much for your thorough work.

One of these days I'd love to hear all about your testing setup. It would so 
cool to run something similar on our buildbot!
-- 
Daniel Ruggeri

On October 17, 2018 3:01:11 AM CDT, Rainer Jung  wrote:
>Thanks.
>
>I'm doing new builds now for a bunch of OpenSSL versions and shared
>plus 
>static linking (but only the reallyall module set). Then I will run the
>
>test suite, combining each with a bunch of OpenSSL versions used in the
>
>client (perl modules).
>
>I guess those runs will take until tomorrow.
>
>Regards,
>
>Rainer
>
>Am 16.10.2018 um 22:24 schrieb drugg...@apache.org:
>> Author: druggeri
>> Date: Tue Oct 16 20:24:23 2018
>> New Revision: 1844047
>> 
>> URL: http://svn.apache.org/viewvc?rev=1844047&view=rev
>> Log:
>>*) mod_ssl: Handle SSL_read() return code 0 similarly to <0. It is
>needed
>>when using OpenSSL 1.1.1 and should not harm for
>versions before
>>1.1.1.
>>Without the patch for 1.1.1 a 0 byte read no longer
>results in
>>EAGAIN but instead in APR_EOF which leads to HTTP/2
>failures.
>>For the changelog: Fix HTTP/2 failures when using
>OpenSSL 1.1.1.
>>   trunk patch: http://svn.apache.org/r1843954
>>   2.4.x patch: svn merge -c 1843954 ^/httpd/httpd/trunk .
>>   +1: rjung, druggeri, rpluem
>> 
>> 
>> Modified:
>>  httpd/httpd/branches/2.4.x/   (props changed)
>>  httpd/httpd/branches/2.4.x/STATUS
>>  httpd/httpd/branches/2.4.x/modules/ssl/ssl_engine_io.c
>> 
>> Propchange: httpd/httpd/branches/2.4.x/
>>
>--
>> --- svn:mergeinfo (original)
>> +++ svn:mergeinfo Tue Oct 16 20:24:23 2018
>> @@ -8,4 +8,4 @@
>>   /httpd/httpd/branches/trunk-md:1804087-1804529
>>   /httpd/httpd/branches/trunk-override-index:1793921-1793931
>>   /httpd/httpd/branches/wombat-integration:723609-723841
>>
>-/httpd/httpd/trunk:1200475,1200478,1200482,1200491,1200496,1200513,1200550,1200556,1200580,1200605,1200612,1200614,1200639,1200646,1200656,1200667,1200679,1200699,1200702,1200955,1200957,1200961,1200963,1200968,1200975,1200977,1201032,1201042,120,1201194,1201198,1201202,1201443,1201450,1201460,1201956,1202236,1202453,1202456,1202886,1203400,1203491,1203632,1203714,1203859,1203980,1204630,1204968,1204990,1205061,1205075,1205379,1205885,1206291,1206472,1206587,1206850,1206940,1206978,1207719,1208753,1208835,1209053,1209085,1209417,1209432,1209461,1209601,1209603,1209618,1209623,1209741,1209754,1209766,1209776,1209797-1209798,1209811-1209812,1209814,1209908,1209910,1209913,1209916-1209917,1209947,1209952,1210067,1210080,1210120,1210124,1210130,1210148,1210219,1210221,1210252,1210284,1210336,1210378,1210725,1210892,1210951,1210954,1211351-1211352,1211364,1211490,1211495,1211528,1211663,1211680,1212872,1212883,1213338,1213380-1213381,1213391,1213399,1213567,1214003,1214005,1214015,12
>>  
>15514,1220462,1220467,1220493,1220524,1220570,1220768,1220794,1220826,1220846,1221205,1221292,1222335,1222370,1222473,1222915,1222917,1222921,1222930,1223048,1225060,1225197-1225199,1225223,1225380,1225476,1225478,1225791,1225795-1225796,1226339,1226375,1227910,1228700,1228816,1229024,1229059,1229099,1229116,1229134,1229136,1229930,1230286,1231255,1231257,1231442,1231446,1231508,1231510,1231518,1232575,1232594,1232630,1232838,1234180,1234297,1234479,1234511,1234565,1234574,1234642-1234643,1234876,1234899,1235019,1236122,1236701,1237407,1238545,1238768,1239029-1239030,1239071,1239565,1240315,1240470,1240778,1241069,1241071,1242089,1242798,1242967,1243176,1243246,1243797,1243799,1244211,1245717,1290823,1290835,1291819-1291820,1291834,1291840,1292043,1293405,1293534-1293535,1293658,1293678,1293708,1294306,1294349,1294356,1294358,1294372,1294471,1297560,1299718,1299786,1300766,130,1301725,1302444,1302483,1302653,1302665,1302674,1303201,1303435,1303827,1304087,1304874-1304875,1305167
>>  
>,1305586,1306350,1306409,1306426,1306841,1307790,1308327,1308459,1309536,1309567,1311468,1324760,1325218,1325227,1325250,1325265,1325275,1325632,1325724,1326980,1326984,1326991,1327689,1328325-1328326,1328339,1328345,1328950,1330189,1330964,1331110,1331115,1331942,1331977,1332378,1333969,1334343,1335882,1337344,1341905-1341906,1341913,1341930,1342065,1343085,1343087,1343094,1343099,1343109,1343935,1344712,1345147,1345319,1345329,1346905,1347980,1348036,1348653,1348656,1348660,1349905,1351012-1351020,1351071-1351072,1351074,1351737,1352047,1352534,1352909-1352912,1357685,1358061,1359057,1359881,1359884,1361153,1361298,1361766,1361773,1361778,1361784,1361791-1361792,1361801,1361803,1362020,1362538,1362707,1363035,1363183,1363186,1363312,1363440,1363557,1363589,1363829,1363832,1363836-1363837,1363853,1364133,1364138,1364229,1364601,1364695,1365001,1365020,1365029,1365479,1366319,1366344,1366621,1367778,1367819,1368053,1368058,1368094,1368121,1368131,1368393,1368396,1369419,1369568,1369
>>  
>604,1369618,1369904,1369995,

Re: svn commit: r1844047 - in /httpd/httpd/branches/2.4.x: ./ STATUS modules/ssl/ssl_engine_io.c

2018-10-17 Thread Rainer Jung

Thanks.

I'm doing new builds now for a bunch of OpenSSL versions and shared plus 
static linking (but only the reallyall module set). Then I will run the 
test suite, combining each with a bunch of OpenSSL versions used in the 
client (perl modules).


I guess those runs will take until tomorrow.

Regards,

Rainer

Am 16.10.2018 um 22:24 schrieb drugg...@apache.org:

Author: druggeri
Date: Tue Oct 16 20:24:23 2018
New Revision: 1844047

URL: http://svn.apache.org/viewvc?rev=1844047&view=rev
Log:
   *) mod_ssl: Handle SSL_read() return code 0 similarly to <0. It is needed
   when using OpenSSL 1.1.1 and should not harm for versions before
   1.1.1.
   Without the patch for 1.1.1 a 0 byte read no longer results in
   EAGAIN but instead in APR_EOF which leads to HTTP/2 failures.
   For the changelog: Fix HTTP/2 failures when using OpenSSL 1.1.1.
  trunk patch: http://svn.apache.org/r1843954
  2.4.x patch: svn merge -c 1843954 ^/httpd/httpd/trunk .
  +1: rjung, druggeri, rpluem


Modified:
 httpd/httpd/branches/2.4.x/   (props changed)
 httpd/httpd/branches/2.4.x/STATUS
 httpd/httpd/branches/2.4.x/modules/ssl/ssl_engine_io.c

Propchange: httpd/httpd/branches/2.4.x/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Oct 16 20:24:23 2018
@@ -8,4 +8,4 @@
  /httpd/httpd/branches/trunk-md:1804087-1804529
  /httpd/httpd/branches/trunk-override-index:1793921-1793931
  /httpd/httpd/branches/wombat-integration:723609-723841
-/httpd/httpd/trunk:1200475,1200478,1200482,1200491,1200496,1200513,1200550,1200556,1200580,1200605,1200612,1200614,1200639,1200646,1200656,1200667,1200679,1200699,1200702,1200955,1200957,1200961,1200963,1200968,1200975,1200977,1201032,1201042,120,1201194,1201198,1201202,1201443,1201450,1201460,1201956,1202236,1202453,1202456,1202886,1203400,1203491,1203632,1203714,1203859,1203980,1204630,1204968,1204990,1205061,1205075,1205379,1205885,1206291,1206472,1206587,1206850,1206940,1206978,1207719,1208753,1208835,1209053,1209085,1209417,1209432,1209461,1209601,1209603,1209618,1209623,1209741,1209754,1209766,1209776,1209797-1209798,1209811-1209812,1209814,1209908,1209910,1209913,1209916-1209917,1209947,1209952,1210067,1210080,1210120,1210124,1210130,1210148,1210219,1210221,1210252,1210284,1210336,1210378,1210725,1210892,1210951,1210954,1211351-1211352,1211364,1211490,1211495,1211528,1211663,1211680,1212872,1212883,1213338,1213380-1213381,1213391,1213399,1213567,1214003,1214005,1214015,12
  
15514,1220462,1220467,1220493,1220524,1220570,1220768,1220794,1220826,1220846,1221205,1221292,1222335,1222370,1222473,1222915,1222917,1222921,1222930,1223048,1225060,1225197-1225199,1225223,1225380,1225476,1225478,1225791,1225795-1225796,1226339,1226375,1227910,1228700,1228816,1229024,1229059,1229099,1229116,1229134,1229136,1229930,1230286,1231255,1231257,1231442,1231446,1231508,1231510,1231518,1232575,1232594,1232630,1232838,1234180,1234297,1234479,1234511,1234565,1234574,1234642-1234643,1234876,1234899,1235019,1236122,1236701,1237407,1238545,1238768,1239029-1239030,1239071,1239565,1240315,1240470,1240778,1241069,1241071,1242089,1242798,1242967,1243176,1243246,1243797,1243799,1244211,1245717,1290823,1290835,1291819-1291820,1291834,1291840,1292043,1293405,1293534-1293535,1293658,1293678,1293708,1294306,1294349,1294356,1294358,1294372,1294471,1297560,1299718,1299786,1300766,130,1301725,1302444,1302483,1302653,1302665,1302674,1303201,1303435,1303827,1304087,1304874-1304875,1305167
  
,1305586,1306350,1306409,1306426,1306841,1307790,1308327,1308459,1309536,1309567,1311468,1324760,1325218,1325227,1325250,1325265,1325275,1325632,1325724,1326980,1326984,1326991,1327689,1328325-1328326,1328339,1328345,1328950,1330189,1330964,1331110,1331115,1331942,1331977,1332378,1333969,1334343,1335882,1337344,1341905-1341906,1341913,1341930,1342065,1343085,1343087,1343094,1343099,1343109,1343935,1344712,1345147,1345319,1345329,1346905,1347980,1348036,1348653,1348656,1348660,1349905,1351012-1351020,1351071-1351072,1351074,1351737,1352047,1352534,1352909-1352912,1357685,1358061,1359057,1359881,1359884,1361153,1361298,1361766,1361773,1361778,1361784,1361791-1361792,1361801,1361803,1362020,1362538,1362707,1363035,1363183,1363186,1363312,1363440,1363557,1363589,1363829,1363832,1363836-1363837,1363853,1364133,1364138,1364229,1364601,1364695,1365001,1365020,1365029,1365479,1366319,1366344,1366621,1367778,1367819,1368053,1368058,1368094,1368121,1368131,1368393,1368396,1369419,1369568,1369
  
604,1369618,1369904,1369995,136,1370001,1370466,1370592,1370615-1370616,1370763,1371387,1371791,1371801,1371878,1371903,1373270,1373447,1373898,1373955,1374157,1374199,1374214,1374216,1374247,1374874,1374877,1374880,1375006,1375009,1375011,1375013,1375445,1375584,1376695,1376700,1378178,1383490,1384408,1384913,1386576,1386578,1386726,1386822,1386880,1386913,1387085,1387088,1387110,1387389