Re: [VOTE] Release httpd-2.4.31
> On Mar 3, 2018, at 4:51 PM, Yann Ylavic wrote: > > On Sat, Mar 3, 2018 at 6:40 PM, li...@rhsoft.net wrote: >> >> -1 >> >> "ab" no longer can benchmark https urls, same build-spec and environment >> (Fedora 26 and 27) > > Hmm, looks like 2.4 is missing http://svn.apache.org/r1580928 (second hunk). > This somehow never made it to 2.4.x, while nonblocking SSL introduced > in r1814468 makes SSL_write(,,0) fail... Hmmm... This implies, to me, that 2.4.31 is DOA. -1
Fix for ab defect (was: [VOTE] Release httpd-2.4.31)
On Sat, Mar 3, 2018 at 10:51 PM, Yann Ylavic wrote: > On Sat, Mar 3, 2018 at 6:40 PM, li...@rhsoft.net wrote: >> >> -1 >> >> "ab" no longer can benchmark https urls, same build-spec and environment >> (Fedora 26 and 27) > > Hmm, looks like 2.4 is missing http://svn.apache.org/r1580928 (second hunk). Does it work for you with this patch (on top of 2.4.31): http://home.apache.org/~ylavic/patches/httpd-2.4.x-ab-nonblock_length.patch ? Thanks for testing (if possible). Regards, Yann.
Re: [VOTE] Release httpd-2.4.31
Am 04.03.2018 um 20:24 schrieb Yann Ylavic: On Sat, Mar 3, 2018 at 10:51 PM, Yann Ylavic wrote: On Sat, Mar 3, 2018 at 6:40 PM, li...@rhsoft.net wrote: -1 "ab" no longer can benchmark https urls, same build-spec and environment (Fedora 26 and 27) Hmm, looks like 2.4 is missing http://svn.apache.org/r1580928 (second hunk). Does it work for you with this patch (on top of 2.4.31): http://home.apache.org/~ylavic/patches/httpd-2.4.x-ab-nonblock_length.patch ? Thanks for testing (if possible) that pacthfile is unuseable for rpmbuild + echo 'Patch #4 (httpd-2.4.x-ab-nonblock_length.patch):' Patch #4 (httpd-2.4.x-ab-nonblock_length.patch): + /usr/bin/patch --no-backup-if-mismatch -p1 --fuzz=0 can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -- |Index: CHANGES |=== |--- CHANGES(revision 1825829) |+++ CHANGES(working copy) --
Re: [VOTE] Release httpd-2.4.31
On Sun, Mar 4, 2018 at 8:27 PM, li...@rhsoft.net wrote:
>
> that pacthfile is unuseable for rpmbuild
>
> + echo 'Patch #4 (httpd-2.4.x-ab-nonblock_length.patch):'
> Patch #4 (httpd-2.4.x-ab-nonblock_length.patch):
> + /usr/bin/patch --no-backup-if-mismatch -p1 --fuzz=0
> can't find file to patch at input line 5
It requires -p0 (instead of -p1).
Nevermind, does the attached one work?
Index: 2.4.x/support/ab.c
===
--- 2.4.x/support/ab.c (revision 1825829)
+++ 2.4.x/support/ab.c (working copy)
@@ -780,6 +780,7 @@ static void write_request(struct connection * c)
c->rwrite = reqlen;
if (send_body)
c->rwrite += postlen;
+l = c->rwrite;
}
else if (tnow > c->connect + aprtimeout) {
printf("Send request timed out!\n");
Re: [VOTE] Release httpd-2.4.31
Am 04.03.2018 um 20:33 schrieb Yann Ylavic: On Sun, Mar 4, 2018 at 8:27 PM, li...@rhsoft.net wrote: that patchfile is unuseable for rpmbuild + echo 'Patch #4 (httpd-2.4.x-ab-nonblock_length.patch):' Patch #4 (httpd-2.4.x-ab-nonblock_length.patch): + /usr/bin/patch --no-backup-if-mismatch -p1 --fuzz=0 can't find file to patch at input line 5 It requires -p0 (instead of -p1). Nevermind, does the attached one work? confirmed, thanks [root@testserver:~]$ rpm -q httpd httpd-2.4.31-2.0.fc27.20180304.rh.sandybridge.x86_64 [root@testserver:~]$ ab -c 1 -n 10 https://www.google.com/ This is ApacheBench, Version 2.3 <$Revision: 1814468 $> Copyright 1996 Adam Twiss, Zeus Technology Ltd, http://www.zeustech.net/ Licensed to The Apache Software Foundation, http://www.apache.org/ Benchmarking www.google.com (be patient).done Server Software: Server Hostname:www.google.com Server Port:443 SSL/TLS Protocol: TLSv1.2,ECDHE-ECDSA-CHACHA20-POLY1305,256,256 TLS Server Name:www.google.com Document Path: / Document Length:269 bytes Concurrency Level: 1 Time taken for tests: 1.202 seconds Complete requests: 10 Failed requests:0 Non-2xx responses: 10 Total transferred: 6700 bytes HTML transferred: 2690 bytes Requests per second:8.32 [#/sec] (mean) Time per request: 120.213 [ms] (mean) Time per request: 120.213 [ms] (mean, across all concurrent requests) Transfer rate: 5.44 [Kbytes/sec] received Connection Times (ms) min mean[+/-sd] median max Connect: 81 95 13.5 90 119 Processing:19 25 7.1 21 40 Waiting: 19 24 7.2 21 40 Total:103 120 17.0114 159 Percentage of the requests served within a certain time (ms) 50%114 66%119 75%126 80%137 90%159 95%159 98%159 99%159 100%159 (longest request)
Re: [VOTE] Release httpd-2.4.31
On Sun, Mar 4, 2018 at 8:38 PM, li...@rhsoft.net wrote: > > Am 04.03.2018 um 20:33 schrieb Yann Ylavic: >> >> On Sun, Mar 4, 2018 at 8:27 PM, li...@rhsoft.net wrote: >>> >>> >>> that patchfile is unuseable for rpmbuild >>> >>> + echo 'Patch #4 (httpd-2.4.x-ab-nonblock_length.patch):' >>> Patch #4 (httpd-2.4.x-ab-nonblock_length.patch): >>> + /usr/bin/patch --no-backup-if-mismatch -p1 --fuzz=0 >>> can't find file to patch at input line 5 >> >> >> It requires -p0 (instead of -p1). >> Nevermind, does the attached one work? > > > confirmed, thanks Thank you for testing!
Re: [VOTE] Release httpd-2.4.31
On Sat, Mar 3, 2018 at 4:56 PM, Daniel Ruggeri wrote: > > I would like to call a VOTE over the next few days to release this candidate > tarball as 2.4.31: [X] +1: It’s not just good, it’s good enough! Works for me on Debian(s) 9, 8 and 7. No opinion on whether "ab" defect is show stopper...
[RESULT] Release httpd-2.4.31
As RM, I am not comfortable releasing this with the bug discovered in ab. As such, I'm calling this one dead-on-the-vine and version 2.4.31 will not be released. -- Daniel Ruggeri From: Daniel Ruggeri [mailto:drugg...@primary.net] Sent: Saturday, March 03, 2018 9:57 AM To: dev@httpd.apache.org Subject: [VOTE] Release httpd-2.4.31 Hi, all; Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball as 2.4.31: [ ] +1: It's not just good, it's good enough! [ ] +0: Let's have a talk. [ ] -1: There's trouble in paradise. Here's what's wrong. -- Daniel Ruggeri
RE: Fix for ab defect (was: [VOTE] Release httpd-2.4.31)
I've tested the patch against 2.4.31 as provided in STATUS and confirmed it fixes the issue. Thanks for the very fast turnaround. I'd like to ask a followup question... how do we catch this in the test suite? With this (100% failure), ab still returns a 0 exit code. It *does* at least give the error message to STDERR. Perhaps we should add to the test suite that `ab -q` completed against the http and https vshosts with no lines printed to STDERR and has a 0 exit code? -- Daniel Ruggeri > -Original Message- > From: Yann Ylavic [mailto:ylavic@gmail.com] > Sent: Sunday, March 04, 2018 1:25 PM > To: li...@rhsoft.net > Cc: httpd-dev > Subject: Fix for ab defect (was: [VOTE] Release httpd-2.4.31) > > On Sat, Mar 3, 2018 at 10:51 PM, Yann Ylavic wrote: > > On Sat, Mar 3, 2018 at 6:40 PM, li...@rhsoft.net wrote: > >> > >> -1 > >> > >> "ab" no longer can benchmark https urls, same build-spec and > environment > >> (Fedora 26 and 27) > > > > Hmm, looks like 2.4 is missing http://svn.apache.org/r1580928 (second > hunk). > > Does it work for you with this patch (on top of 2.4.31): > http://home.apache.org/~ylavic/patches/httpd-2.4.x-ab- > nonblock_length.patch > ? > > Thanks for testing (if possible). > > Regards, > Yann.
Re: Fix for ab defect (was: [VOTE] Release httpd-2.4.31)
On Sun, Mar 4, 2018 at 11:48 PM, Daniel Ruggeri wrote: > > I'd like to ask a followup question... how do we catch this in the > test suite? With this (100% failure), ab still returns a 0 exit code. > It *does* at least give the error message to STDERR. Perhaps we > should add to the test suite that `ab -q` completed against the http > and https vshosts with no lines printed to STDERR and has a 0 exit > code? The best way is probably to capture stderr... In this case though, this is not exactly "100% failure" in any circonstances, for instance on localhost (or fast enough local network) it won't fail since the errorneous path is not taken when non-blocking connect succeeds. It might not be easy/wise to launch/automate "ab" on an external server in a test suite... Regards, Yann.
RE: Fix for ab defect (was: [VOTE] Release httpd-2.4.31)
> -Original Message- > From: Yann Ylavic [mailto:ylavic@gmail.com] > Sent: Sunday, March 04, 2018 5:09 PM > To: httpd-dev > Subject: Re: Fix for ab defect (was: [VOTE] Release httpd-2.4.31) > > On Sun, Mar 4, 2018 at 11:48 PM, Daniel Ruggeri > wrote: > > > > I'd like to ask a followup question... how do we catch this in the > > test suite? With this (100% failure), ab still returns a 0 exit code. > > It *does* at least give the error message to STDERR. Perhaps we > > should add to the test suite that `ab -q` completed against the http > > and https vshosts with no lines printed to STDERR and has a 0 exit > > code? > > The best way is probably to capture stderr... > In this case though, this is not exactly "100% failure" in any > circonstances, for instance on localhost (or fast enough local > network) it won't fail since the errorneous path is not taken when > non-blocking connect succeeds. > It might not be easy/wise to launch/automate "ab" on an external > server in a test suite... I just added r1825841 to stub out some very basic ab tests (and r1825842 now that I noticed a shortcoming). I'm not sure about the statement above. Maybe I misunderstand, but with my tests before/after the patch, the new test can detect this particular failure and should at least also protect us from trying to ship an ab build that returns non-zero and has anything in STDERR under normal circumstances. Review much appreciated, of course. What I greatly dislike about the above commit is that (at least on my tests), the STDERR and STDOUT from the child process appears to be folded into STDOUT. Thus, I added a failsafe check that STDOUT doesn't contain what looks to be an SSL error. This may be a side effect of the test suite because when running the same command in a standard shell the SSL complaint is on STDERR. I'm wondering if anyone can explain that behavior since IPC::Open3 has always segregated these streams? > > Regards, > Yann. -- Daniel Ruggeri
Re: svn commit: r1825777 - in /httpd/httpd/branches/2.4.x: CHANGES STATUS docs/manual/style/version.ent include/ap_release.h
On 03/03/2018 04:53 PM, drugg...@apache.org wrote:
> Author: druggeri
> Date: Sat Mar 3 15:53:13 2018
> New Revision: 1825777
>
> URL: http://svn.apache.org/viewvc?rev=1825777&view=rev
> Log:
> Post 2.4.31 tag updates
>
> Modified:
> httpd/httpd/branches/2.4.x/CHANGES
> httpd/httpd/branches/2.4.x/STATUS
> httpd/httpd/branches/2.4.x/docs/manual/style/version.ent
> httpd/httpd/branches/2.4.x/include/ap_release.h
>
> Modified: httpd/httpd/branches/2.4.x/CHANGES
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/CHANGES?rev=1825777&r1=1825776&r2=1825777&view=diff
> ==
> --- httpd/httpd/branches/2.4.x/CHANGES [utf-8] (original)
> +++ httpd/httpd/branches/2.4.x/CHANGES [utf-8] Sat Mar 3 15:53:13 2018
> @@ -1,4 +1,6 @@
> -*- coding: utf-8
> -*-
> +Changes with Apache 2.4.32
> +
> Changes with Apache 2.4.31
>
>*) mod_proxy_fcgi: Add the support for mod_proxy's flushpackets and
> flushwait
>
> Modified: httpd/httpd/branches/2.4.x/STATUS
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1825777&r1=1825776&r2=1825777&view=diff
> ==
> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Sat Mar 3 15:53:13 2018
> @@ -29,7 +29,7 @@ Release history:
> [NOTE that x.{odd}.z versions are strictly Alpha/Beta releases,
>while x.{even}.z versions are Stable/GA releases.]
>
> -2.4.31 : In development.
> +2.4.31 : Tagged on March 03, 2018
Shouldn't that add
2.4.32 : In development?
Regards
Rüdiger
> 2.4.30 : Tagged on February 19, 2018, not released.
> 2.4.29 : Tagged on October 17, 2017. Released on October 23, 2017.
> 2.4.28 : Tagged on September 25, 2017. Released on October 5, 2017.
>
