Re: [DISCUSS] Logos on project front page.
+1 to follow the best practices. vbal...@apache.org 于2020年5月13日周三 上午10:31写道： > > I agree on following the best practices. > Balaji.VOn Tuesday, May 12, 2020, 06:52:59 PM PDT, Vinoth Chandar < > vin...@apache.org> wrote: > > Hello all, > > This was raised during the graduation discussion. We have been referred to > [1]. The doc ends saying. "These best practices for linking to outside > pages on project websites are meant as suggestions for projects. PMCs are > free to adopt (or not) any of these suggestions for their sites.". > > But I would prefer to play by the best practices if we can.. > > Can you all chime in with your thoughts? > > > > [1] https://www.apache.org/foundation/marks/linking >
Re: [DISCUSS] should we do a 0.5.3 patch set release ?
Thank you all. I created a jira here - https://jira.apache.org/jira/browse/HUDI-890 that tracks the list of patches going into this release. So far I am able to cherry pick these commits and get a successful local run of tests. Let us aim to code freeze by end of this week (May 16th EOD) for more patches that can go into 0.5.3 release. Please respond if you think there are more candidate PRs (criteria: perf improvements/bug fixes) that can be included in 0.5.3. Thanks, Sudha On Thu, May 7, 2020 at 4:16 PM Minjeong Noh wrote: > > https://github.com/apache/incubator-hudi/commit/dbc9acd23a4eb208c7cd458bb3adaf54731d4145 > < > https://github.com/apache/incubator-hudi/commit/dbc9acd23a4eb208c7cd458bb3adaf54731d4145> > > > On 2020/05/06 20:31:00, Vinoth Chandar wrote: > > Hi Sudha,> > > > > +1 on the overall idea.. I tried to pick out few of these PRs that are> > > > > - Small enough to apply easily> > > - Have limited scope, fixing pointed problems> > > - Have high impact on performance or usability> > > > > [HUDI-799] Use appropriate FS when loading configs> > > > https://github.com/apache/incubator-hudi/commit/acb1ada2f756b49d9f9a0aa152f99fcc9e86dde7> > > > > > [HUDI-713] Fix conversion of Spark array of struct type to Avro schema> > > > https://github.com/apache/incubator-hudi/commit/ce0a4c64d07d6eea926d1bfb92b69ae387b88f50> > > > > > [HUDI-656][Performance] Return a dummy Spark relation after writing> > > > https://github.com/apache/incubator-hudi/commit/c40a0d4e91896dece51969f5308016ecb3aa635c> > > > > > [HUDI-850] Avoid unnecessary listings in incremental cleaning mode> > > > https://github.com/apache/incubator-hudi/commit/506447fd4fde4cd922f7aa8f4e17a7f0dc97> > > > > > [HUDI-724] Parallelize getSmallFiles for partitions> > > > https://github.com/apache/incubator-hudi/commit/1f5b0c77d6c87a936f2d34287ec6a1df1cb18b33> > > > > > [HUDI-607] Fix to allow creation/syncing of Hive tables partitioned> > > > https://github.com/apache/incubator-hudi/commit/2d040145810b8b14c59c5882f9115698351039d1> > > > > > Add constructor to HoodieROTablePathFilter> > > > https://github.com/apache/incubator-hudi/commit/418f9bb2e91ed6c02077d36e49a47f0c8d08303a> > > > > > [HUDI-539] Make ROPathFilter conf member serializable> > > > https://github.com/apache/incubator-hudi/commit/e3019031d8fff60df4fec82eac3fd5c044011635> > > > > > Add changes for presto mor queries> > > > https://github.com/apache/incubator-hudi/commit/e21441ad8317f302fed947c414e059a332e4d1ef> > > > > > [HUDI-782] Add support of Aliyun object storage service.> > > > https://github.com/apache/incubator-hudi/commit/5d717a28f45137bea71dffa31b0ae7ccbf1bda00> > > > > > > > Please chime in with your thoughts, as well.> > > > > I think there are some bug fixes in the pending PRs as well. esp from > Alex> > > and Pratyaksh .> > > > > Thanks> > > Vinoth> > > > > > > On Tue, May 5, 2020 at 9:33 PM Bhavani Sudha > > > wrote:> > > > > > Hello all,> > > >> > > > I am wondering if we should do a 0.5.3 release by backporting all > minor to> > > > medium bug fixes (that are in master already) to 0.5.2 and do a minor> > > > release ? That way we can use some time to reserve 0.6.0 release for > all> > > > major features that are upcoming and/or almost there. Please share > your> > > > thoughts. If you agree also please share the list of fixes that you > know of> > > > that can go into 0.5.3.> > > >> > > > Thanks,> > > > Sudha> > > >> > >
Re: [DISCUSS] Logos on project front page.
I agree on following the best practices. Balaji.VOn Tuesday, May 12, 2020, 06:52:59 PM PDT, Vinoth Chandar wrote: Hello all, This was raised during the graduation discussion. We have been referred to [1]. The doc ends saying. "These best practices for linking to outside pages on project websites are meant as suggestions for projects. PMCs are free to adopt (or not) any of these suggestions for their sites.". But I would prefer to play by the best practices if we can.. Can you all chime in with your thoughts? [1] https://www.apache.org/foundation/marks/linking
[DISCUSS] Logos on project front page.
Hello all, This was raised during the graduation discussion. We have been referred to [1]. The doc ends saying. "These best practices for linking to outside pages on project websites are meant as suggestions for projects. PMCs are free to adopt (or not) any of these suggestions for their sites.". But I would prefer to play by the best practices if we can.. Can you all chime in with your thoughts? [1] https://www.apache.org/foundation/marks/linking
Re: [DISCUSS] Why add unit tests for hudi-cli module
This is mainly a function test, not a parameter test. Also, ensure that all base commands are executed successfully.
Re: [DISCUSS] Why add unit tests for hudi-cli module
+1 People rely on CLI to operate on Hudi datasets. So having some tests there, would definitely be useful On Tue, May 12, 2020 at 12:39 PM Shiyan Xu wrote: > Hi, the tests in hudi-cli are more of functional tests. They are conducive > to verifying features in cli module are working. Though not covering all > options, it is always better to have some assuring passing tests than none, > isn't it? :) > > On Tue, May 12, 2020 at 8:31 AM hmantu wrote: > > > hi all, > > > > > > > > I can not understand why add so many tests for hudi-cli module? We know > > that each > > command has many options, unit tests can not cover all of these options, > > and each > > module has thier own unit tests, so I think they are redundant, any > > thoughs? > > > > > > > > > > > > Thanks >
Re: [DISCUSS] Why add unit tests for hudi-cli module
Hi, the tests in hudi-cli are more of functional tests. They are conducive to verifying features in cli module are working. Though not covering all options, it is always better to have some assuring passing tests than none, isn't it? :) On Tue, May 12, 2020 at 8:31 AM hmantu wrote: > hi all, > > > > I can not understand why add so many tests for hudi-cli module? We know > that each > command has many options, unit tests can not cover all of these options, > and each > module has thier own unit tests, so I think they are redundant, any > thoughs? > > > > > > Thanks
[DISCUSS] Why add unit tests for hudi-cli module
hi all, I can not understand why add so many tests for hudi-cli module? We know that each command has many options, unit tests can not cover all of these options, and each module has thier own unit tests, so I think they are redundant, any thoughs? Thanks
