Re: Coding guidelines

2020-09-02 Thread Balaji Varadarajan 
 +1. All current and future contributors/committers need to read this.
Balaji.V
On Wednesday, September 2, 2020, 01:11:46 AM PDT, vino yang 
 wrote:  
 
 +1 to have the coding guidelines.

Left some comments.

Best,
Vino

Vinoth Chandar  于2020年9月2日周三 上午9:51写道：

> Hello all,
>
> Put together a list to formalize the things we follow in code review
> process today. Please chime in on the PR review, for comments.
>
> https://github.com/apache/hudi/pull/2061
>
>
> Thanks
> Vinoth
>

Re: Coding guidelines

2020-09-02 Thread vino yang 
+1 to have the coding guidelines.

Left some comments.

Best,
Vino

Vinoth Chandar  于2020年9月2日周三 上午9:51写道：

> Hello all,
>
> Put together a list to formalize the things we follow in code review
> process today. Please chime in on the PR review, for comments.
>
> https://github.com/apache/hudi/pull/2061
>
>
> Thanks
> Vinoth
>

Coding guidelines

2020-09-01 Thread Vinoth Chandar 
Hello all,

Put together a list to formalize the things we follow in code review
process today. Please chime in on the PR review, for comments.

https://github.com/apache/hudi/pull/2061


Thanks
Vinoth