Re: Case sensitive indexes question.
i fill the ticket https://issues.apache.org/jira/browse/IGNITE-10654 , Vladimir can u check it? thanks. >Суббота, 15 декабря 2018, 20:11 +03:00 от stanilovsky evgeny >: > > > >--- Forwarded message --- >From: "Vladimir Ozerov" < voze...@gridgain.com > >To: dev < dev@ignite.apache.org > >Cc: arzamas...@mail.ru >Subject: Re: Case sensitive indexes question. >Date: Tue, 04 Dec 2018 15:27:02 +0300 > >I think that this is not an exceptional case, as nothing is broken. >Throwing exception may make migration from other systems harder. Warning >should be enough. >Also remember that all SQL caches already have 1-2 automatic indexes out of >the box, and we haven't seen much performance complaints about that. >Additional duplicate index will not lead to severe performance degradation >or system stall. > >On Fri, Nov 30, 2018 at 3:52 PM Yakov Zhdanov < yzhda...@apache.org > wrote: > >> Zhenya, >> >> Vladimir suggested not to restrict anything. However, my opinion is to >> throw exception on duplicating indexes. We should better add ability to >> rename index if it can be useful for anyone. Having same field set >> indexed >> with same index type is pretty strange and adds a lot of risk for >> performance of the system. If this is hard to support in 2.x then let's >> do >> it in 3.0. Vladimir, what do you think? >> >> -- Yakov -- Zhenya Stanilovsky
[jira] [Created] (IGNITE-10707) BinaryField: Allow checking NULL-value without reading value
Dmitry Lazurkin created IGNITE-10707: Summary: BinaryField: Allow checking NULL-value without reading value Key: IGNITE-10707 URL: https://issues.apache.org/jira/browse/IGNITE-10707 Project: Ignite Issue Type: Improvement Components: binary Reporter: Dmitry Lazurkin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Abbreviation code-style requirement.
Vyacheslav, > PR looks good to me in general, but I've noticed a possible typo in > the PR and Wiki: > 'lable' -> 'label' Good catch! I updated a PR [1]. Could someone fix it on wiki or give me rights to edit wiki? (my login is "pavlukhin") > Also, according to the wiki, the following rules should be added: > 'topologyVersion' -> 'topVer' > 'regularExpression' -> 'regex' Actually, the plugin operates with tokens which are determined assuming camel-case naming style. So, "topologyVersion" will be split to "topology" and "Version" and converted to "topVer" by transforming each token. But we cannot do so with "regularExpression" because there is no rules for "regular" and "expression". And even if we had such it would produce "regEx". Adding a rule "regularExpression=regex" to abbreviation.properties does not lead to desired effect. [1] https://github.com/dspavlov/ignite-abbrev-plugin/pull/2 2018-12-15 12:13 GMT+03:00, Vyacheslav Daradur : > Ivan, thank you! > > PR looks good to me in general, but I've noticed a possible typo in > the PR and Wiki: > 'lable' -> 'label' > > Also, according to the wiki, the following rules should be added: > 'topologyVersion' -> 'topVer' > 'regularExpression' -> 'regex' > > Am I miss something? > > On Sat, Dec 15, 2018 at 11:17 AM Павлухин Иван wrote: >> >> Hi Dmitriy, Vyacheslav, >> >> I created a ticket [1] and PR [2] for updating a list of abbreviations >> used by the plugin. The changes in the plugin itself looks trivial. >> But some extra build and publish steps are required (see the ticket). >> Also if I understand it correctly plugin should be build with scala >> support. I will need some time to ensure that I can build it properly. >> >> [1] https://issues.apache.org/jira/browse/IGNITE-10704 >> [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/2 >> >> 2018-11-02 21:38 GMT+03:00, Dmitriy Pavlov : >> > Hi Vyacheslav, >> > >> > I'm sorry I almost gave up with this donation >> > >> > http://apache-ignite-developers.2346864.n4.nabble.com/Re-Place-Ignite-Abbrev-Plugin-to-ASF-Ignite-supplementary-git-repo-tp32745p32764.html >> > because >> > we need someone to sign a software grant agreement, but there were >> > several >> > people who contributed to the plugin. >> > >> > Some of the authors are not active contributors anymore. So I've stuck >> > with >> > finding a way how to donate. >> > >> > Sincerely, >> > Dmitriy Pavlov >> > >> > пт, 2 нояб. 2018 г. в 21:24, Vyacheslav Daradur : >> > >> >> I've double checked, we are really able to use IDEA inspection's to >> >> inspect abbreviations by inspection's structure search and replace >> >> templates. >> >> It rather not intuitive and requires complex regex patterns. >> >> >> >> Also, at first sight, it shouldn't be difficult to work with the >> >> project's local properties from the plugin. >> >> >> >> On Fri, Nov 2, 2018 at 2:32 PM Vyacheslav Daradur >> >> >> >> wrote: >> >> > >> >> > I like your idea about auto updates. >> >> > >> >> > In this case, abbr-plugin should be improved to check and download >> >> > updates from external URI or local repo. >> >> > Looks like it could be implemented using Intellij's SDK virtual file >> >> > [1]. >> >> > >> >> > But as I can see that abbreviations list update is the very rare >> >> > case, >> >> > therefore I'm not sure that we really need to do it. >> >> > >> >> > Also, I have another idea we can try to use IDEA inspections and >> >> > it's >> >> > naming conventions rules. >> >> > IDEA inspections are under the project's git already. >> >> > >> >> > [1] >> >> https://www.jetbrains.org/intellij/sdk/docs/basics/architectural_overview/virtual_file.html >> >> > On Fri, Nov 2, 2018 at 1:47 PM Yakov Zhdanov >> >> wrote: >> >> > > >> >> > > No, I meant under Ignite's git so any change to resource file >> >> > > arrives >> >> with >> >> > > project workspace updates and gets automatically picked up by >> >> > > plugin. >> >> > > >> >> > > Makes sense? >> >> > > >> >> > > --Yakov >> >> > >> >> > >> >> > >> >> > -- >> >> > Best Regards, Vyacheslav D. >> >> >> >> >> >> >> >> -- >> >> Best Regards, Vyacheslav D. >> >> >> > >> >> >> -- >> Best regards, >> Ivan Pavlukhin > > > > -- > Best Regards, Vyacheslav D. > -- Best regards, Ivan Pavlukhin
[jira] [Created] (IGNITE-10706) SSL engine error in TcpCommunicationSpi connection is interrupted immediately after task send
Mikhail Filatov created IGNITE-10706: Summary: SSL engine error in TcpCommunicationSpi connection is interrupted immediately after task send Key: IGNITE-10706 URL: https://issues.apache.org/jira/browse/IGNITE-10706 Project: Ignite Issue Type: Bug Environment: java version "1.8.0_121" Java(TM) SE Runtime Environment (build 1.8.0_121-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.121-b13, mixed mode) Reporter: Mikhail Filatov Attachments: client.log, server.log Reproduced in test GridTcpCommunicationSpiSslSelfTest#testSendToManyNodes Application logs inclided -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Code inspection
Folks, There is a strange error on TC https://ci.ignite.apache.org/viewLog.html?buildId=2556875=IgniteTests24Java8_InspectionsCore It appeared after TC update to the latest version. Sincerely, Dmitry Pavlov пт, 14 дек. 2018 г. в 16:09, Andrey Mashenkov : > Maxim, > > PR is incomplete. Some plugins should be disabled with different id\name. > Maven plugin shouldn't be disabled as Idea Inspector use it to use Ignite > project pom file. > > Please, find details in ticket. > > > On Fri, Dec 14, 2018 at 12:00 PM Andrey Mashenkov < > andrey.mashen...@gmail.com> wrote: > > > Maxim, > > > > Thanks, I'll check PR and let you know about results. > > > > For now, Inspections task execution time looks much better (15-22 min), > > but fluctuation is still noticeable. > > > > On Fri, Dec 14, 2018 at 11:13 AM Maxim Muzafarov > > wrote: > > > >> Andrey, > >> > >> Thanks! I've consulted with the IntelliJ IDEA source code and found > >> how this disabled plugins file should look like. I've created a new > >> issue [1] and prepared PR [2] with the set of disabled plugins (maybe > >> not complete set). I don't have access to change corresponding > >> `~Excluded [Inspections] Core Debug` test suite properties. > >> Can we test this PR? > >> > >> [1] https://issues.apache.org/jira/browse/IGNITE-10682 > >> [2] https://github.com/apache/ignite/pull/5666 > >> On Thu, 13 Dec 2018 at 17:35, Andrey Mashenkov > >> wrote: > >> > > >> > Maxim, > >> > > >> > Idea has a file in config directory ./config/disabled_plugins.txt , > you > >> can easily find it at you local machine. > >> > Teamcity Inspections runner has an option "Disabled plugins" where > >> disabled_plugins.txt file content can be set. > >> > > >> > So, looks like we can disable useless plugins. > >> > But I'm not expert and can't suggest changes we can safely apply. > >> > > >> > On Thu, Dec 13, 2018 at 4:59 PM Maxim Muzafarov > >> wrote: > >> >> > >> >> Andrey, > >> >> > >> >> Thank you for solving this issue with GC pauses! I've checked the > >> >> given report. The inspections configuration is correct, but it seems > >> >> to me that we have enabled by default rules of included plugins (for > >> >> instance, KotlinInternalInJava in the report is enabled). > >> >> > >> >> Can you share more details about `disable plugin` option you found? > >> >> > >> >> I see that idea instance starts with the default -Didea.plugins.path > >> >> system property, can we change it so the plugins will be not loaded > by > >> >> default? > >> >> On Thu, 13 Dec 2018 at 15:45, Andrey Mashenkov > >> >> wrote: > >> >> > > >> >> > Maxim, > >> >> > > >> >> > It looks like we can't make logs more verbose due to possible bug, > >> I've create a ticket in Jetbrains Jira [1]. > >> >> > We can just publish idea logs in artefacts as suggested in this > >> manual [2]. > >> >> > > >> >> > For now, Inspections logs looks like this one [3]. > >> >> > Also, would you please to take a look at inspection report and > check > >> if we missed smth and there are any unwanted inspection turned on. > >> >> > > >> >> > [1] https://youtrack.jetbrains.com/issue/TW-58422 > >> >> > [2] > >> > https://confluence.jetbrains.com/display/TCD10/Reporting+Issues#ReportingIssues-IntelliJIDEAInspections > >> >> > [3] > >> > https://ci.ignite.apache.org/viewLog.html?buildId=2538111=IgniteTests24Java8_ExcludedInspections2=artifacts > >> >> > > >> >> > On Thu, Dec 13, 2018 at 3:19 PM Dmitriy Pavlov > > >> wrote: > >> >> >> > >> >> >> Maxim M, do you know if we can disable inspections by wildcard? > E.g. > >> >> >> Android* ? > >> >> >> > >> >> >> чт, 13 дек. 2018 г. в 14:59, Andrey Mashenkov < > >> andrey.mashen...@gmail.com>: > >> >> >> > >> >> >> > Fixed memory issues with increasing heap size and forcing G1GC. > >> >> >> > > >> >> >> > Do we need all these plugins loaded for inspections? > >> >> >> > I've found a 'disable plugin' option in TC Inspections build > >> configuration, > >> >> >> > but it is unclear how to disable plugin correctly. > >> >> >> > Can someone take over this? > >> >> >> > > >> >> >> > > 46 plugins initialized in 1031 ms > >> >> >> > > 2018-12-13 10:55:24,875 [ 1342] INFO - > >> llij.ide.plugins.PluginManager - > >> >> >> > > Loaded bundled plugins: Android Support (10.2.3), Ant Support > >> (1.0), CSS > >> >> >> > > Support (172.4574.11), Database Tools and SQL (172.4574.11), > >> Eclipse > >> >> >> > > Integration (3.0), FreeMarker support (1.0), GWT Support > (1.0), > >> Gradle > >> >> >> > > (172.4574.11), Groovy (9.0), Guice (8.0), HTML Tools (2.0), > >> Hibernate > >> >> >> > > Support (1.0), I18n for Java (172.4574.11), IDEA CORE > >> (172.4574.11), > >> >> >> > > IntelliLang (8.0), JBoss Seam Support (1.0), JUnit (1.0), Java > >> EE: Bean > >> >> >> > > Validation Support (1.1), Java EE: Contexts and Dependency > >> Injection > >> >> >> > (1.1), > >> >> >> > > Java EE: EJB, JPA, Servlets (1.0), Java EE: Java Server Faces > >> (2.2.X.), > >> >> >> > > Java EE: Web Services (JAX-WS) (1.9),
[jira] [Created] (IGNITE-10705) Wrong check of test's compatible 'dataMode' in IgniteConfigVariationsAbstractTest
Vyacheslav Daradur created IGNITE-10705:
---
Summary: Wrong check of test's compatible 'dataMode' in
IgniteConfigVariationsAbstractTest
Key: IGNITE-10705
URL: https://issues.apache.org/jira/browse/IGNITE-10705
Project: Ignite
Issue Type: Bug
Reporter: Vyacheslav Daradur
Found that method {{IgniteConfigVariationsAbstractTest#isCompatible}} works
incorrectly.
Here is the actual code:
{code:java}
protected boolean isCompatible() throws Exception {
switch (dataMode) {
case BINARILIZABLE:
case PLANE_OBJECT:
return !(getConfiguration().getMarshaller() instanceof
JdkMarshaller);
}
return false;
}
{code}
It returns {{false}} if a test mode is [SERIALIZABLE, CUSTOM_SERIALIZABLE], but
this is main modes which are supported by any marshaller.
*That means a set of tests which should be executed will be skipped instead.*
Also, modes {{BINARILIZABLE}} and {{PLANE_OBJECT}} are supported only by
{{BinaryMarshaller}} and {{OptimizedMarshaller.setRequireSerializable(false)}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: Abbreviation code-style requirement.
Ivan, thank you! PR looks good to me in general, but I've noticed a possible typo in the PR and Wiki: 'lable' -> 'label' Also, according to the wiki, the following rules should be added: 'topologyVersion' -> 'topVer' 'regularExpression' -> 'regex' Am I miss something? On Sat, Dec 15, 2018 at 11:17 AM Павлухин Иван wrote: > > Hi Dmitriy, Vyacheslav, > > I created a ticket [1] and PR [2] for updating a list of abbreviations > used by the plugin. The changes in the plugin itself looks trivial. > But some extra build and publish steps are required (see the ticket). > Also if I understand it correctly plugin should be build with scala > support. I will need some time to ensure that I can build it properly. > > [1] https://issues.apache.org/jira/browse/IGNITE-10704 > [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/2 > > 2018-11-02 21:38 GMT+03:00, Dmitriy Pavlov : > > Hi Vyacheslav, > > > > I'm sorry I almost gave up with this donation > > > > http://apache-ignite-developers.2346864.n4.nabble.com/Re-Place-Ignite-Abbrev-Plugin-to-ASF-Ignite-supplementary-git-repo-tp32745p32764.html > > because > > we need someone to sign a software grant agreement, but there were several > > people who contributed to the plugin. > > > > Some of the authors are not active contributors anymore. So I've stuck with > > finding a way how to donate. > > > > Sincerely, > > Dmitriy Pavlov > > > > пт, 2 нояб. 2018 г. в 21:24, Vyacheslav Daradur : > > > >> I've double checked, we are really able to use IDEA inspection's to > >> inspect abbreviations by inspection's structure search and replace > >> templates. > >> It rather not intuitive and requires complex regex patterns. > >> > >> Also, at first sight, it shouldn't be difficult to work with the > >> project's local properties from the plugin. > >> > >> On Fri, Nov 2, 2018 at 2:32 PM Vyacheslav Daradur > >> wrote: > >> > > >> > I like your idea about auto updates. > >> > > >> > In this case, abbr-plugin should be improved to check and download > >> > updates from external URI or local repo. > >> > Looks like it could be implemented using Intellij's SDK virtual file > >> > [1]. > >> > > >> > But as I can see that abbreviations list update is the very rare case, > >> > therefore I'm not sure that we really need to do it. > >> > > >> > Also, I have another idea we can try to use IDEA inspections and it's > >> > naming conventions rules. > >> > IDEA inspections are under the project's git already. > >> > > >> > [1] > >> https://www.jetbrains.org/intellij/sdk/docs/basics/architectural_overview/virtual_file.html > >> > On Fri, Nov 2, 2018 at 1:47 PM Yakov Zhdanov > >> wrote: > >> > > > >> > > No, I meant under Ignite's git so any change to resource file arrives > >> with > >> > > project workspace updates and gets automatically picked up by plugin. > >> > > > >> > > Makes sense? > >> > > > >> > > --Yakov > >> > > >> > > >> > > >> > -- > >> > Best Regards, Vyacheslav D. > >> > >> > >> > >> -- > >> Best Regards, Vyacheslav D. > >> > > > > > -- > Best regards, > Ivan Pavlukhin -- Best Regards, Vyacheslav D.
Re: Abbreviation code-style requirement.
Hi Dmitriy, Vyacheslav, I created a ticket [1] and PR [2] for updating a list of abbreviations used by the plugin. The changes in the plugin itself looks trivial. But some extra build and publish steps are required (see the ticket). Also if I understand it correctly plugin should be build with scala support. I will need some time to ensure that I can build it properly. [1] https://issues.apache.org/jira/browse/IGNITE-10704 [2] https://github.com/dspavlov/ignite-abbrev-plugin/pull/2 2018-11-02 21:38 GMT+03:00, Dmitriy Pavlov : > Hi Vyacheslav, > > I'm sorry I almost gave up with this donation > > http://apache-ignite-developers.2346864.n4.nabble.com/Re-Place-Ignite-Abbrev-Plugin-to-ASF-Ignite-supplementary-git-repo-tp32745p32764.html > because > we need someone to sign a software grant agreement, but there were several > people who contributed to the plugin. > > Some of the authors are not active contributors anymore. So I've stuck with > finding a way how to donate. > > Sincerely, > Dmitriy Pavlov > > пт, 2 нояб. 2018 г. в 21:24, Vyacheslav Daradur : > >> I've double checked, we are really able to use IDEA inspection's to >> inspect abbreviations by inspection's structure search and replace >> templates. >> It rather not intuitive and requires complex regex patterns. >> >> Also, at first sight, it shouldn't be difficult to work with the >> project's local properties from the plugin. >> >> On Fri, Nov 2, 2018 at 2:32 PM Vyacheslav Daradur >> wrote: >> > >> > I like your idea about auto updates. >> > >> > In this case, abbr-plugin should be improved to check and download >> > updates from external URI or local repo. >> > Looks like it could be implemented using Intellij's SDK virtual file >> > [1]. >> > >> > But as I can see that abbreviations list update is the very rare case, >> > therefore I'm not sure that we really need to do it. >> > >> > Also, I have another idea we can try to use IDEA inspections and it's >> > naming conventions rules. >> > IDEA inspections are under the project's git already. >> > >> > [1] >> https://www.jetbrains.org/intellij/sdk/docs/basics/architectural_overview/virtual_file.html >> > On Fri, Nov 2, 2018 at 1:47 PM Yakov Zhdanov >> wrote: >> > > >> > > No, I meant under Ignite's git so any change to resource file arrives >> with >> > > project workspace updates and gets automatically picked up by plugin. >> > > >> > > Makes sense? >> > > >> > > --Yakov >> > >> > >> > >> > -- >> > Best Regards, Vyacheslav D. >> >> >> >> -- >> Best Regards, Vyacheslav D. >> > -- Best regards, Ivan Pavlukhin
[jira] [Created] (IGNITE-10704) Abbr-plugin: update list of abbreviations
Ivan Pavlukhin created IGNITE-10704: --- Summary: Abbr-plugin: update list of abbreviations Key: IGNITE-10704 URL: https://issues.apache.org/jira/browse/IGNITE-10704 Project: Ignite Issue Type: Task Reporter: Ivan Pavlukhin Assignee: Ivan Pavlukhin Recently the list of abbreviation to use was revisited. Updated list is located at https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules The following should be done: * Update the list used by abbreviation plugin. * Rebuild and publish new version of the plugin. NOTE: New version must attached to the page containing rules. Also it could be published on GitHub. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
