Re: No commits to Ignite website: migration from SVN to Git is in progress

2020-04-18 Thread Saikat Maitra
Hi Dmitriy,

Thank you for your email. I am fine with Github built-in merge tool.

Since, in ignite repo we were using the apply-pull-request.sh script and
pushing changes to gitbox (https://gitbox.apache.org/repos/asf/ignite.git)

I noted that it was immediately syncing the changes in github as well.

My understanding is the repo sync is two way and if we merge changes in
github then also it will be synced back to gitbox repo.

Regards,
Saikat



On Sat, Apr 18, 2020 at 6:40 PM Dmitriy Pavlov  wrote:

>  Hi Folks,
>
> Thanks, to Denis and Infra
>
> Saikat,
>
> with a slight risk of starting off-topic discussions about that, I
> nevertheless would like to suggest using GitHub build-in merge tool for PRs
> in the ignite-website. It always closes PRs, it closes right PR, so I find
> this option less error-prone. Since Infra integrated ASF repos with GitHub
> It is really easy to merge changes.
>
> But still, if you find having apply-pr script useful by any means, sure, go
> ahead. There are no restrictions there.
>
> Sincerely,
> Dmitriy Pavlov
>
> сб, 18 апр. 2020 г. в 21:43, Saikat Maitra :
>
> > Hi Denis,
> >
> > Thank you for your email. Yes, the docs looks good.
> >
> > I was asking about this script that we use in ignite repo as well for
> > committing changes.
> >
> >
> https://github.com/apache/ignite/blob/master/scripts/apply-pull-request.sh
> >
> > Regards,
> > Saikat
> >
> >
> >
> > On Mon, Apr 13, 2020 at 11:53 AM Denis Magda  wrote:
> >
> > > Hello Saikat,
> > >
> > > You can find short website development guidelines on this page [1].
> They
> > > are elementary and request to use pull-requests, especially, if the one
> > is
> > > not a committer. Feel free to elaborate on the process.
> > >
> > > Btw, what are the scripts referred by you?
> > >
> > > [1]
> > https://cwiki.apache.org/confluence/display/IGNITE/Website+Development
> > > -
> > > Denis
> > >
> > >
> > > On Sun, Apr 12, 2020 at 12:26 PM Saikat Maitra <
> saikat.mai...@gmail.com>
> > > wrote:
> > >
> > > > Hello,
> > > >
> > > > Are we following the same contribution flow as we are doing for
> ignite
> > > git
> > > > repo?
> > > >
> > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ClosingaTicket
> > > >
> > > > I have observed that github ignite-website is also mirrored at
> > > > https://gitbox.apache.org/repos/asf?p=ignite-website.git
> > > >
> > > > I can add our scripts folder in ignite-website folder if it helps.
> > > >
> > > > Regards,
> > > > Saikat
> > > >
> > > > On Tue, Apr 7, 2020 at 12:49 AM Ivan Pavlukhin 
> > > > wrote:
> > > >
> > > > > Thank you!
> > > > >
> > > > > Best regards,
> > > > > Ivan Pavlukhin
> > > > >
> > > > > вт, 7 апр. 2020 г. в 00:46, Denis Magda :
> > > > > >
> > > > > > The website is back to normal and serves the content from the Git
> > > > > > repository's "master" branch:
> > > > > > https://github.com/apache/ignite-website/blob/master
> > > > > >
> > > > > > -
> > > > > > Denis
> > > > > >
> > > > > >
> > > > > > On Mon, Apr 6, 2020 at 2:19 PM Denis Magda 
> > > wrote:
> > > > > >
> > > > > > > I'm checking with the INFRA. It's down for at least the last
> > couple
> > > > of
> > > > > > > hours.
> > > > > > >
> > > > > > > -
> > > > > > > Denis
> > > > > > >
> > > > > > >
> > > > > > > On Mon, Apr 6, 2020 at 12:44 PM Ivan Pavlukhin <
> > > vololo...@gmail.com>
> > > > > > > wrote:
> > > > > > >
> > > > > > >> Denis,
> > > > > > >>
> > > > > > >> Is it expected that main website https://ignite.apache.org/
> > does
> > > > not
> > > > > > >> work now?
> > > > > > >>
> > > > > > >> Best regards,
> > > > > > >> Ivan Pavlukhin
> > > > > > >>
> > > > > > >> сб, 4 апр. 2020 г. в 01:15, Denis Magda :
> > > > > > >> >
> > > > > > >> > Igniters,
> > > > > > >> >
> > > > > > >> > Please avoid any commits to the website repository until
> > further
> > > > > notice.
> > > > > > >> > We're in a process of the migration:
> > > > > > >> > https://issues.apache.org/jira/browse/INFRA-20065
> > > > > > >> >
> > > > > > >> > -
> > > > > > >> > Denis
> > > > > > >>
> > > > > > >
> > > > >
> > > >
> > >
> >
>


Re: No commits to Ignite website: migration from SVN to Git is in progress

2020-04-18 Thread Dmitriy Pavlov
 Hi Folks,

Thanks, to Denis and Infra

Saikat,

with a slight risk of starting off-topic discussions about that, I
nevertheless would like to suggest using GitHub build-in merge tool for PRs
in the ignite-website. It always closes PRs, it closes right PR, so I find
this option less error-prone. Since Infra integrated ASF repos with GitHub
It is really easy to merge changes.

But still, if you find having apply-pr script useful by any means, sure, go
ahead. There are no restrictions there.

Sincerely,
Dmitriy Pavlov

сб, 18 апр. 2020 г. в 21:43, Saikat Maitra :

> Hi Denis,
>
> Thank you for your email. Yes, the docs looks good.
>
> I was asking about this script that we use in ignite repo as well for
> committing changes.
>
> https://github.com/apache/ignite/blob/master/scripts/apply-pull-request.sh
>
> Regards,
> Saikat
>
>
>
> On Mon, Apr 13, 2020 at 11:53 AM Denis Magda  wrote:
>
> > Hello Saikat,
> >
> > You can find short website development guidelines on this page [1]. They
> > are elementary and request to use pull-requests, especially, if the one
> is
> > not a committer. Feel free to elaborate on the process.
> >
> > Btw, what are the scripts referred by you?
> >
> > [1]
> https://cwiki.apache.org/confluence/display/IGNITE/Website+Development
> > -
> > Denis
> >
> >
> > On Sun, Apr 12, 2020 at 12:26 PM Saikat Maitra 
> > wrote:
> >
> > > Hello,
> > >
> > > Are we following the same contribution flow as we are doing for ignite
> > git
> > > repo?
> > >
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ClosingaTicket
> > >
> > > I have observed that github ignite-website is also mirrored at
> > > https://gitbox.apache.org/repos/asf?p=ignite-website.git
> > >
> > > I can add our scripts folder in ignite-website folder if it helps.
> > >
> > > Regards,
> > > Saikat
> > >
> > > On Tue, Apr 7, 2020 at 12:49 AM Ivan Pavlukhin 
> > > wrote:
> > >
> > > > Thank you!
> > > >
> > > > Best regards,
> > > > Ivan Pavlukhin
> > > >
> > > > вт, 7 апр. 2020 г. в 00:46, Denis Magda :
> > > > >
> > > > > The website is back to normal and serves the content from the Git
> > > > > repository's "master" branch:
> > > > > https://github.com/apache/ignite-website/blob/master
> > > > >
> > > > > -
> > > > > Denis
> > > > >
> > > > >
> > > > > On Mon, Apr 6, 2020 at 2:19 PM Denis Magda 
> > wrote:
> > > > >
> > > > > > I'm checking with the INFRA. It's down for at least the last
> couple
> > > of
> > > > > > hours.
> > > > > >
> > > > > > -
> > > > > > Denis
> > > > > >
> > > > > >
> > > > > > On Mon, Apr 6, 2020 at 12:44 PM Ivan Pavlukhin <
> > vololo...@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > >> Denis,
> > > > > >>
> > > > > >> Is it expected that main website https://ignite.apache.org/
> does
> > > not
> > > > > >> work now?
> > > > > >>
> > > > > >> Best regards,
> > > > > >> Ivan Pavlukhin
> > > > > >>
> > > > > >> сб, 4 апр. 2020 г. в 01:15, Denis Magda :
> > > > > >> >
> > > > > >> > Igniters,
> > > > > >> >
> > > > > >> > Please avoid any commits to the website repository until
> further
> > > > notice.
> > > > > >> > We're in a process of the migration:
> > > > > >> > https://issues.apache.org/jira/browse/INFRA-20065
> > > > > >> >
> > > > > >> > -
> > > > > >> > Denis
> > > > > >>
> > > > > >
> > > >
> > >
> >
>


Re: No commits to Ignite website: migration from SVN to Git is in progress

2020-04-18 Thread Saikat Maitra
Hi Denis,

Thank you for your email. Yes, the docs looks good.

I was asking about this script that we use in ignite repo as well for
committing changes.

https://github.com/apache/ignite/blob/master/scripts/apply-pull-request.sh

Regards,
Saikat



On Mon, Apr 13, 2020 at 11:53 AM Denis Magda  wrote:

> Hello Saikat,
>
> You can find short website development guidelines on this page [1]. They
> are elementary and request to use pull-requests, especially, if the one is
> not a committer. Feel free to elaborate on the process.
>
> Btw, what are the scripts referred by you?
>
> [1] https://cwiki.apache.org/confluence/display/IGNITE/Website+Development
> -
> Denis
>
>
> On Sun, Apr 12, 2020 at 12:26 PM Saikat Maitra 
> wrote:
>
> > Hello,
> >
> > Are we following the same contribution flow as we are doing for ignite
> git
> > repo?
> >
> >
> >
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ClosingaTicket
> >
> > I have observed that github ignite-website is also mirrored at
> > https://gitbox.apache.org/repos/asf?p=ignite-website.git
> >
> > I can add our scripts folder in ignite-website folder if it helps.
> >
> > Regards,
> > Saikat
> >
> > On Tue, Apr 7, 2020 at 12:49 AM Ivan Pavlukhin 
> > wrote:
> >
> > > Thank you!
> > >
> > > Best regards,
> > > Ivan Pavlukhin
> > >
> > > вт, 7 апр. 2020 г. в 00:46, Denis Magda :
> > > >
> > > > The website is back to normal and serves the content from the Git
> > > > repository's "master" branch:
> > > > https://github.com/apache/ignite-website/blob/master
> > > >
> > > > -
> > > > Denis
> > > >
> > > >
> > > > On Mon, Apr 6, 2020 at 2:19 PM Denis Magda 
> wrote:
> > > >
> > > > > I'm checking with the INFRA. It's down for at least the last couple
> > of
> > > > > hours.
> > > > >
> > > > > -
> > > > > Denis
> > > > >
> > > > >
> > > > > On Mon, Apr 6, 2020 at 12:44 PM Ivan Pavlukhin <
> vololo...@gmail.com>
> > > > > wrote:
> > > > >
> > > > >> Denis,
> > > > >>
> > > > >> Is it expected that main website https://ignite.apache.org/ does
> > not
> > > > >> work now?
> > > > >>
> > > > >> Best regards,
> > > > >> Ivan Pavlukhin
> > > > >>
> > > > >> сб, 4 апр. 2020 г. в 01:15, Denis Magda :
> > > > >> >
> > > > >> > Igniters,
> > > > >> >
> > > > >> > Please avoid any commits to the website repository until further
> > > notice.
> > > > >> > We're in a process of the migration:
> > > > >> > https://issues.apache.org/jira/browse/INFRA-20065
> > > > >> >
> > > > >> > -
> > > > >> > Denis
> > > > >>
> > > > >
> > >
> >
>


Re: Apache Ignite 2.8.1 RELEASE [Time, Scope, Manager]

2020-04-18 Thread Nikolay Izhikov
Hello, Igniters.

After some scripting I got the following lists of commits to transfer from 
master to 2.8.1
It will be very helpful if someone double check my results.

I did the following:

1. Export all resolved tickets targeted to 2.8.1 from Mira
2. Found commit difference between 2.8.0 and master

git merge-base upstream-http/ignite-2.8 upstream-http/master
git log --pretty=oneline --abbrev-commit 
9265c04a368c4cf0fc331aac5a71f7d0db365ea8..HEAD

3. Filter commits to transfer preserving order with the dirty python script:

```
tickets = set()
founded = {}
with open("/Users/sbt-izhikov-nv/src/ignite-2.8.1/resolved.csv") as file_in:
for line in file_in:
if not line.startswith('-'):
ticket = line[:-1]
tickets.add(ticket)
founded[ticket] = 0 
print(tickets)

with open("/Users/sbt-izhikov-nv/src/ignite-2.8.1/commits-after-cut-2.8.txt") 
as file_in:
for commit_msg in file_in:
for ticket in tickets:
if ticket in commit_msg:
print(commit_msg)
founded[ticket] += 1

for ticket in founded.keys():
if founded[ticket] != 1:
print(ticket + " = " + str(founded[ticket]))
```

Results:


TO CHERRY PICK (FROM BOTTOM TO TOP):
4e6cd2ce04 IGNITE-12759 Getting a SecurityContext from GridSecurityProcessor - 
Fixes #7523.
a65e51c914 IGNITE-12790 Introduce distributed SQL configuration and ability to 
disable SQL functions. (#7593)
d0c155fe43 IGNITE-12772 Fixed JmxMetricExporterSpi uses log method which must 
not be used in production code (#7604)
00cb1ad7a3 IGNITE-12764: Thin JDBC streaming fails BatchUpdateException if 
function is used (#7615)
60ebc23f99 IGNITE-12848 fix H2Connection leaks on INSERT (#7649)
b8167296b1 IGNITE-12805 Fixed NullPointerException when memory restore is in 
progress. Fixes #7562
f57509e8e6 IGNITE-12828 Fixes NPE during CQ registration with failed 
deployment. (#7620)
826aad8890 IGNITE-12726 Long keys support for metastorage. (#7606)
2b1d2b4dec IGNITE-12859: Support of .Net service call with the Timestamp and 
Guid params. (#7618)
6f3515686f IGNITE-12769: histogramNames cache in MetricRegistryMBean removed. 
(#7549)
0b185b192f IGNITE-12800  SQL: local queries cursors must be closed or full read 
to unlock the GridH2Table. (#7551)
795617fc94 IGNITE-12774 Handle "Too many open files" exception - Fixes #7516.
3928bb3a13 IGNITE-12799 Fixed wrong SpEL expression.
bcaae8deef IGNITE-12734 Fixed scan query over evicted partition - Fixes #7494.
ef4f67e351 IGNITE-12743 Java thin client: Fixed thread shutdown on client close 
when partition awareness is enabled - Fixes #7522.
13637a2dfe IGNITE-12745: Compute job view implemented. (#7495)
e389bb8f55 IGNITE-12728 Collect time statistics on cache#putAllAsync - Fixes 
#7483.
4921fcf1fe IGNITE-12701 : Disallow silent deactivation in CLI and REST. (#7471)
683f22e64f IGNITE-12756 TcpCommunication SPI metrics improvement
e4f9be52f8 IGNITE-12717 SQL: index creation refactoring (#7474)
90951c6b2e IGNITE-12711 Fixed tests memory usage. - Fixes #7469.
f32b44deb1 IGNITE-12590: Fix (remove) check KEY at the MERGE command (#7321)
59917f0731 IGNITE-12624 Java thin client: typeId generation for system types 
fixed - Fixes #7416.
cc6f4d7814 IGNITE-12671 Ignoring single messages during PME can prevent late 
affinity switch. - Fixes #7425.
02ac292662 IGNITE-11798 Fix memory leak on unstable topology caused by 
partition reservation (#7251)
8ed8576544 IGNITE-12665: SQL: Fix potential race on MapResult close.
465cc444d0 IGNITE-12582 Add Spring EL support in Spring Data. - Fixes #7411.
100101ccce IGNITE-12605: Reset initial update counter value before clearing a 
partition (#7341)
e17887bfbf IGNITE-12654 Some of rentingFutures in GridDhtPartitionTopologyImpl 
may accumulate a huge number of eviction callbacks - Fixes #7399.
bdbe6a79d0 IGNITE-12651 Non-comparable keys for eviction policy cause failure 
handle and node shutdown - Fixes #7397.
56a515db6d IGNITE-12631 Incorrect rewriting wal record type in marshalled mode 
during iteration - Fixes #7371.
14dd160f90 IGNITE-12621 Node leave may cause NullPointerException during IO 
message processing if security is enabled - Fixes #7366.
67ac1d5d68 IGNITE-12636 Full rebalance instead of a historical one - Fixes 
#7379.
4433485d74 IGNTIE-12468 Java thin client: deserialization of arrays, 
collections and maps fixed - Fixes #7320.
0dfd98388e IGNITE-12618 Affinity cache for version of last server event can be 
wiped from history - Fixes #7359.
e2c597fff1 IGNITE-12013 NullPointerException is thrown by ExchangeLatchManager 
during cache creation - Fixes #7335.
a9278eedf7 IGNITE-11797 Fixed partition consistency issues for atomic and mixed 
tx-atomic cache groups. - Fixes #7315.
e160c8f231 IGNITE-12557 Fix possible IgniteOOM during cache destroy. - Fixes 
#7298.
41ed3294ec IGNITE-12567 H2Tree goes into illegal state when non-indexed columns 
are dropped - Fixes #7290.
e89c71d3cb IGNITE-12569 Can't set serializ

Re: New Monitoring System: items to complete before GA

2020-04-18 Thread Nikolay Izhikov
> 1. Add ability to enable\disable subset of the metrics for collection:
> https://issues.apache.org/jira/browse/IGNITE-11927
> Am I right that the task will let us perform a desired configuration
MetricExporterSPI and its specific implementation?

This improvement should allow Ignite users to disable or enable
`MetricsRegistry` globally on the node.
When some `MetricRegistry` disabled then registry:
* Do not consume resources(CPU, RAM) to keep metrics values up to
date(don’t perform increment, decrement operations,  etc)
* Can’t be viewed in any exporter.

> Frankly, I couldn't figure out how to do that with
"setExportFilter(Predicate filter);"

With filter user can exclude arbitrary registry from arbitrary exporter.
Example of filtering out all cache metrics from JMX:

```
JmxMetricExporterSpi jmxSpi = new JmxMetricExporterSpi();
jmxSpi.setExportFilter(mreg -> !mreg.name().startsWith(«cache»));

cfg.setMetricExporterSpi(jmxSpi);
```

> 2. Extension of IgniteSpiContext in order to allow Ignite developers to
implement their own exporters

Please, clarify, your idea.
Exporters can be implemented without usage of the internal API.
You can look into JmxMetricExporterSpi as an example.

> 3. Adding/extending/removing public metrics related to the API facade.

I think we can start with a discussion and finishing Java API to read
metrics.
It implemented in my PR [1].

> 4. After registering an exporter with a node only a subset of metrics
gets updated. This is extremely confusing. Any way we can remove this
ambiguity?

Yes, it a bad thing.
And it’s known restriction of the current implementation that was
introduced to preserve backward compatibility.
It seems we can remove this restriction after  IGNITE-11927 would be
implemented.

> 5. The system view that should track compute tasks (views.tasks) is
always empty

TASKS reflects the running task that was started on the local node.
You can find an example of using this view in tests [2]
It seems we should add examples for the views.

The view to observe compute JOBS(parts of the task that are executed on the
remote node) was added by me in [3]
It’s not a part of 2.8.0 release but should be available in 2.8.1

> 6. Ignite MBeans are listed under "org.apache.{node_id}" but should be
placed under "org.apache.ignite.{node_id}".

Please, create a ticket and I will try to fix it.

> we can also add descriptions to MXBeans explaining what a metric is used
for.

Great idea! Let’s do it, for sure!
Please, create a ticket for it

> 8. Failed to use LogExporterSpi:

On my plate, I will fix it.

[1] https://github.com/apache/ignite/pull/7283
[2]
https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/metric/SystemViewSelfTest.java#L236
[3] https://issues.apache.org/jira/browse/IGNITE-12745


ср, 8 апр. 2020 г. в 23:10, Denis Magda :

> Igniters,
>
> There was a private discussion between Nikolay Izhikov, Andrey Gura, Alex
> Goncharuk and I some time ago where we attempted to outline a list of tasks
> to complete before announcing the feature in the GA state (removing the
> experimental flag from the new APIs and deprecating the legacy ones).
> Folks, with your permission, let me share the list first and next we can
> talk out each item in detail separately:
>
> 1. Add ability to enable\disable subset of the metrics for collection:
> https://issues.apache.org/jira/browse/IGNITE-11927
> Am I right that the task will let us perform a desired configuration
> MetricExporterSPI and its specific implementation? Frankly, I couldn't
> figure out how to do that
> with "setExportFilter(Predicate filter);" method --
> probably, that's just the matter of documentation.
>
> 2. Extension of IgniteSpiContext in order to allow Ignite developers to
> implement their own exporters (with no usage of the internal API).
>
> 3. Adding/extending/removing public metrics related to the API
> facade. Andrey, please elaborate on this item if needed.
>
> Also, I had a chance to experience the API in wearing a hat of an
> application developer while preparing for the Ignite 2.8 webinar. Please
> take into account my feedback below. Overall, I was impressed with the way
> the new system is designed and operates. All I had to do is just to
> register exporters and connect my favorite tool to the cluster. Kudos to
> Nikolay, Andrey and everyone else involved. So, that's my list and I ready
> to create JIRA tickets whenever is relevant:
>
> 4. After registering an exporter with a node only a subset of metrics gets
> updated. For instance, "GetTime_X" set of metrics belonging to a specific
> cache get updated all the times while CacheGets/Puts/Hits require me to
> enable "setStatisticsEnable(true)" for the cache. This is extremely
> confusing. Any way we can remove this ambiguity? Guess the same applies for
> memory and persistence metrics - there are old ones that might require to
> turn on "metricsEnabled" flag for data regions.
>
> 5. The system view that should t