Re: Removal of "default" cache from REST APIs

2020-07-19 Thread Evgeniy Rudenko
Hi Saikat,

I understand this, but as I wrote this is pointless. It is not safe
fallback, because there is no "default" cache. If you will try to use any
API without a name you will receive the following error:

*org.apache.ignite.IgniteCheckedException: Failed to find cache for given
cache name: default*

Better to replace it by the correctly formed error message that will point
to the actual problem of the request. API documents will be updated
accordingly when PR will be merged.

On Sun, Jul 19, 2020 at 12:56 AM Saikat Maitra 
wrote:

> Hi Evgeniy,
>
> The default cacheName is safe fallback when cache name is not provided in
> the request. It is part of rest document.
>
> https://apacheignite.readme.io/docs/rest-api#put
>
> When request do not have cacheName since it is optional param then this
> DFLT_CACHE_NAME is used
>
> https://github.com/apache/ignite/pull/8041/files#diff-a3477d5e0cfdfcceed3371fc899a9d15L30
>
> Regards,
> Saikat
>
> On Wed, Jul 15, 2020 at 10:43 PM Evgeniy Rudenko 
> wrote:
>
> > Hi guys,
> >
> > Most of the cache APIs are trying to use "default" cache when cacheName
> is
> > not provided. This is pointless, because we don't have such cache by
> > default. I would like to change that and just return "Failed to find
> > mandatory parameter in request" error if name is absent.
> >
> > Please tell if you have any concerns. Update can be found at
> > https://github.com/apache/ignite/pull/8041
> >
> > --
> > Best regards,
> > Evgeniy
> >
>


-- 
Best regards,
Evgeniy


[jira] [Created] (IGNITE-13268) Add indexes manipulation commands to control.sh

2020-07-19 Thread Vladimir Malinovskiy (Jira)
Vladimir Malinovskiy created IGNITE-13268:
-

 Summary: Add indexes manipulation commands to control.sh
 Key: IGNITE-13268
 URL: https://issues.apache.org/jira/browse/IGNITE-13268
 Project: Ignite
  Issue Type: Improvement
  Components: control.sh
Reporter: Vladimir Malinovskiy
Assignee: Vladimir Malinovskiy


These subcommands are to be added to the *--cache* command:
h2. --indexes_list

Gets list of indexes info. Although filters can be specified via command 
arguments lines of output should still be grepable.
h4. Argument:
 * *--node-id* is a UUID of node for which to perform the operation. If node 
isn’t specified explicitly it will be chosen by grid.

 * *--group-name* is a regular expression corresponding to the group name.

 * *--cache-name* is a regular expression corresponding to the name of the 
cache.

 * *--index-name* is a regular expression that matches the name of the index.

h2. --indexes-rebuild-status

Gets list of indexes that are currently being rebuilt.
h4. Argument:
 * *--node-id* is a UUID of node for which to perform the operation. If node 
isn’t specified explicitly indexes rebuild info will be collected from all 
nodes.

h2. --indexes_force_rebuild

Triggers force rebuild of indexes. This information should be reported in the 
output:
 * List of caches that weren’t found.

 * List of caches that have index rebuild in progress. Indexes rebuild 
shouldn’t be restarted for these caches.

 * List of caches for which index rebuild was triggered.

Indexes rebuild should be performed asynchronously.
h4. Argument:
 * *--node-id* is a UUID of node for which to perform the operation. Mandatory 
parameter.

 * *--group-names* is a comma-separated list of group names for which to 
rebuild indexes. Either this option or --cache-names must be specified.

 * *--cache-names* is a comma-separated list of cache names for which to 
rebuild indexes. Either this option or --group-names must be specified.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


IGNITE-13040, please review pull request

2020-07-19 Thread Aleksey Kurinov
Hello

Vladimir Steshin
, Alexey
Goncharuk
 ,
please check out the pull
request. https://github.com/apache/ignite/pull/7977

thank you

Aleksei Kurinov