Re: [DISCUSS] Missed (non-suited) tests
Hi, Petr! I've created a ticket [1] for that and assigned it on you. Could you please catch it when you have time? [1] https://issues.apache.org/jira/browse/IGNITE-14283 On Wed, Mar 3, 2021 at 11:06 PM Maxim Muzafarov wrote: > Max, > > > There is an overhead for running git + mvn test twice, but it is a cost > for the flexibility. > > Yes, I mean this issue. I have no objections, the build queue seems to > be empty most of the time. > > On Wed, 3 Mar 2021 at 21:01, Max Timonin wrote: > > > > Yes, they can be performed as parallel, as doesn't depend on each other. > > There is an overhead for running git + mvn test twice, but it is a cost > for > > the flexibility. > > > > On Wed, Mar 3, 2021 at 8:55 PM Max Timonin > wrote: > > > > > I mean that any TC job with tests depends on both [Build], [Sanity > > > Checks]. No tests run if any of those jobs failed. > > > > > > [Build] prepares ignite.zip for distribution between TC agents (mvn > > > install). > > > [Sanity Checks] checks that code is correct in terms of our static > checks > > > (mvn test). > > > > > > Indeed it can be run as a single job, but in favor of flexibility in > > > configuration (enable / disable checks) it is OK to separate it in 2 > steps. > > > > > > Do you have some objections to do it that way? > > > > > > On Wed, Mar 3, 2021 at 8:45 PM Maxim Muzafarov > wrote: > > > > > >> Maxim, > > >> > > >> Can you clarify what means '[Sanity Checks] runs in parallel with > > >> [Build]'? AFAIK the checks need the build results to run themselves. > > >> > > >> On Wed, 3 Mar 2021 at 18:48, Max Timonin > wrote: > > >> > > > >> > Discussed with Petr privately. Proposal is: > > >> > > > >> > 1. The [Build] job runs without any checks. > > >> > 2. There will be a new job [Sanity Checks], that runs all checks - > > >> > checkstyle, licenses, javadoc, check-suites. > > >> > 3. [Sanity Checks] runs in parallel with [Build]. > > >> > 4. All TC jobs with tests depend on a result of the [Sanity Checks] > > >> job. If > > >> > the check job fails then a test job won't be started. > > >> > 5. Users can disable the [Sanity Checks] job with a selector on the > > >> > Parameters tab of custom TC build. > > >> > > > >> > If no one has objections I will create a JIRA ticket for that. > > >> > > > >> > > > >> > On Wed, Mar 3, 2021 at 5:11 PM Max Timonin > > > >> wrote: > > >> > > > >> > > Hi Petr! My proposal is: > > >> > > > > >> > > 1. Create a parameter in [Build] TC suite - MAVEN_CHECKS, default > > >> value is > > >> > > "-Plicenses,checkstyle,check-licenses,check-test-suites". > > >> > > 2. Use it in a command along with MAVEN_MODULES_STRING. > > >> > > -U -Pall-java,all-scala,scala,lgpl,examples %MAVEN_CHECKS% > > >> > > %MAVEN_MODULES_STRING% > > >> > > > > >> > > 3. Provide a global param for test suites > "reverse.dep.MAVEN_CHECKS" > > >> that > > >> > > is possible to override in a custom build. If I understand it > > >> correctly is > > >> > > possible to do by editing the job [1]. > > >> > > 4. This param should be represented to a user as a selector with 2 > > >> > > options: > > >> > > - default (see point 1.) > > >> > > - "-DskipTests=true" - that ignores all checks, skip tests and > just > > >> build > > >> > > a .zip of Ignite. > > >> > > > > >> > > Could you please review this solution? Is it OK for you? > > >> > > > > >> > > [1] > > >> > > > > >> > https://ci.ignite.apache.org/admin/editBuildParams.html?id=template:IgniteTests24Java8_RunTestSuitesJava > > >> > > > > >> > > On Thu, Feb 25, 2021 at 1:47 PM Petr Ivanov > > > >> wrote: > > >> > > > > >> > >> If profile can handle this — its ok. > > >> > >> > > >> > >> For choosing build type — we can introduce select, that will > choose > > >> > >> between -p and -DskipTests=true (defaulting to > profile). > > >> > >> Thus [Build] will pass either way. > > >> > >> > > >> > >> > > >> > >> Regards, > > >> > >> Petr Ivanov > > >> > >> Head of IT > > >> > >> IT & Development Solutions | GRIDGAIN SYSTEMS > > >> > >> +7 (911) 945-00-59 > > >> > >> > > >> > >> > On 25 Feb 2021, at 13:23, Max Timonin > > > >> wrote: > > >> > >> > > > >> > >> > Yes, it's correct that "mvn install" runs also the "mvn test" > > >> command, > > >> > >> and > > >> > >> > this is OK as the check-test-suites profile handles all tests > > >> > >> > without running them. If the skipTests flag is triggered then > this > > >> > >> check is > > >> > >> > useless. It will take only about 2 min to run "mvn test" with > this > > >> > >> profile. > > >> > >> > Travis does that as one of steps. > > >> > >> > > > >> > >> > So, there are no issues with tests. Should I provide more info > how > > >> this > > >> > >> > check works? > > >> > >> > > > >> > >> > Also, discussed with Anton Vinogradov, Alex Plekhanov. There > can > > >> be an > > >> > >> > issue, that sometimes it's required to run custom test suites > to > > >> debug > > >> > >> > flaky tests. Sequence of steps is the following: > > >> > >> > 1. Find a test suite with
[jira] [Created] (IGNITE-14283) Create the Sanity Checks job on TC
Maksim Timonin created IGNITE-14283: --- Summary: Create the Sanity Checks job on TC Key: IGNITE-14283 URL: https://issues.apache.org/jira/browse/IGNITE-14283 Project: Ignite Issue Type: New Feature Reporter: Maksim Timonin Assignee: Peter Ivanov 1. The [Build] job runs without any checks. 2. There will be a new job [Sanity Checks], that runs all checks - checkstyle, licenses, javadoc, check-suites. 3. [Sanity Checks] runs in parallel with [Build]. 4. All TC jobs with tests depend on a result of the [Sanity Checks] job. If the check job fails then a test job won't be started. 5. Users can disable the [Sanity Checks] job with a selector on the Parameters tab of custom TC build. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Release Apache Ignite 2.10.0 RC1
+1 (binding)
Downloaded the binary package and started a 2-node cluster on MacOS with
ignite.sh.
-
Denis
On Wed, Mar 3, 2021 at 1:03 PM Maxim Muzafarov wrote:
> Dear Community,
>
> The release candidate is ready. The rest of the documentation pages
> will be completed prior to the release announcement message. Please,
> see the links below.
>
>
> I have uploaded a release candidate to:
> https://dist.apache.org/repos/dist/dev/ignite/2.10.0-rc1/
> https://dist.apache.org/repos/dist/dev/ignite/packages_2.10.0-rc1/
>
> The following staging can be used for testing:
> https://repository.apache.org/content/repositories/orgapacheignite-1506
>
> https://www.myget.org/feed/apache-ignite-staging/package/nuget/Apache.Ignite
>
> Tag name is 2.10.0-rc1:
>
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=refs/tags/2.10.0-rc1
>
> RELEASE_NOTES:
>
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=RELEASE_NOTES.txt;hb=ignite-2.10
>
> Complete list of resolved issues:
>
> https://issues.apache.org/jira/issues/?jql=(project%20%3D%20'Ignite'%20AND%20fixVersion%20is%20not%20empty%20AND%20fixVersion%20in%20('2.10'))
>
> DEVNOTES:
>
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=DEVNOTES.txt;hb=ignite-2.10
>
>
> Additional checks have been performed (available for users included into
> the release group on TeamCity).
>
> TC [Check RC: Licenses, compile, chksum]
>
> https://ci.ignite.apache.org/viewLog.html?buildId=5901349=ApacheIgniteReleaseJava8_PrepareVote4CheckRcLicensesChecksum
>
> TC [3] Build & Upload Nuget Staging Packages
>
> https://ci.ignite.apache.org/viewLog.html?buildId=5901347=ApacheIgniteReleaseJava8_PrepareVote3BuildNuGetPackages
>
> TC [2] Compare w/ Previous Release
>
> https://ci.ignite.apache.org/viewLog.html?buildId=5901351=ApacheIgniteReleaseJava8_IgniteRelease72CheckFileConsistency=artifacts_Releases_ApacheIgniteMain=ignite-2.9.1#%2Fresults
>
>
> The vote is formal, see voting guidelines
> https://www.apache.org/foundation/voting.html
>
> +1 - to accept Apache Ignite 2.10.0-rc1
> 0 - don't care either way
> -1 - DO NOT accept Apache Ignite Ignite 2.10.0-rc1 (explain why)
>
> See notes on how to verify release here
> https://www.apache.org/info/verification.html
> and
>
> https://cwiki.apache.org/confluence/display/IGNITE/Release+Process#ReleaseProcess-P5.VotingonReleaseandReleaseVerification
>
> This vote will be open until Mon Mar 8, 15:00 UTC.
> Please, write me down the thread if you need additional time to check
> the release.
>
> https://www.timeanddate.com/countdown/vote?iso=20210308T18=166=VOTE+on+the+Apache+Ignite+Release+2.10.0+RC1=sanserif
>
Re: New committer: Mauricio Stekl
Congrats, Mauricio! For me, this election proves the statement, that you can contribute in many different ways. чт, 4 мар. 2021 г. в 18:32, Никита Сафонов : > Congratulations, Mauricio! > > Thank you for your hard work. > > Regards, > Nikita > > чт, 4 мар. 2021 г. в 17:56, Kseniya Romanova : > > > Mauricio, congrats, and many thanks for the help! > > > > чт, 4 мар. 2021 г. в 07:31, Denis Magda : > > > > > The Project Management Committee (PMC) for Apache Ignite has invited > > > Mauricio Stekl to become a committer and we are pleased to announce > > > that he has accepted. > > > > > > Mauricio is the contributor who has been maintaining and improving our > > > website for the last two years. There are countless small and > > > significant changes he has made throughout that time. He helped to > > > redesign the website, integrated the website into the documentation > > > publication process, regularly optimizes the pages to ensure our > > > project is easily discoverable by search engines. > > > > > > Being a committer enables easier contribution to the project since > > > there is no need to go via the patch submission process. This should > > > enable better productivity. > > > > > > - > > > Denis > > > > > >
[jira] [Created] (IGNITE-14282) .Net: Don't swallow exception in case Platform cache update error
Nikolay Izhikov created IGNITE-14282: Summary: .Net: Don't swallow exception in case Platform cache update error Key: IGNITE-14282 URL: https://issues.apache.org/jira/browse/IGNITE-14282 Project: Ignite Issue Type: Improvement Reporter: Nikolay Izhikov Currently, any error during platform cache update just logging and swallowing. Ignite should throw it to a higher level to handle with Failure Handler or similar way. Ignite shouldn't finish operation successfully in case of platform cache update. https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheMapEntry.java#L7047 -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: New committer: Mauricio Stekl
Congratulations, Mauricio! Thank you for your hard work. Regards, Nikita чт, 4 мар. 2021 г. в 17:56, Kseniya Romanova : > Mauricio, congrats, and many thanks for the help! > > чт, 4 мар. 2021 г. в 07:31, Denis Magda : > > > The Project Management Committee (PMC) for Apache Ignite has invited > > Mauricio Stekl to become a committer and we are pleased to announce > > that he has accepted. > > > > Mauricio is the contributor who has been maintaining and improving our > > website for the last two years. There are countless small and > > significant changes he has made throughout that time. He helped to > > redesign the website, integrated the website into the documentation > > publication process, regularly optimizes the pages to ensure our > > project is easily discoverable by search engines. > > > > Being a committer enables easier contribution to the project since > > there is no need to go via the patch submission process. This should > > enable better productivity. > > > > - > > Denis > > >
Re: New committer: Mauricio Stekl
Mauricio, congrats, and many thanks for the help! чт, 4 мар. 2021 г. в 07:31, Denis Magda : > The Project Management Committee (PMC) for Apache Ignite has invited > Mauricio Stekl to become a committer and we are pleased to announce > that he has accepted. > > Mauricio is the contributor who has been maintaining and improving our > website for the last two years. There are countless small and > significant changes he has made throughout that time. He helped to > redesign the website, integrated the website into the documentation > publication process, regularly optimizes the pages to ensure our > project is easily discoverable by search engines. > > Being a committer enables easier contribution to the project since > there is no need to go via the patch submission process. This should > enable better productivity. > > - > Denis >
[jira] [Created] (IGNITE-14281) Calcite. Colocated tables considered non colocated
Konstantin Orlov created IGNITE-14281: - Summary: Calcite. Colocated tables considered non colocated Key: IGNITE-14281 URL: https://issues.apache.org/jira/browse/IGNITE-14281 Project: Ignite Issue Type: Bug Components: sql Reporter: Konstantin Orlov Assignee: Konstantin Orlov Currently distribution trait for replicated cache is built over 0th column which is _KEY column. Because of this a colocated join is considered non-colocated until _KEY columns is not used explicitly as join predicate. Need to fix this. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (IGNITE-14280) Add view source code to SYS.VIEWS
Lukas Eder created IGNITE-14280: --- Summary: Add view source code to SYS.VIEWS Key: IGNITE-14280 URL: https://issues.apache.org/jira/browse/IGNITE-14280 Project: Ignite Issue Type: New Feature Components: sql Affects Versions: 2.9.1 Reporter: Lukas Eder Most RDBMS support recovering the source code for views in some INFORMATION_SCHEMA.VIEWS.VIEW_DEFINITION column, or similar. It would be interesting to offer this as well in SYS.VIEWS -- This message was sent by Atlassian Jira (v8.3.4#803005)
IEP-68: Thin Client Data Streamer
Igniters, Please review the IEP [1] and let me know what you think. [1] https://cwiki.apache.org/confluence/display/IGNITE/IEP-68%3A+Thin+Client+Data+Streamer
Re: [VOTE] Release Apache Ignite 2.10.0 RC1
+1 (binding)
Checked binary packages, started nodes, .NET examples, .NET nodes
On Wed, Mar 3, 2021 at 11:03 PM Maxim Muzafarov wrote:
> Dear Community,
>
> The release candidate is ready. The rest of the documentation pages
> will be completed prior to the release announcement message. Please,
> see the links below.
>
>
> I have uploaded a release candidate to:
> https://dist.apache.org/repos/dist/dev/ignite/2.10.0-rc1/
> https://dist.apache.org/repos/dist/dev/ignite/packages_2.10.0-rc1/
>
> The following staging can be used for testing:
> https://repository.apache.org/content/repositories/orgapacheignite-1506
>
> https://www.myget.org/feed/apache-ignite-staging/package/nuget/Apache.Ignite
>
> Tag name is 2.10.0-rc1:
>
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=commit;h=refs/tags/2.10.0-rc1
>
> RELEASE_NOTES:
>
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=RELEASE_NOTES.txt;hb=ignite-2.10
>
> Complete list of resolved issues:
>
> https://issues.apache.org/jira/issues/?jql=(project%20%3D%20'Ignite'%20AND%20fixVersion%20is%20not%20empty%20AND%20fixVersion%20in%20('2.10'))
>
> DEVNOTES:
>
> https://gitbox.apache.org/repos/asf?p=ignite.git;a=blob_plain;f=DEVNOTES.txt;hb=ignite-2.10
>
>
> Additional checks have been performed (available for users included into
> the release group on TeamCity).
>
> TC [Check RC: Licenses, compile, chksum]
>
> https://ci.ignite.apache.org/viewLog.html?buildId=5901349=ApacheIgniteReleaseJava8_PrepareVote4CheckRcLicensesChecksum
>
> TC [3] Build & Upload Nuget Staging Packages
>
> https://ci.ignite.apache.org/viewLog.html?buildId=5901347=ApacheIgniteReleaseJava8_PrepareVote3BuildNuGetPackages
>
> TC [2] Compare w/ Previous Release
>
> https://ci.ignite.apache.org/viewLog.html?buildId=5901351=ApacheIgniteReleaseJava8_IgniteRelease72CheckFileConsistency=artifacts_Releases_ApacheIgniteMain=ignite-2.9.1#%2Fresults
>
>
> The vote is formal, see voting guidelines
> https://www.apache.org/foundation/voting.html
>
> +1 - to accept Apache Ignite 2.10.0-rc1
> 0 - don't care either way
> -1 - DO NOT accept Apache Ignite Ignite 2.10.0-rc1 (explain why)
>
> See notes on how to verify release here
> https://www.apache.org/info/verification.html
> and
>
> https://cwiki.apache.org/confluence/display/IGNITE/Release+Process#ReleaseProcess-P5.VotingonReleaseandReleaseVerification
>
> This vote will be open until Mon Mar 8, 15:00 UTC.
> Please, write me down the thread if you need additional time to check
> the release.
>
> https://www.timeanddate.com/countdown/vote?iso=20210308T18=166=VOTE+on+the+Apache+Ignite+Release+2.10.0+RC1=sanserif
>
[jira] [Created] (IGNITE-14279) Introduce "sendWithResponse" into network API
Ivan Bessonov created IGNITE-14279:
--
Summary: Introduce "sendWithResponse" into network API
Key: IGNITE-14279
URL: https://issues.apache.org/jira/browse/IGNITE-14279
Project: Ignite
Issue Type: Sub-task
Reporter: Ivan Bessonov
Assignee: Ivan Bessonov
Fix For: 3.0.0-alpha2
{noformat}
/**
* Sends asynchronously a message with same guarantees as for {@link
#send(NetworkMember, Object)} and
* returns a response (RPC style).
*
* @param member Network member which should receive the message.
* @param msg A message.
* @param timeout Waiting for response timeout in milliseconds.
* @param Expected response type.
* @return A future holding the response or error if the expected response
was not received.
*/
CompletableFuture sendWithResponse(NetworkMember member, Object msg,
long timeout);
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
