Cherry-picked to release branch.
Best Regards,
Igor
On Fri, Jul 30, 2021 at 3:11 PM Alexey Gidaspov
wrote:
> Ok, I think we should add [1] to 2.11 release. Can you cherry-pick it to
> release branch?
> [1] https://issues.apache.org/jira/browse/IGNITE-14815
>
> On 2021/07/30 02:25:25, Igor Sapego wrote:
> > I'm fine with any of these two solutions.
> >
> > Best Regards,
> > Igor
> >
> >
> > On Thu, Jul 29, 2021 at 6:36 PM Ilya Kasnacheev <
> ilya.kasnach...@gmail.com>
> > wrote:
> >
> > > Hello!
> > >
> > > I think it does make sense to include changes which will let us avoid
> > > migration issues in the future.
> > >
> > > Alternatively, maybe we can revert the incomplete change from 2.11 in
> order
> > > to reintroduce it in 2.12 in full form if Igor agrees and RE thinks
> this is
> > > the best course of action.
> > >
> > > Regards,
> > > --
> > > Ilya Kasnacheev
> > >
> > >
> > > чт, 29 июл. 2021 г. в 18:07, Igor Sapego :
> > >
> > > > Alexey,
> > > >
> > > > It contains changes we could not introduce if we release ignite in
> its
> > > > current state as they are going to be breaking changes.
> > > >
> > > > Best Regards,
> > > > Igor
> > > >
> > > >
> > > > On Thu, Jul 29, 2021 at 4:13 PM Alexey Gidaspov <
> olive.c...@gmail.com>
> > > > wrote:
> > > >
> > > > > Hi, Igor!
> > > > >
> > > > > Now we are in stabilization phase and accepting only blockers. I
> may be
> > > > > wrong, but this ticket doesn't seem to be of that kind.
> > > > >
> > > > > On 2021/07/28 21:00:15, Igor Sapego wrote:
> > > > > > Igniters,
> > > > > >
> > > > > > I suggest adding [1] to the scope of release, because it contains
> > > > > > changes to code introduced by [2], which is already included in
> > > > release.
> > > > > >
> > > > > > [1] - https://issues.apache.org/jira/browse/IGNITE-14815
> > > > > > [2] - https://issues.apache.org/jira/browse/IGNITE-14658
> > > > > >
> > > > > > Best Regards,
> > > > > > Igor
> > > > > >
> > > > > >
> > > > > > On Mon, Jul 26, 2021 at 11:30 PM Maxim Muzafarov <
> mmu...@apache.org>
> > > > > wrote:
> > > > > >
> > > > > > > Folks,
> > > > > > >
> > > > > > > The issues mentioned above were successfully resolved and
> > > > > > > cherry-picked to the ignite-2.11 branch. Sorry for the delay. I
> > > think
> > > > > > > we can proceed with the release.
> > > > > > >
> > > > > > > On Thu, 22 Jul 2021 at 15:44, Maxim Muzafarov <
> mmu...@apache.org>
> > > > > wrote:
> > > > > > > >
> > > > > > > > Folks,
> > > > > > > >
> > > > > > > > Yes, both the fixes [1] [2] will not require performance
> tests
> > > > rerun.
> > > > > > > >
> > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15146
> > > > > > > > [2] https://issues.apache.org/jira/browse/IGNITE-15170
> > > > > > > >
> > > > > > > > On Thu, 22 Jul 2021 at 15:30, Dmitry Pavlov <
> dpav...@apache.org>
> > > > > wrote:
> > > > > > > > >
> > > > > > > > > I personally trust opinion of Nikolay and Maxim, we can
> > > consider
> > > > > both
> > > > > > > as blockers.
> > > > > > > > >
> > > > > > > > > Just an idea to consider:
> > > > > > > > > For fixed ticket/PR (
> > > > > > > https://issues.apache.org/jira/browse/IGNITE-15170) most
> likely
> > > we
> > > > > don't
> > > > > > > need to re-run performance tests.
> > > > > > > > >
> > > > > > > > > If second issue has no impact on performance, we can take
> perf
> > > > > results
> > > > > > > from rc.-1 and run only functional tests for rc.0.
> > > > > > > > >
> > > > > > > > > On 2021/07/22 04:44:01, "Николай Ижиков" <
> nizhi...@apache.org>
> > > > > wrote:
> > > > > > > > > > +1 to fix both prior to release
> > > > > > > > > >
> > > > > > > > > > Отправлено с iPhone
> > > > > > > > > >
> > > > > > > > > > > 22 июля 2021 г., в 02:36, Maxim Muzafarov <
> > > mmu...@apache.org
> > > > >
> > > > > > > написал(а):
> > > > > > > > > > >
> > > > > > > > > > > Folks,
> > > > > > > > > > >
> > > > > > > > > > > We've faced [1][2] issues related to the new
> functionality
> > > > > added to
> > > > > > > > > > > the 2.11 release (it will be safe to merge to the
> release
> > > > > branch).
> > > > > > > > > > > From my point of view, both of them are critical and
> must
> > > be
> > > > > > > included
> > > > > > > > > > > in the 2.11 release.
> > > > > > > > > > > The [2] is ready for merge. The [1] will be completed
> by
> > > the
> > > > > end
> > > > > > > of this week.
> > > > > > > > > > >
> > > > > > > > > > > Please share your thoughts.
> > > > > > > > > > >
> > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15146
> > > > > > > > > > > [2] https://issues.apache.org/jira/browse/IGNITE-15170
> > > > > > > > > > >
> > > > > > > > > > >> On Tue, 20 Jul 2021 at 15:08, Maxim Muzafarov <
> > > > > mmu...@apache.org>
> > > > > > > wrote:
> > > > > > > > > > >>
> > > > > > > > > > >> Folks,
> > > > > > > > > > >>
> > > > > > > > > > >> Since the release branch was created some time ago,
> should
> > > > we
> > > > > > > bump up
> > > > > > > > > >
