Re: Apache calcite dependency update issue.

2022-08-30 Thread Ivan Daschinsky
Oh, sorry, I see that it has been alredy reported. So let us wait for a bug
fix.

ср, 31 авг. 2022 г., 08:10 Ivan Daschinsky :

> I suppose that we are not in rush, because we have just cut off a release
> branch for 2.14. Let us wait for a new release of Calcite. By the way, has
> that bug been already reported?
>
> вт, 30 авг. 2022 г., 20:35 Zhenya Stanilovsky  >:
>
>>
>> Igniters, i found that new release of apache calcite was released (1.31)
>> [1]. This release contains great improvement [2] which makes possible to
>> resolve [3],  but also contains a bug [4] with natural join validation
>> (possibly not one, but apache ignite sql test suite highlight only this
>> one). I tried to override such a validation in IgniteSqlValidator but seems
>> there are lot of custom private stuff, so i failed here.
>> I don`t have my own opinion here, so we can:
>> *  update calcite version, mute test under calcite issue and wait new
>> calcite release.
>> *  do nothing and just wait new calcite version.
>> What do you think ?
>> Thanks !
>>
>> [1]  https://calcite.apache.org/docs/history.html#v1-31-0
>> [2]  https://issues.apache.org/jira/browse/CALCITE-4913
>> [3]  https://issues.apache.org/jira/browse/IGNITE-16040
>> [4]  https://issues.apache.org/jira/browse/CALCITE-5253
>>
>>
>>
>
>


Re: Apache calcite dependency update issue.

2022-08-30 Thread Ivan Daschinsky
I suppose that we are not in rush, because we have just cut off a release
branch for 2.14. Let us wait for a new release of Calcite. By the way, has
that bug been already reported?

вт, 30 авг. 2022 г., 20:35 Zhenya Stanilovsky :

>
> Igniters, i found that new release of apache calcite was released (1.31)
> [1]. This release contains great improvement [2] which makes possible to
> resolve [3],  but also contains a bug [4] with natural join validation
> (possibly not one, but apache ignite sql test suite highlight only this
> one). I tried to override such a validation in IgniteSqlValidator but seems
> there are lot of custom private stuff, so i failed here.
> I don`t have my own opinion here, so we can:
> *  update calcite version, mute test under calcite issue and wait new
> calcite release.
> *  do nothing and just wait new calcite version.
> What do you think ?
> Thanks !
>
> [1]  https://calcite.apache.org/docs/history.html#v1-31-0
> [2]  https://issues.apache.org/jira/browse/CALCITE-4913
> [3]  https://issues.apache.org/jira/browse/IGNITE-16040
> [4]  https://issues.apache.org/jira/browse/CALCITE-5253
>
>
>


Apache calcite dependency update issue.

2022-08-30 Thread Zhenya Stanilovsky

Igniters, i found that new release of apache calcite was released (1.31) [1]. 
This release contains great improvement [2] which makes possible to resolve 
[3],  but also contains a bug [4] with natural join validation (possibly not 
one, but apache ignite sql test suite highlight only this one). I tried to 
override such a validation in IgniteSqlValidator but seems there are lot of 
custom private stuff, so i failed here.  
I don`t have my own opinion here, so we can:
*  update calcite version, mute test under calcite issue and wait new calcite 
release.
*  do nothing and just wait new calcite version.
What do you think ?
Thanks !
 
[1]  https://calcite.apache.org/docs/history.html#v1-31-0
[2]  https://issues.apache.org/jira/browse/CALCITE-4913
[3]  https://issues.apache.org/jira/browse/IGNITE-16040
[4]  https://issues.apache.org/jira/browse/CALCITE-5253