Re: [DISCUSSION] Removal of ignitevisorcmd
Hi Igniters, I fully support the idea to stop supporting Visor and removing its implementation. However, do we have a list of useful features that do not exist in our control utility? Perhaps, it makes sense to reimplement such functionality and provide it based on control.sh script. Thanks, Slava. чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov : > PR is ready for review - https://github.com/apache/ignite/pull/10411 > > чт, 1 дек. 2022 г. в 16:49, Taras Ledkov : > > > Hi, > > > > +1 for remove Visor related code. > > Unfortunately we have to migrate `control-utility` to use IgniteClient > > (thin client) before drop GridClient. I guess we will do it in the > future. > > > > Also, the old thin JDBC based on the GridClient (classes placed at the > > org.apache.ignite.internal.jdbc.*) must be removed. > > >
A new feedback has been added : 99
A new feedback has been added, go to bugyard.io to see all the details... https://bugyard.io A new feedback has been added "Need to amend city_id to company_id for Primary Key definition" by jury.gerzhedowich View feedback https://app.bugyard.io/web/app/rycqZJDyY/f/6388bd86b6f6cf00142adea4
Re: [DISCUSSION] Removal of ignitevisorcmd
PR is ready for review - https://github.com/apache/ignite/pull/10411 чт, 1 дек. 2022 г. в 16:49, Taras Ledkov : > Hi, > > +1 for remove Visor related code. > Unfortunately we have to migrate `control-utility` to use IgniteClient > (thin client) before drop GridClient. I guess we will do it in the future. > > Also, the old thin JDBC based on the GridClient (classes placed at the > org.apache.ignite.internal.jdbc.*) must be removed. >
Re:[DISCUSSION] Removal of ignitevisorcmd
Hi, +1 for remove Visor related code. Unfortunately we have to migrate `control-utility` to use IgniteClient (thin client) before drop GridClient. I guess we will do it in the future. Also, the old thin JDBC based on the GridClient (classes placed at the org.apache.ignite.internal.jdbc.*) must be removed.
Re: Re[2]: [DISCUSSION] Removal of ignitevisorcmd
+1 > GridClient and related classes are not used by visorcmd, but used by > control.sh and can't be removed. I think it should not be too difficult to migrate GridClient -> IgniteClient and once it will happen the removal becomes be possible. On Thu, 1 Dec 2022 at 07:30, Alex Plehanov wrote: > > +1 for remove visorcmd and daemon nodes (there was already discussion about > this on dev list as far as I remember). > GridClient and related classes are not used by visorcmd, but used by > control.sh and can't be removed. > > чт, 1 дек. 2022 г. в 09:00, Zhenya Stanilovsky : > > > > > +1 for remove. > > > > > > > > > > >+1 This module seems to be completely abandoned > > > > > >чт, 1 дек. 2022 г., 00:46 Ilya Kasnacheev < ilya.kasnach...@gmail.com >: > > > > > >> Hello! > > >> > > >> Let's go ahead and remove what we don't use. Most of that stuff is deep > > >> legacy, even if it contains some rare gems of functionality that nobody > > >> knows how to use anymore. > > >> > > >> Regards, > > >> -- > > >> Ilya Kasnacheev > > >> > > >> > > >> ср, 30 нояб. 2022 г. в 20:12, Nikolay Izhikov < nizhi...@apache.org >: > > >> > > >> > Hello, Igniters. > > >> > > > >> > There are legacy modules - visor-console, visor-plugins, > > >> visor-console-2.10 > > >> > Looks like that modules are not evolving by community and barely used > > by > > >> > the Ignite users. > > >> > > > >> > I propose to remove it completely. > > >> > There are IEP [1] for this > > >> > > > >> > It seems that removal of visor modules allow to us to remove another > > >> legacy > > >> > code from Ignite codebase: > > >> > > > >> > * support of daemon nodes. > > >> > * GridClient and related classes. > > >> > > > >> > What do you think? > > >> > > > >> > [1] > > >> > > > >> > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=217392419 > > >> > > > >> > > > > > > > >
