Re: Please a reviewer for the case IGNITE-12518
Hi Saikat, Denis, I'll start to migrate the development to maven for your test. Best regards, *Luis Arce Martínez*Licenciado e Ingeniero en Informática y Gestión 09-57861903 Linkedin: https://cl.linkedin.com/in/luisalejandroarcemartinez El sáb., 25 ene. 2020 a las 23:24, Saikat Maitra () escribió: > Hi, Luis, Denis > > We can take up the changes in either Ignite-extensions repo as new > independent module or as part of ignite repo inside rest-http module but > since the changes are not in git pull request it is hard for us to review > and share feedback. > > 1. There are jar dependencies shared in the jira ticket[1] but we do not > accept jar instead we will require the changes in maven pom.xml file. > > 2. There are also changes in GridJettyRestHandler and GridJettyRestProtocol > but there are no corresponding tests for validation. It will be better if > required tests are added as part of PR. > > 3. It is also unclear how do we incorporate the changes mentioned in the > jira related to web.xml file, Do they need to be part of README.md? > > Please let me know if I can help in any way with PR process. > > Our docs for contribution are available here [2] > > [1] https://issues.apache.org/jira/browse/IGNITE-12518 > [2] https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute > > > Regards, > Saikat > > > > > > > > On Fri, Jan 24, 2020 at 11:09 AM Denis Magda wrote: > > > Hi Luis, > > > > Presently, the community is on the route of Ignite simplification. We're > > trying to define Ignite core that has minimal dependencies with 3rd party > > libraries. That also led to the modularization initiative [1] with the > > first results in the form of Ignite Extensions repository where we're > > moving all 3rd party integrations. > > > > Saikat, do you think Luis's contribution needs to reside in the > extensions > > repository? > > > > [1] > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization > > > > - > > Denis > > > > > > On Thu, Jan 23, 2020 at 8:48 PM Luis Arce wrote: > > > > > Hi Saikat, > > > Thanks for you response: > > > > > > My system need a web server for work. i work correctly with Wildfly > and i > > > use Ignite as Backend for database. > > > My problem is the combination of both is around 6 GB RAM for work in > the > > > VPS. > > > For this reason i modified the unique plugin with webserver inside > > > (rest-http module). > > > The change enabled the possibility for use only 3GB RAM in a VPS ( > > > vpsserver.com) saving money and enabling horizontal scalling. > > > I shared this change in the Jira ticket touching the two classes of > > > rest-http plugin. > > > The change has less impact (programaticly), the point is the library > > > dependencies (quantity of jars). > > > > > > It change has sense for you?, i think is a util because that > technologies > > > dont has present inside of ignite currently and is friendly with the > code > > > of rest-ignite. > > > > > > > > > > > > > > > Best regards, > > > > > > > > > *Luis Arce Martínez*Licenciado e Ingeniero en Informática y Gestión > > > 09-57861903 > > > Linkedin: > > > https://cl.linkedin.com/in/luisalejandroarcemartinez > > > > > > > > > > > > > > > > > > El mié., 22 ene. 2020 a las 0:38, Saikat Maitra (< > > saikat.mai...@gmail.com > > > >) > > > escribió: > > > > > > > Hello Luis, > > > > > > > > Thank you for your email. You can plan to create a separate > application > > > for > > > > jaxws service and use any build tools like gradle or maven to define > > your > > > > dependencies. > > > > > > > > Please find below some of the performance tips related to Ignite > > > > > > > > https://apacheignite.readme.io/docs/durable-memory-tuning > > > > > > > > You can use IgniteClient in your service and can connect to remote > > > cluster > > > > of Apache Ignite for data persistence. > > > > > > > > Can you please correct my understanding on the usage of > > ignite-rest-http > > > > in IGNITE-12518, I see the dependencies you have mentioned are > related > > to > > > > your project and my understanding is you are trying to use > > > ignite-rest-http >
Re: Please a reviewer for the case IGNITE-12518
Hi Saikat, Thanks for you response: My system need a web server for work. i work correctly with Wildfly and i use Ignite as Backend for database. My problem is the combination of both is around 6 GB RAM for work in the VPS. For this reason i modified the unique plugin with webserver inside (rest-http module). The change enabled the possibility for use only 3GB RAM in a VPS ( vpsserver.com) saving money and enabling horizontal scalling. I shared this change in the Jira ticket touching the two classes of rest-http plugin. The change has less impact (programaticly), the point is the library dependencies (quantity of jars). It change has sense for you?, i think is a util because that technologies dont has present inside of ignite currently and is friendly with the code of rest-ignite. Best regards, *Luis Arce Martínez*Licenciado e Ingeniero en Informática y Gestión 09-57861903 Linkedin: https://cl.linkedin.com/in/luisalejandroarcemartinez El mié., 22 ene. 2020 a las 0:38, Saikat Maitra () escribió: > Hello Luis, > > Thank you for your email. You can plan to create a separate application for > jaxws service and use any build tools like gradle or maven to define your > dependencies. > > Please find below some of the performance tips related to Ignite > > https://apacheignite.readme.io/docs/durable-memory-tuning > > You can use IgniteClient in your service and can connect to remote cluster > of Apache Ignite for data persistence. > > Can you please correct my understanding on the usage of ignite-rest-http > in IGNITE-12518, I see the dependencies you have mentioned are related to > your project and my understanding is you are trying to use ignite-rest-http > jetty server for running your application. My understanding is this change > will make ignite-rest-http very large jar file with dependencies > like tomcat-servlet-api-9.0.10.jar may not needed outside of your project > scope. > > Please let me know your thoughts. > > Regards, > Saikat > > > On Sun, Jan 19, 2020 at 9:47 PM Luis Arce wrote: > > > Hi Saikat, > > I agree, the impact of changes is bigger on the module. > > I have a question: If i need create a jaxws service what is your > > recomendation? > > My motivation for the changes is the next: > > *Introduction.* > > A few time ago i design a ABB for traceability for Oracle Service Bus > with > > the objective of detecting failures points in many processes of a > customer. > > In first instance my team worked with rest-http module in ignite 2.4 with > > poor results, the quantity of TPS was 4.Then we make a implementation of > > Rest service inside Apache Tomcat and call to Apache Ignite directly to > > Database with persistence activated. This change, enabled the possibility > > for work with 4 environment of the customer (Development, Testing, QA, > > Production) with 8GB of RAM in the machine, the configuration of the > client > > had a Oracle Portal for the View layer, EJB for composition of the > > controller layer, and OSB for the integration the TPS of the client are > > biggest. > > > > *AS-IS* > > > > [image: imagen.png] > > > > *To Be roadmap* > > > > [image: imagen.png] > > > > With the ignite modification published in Jira is possible run JSF for > run > > my reports and forms, JaxWS for the service SOAP and Jersey for Rest (i > > start modification in this task). > > The code published in Jira have capabilites for work with Primefaces > > (tested ok), JaxWS (tested ok), but jersey is not included yet. > > > > Best regards, > > > > > > *Luis Arce Martínez*Licenciado e Ingeniero en Informática y Gestión > > 09-57861903 > > Linkedin: > > https://cl.linkedin.com/in/luisalejandroarcemartinez > > > > > > > > > > > > El jue., 16 ene. 2020 a las 0:25, Saikat Maitra (< > saikat.mai...@gmail.com>) > > escribió: > > > >> Hi Luis, > >> > >> Thank you for sharing the details on the changes. I reviewed the > >> dependencies that you shared in the jira issue and wanted to discuss on > >> the > >> changes. > >> > >> The purpose of ignite-rest-http is to provide a web based interface to > >> easily access and use the ignite features and the changes you suggested > >> can > >> be built as part of separate application and ignite-rest-http can be > used > >> as an add on dependency. This will help keep ignite-rest-http module as > >> minimal and thin as possible. > >> > >> Please review and share your thoughts. > >> > >> Regards, > >> Saikat >
Re: Please a reviewer for the case IGNITE-12518
Hi Saikat, I agree, the impact of changes is bigger on the module. I have a question: If i need create a jaxws service what is your recomendation? My motivation for the changes is the next: *Introduction.* A few time ago i design a ABB for traceability for Oracle Service Bus with the objective of detecting failures points in many processes of a customer. In first instance my team worked with rest-http module in ignite 2.4 with poor results, the quantity of TPS was 4.Then we make a implementation of Rest service inside Apache Tomcat and call to Apache Ignite directly to Database with persistence activated. This change, enabled the possibility for work with 4 environment of the customer (Development, Testing, QA, Production) with 8GB of RAM in the machine, the configuration of the client had a Oracle Portal for the View layer, EJB for composition of the controller layer, and OSB for the integration the TPS of the client are biggest. *AS-IS* [image: imagen.png] *To Be roadmap* [image: imagen.png] With the ignite modification published in Jira is possible run JSF for run my reports and forms, JaxWS for the service SOAP and Jersey for Rest (i start modification in this task). The code published in Jira have capabilites for work with Primefaces (tested ok), JaxWS (tested ok), but jersey is not included yet. Best regards, *Luis Arce Martínez*Licenciado e Ingeniero en Informática y Gestión 09-57861903 Linkedin: https://cl.linkedin.com/in/luisalejandroarcemartinez El jue., 16 ene. 2020 a las 0:25, Saikat Maitra () escribió: > Hi Luis, > > Thank you for sharing the details on the changes. I reviewed the > dependencies that you shared in the jira issue and wanted to discuss on the > changes. > > The purpose of ignite-rest-http is to provide a web based interface to > easily access and use the ignite features and the changes you suggested can > be built as part of separate application and ignite-rest-http can be used > as an add on dependency. This will help keep ignite-rest-http module as > minimal and thin as possible. > > Please review and share your thoughts. > > Regards, > Saikat > > > > > > > > > On Mon, Jan 13, 2020 at 7:24 PM Luis Arce wrote: > > > Hi Saikat, > > I add information for evidence for the changes of ignite rest-http > module. > > > > 1. Can you please share more information on the issue that will be > resolved > > with this change? > > R: This change add the possibility for publish war files with webpages > in > > JSF or webservices JaxWS inside of the jetty server embedded. > > When the WAR file is loade automatically attached the JNDI for lockup to > > Ignite DataBase to the context of the page. > > (I have a mvc4 application with ignite as a backend, with it change i > dont > > need a primary web server). > > > > [image: imagen.png] > > > > [image: imagen.png] > > > > My webpage > > [image: imagen.png] > > > > My mvc4 > > [image: imagen.png] > > > > The WebService > > > > [image: imagen.png] > > The WSDL > > [image: imagen.png] > > > > SoapUI > > [image: imagen.png] > > > > TestSuite SoapUI > > [image: imagen.png] > > > > > > > > > > *Luis Arce Martínez*Licenciado e Ingeniero en Informática y Gestión > > 09-57861903 > > Linkedin: > > https://cl.linkedin.com/in/luisalejandroarcemartinez > > > > > > > > > > > > El dom., 12 ene. 2020 a las 14:43, Saikat Maitra (< > saikat.mai...@gmail.com>) > > escribió: > > > >> Hi Luis, > >> > >> 1. Can you please share more information on the issue that will be > >> resolved > >> with this change? > >> 2. To accommodate the change, would you be able to raise a PR please. > >> Please take a look into the PR process > >> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute > >> 3. Can you please add tests and execute the related testsuite in > teamcity > >> https://ci.ignite.apache.org/ > >> > >> Regards, > >> Saikat > >> > >> On Fri, Jan 10, 2020 at 5:39 PM Luis Arce wrote: > >> > >> > Dear community, > >> > > >> > I made modifications to the module rest-http. > >> > It works correctly. > >> > Is possible if anybody take my case for the review? > >> > > >> > The modifications are: > >> > Support for webpages (test with jsf and primefaces), support for root > >> > context. > >> > Support to JaxWS with RI version. > >> > Support for access to Ignite database with JNDI and basic connection > >> > pooling' > >> > > >> > Se despide Atentamente, > >> > > >> > > >> > *Luis Arce Martínez*Licenciado e Ingeniero en Informática y Gestión > >> > 09-57861903 > >> > Linkedin: > >> > https://cl.linkedin.com/in/luisalejandroarcemartinez > >> > > >> > > >
Re: Please a reviewer for the case IGNITE-12518
Hi Saikat, I add information for evidence for the changes of ignite rest-http module. 1. Can you please share more information on the issue that will be resolved with this change? R: This change add the possibility for publish war files with webpages in JSF or webservices JaxWS inside of the jetty server embedded. When the WAR file is loade automatically attached the JNDI for lockup to Ignite DataBase to the context of the page. (I have a mvc4 application with ignite as a backend, with it change i dont need a primary web server). [image: imagen.png] [image: imagen.png] My webpage [image: imagen.png] My mvc4 [image: imagen.png] The WebService [image: imagen.png] The WSDL [image: imagen.png] SoapUI [image: imagen.png] TestSuite SoapUI [image: imagen.png] *Luis Arce Martínez*Licenciado e Ingeniero en Informática y Gestión 09-57861903 Linkedin: https://cl.linkedin.com/in/luisalejandroarcemartinez El dom., 12 ene. 2020 a las 14:43, Saikat Maitra () escribió: > Hi Luis, > > 1. Can you please share more information on the issue that will be resolved > with this change? > 2. To accommodate the change, would you be able to raise a PR please. > Please take a look into the PR process > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute > 3. Can you please add tests and execute the related testsuite in teamcity > https://ci.ignite.apache.org/ > > Regards, > Saikat > > On Fri, Jan 10, 2020 at 5:39 PM Luis Arce wrote: > > > Dear community, > > > > I made modifications to the module rest-http. > > It works correctly. > > Is possible if anybody take my case for the review? > > > > The modifications are: > > Support for webpages (test with jsf and primefaces), support for root > > context. > > Support to JaxWS with RI version. > > Support for access to Ignite database with JNDI and basic connection > > pooling' > > > > Se despide Atentamente, > > > > > > *Luis Arce Martínez*Licenciado e Ingeniero en Informática y Gestión > > 09-57861903 > > Linkedin: > > https://cl.linkedin.com/in/luisalejandroarcemartinez > > >
Please a reviewer for the case IGNITE-12518
Dear community, I made modifications to the module rest-http. It works correctly. Is possible if anybody take my case for the review? The modifications are: Support for webpages (test with jsf and primefaces), support for root context. Support to JaxWS with RI version. Support for access to Ignite database with JNDI and basic connection pooling' Se despide Atentamente, *Luis Arce Martínez*Licenciado e Ingeniero en Informática y Gestión 09-57861903 Linkedin: https://cl.linkedin.com/in/luisalejandroarcemartinez
[jira] [Created] (IGNITE-12518) rest-http module (Added JSF,jndi for jdbc/ignite), please validate and include in a ignite version if is possible
Luis Arce Martinez created IGNITE-12518:
---
Summary: rest-http module (Added JSF,jndi for jdbc/ignite), please
validate and include in a ignite version if is possible
Key: IGNITE-12518
URL: https://issues.apache.org/jira/browse/IGNITE-12518
Project: Ignite
Issue Type: Improvement
Components: rest
Affects Versions: 2.7.6
Environment: I test in Windows 10 pro x64, Acer Predator Helios 300,
16GB Ram.
Linux Fedora 27 (vpsserver.com), 8GB Ram.
Reporter: Luis Arce Martinez
Attachments: GridJettyRestHandler.java, GridJettyRestProtocol.java
Hi community,
I modified the Java Classes: GridJettyRestHandler and GridJettyRestProtocol
It's including support for JSF WebPages, auto load JNDI for JDBC/Ignite,
Tunning for Thread of Jetty Embedded & support for context root page (if exists
/ignite context is set for rest).
Please remove old libraries of Jetty. The list of depencies are the next:
commons-dbcp2-2.7.0.jar
commons-lang-2.6.jar
commons-pool2-2.8.0.jar el-ri-1.0.jar
*ignite-rest-http-2.7.6.jar must be Modified with the classes
GridJettyRestHandler and GridJettyRestProtocol)*
ignite-web-2.7.6.jar
jackson-annotations-2.9.6.jar
jackson-core-2.9.6.jar
jackson-databind-2.9.6.jar
javax.el-api-3.0.1-b06.jar
javax.servlet-api-4.0.1.jar
jboss-jsf-api_2.2_spec-2.2.14.jar
jetty-continuation-9.4.22.v20191022.jar
jetty-http-9.4.22.v20191022.jar
jetty-io-9.4.22.v20191022.jar
jetty-jndi-9.4.22.v20191022.jar
jetty-plus-9.4.22.v20191022.jar
jetty-security-9.4.22.v20191022.jar
jetty-server-9.4.22.v20191022.jar
jetty-servlet-9.4.22.v20191022.jar
jetty-util-9.4.22.v20191022.jar
jetty-webapp-9.4.22.v20191022.jar
jetty-xml-9.4.22.v20191022.jar
jsf-api-2.2.19.jar jsf-impl-2.2.19.jar
jsp-api-2.2.1-b03.jar log4j-1.2.17.jar
slf4j-api-1.7.7.jar slf4j-log4j12-1.7.7.jar
tomcat-servlet-api-9.0.10.jar
Inside of the web.xml in the webpage is need add the next lines:
Ignite DataSource Reference
jdbc/ignite
javax.sql.DataSource
Container
com.sun.faces.config.ConfigureListener
Call to Datasource from java: (DataSource)
initContext.lookup("java:comp/env/jdbc/ignite");
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
