Re: Converting TreeMap to BinaryObject causes ClassCastException (IGNITE-2852)

[NoTrueScotsman]

A new TreeMap<K, V> gets created when toBinary() is called, and keys
as well as values are converted to binary objects and added to it.
This fails with a CCE because binary objects are not comparable (so
the comparison logic for the keys is lost after conversion).

Not sure whether there are discussions going on in the background due
to the non-newbie nature of this, but my thought was that you force
the programmer to provide the logic how the binary versions of the
keys should be compared. Maybe by requiring the original keys to
implement a org.apache.ignite.binary.BinaryComparable interface
(basically Comparable)

Would that make any sense?





On Thu, Jul 21, 2016 at 9:28 PM, Dmitriy Setrakyan
<dsetrak...@apache.org> wrote:
> Well, in my view we should have that discussion or close this ticket. What
> are the challenges there? Is there a dev thread I can review?
>
> On Thu, Jul 21, 2016 at 5:41 AM, Denis Magda <dma...@gridgain.com> wrote:
>
>> Dmitriy,
>>
>> Presently even the guys who spent bunch the time developing and improving
>> binary marshaller don’t have a view on how to implement this feature. So
>> initially we should discuss how to implement it in general and after that
>> decide if the ticket can be taken over by new contributors.
>>
>> —
>> Denis
>>
>> > On Jul 21, 2016, at 1:18 PM, Dmitriy Setrakyan <dsetrak...@apache.org>
>> wrote:
>> >
>> > On Wed, Jul 20, 2016 at 2:45 PM, Denis Magda <dma...@gridgain.com>
>> wrote:
>> >
>> >> Hi Jens,
>> >>
>> >> This is not the best candidate for the first contribution and presently
>> I
>> >> don’t think that this feature should be supported at all.
>> >>
>> >
>> > Denis, why not?
>> >
>> >
>> >>
>> >> I would recommend you picking up one of the tickets with “newbie”
>> filter.
>> >> https://issues.apache.org/jira/issues/?filter=12338037 <
>> >> https://issues.apache.org/jira/issues/?filter=12338037>
>> >>
>> >> Regards,
>> >> Denis
>> >>
>> >>> On Jul 19, 2016, at 9:00 PM, NoTrueScotsman <
>> no.true.scots...@gmail.com>
>> >> wrote:
>> >>>
>> >>> It happens when applying ignite.binary().toBinary(m) to a TreeMap<K,
>> >>> V> with a custom key K.
>> >>>
>> >>> I thought this would be a nice task to pick as a first (attempt of a)
>> >>> contribution, however there is a ticket for this already assigned to
>> >>> someone: https://issues.apache.org/jira/browse/IGNITE-2852
>> >>>
>> >>> I haven't seen much activity on it though. Would it be possible for me
>> >>> to pick it?
>> >>>
>> >>> Thanks
>> >>> Jens
>> >>
>> >>
>>
>>

Re: Documentation for IGNITE-3399 (Support primitive type names in QueryEntity)

[NoTrueScotsman]

Hi Pavel, yes that's correct re "int". Thanks for the info.

Thanks
Jens

On Thu, Jul 28, 2016 at 1:29 PM, Pavel Tupitsyn <ptupit...@gridgain.com> wrote:
> Hi,
>
> Do I understand correctly that we can now replace
> 
> with
> 
> in QueryEntity.fields?
>
> There are Spring XML examples on apacheignite-net.readme.io, these can be
> fixed in 1.7.
>
> But not many people use Spring in .NET, so this change does not affect
> Ignite.NET much.
> When queries are configured in native C# code or app.config, we map .NET
> primitives to Java automatically.
>
> Pavel.
>
> On Thu, Jul 28, 2016 at 1:20 PM, NoTrueScotsman <no.true.scots...@gmail.com>
> wrote:
>
>> Hi all,
>>
>> I worked on this issue and wondered whether it is worth adding
>> something to the documentation. Candidates:
>> https://apacheignite.readme.io/docs/cache-queries
>> https://apacheignite.readme.io/docs/sql-queries
>>
>> The ticket description also mentioned improved usability for .NET and
>> C++ users, so maybe it's good to mention it too:
>> https://apacheignite-net.readme.io/docs/sql-queries
>>
>> I'm not familiar with .NET so not sure about what the improvements
>> would look like.
>>
>> What do you think?
>>
>> Thanks
>> Jens
>>

Documentation for IGNITE-3399 (Support primitive type names in QueryEntity)

[NoTrueScotsman]

Hi all,

I worked on this issue and wondered whether it is worth adding
something to the documentation. Candidates:
https://apacheignite.readme.io/docs/cache-queries
https://apacheignite.readme.io/docs/sql-queries

The ticket description also mentioned improved usability for .NET and
C++ users, so maybe it's good to mention it too:
https://apacheignite-net.readme.io/docs/sql-queries

I'm not familiar with .NET so not sure about what the improvements
would look like.

What do you think?

Thanks
Jens

Re: [GitHub] ignite pull request #895: IGNITE-3323 Use maven dependencies for Jetbrains a...

[NoTrueScotsman]

Hi Anton, devs,

it seems that a commit was missed in the merge for
https://issues.apache.org/jira/browse/IGNITE-3323
The current state of master might not be good. Please see my comments
on the ticket.

Thanks
Jens




On Tue, Jul 26, 2016 at 9:59 AM, NoTrueScotsman
<no.true.scots...@gmail.com> wrote:
> Ready for review:
> https://issues.apache.org/jira/browse/IGNITE-3323
>
> I ran a number of TC tests, almost all are passing apart from 3 that
> are failing, but the failures don't seem to be related to the change
> and also fail in other runs.
>
> Cheers,
> Jens
>
> On Tue, Jul 26, 2016 at 12:40 AM, jayho <g...@git.apache.org> wrote:
>> GitHub user jayho opened a pull request:
>>
>> https://github.com/apache/ignite/pull/895
>>
>> IGNITE-3323 Use maven dependencies for Jetbrains annotations
>>
>>
>>
>> You can merge this pull request into a Git repository by running:
>>
>> $ git pull https://github.com/jayho/ignite ignite-3323
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>> https://github.com/apache/ignite/pull/895.patch
>>
>> To close this pull request, make a commit to your master/trunk branch
>> with (at least) the following in the commit message:
>>
>> This closes #895
>>
>> 
>> commit 4fe63750a0130d2c8b854a82ec6547a75d37d14b
>> Author: Jens Hoffmann <jchoffm...@gmail.com>
>> Date:   2016-07-25T22:38:13Z
>>
>> IGNITE-3323 Use maven dependencies for Jetbrains annotations
>>
>> 
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working, please
>> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
>> with INFRA.
>> ---

Re: [GitHub] ignite pull request #895: IGNITE-3323 Use maven dependencies for Jetbrains a...

[NoTrueScotsman]

Ready for review:
https://issues.apache.org/jira/browse/IGNITE-3323

I ran a number of TC tests, almost all are passing apart from 3 that
are failing, but the failures don't seem to be related to the change
and also fail in other runs.

Cheers,
Jens

On Tue, Jul 26, 2016 at 12:40 AM, jayho  wrote:
> GitHub user jayho opened a pull request:
>
> https://github.com/apache/ignite/pull/895
>
> IGNITE-3323 Use maven dependencies for Jetbrains annotations
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/jayho/ignite ignite-3323
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/ignite/pull/895.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #895
>
> 
> commit 4fe63750a0130d2c8b854a82ec6547a75d37d14b
> Author: Jens Hoffmann 
> Date:   2016-07-25T22:38:13Z
>
> IGNITE-3323 Use maven dependencies for Jetbrains annotations
>
> 
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---

Re: New contributor: Support primitive type names in QueryEntity (IGNITE-3399)

[NoTrueScotsman]

Thanks Saikat.

I registered and had to find my way TC around a bit, but managed to
run the test suite. I'll add some clarification to the Wiki that will
hopefully help other newcomers.

Many thanks
Jens



On Sat, Jul 23, 2016 at 3:30 PM, Saikat Maitra <saikat.mai...@gmail.com> wrote:
> Hi
>
> You can register in TeamCity and run the TestSuite on your pull request.
> Once the tests passes you can submit the jira ticket as Submit Patch.
>
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-SubmittingForReview
>
> Regards
> Saikat
>
> On Thu, Jul 21, 2016 at 6:05 PM, NoTrueScotsman <no.true.scots...@gmail.com>
> wrote:
>
>> Thanks Semyon.
>>
>> I created a pull request a short while ago, however I am not quite
>> sure what I need to do in TeamCity. Do I need to register and run the
>> test suite that I changed, or can I move the ticket to ready for
>> review?
>>
>> Thanks
>> Jens
>>
>> On Thu, Jul 21, 2016 at 1:07 PM, Semyon Boikov <sboi...@gridgain.com>
>> wrote:
>> > Hi,
>> >
>> > I added you in the contributors list.
>> >
>> > On Thu, Jul 21, 2016 at 1:54 PM, NoTrueScotsman <
>> no.true.scots...@gmail.com>
>> > wrote:
>> >
>> >> Hi all,
>> >>
>> >> I'd like to attempt a fix for IGNITE-3399 (currently unclaimed in
>> >> Jira) as my newbie contribution.
>> >>
>> >> Could you add me to the list of Ignite contributors?
>> >> Jira username: thehoff
>> >>
>> >> Cheers
>> >> Jens
>> >>
>>

IGNITE-3399 ready for review

[NoTrueScotsman]

Thanks
Jens

Re: New contributor: Support primitive type names in QueryEntity (IGNITE-3399)

[NoTrueScotsman]

Thanks Semyon.

I created a pull request a short while ago, however I am not quite
sure what I need to do in TeamCity. Do I need to register and run the
test suite that I changed, or can I move the ticket to ready for
review?

Thanks
Jens

On Thu, Jul 21, 2016 at 1:07 PM, Semyon Boikov <sboi...@gridgain.com> wrote:
> Hi,
>
> I added you in the contributors list.
>
> On Thu, Jul 21, 2016 at 1:54 PM, NoTrueScotsman <no.true.scots...@gmail.com>
> wrote:
>
>> Hi all,
>>
>> I'd like to attempt a fix for IGNITE-3399 (currently unclaimed in
>> Jira) as my newbie contribution.
>>
>> Could you add me to the list of Ignite contributors?
>> Jira username: thehoff
>>
>> Cheers
>> Jens
>>

New contributor: Support primitive type names in QueryEntity (IGNITE-3399)

[NoTrueScotsman]

Hi all,

I'd like to attempt a fix for IGNITE-3399 (currently unclaimed in
Jira) as my newbie contribution.

Could you add me to the list of Ignite contributors?
Jira username: thehoff

Cheers
Jens

Re: Converting TreeMap to BinaryObject causes ClassCastException (IGNITE-2852)

[NoTrueScotsman]

Hi Denis,

thanks for clarifying. I'll take a look around Jira instead.

Thanks
Jens

On Wed, Jul 20, 2016 at 1:45 PM, Denis Magda <dma...@gridgain.com> wrote:
> Hi Jens,
>
> This is not the best candidate for the first contribution and presently I 
> don’t think that this feature should be supported at all.
>
> I would recommend you picking up one of the tickets with “newbie” filter.
> https://issues.apache.org/jira/issues/?filter=12338037 
> <https://issues.apache.org/jira/issues/?filter=12338037>
>
> Regards,
> Denis
>
>> On Jul 19, 2016, at 9:00 PM, NoTrueScotsman <no.true.scots...@gmail.com> 
>> wrote:
>>
>> It happens when applying ignite.binary().toBinary(m) to a TreeMap<K,
>> V> with a custom key K.
>>
>> I thought this would be a nice task to pick as a first (attempt of a)
>> contribution, however there is a ticket for this already assigned to
>> someone: https://issues.apache.org/jira/browse/IGNITE-2852
>>
>> I haven't seen much activity on it though. Would it be possible for me
>> to pick it?
>>
>> Thanks
>> Jens
>

Re: Compilation failure on fresh clone

[NoTrueScotsman]

Hi Andrey, thanks for this.

On Tue, Jul 5, 2016 at 1:21 PM, Andrey Novikov <anovi...@apache.org> wrote:
> Hi NoTrueScotsman,
>
> Compilation failed only under java 8. CI used java 7 for tests.
>
> Fixed compilation error in master.
>
> On Tue, Jul 5, 2016 at 3:52 PM, NoTrueScotsman <no.true.scots...@gmail.com>
> wrote:
>
>> Hi all, I just tried to compile a fresh clone off master branch[1] and
>> getting a compilation failure:
>>
>> $ mvn clean package -DskipTests
>> ...
>> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile
>> (default-testCompile) on project ignite-clients: Compilation failure
>> [ERROR]
>>
>> /Users/jhoffmann/Development/apache-ignite/modules/clients/src/test/java/org/apache/ignite/internal/client/integration/ClientAbstractSelfTest.java:[505,9]
>> reference to assertEquals is ambiguous
>> [ERROR] both method assertEquals(java.lang.Object,java.lang.Object) in
>> junit.framework.TestCase and method assertEquals(int,int) in
>> junit.framework.TestCase match
>>
>>
>> While fairly easy to fix locally, I'm wondering how can it get past CI?
>>
>> It was apparently fixed in a recent commit[2], but then undone again in the
>> subsequent commit[3].
>>
>> Am I doing something wrong or should I raise a bug for it?
>>
>> Cheers
>> Jens
>>
>> [1] https://github.com/apache/ignite
>> [2]
>>
>> https://github.com/apache/ignite/commit/c60fcafc2c73d6ca52a9e60677980ae97a1f8505
>> [3]
>>
>> https://github.com/apache/ignite/commit/40d863246dab99c34d215a47eb6598e285e1a7f7
>>

Compilation failure on fresh clone

[NoTrueScotsman]

Hi all, I just tried to compile a fresh clone off master branch[1] and
getting a compilation failure:

$ mvn clean package -DskipTests
...
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile
(default-testCompile) on project ignite-clients: Compilation failure
[ERROR]
/Users/jhoffmann/Development/apache-ignite/modules/clients/src/test/java/org/apache/ignite/internal/client/integration/ClientAbstractSelfTest.java:[505,9]
reference to assertEquals is ambiguous
[ERROR] both method assertEquals(java.lang.Object,java.lang.Object) in
junit.framework.TestCase and method assertEquals(int,int) in
junit.framework.TestCase match


While fairly easy to fix locally, I'm wondering how can it get past CI?

It was apparently fixed in a recent commit[2], but then undone again in the
subsequent commit[3].

Am I doing something wrong or should I raise a bug for it?

Cheers
Jens

[1] https://github.com/apache/ignite
[2]
https://github.com/apache/ignite/commit/c60fcafc2c73d6ca52a9e60677980ae97a1f8505
[3]
https://github.com/apache/ignite/commit/40d863246dab99c34d215a47eb6598e285e1a7f7