[GitHub] SomeFire commented on a change in pull request #15: Incremental build upload
SomeFire commented on a change in pull request #15: Incremental build upload
URL: https://github.com/apache/ignite-teamcity-bot/pull/15#discussion_r219076597
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
##
@@ -297,9 +303,25 @@ public void init(String serverId) {
//todo sinceBuild:(number:) // --todo -10 build numbers
+Integer sinceBuildNumber = null;
+if(persistedBuilds!=null) {
+List prevData = persistedBuilds.getData();
+if (prevData.size() > 10) {
+BuildRef buildRef = prevData.get(prevData.size() - 10);
+
+if (!Strings.isNullOrEmpty(buildRef.buildNumber)) {
+try {
+sinceBuildNumber =
Integer.valueOf(buildRef.buildNumber);
+} catch (NumberFormatException e) {
+logger.info("", e);
+}
+}
+}
+}
List dataFromRest;
try {
-dataFromRest = realLoad.apply(key);
+dataFromRest = realLoad.apply(key, sinceBuildNumber);
+
Review comment:
Redundant empty line.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #15: Incremental build upload
SomeFire commented on a change in pull request #15: Incremental build upload
URL: https://github.com/apache/ignite-teamcity-bot/pull/15#discussion_r219076843
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityHelper.java
##
@@ -566,18 +561,21 @@ public ChangesList getChangesList(String href) {
@Override public List getFinishedBuilds(String projectId,
String branch) {
-return getFinishedBuilds(projectId, branch, null);
+return getFinishedBuilds(projectId, branch, null, null);
}
/** {@inheritDoc} */
@Override
@AutoProfiling
public List getFinishedBuilds(String projectId,
-String branch, Long cnt) {
+String branch, Long cnt,
Review comment:
Move `cnt` to a new line.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #15: Incremental build upload
SomeFire commented on a change in pull request #15: Incremental build upload
URL: https://github.com/apache/ignite-teamcity-bot/pull/15#discussion_r219077963
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
##
@@ -297,9 +303,25 @@ public void init(String serverId) {
//todo sinceBuild:(number:) // --todo -10 build numbers
+Integer sinceBuildNumber = null;
Review comment:
Rename to `sinceBuildNum`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #15: Incremental build upload
SomeFire commented on a change in pull request #15: Incremental build upload
URL: https://github.com/apache/ignite-teamcity-bot/pull/15#discussion_r219074854
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityHelper.java
##
@@ -566,18 +561,21 @@ public ChangesList getChangesList(String href) {
@Override public List getFinishedBuilds(String projectId,
String branch) {
-return getFinishedBuilds(projectId, branch, null);
+return getFinishedBuilds(projectId, branch, null, null);
}
/** {@inheritDoc} */
@Override
@AutoProfiling
public List getFinishedBuilds(String projectId,
-String branch, Long cnt) {
+String branch, Long cnt,
+@Nullable Integer
sinceBuildNumber) {
List finished = getBuildHistory(projectId,
UrlUtil.escape(branch),
true,
-null, cnt);
+null,
+cnt,
Review comment:
Wrong indent.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #15: Incremental build upload
SomeFire commented on a change in pull request #15: Incremental build upload
URL: https://github.com/apache/ignite-teamcity-bot/pull/15#discussion_r219074162
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
##
@@ -297,9 +303,25 @@ public void init(String serverId) {
//todo sinceBuild:(number:) // --todo -10 build numbers
+Integer sinceBuildNumber = null;
+if(persistedBuilds!=null) {
Review comment:
need space after `if` and between arguments.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #15: Incremental build upload
SomeFire commented on a change in pull request #15: Incremental build upload
URL: https://github.com/apache/ignite-teamcity-bot/pull/15#discussion_r219076961
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/issue/IssueDetector.java
##
@@ -396,8 +396,7 @@ private void checkFailuresEx() {
false,
1,
backgroundOpsTcHelper,
-backgroundOpsCreds,
-executor);
+backgroundOpsCreds, executor);
Review comment:
Move `executor` to a new line.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
