Re: Compilation failure on fresh clone

[NoTrueScotsman]

Hi Andrey, thanks for this.

On Tue, Jul 5, 2016 at 1:21 PM, Andrey Novikov  wrote:
> Hi NoTrueScotsman,
>
> Compilation failed only under java 8. CI used java 7 for tests.
>
> Fixed compilation error in master.
>
> On Tue, Jul 5, 2016 at 3:52 PM, NoTrueScotsman 
> wrote:
>
>> Hi all, I just tried to compile a fresh clone off master branch[1] and
>> getting a compilation failure:
>>
>> $ mvn clean package -DskipTests
>> ...
>> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile
>> (default-testCompile) on project ignite-clients: Compilation failure
>> [ERROR]
>>
>> /Users/jhoffmann/Development/apache-ignite/modules/clients/src/test/java/org/apache/ignite/internal/client/integration/ClientAbstractSelfTest.java:[505,9]
>> reference to assertEquals is ambiguous
>> [ERROR] both method assertEquals(java.lang.Object,java.lang.Object) in
>> junit.framework.TestCase and method assertEquals(int,int) in
>> junit.framework.TestCase match
>>
>>
>> While fairly easy to fix locally, I'm wondering how can it get past CI?
>>
>> It was apparently fixed in a recent commit[2], but then undone again in the
>> subsequent commit[3].
>>
>> Am I doing something wrong or should I raise a bug for it?
>>
>> Cheers
>> Jens
>>
>> [1] https://github.com/apache/ignite
>> [2]
>>
>> https://github.com/apache/ignite/commit/c60fcafc2c73d6ca52a9e60677980ae97a1f8505
>> [3]
>>
>> https://github.com/apache/ignite/commit/40d863246dab99c34d215a47eb6598e285e1a7f7
>>

Re: Compilation failure on fresh clone

[Andrey Novikov]

Hi NoTrueScotsman,

Compilation failed only under java 8. CI used java 7 for tests.

Fixed compilation error in master.

On Tue, Jul 5, 2016 at 3:52 PM, NoTrueScotsman 
wrote:

> Hi all, I just tried to compile a fresh clone off master branch[1] and
> getting a compilation failure:
>
> $ mvn clean package -DskipTests
> ...
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile
> (default-testCompile) on project ignite-clients: Compilation failure
> [ERROR]
>
> /Users/jhoffmann/Development/apache-ignite/modules/clients/src/test/java/org/apache/ignite/internal/client/integration/ClientAbstractSelfTest.java:[505,9]
> reference to assertEquals is ambiguous
> [ERROR] both method assertEquals(java.lang.Object,java.lang.Object) in
> junit.framework.TestCase and method assertEquals(int,int) in
> junit.framework.TestCase match
>
>
> While fairly easy to fix locally, I'm wondering how can it get past CI?
>
> It was apparently fixed in a recent commit[2], but then undone again in the
> subsequent commit[3].
>
> Am I doing something wrong or should I raise a bug for it?
>
> Cheers
> Jens
>
> [1] https://github.com/apache/ignite
> [2]
>
> https://github.com/apache/ignite/commit/c60fcafc2c73d6ca52a9e60677980ae97a1f8505
> [3]
>
> https://github.com/apache/ignite/commit/40d863246dab99c34d215a47eb6598e285e1a7f7
>

Compilation failure on fresh clone

[NoTrueScotsman]

Hi all, I just tried to compile a fresh clone off master branch[1] and
getting a compilation failure:

$ mvn clean package -DskipTests
...
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile
(default-testCompile) on project ignite-clients: Compilation failure
[ERROR]
/Users/jhoffmann/Development/apache-ignite/modules/clients/src/test/java/org/apache/ignite/internal/client/integration/ClientAbstractSelfTest.java:[505,9]
reference to assertEquals is ambiguous
[ERROR] both method assertEquals(java.lang.Object,java.lang.Object) in
junit.framework.TestCase and method assertEquals(int,int) in
junit.framework.TestCase match


While fairly easy to fix locally, I'm wondering how can it get past CI?

It was apparently fixed in a recent commit[2], but then undone again in the
subsequent commit[3].

Am I doing something wrong or should I raise a bug for it?

Cheers
Jens

[1] https://github.com/apache/ignite
[2]
https://github.com/apache/ignite/commit/c60fcafc2c73d6ca52a9e60677980ae97a1f8505
[3]
https://github.com/apache/ignite/commit/40d863246dab99c34d215a47eb6598e285e1a7f7