IGNITE-1025 is ready for review (Need to print out warning if IP finder has a lot of addresses on Windows)
Hi, Igniters! I've prepared PR [1] for the issue IGNITE-1025 "Need to print out warning if IP finder has a lot of addresses on Windows" [2] . TeamCity tests look good [3]. Could someone review it? Thanks in advance! [1]https://github.com/apache/ignite/pull/2966 [2]https://issues.apache.org/jira/browse/IGNITE-1025 [3] https://ci.ignite.apache.org/project.html?projectId=Ignite20Tests=8753246349372607337=testDetails_Ignite20Tests=pull%2F2966%2Fhead -- Ivan Fedotov. ivanan...@gmail.com
IGNITE-1025 is ready for review (Need to print out warning if IP finder has a lot of addresses on Windows)
Hi, Igniters! I've prepared PR [1] for the issue IGNITE-1025 "Need to print out warning if IP finder has a lot of addresses on Windows" [2] . TeamCity tests look good [3]. Could someone review it? Thanks in advance! [1]https://github.com/apache/ignite/pull/2966 [2]https://issues.apache.org/jira/browse/IGNITE-1025 [3]https://ci.ignite.apache.org/project.html?projectId= Ignite20Tests=8753246349372607337=testDetails_ Ignite20Tests=pull%2F2966%2Fhead -- Ivan Fedotov. ivanan...@gmail.com
[GitHub] ignite pull request #2966: IGNITE-1025
GitHub user 1vanan opened a pull request: https://github.com/apache/ignite/pull/2966 IGNITE-1025 You can merge this pull request into a Git repository by running: $ git pull https://github.com/1vanan/ignite ignite-1025 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/2966.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2966 commit 5a44af1199a654f4737438193a5c8d061a6ef5e4 Author: ivanan <vane...@gmail.com> Date: 2017-10-05T07:10:44Z wrong ip addresses worning was added in TCPDiscoveryVmIpFinder commit de407e2a16f22536186f7b3e4de8adbb03308a04 Author: ivanan <vane...@gmail.com> Date: 2017-10-05T21:41:10Z change some var names commit 99b6ca29bfc953904148004518cdc7baf14c844e Author: ivanan <vane...@gmail.com> Date: 2017-10-09T21:36:48Z remarks were taken into account commit a55dcc1c329459a612aaf60e2877367c867caa66 Author: ivanan <vane...@gmail.com> Date: 2017-10-10T21:42:39Z fix changes 11.10.17 commit adaf649409db53cc025de7bd8d484886847f784a Author: ivanan <vane...@gmail.com> Date: 2017-10-18T22:56:49Z added TcpDiscoveryVmIpFinderSetAddressesWarningTest commit 17465c952f96e11584147a6828d082c867f7838b Author: Ivan <vane...@gmail.com> Date: 2017-10-24T14:32:43Z isUnresolved instead of TcpTimeout commit d7be15ecc8fbce57996e234573129d00912e66a2 Author: Ivan <vane...@gmail.com> Date: 2017-10-24T14:38:29Z test with single and multiports commit 458377e35bb9f10b5a02f77645e61f98f5e749dd Author: Ivan <vane...@gmail.com> Date: 2017-10-27T14:01:54Z 27.10.17 commit 020ca8ca9f07636bc3288f6018a3d1a94c025839 Author: Ivan <vane...@gmail.com> Date: 2017-10-31T13:52:46Z isLoggingOfWrongAddressFirst method was added, minor changes in TcpDiscoveryVmIpFinderSetAddressesWarningTest commit 8f3faed2db05fbc75a958ca99c8d2befe688718c Author: Ivan <vane...@gmail.com> Date: 2017-10-31T15:58:54Z fix some comments in TcpDiscoveryVmIpFinderSetAddressesWarningTest commit b8f3effa0bff5fd6e696d5c22abb64cea17f76a3 Author: Ivan <vane...@gmail.com> Date: 2017-11-01T12:06:49Z delete obvious comment commit cb4519dc37ec0b96b6bcde7e6a3ceba875fde374 Author: Ivan <vane...@gmail.com> Date: 2017-11-01T13:50:18Z fix style remarks commit fb6a02fcd58619ffedbd67cc3ec609db9f34d447 Author: Ivan <vane...@gmail.com> Date: 2017-11-01T14:56:26Z rename logIfInvalidAddressAppearedFirst to logFirstInvalidAddress ---
Re: IGNITE-1025
Anton, Thanks, I'll start it. 2017-09-19 14:54 GMT+03:00 Anton Vinogradov <avinogra...@gridgain.com>: > Ivan, > > Issue is still actual. > > On Tue, Sep 19, 2017 at 2:10 PM, Иван Федотов <ivanan...@gmail.com> wrote: > > > Hi, Igniters! > > I've picked up task https://issues.apache.org/jira/browse/IGNITE-1025 > > "Need > > to print out warning if IP finder has a lot of addresses on Windows", but > > this task was created in June 2015. Is this task still relevant? > > Thanks in advance. > > > > -- > > Ivan Fedotov. > > > > ivanan...@gmail.com > > > -- Ivan Fedotov. ivanan...@gmail.com
Re: IGNITE-1025
Ivan, Issue is still actual. On Tue, Sep 19, 2017 at 2:10 PM, Иван Федотов <ivanan...@gmail.com> wrote: > Hi, Igniters! > I've picked up task https://issues.apache.org/jira/browse/IGNITE-1025 > "Need > to print out warning if IP finder has a lot of addresses on Windows", but > this task was created in June 2015. Is this task still relevant? > Thanks in advance. > > -- > Ivan Fedotov. > > ivanan...@gmail.com >
IGNITE-1025
Hi, Igniters! I've picked up task https://issues.apache.org/jira/browse/IGNITE-1025 "Need to print out warning if IP finder has a lot of addresses on Windows", but this task was created in June 2015. Is this task still relevant? Thanks in advance. -- Ivan Fedotov. ivanan...@gmail.com
