Re: IGNITE-12356 Migrate Flink module to ignite-extensions
Hi, Saikat! The suite is green now. Thanks! ср, 1 янв. 2020 г. в 00:08, Saikat Maitra : > Hi Sergey, > > I have updated the streamers testsuite. > > > https://ci.ignite.apache.org/viewLog.html?buildId=4897409=IgniteTests24Java8_Streamers > > Regards, > Saikat > > On Tue, Dec 31, 2019 at 2:43 PM Saikat Maitra > wrote: > > > Hello Sergey, > > > > Thank you for your email. Yes, I will update the streamers testsuite. > > > > I had removed flink module from the ignite main repo and I will need to > > update the streamers testsuite to accommodate the change. > > > > Regards, > > Saikat > > > > On Tue, Dec 31, 2019 at 10:39 AM Sergey Antonov < > antonovserge...@gmail.com> > > wrote: > > > >> Hello, Saikat, Ilya. > >> > >> After merge IGNITE-12365 streamers suite is broken in master [1]. Can > your > >> fix it? > >> > >> [1] > >> > >> > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Streamers_IgniteTests24Java8=%3Cdefault%3E=buildTypeStatusDiv > >> > >> вт, 31 дек. 2019 г. в 18:18, Saikat Maitra : > >> > >> > Hello Ilya, > >> > > >> > Thank you, much appreciate it. > >> > > >> > Regards, > >> > Saikat > >> > > >> > On Tue, 31 Dec 2019 at 3:44 AM, Ilya Kasnacheev < > >> ilya.kasnach...@gmail.com > >> > > > >> > wrote: > >> > > >> > > Hello! > >> > > > >> > > Done! > >> > > > >> > > Regards, > >> > > -- > >> > > Ilya Kasnacheev > >> > > > >> > > > >> > > вт, 31 дек. 2019 г. в 00:16, Saikat Maitra >: > >> > > > >> > > > Hi, > >> > > > > >> > > > I have raised a PR for removal of flink module from ignite main > >> repo. I > >> > > > have already moved flink module in ignite-extensions repo ( > >> > > > https://github.com/apache/ignite-extensions). > >> > > > > >> > > > PR https://github.com/apache/ignite/pull/7222 > >> > > > > >> > > > jira : IGNITE-12356 Migrate Flink module to ignite-extensions > >> > > > > >> > > > https://issues.apache.org/jira/browse/IGNITE-12356 > >> > > > > >> > > > Please review and share feedback. > >> > > > > >> > > > Regards, > >> > > > Saikat > >> > > > > >> > > > >> > > >> > >> > >> -- > >> BR, Sergey Antonov > >> > > > -- BR, Sergey Antonov
Re: IGNITE-12356 Migrate Flink module to ignite-extensions
Hi Sergey, I have updated the streamers testsuite. https://ci.ignite.apache.org/viewLog.html?buildId=4897409=IgniteTests24Java8_Streamers Regards, Saikat On Tue, Dec 31, 2019 at 2:43 PM Saikat Maitra wrote: > Hello Sergey, > > Thank you for your email. Yes, I will update the streamers testsuite. > > I had removed flink module from the ignite main repo and I will need to > update the streamers testsuite to accommodate the change. > > Regards, > Saikat > > On Tue, Dec 31, 2019 at 10:39 AM Sergey Antonov > wrote: > >> Hello, Saikat, Ilya. >> >> After merge IGNITE-12365 streamers suite is broken in master [1]. Can your >> fix it? >> >> [1] >> >> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Streamers_IgniteTests24Java8=%3Cdefault%3E=buildTypeStatusDiv >> >> вт, 31 дек. 2019 г. в 18:18, Saikat Maitra : >> >> > Hello Ilya, >> > >> > Thank you, much appreciate it. >> > >> > Regards, >> > Saikat >> > >> > On Tue, 31 Dec 2019 at 3:44 AM, Ilya Kasnacheev < >> ilya.kasnach...@gmail.com >> > > >> > wrote: >> > >> > > Hello! >> > > >> > > Done! >> > > >> > > Regards, >> > > -- >> > > Ilya Kasnacheev >> > > >> > > >> > > вт, 31 дек. 2019 г. в 00:16, Saikat Maitra : >> > > >> > > > Hi, >> > > > >> > > > I have raised a PR for removal of flink module from ignite main >> repo. I >> > > > have already moved flink module in ignite-extensions repo ( >> > > > https://github.com/apache/ignite-extensions). >> > > > >> > > > PR https://github.com/apache/ignite/pull/7222 >> > > > >> > > > jira : IGNITE-12356 Migrate Flink module to ignite-extensions >> > > > >> > > > https://issues.apache.org/jira/browse/IGNITE-12356 >> > > > >> > > > Please review and share feedback. >> > > > >> > > > Regards, >> > > > Saikat >> > > > >> > > >> > >> >> >> -- >> BR, Sergey Antonov >> >
Re: IGNITE-12356 Migrate Flink module to ignite-extensions
Hello Sergey, Thank you for your email. Yes, I will update the streamers testsuite. I had removed flink module from the ignite main repo and I will need to update the streamers testsuite to accommodate the change. Regards, Saikat On Tue, Dec 31, 2019 at 10:39 AM Sergey Antonov wrote: > Hello, Saikat, Ilya. > > After merge IGNITE-12365 streamers suite is broken in master [1]. Can your > fix it? > > [1] > > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Streamers_IgniteTests24Java8=%3Cdefault%3E=buildTypeStatusDiv > > вт, 31 дек. 2019 г. в 18:18, Saikat Maitra : > > > Hello Ilya, > > > > Thank you, much appreciate it. > > > > Regards, > > Saikat > > > > On Tue, 31 Dec 2019 at 3:44 AM, Ilya Kasnacheev < > ilya.kasnach...@gmail.com > > > > > wrote: > > > > > Hello! > > > > > > Done! > > > > > > Regards, > > > -- > > > Ilya Kasnacheev > > > > > > > > > вт, 31 дек. 2019 г. в 00:16, Saikat Maitra : > > > > > > > Hi, > > > > > > > > I have raised a PR for removal of flink module from ignite main > repo. I > > > > have already moved flink module in ignite-extensions repo ( > > > > https://github.com/apache/ignite-extensions). > > > > > > > > PR https://github.com/apache/ignite/pull/7222 > > > > > > > > jira : IGNITE-12356 Migrate Flink module to ignite-extensions > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-12356 > > > > > > > > Please review and share feedback. > > > > > > > > Regards, > > > > Saikat > > > > > > > > > > > > -- > BR, Sergey Antonov >
Re: IGNITE-12356 Migrate Flink module to ignite-extensions
Hello, Saikat, Ilya. After merge IGNITE-12365 streamers suite is broken in master [1]. Can your fix it? [1] https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Streamers_IgniteTests24Java8=%3Cdefault%3E=buildTypeStatusDiv вт, 31 дек. 2019 г. в 18:18, Saikat Maitra : > Hello Ilya, > > Thank you, much appreciate it. > > Regards, > Saikat > > On Tue, 31 Dec 2019 at 3:44 AM, Ilya Kasnacheev > > wrote: > > > Hello! > > > > Done! > > > > Regards, > > -- > > Ilya Kasnacheev > > > > > > вт, 31 дек. 2019 г. в 00:16, Saikat Maitra : > > > > > Hi, > > > > > > I have raised a PR for removal of flink module from ignite main repo. I > > > have already moved flink module in ignite-extensions repo ( > > > https://github.com/apache/ignite-extensions). > > > > > > PR https://github.com/apache/ignite/pull/7222 > > > > > > jira : IGNITE-12356 Migrate Flink module to ignite-extensions > > > > > > https://issues.apache.org/jira/browse/IGNITE-12356 > > > > > > Please review and share feedback. > > > > > > Regards, > > > Saikat > > > > > > -- BR, Sergey Antonov
Re: IGNITE-12356 Migrate Flink module to ignite-extensions
Hello Ilya, Thank you, much appreciate it. Regards, Saikat On Tue, 31 Dec 2019 at 3:44 AM, Ilya Kasnacheev wrote: > Hello! > > Done! > > Regards, > -- > Ilya Kasnacheev > > > вт, 31 дек. 2019 г. в 00:16, Saikat Maitra : > > > Hi, > > > > I have raised a PR for removal of flink module from ignite main repo. I > > have already moved flink module in ignite-extensions repo ( > > https://github.com/apache/ignite-extensions). > > > > PR https://github.com/apache/ignite/pull/7222 > > > > jira : IGNITE-12356 Migrate Flink module to ignite-extensions > > > > https://issues.apache.org/jira/browse/IGNITE-12356 > > > > Please review and share feedback. > > > > Regards, > > Saikat > > >
Re: IGNITE-12356 Migrate Flink module to ignite-extensions
Hello! Done! Regards, -- Ilya Kasnacheev вт, 31 дек. 2019 г. в 00:16, Saikat Maitra : > Hi, > > I have raised a PR for removal of flink module from ignite main repo. I > have already moved flink module in ignite-extensions repo ( > https://github.com/apache/ignite-extensions). > > PR https://github.com/apache/ignite/pull/7222 > > jira : IGNITE-12356 Migrate Flink module to ignite-extensions > > https://issues.apache.org/jira/browse/IGNITE-12356 > > Please review and share feedback. > > Regards, > Saikat >
IGNITE-12356 Migrate Flink module to ignite-extensions
Hi, I have raised a PR for removal of flink module from ignite main repo. I have already moved flink module in ignite-extensions repo ( https://github.com/apache/ignite-extensions). PR https://github.com/apache/ignite/pull/7222 jira : IGNITE-12356 Migrate Flink module to ignite-extensions https://issues.apache.org/jira/browse/IGNITE-12356 Please review and share feedback. Regards, Saikat
Re: IGNITE-12356 Migrate Flink module to ignite-extensions
Hello, The latest build in teamcity has passed https://ci.ignite.apache.org/viewLog.html?buildId=4788928=IgniteExtensions_Build=buildResultsDiv_IgniteExtensions=pull%2F1%2Fhead Regards, Saikat On Sun, Nov 24, 2019 at 10:42 AM Saikat Maitra wrote: > Hello Denis, > > I have fixed the test suites and now working on fixing the teamcity build. > > I have created a new project in teamcity and setting up the build. > > > https://ci.ignite.apache.org/project.html?projectId=IgniteExtensions=projectOverview > > Regards > Saikat > > On Fri, Nov 15, 2019 at 6:59 PM Saikat Maitra > wrote: > >> Hi Denis, >> >> I am working on fixing the tests, an issue I am facing locally is since >> GridTestProperties is unable to find the test.properties file in local >> ignite-extensions repo, the tests are failing. I do have core module as a >> dependency for the project which has this test.properties file in config >> folder. I am debugging it further. >> >> I have not yet integrated with TeamCity or moved the release scripts. >> >> I will take them up as well in this PR. >> >> Regards, >> Saikat >> >> On Fri, Nov 15, 2019 at 3:52 PM Denis Magda wrote: >> >>> Hi Saikat, >>> >>> As I guess the implementation stayed the same and we can skip a review of >>> the source code. Were you able to integrate this into the TeamCity and >>> with >>> the release scripts? >>> >>> - >>> Denis >>> >>> >>> On Sun, Nov 10, 2019 at 2:55 PM Saikat Maitra >>> wrote: >>> >>> > Hi >>> > >>> > I have raised a PR to migrate Flink module to ignite-extensions. >>> > >>> > PR https://github.com/apache/ignite-extensions/pull/1 >>> > >>> > Jira : https://issues.apache.org/jira/browse/IGNITE-12356 >>> > >>> > Please review and share feedback. >>> > >>> > I am observing error with initialization of GridAbstractTest as >>> > GridTestProperties is unable to access " >>> > modules/core/src/test/config/test.properties" >>> > >>> > I am looking into it further. >>> > >>> > Regards, >>> > Saikat >>> > >>> >>
Re: IGNITE-12356 Migrate Flink module to ignite-extensions
Hello Denis, I have fixed the test suites and now working on fixing the teamcity build. I have created a new project in teamcity and setting up the build. https://ci.ignite.apache.org/project.html?projectId=IgniteExtensions=projectOverview Regards Saikat On Fri, Nov 15, 2019 at 6:59 PM Saikat Maitra wrote: > Hi Denis, > > I am working on fixing the tests, an issue I am facing locally is since > GridTestProperties is unable to find the test.properties file in local > ignite-extensions repo, the tests are failing. I do have core module as a > dependency for the project which has this test.properties file in config > folder. I am debugging it further. > > I have not yet integrated with TeamCity or moved the release scripts. > > I will take them up as well in this PR. > > Regards, > Saikat > > On Fri, Nov 15, 2019 at 3:52 PM Denis Magda wrote: > >> Hi Saikat, >> >> As I guess the implementation stayed the same and we can skip a review of >> the source code. Were you able to integrate this into the TeamCity and >> with >> the release scripts? >> >> - >> Denis >> >> >> On Sun, Nov 10, 2019 at 2:55 PM Saikat Maitra >> wrote: >> >> > Hi >> > >> > I have raised a PR to migrate Flink module to ignite-extensions. >> > >> > PR https://github.com/apache/ignite-extensions/pull/1 >> > >> > Jira : https://issues.apache.org/jira/browse/IGNITE-12356 >> > >> > Please review and share feedback. >> > >> > I am observing error with initialization of GridAbstractTest as >> > GridTestProperties is unable to access " >> > modules/core/src/test/config/test.properties" >> > >> > I am looking into it further. >> > >> > Regards, >> > Saikat >> > >> >
Re: IGNITE-12356 Migrate Flink module to ignite-extensions
Hi Denis, I am working on fixing the tests, an issue I am facing locally is since GridTestProperties is unable to find the test.properties file in local ignite-extensions repo, the tests are failing. I do have core module as a dependency for the project which has this test.properties file in config folder. I am debugging it further. I have not yet integrated with TeamCity or moved the release scripts. I will take them up as well in this PR. Regards, Saikat On Fri, Nov 15, 2019 at 3:52 PM Denis Magda wrote: > Hi Saikat, > > As I guess the implementation stayed the same and we can skip a review of > the source code. Were you able to integrate this into the TeamCity and with > the release scripts? > > - > Denis > > > On Sun, Nov 10, 2019 at 2:55 PM Saikat Maitra > wrote: > > > Hi > > > > I have raised a PR to migrate Flink module to ignite-extensions. > > > > PR https://github.com/apache/ignite-extensions/pull/1 > > > > Jira : https://issues.apache.org/jira/browse/IGNITE-12356 > > > > Please review and share feedback. > > > > I am observing error with initialization of GridAbstractTest as > > GridTestProperties is unable to access " > > modules/core/src/test/config/test.properties" > > > > I am looking into it further. > > > > Regards, > > Saikat > > >
Re: IGNITE-12356 Migrate Flink module to ignite-extensions
Hi Saikat, As I guess the implementation stayed the same and we can skip a review of the source code. Were you able to integrate this into the TeamCity and with the release scripts? - Denis On Sun, Nov 10, 2019 at 2:55 PM Saikat Maitra wrote: > Hi > > I have raised a PR to migrate Flink module to ignite-extensions. > > PR https://github.com/apache/ignite-extensions/pull/1 > > Jira : https://issues.apache.org/jira/browse/IGNITE-12356 > > Please review and share feedback. > > I am observing error with initialization of GridAbstractTest as > GridTestProperties is unable to access " > modules/core/src/test/config/test.properties" > > I am looking into it further. > > Regards, > Saikat >
IGNITE-12356 Migrate Flink module to ignite-extensions
Hi I have raised a PR to migrate Flink module to ignite-extensions. PR https://github.com/apache/ignite-extensions/pull/1 Jira : https://issues.apache.org/jira/browse/IGNITE-12356 Please review and share feedback. I am observing error with initialization of GridAbstractTest as GridTestProperties is unable to access " modules/core/src/test/config/test.properties" I am looking into it further. Regards, Saikat
[jira] [Created] (IGNITE-12356) Migrate flink module to ignite-extensions
Saikat Maitra created IGNITE-12356: -- Summary: Migrate flink module to ignite-extensions Key: IGNITE-12356 URL: https://issues.apache.org/jira/browse/IGNITE-12356 Project: Ignite Issue Type: Improvement Components: streaming Reporter: Saikat Maitra Migrate flink module to ignite-extensions -- This message was sent by Atlassian Jira (v8.3.4#803005)
