Re: IGNITE-12359 Migrate RocketMQ module to ignite-extensions
Hi Ilya, Thank you for reviewing the changes. I have updated the PR and merged the changes. Regards, Saikat On Tue, May 26, 2020 at 10:07 AM Ilya Kasnacheev wrote: > Hello! > > We still have a mention of it in assembly/libs/README.txt - I think we > should remove it alongside with some others. I'm not sure where this file > goes to. > > Otherwise, LGTM. > > Regards, > -- > Ilya Kasnacheev > > > пн, 25 мая 2020 г. в 20:13, Saikat Maitra : > > > Hi Ilya, > > > > Thank you for reviewing the changes. > > > > I have updated the PR. > > > > Please review and share your feedback. > > > > Regards, > > Saikat > > > > On Sat, May 16, 2020 at 7:30 PM Saikat Maitra > > wrote: > > > > > Hi, > > > > > > I have raised PRs for the following issue: > > > > > > IGNITE-12359 Migrate RocketMQ module to ignite-extensions > > > > > > https://issues.apache.org/jira/browse/IGNITE-12359 > > > > > > PR > > > https://github.com/apache/ignite-extensions/pull/14 > > > https://github.com/apache/ignite/pull/7809 > > > > > > Please take a look and share feedback. > > > > > > Regards, > > > Saikat > > > > > >
Re: IGNITE-12359 Migrate RocketMQ module to ignite-extensions
Hello! We still have a mention of it in assembly/libs/README.txt - I think we should remove it alongside with some others. I'm not sure where this file goes to. Otherwise, LGTM. Regards, -- Ilya Kasnacheev пн, 25 мая 2020 г. в 20:13, Saikat Maitra : > Hi Ilya, > > Thank you for reviewing the changes. > > I have updated the PR. > > Please review and share your feedback. > > Regards, > Saikat > > On Sat, May 16, 2020 at 7:30 PM Saikat Maitra > wrote: > > > Hi, > > > > I have raised PRs for the following issue: > > > > IGNITE-12359 Migrate RocketMQ module to ignite-extensions > > > > https://issues.apache.org/jira/browse/IGNITE-12359 > > > > PR > > https://github.com/apache/ignite-extensions/pull/14 > > https://github.com/apache/ignite/pull/7809 > > > > Please take a look and share feedback. > > > > Regards, > > Saikat > > >
Re: IGNITE-12359 Migrate RocketMQ module to ignite-extensions
Hi Ilya, Thank you for reviewing the changes. I have updated the PR. Please review and share your feedback. Regards, Saikat On Sat, May 16, 2020 at 7:30 PM Saikat Maitra wrote: > Hi, > > I have raised PRs for the following issue: > > IGNITE-12359 Migrate RocketMQ module to ignite-extensions > > https://issues.apache.org/jira/browse/IGNITE-12359 > > PR > https://github.com/apache/ignite-extensions/pull/14 > https://github.com/apache/ignite/pull/7809 > > Please take a look and share feedback. > > Regards, > Saikat >
IGNITE-12359 Migrate RocketMQ module to ignite-extensions
Hi, I have raised PRs for the following issue: IGNITE-12359 Migrate RocketMQ module to ignite-extensions https://issues.apache.org/jira/browse/IGNITE-12359 PR https://github.com/apache/ignite-extensions/pull/14 https://github.com/apache/ignite/pull/7809 Please take a look and share feedback. Regards, Saikat
[jira] [Created] (IGNITE-12359) Migrate RocketMQ module to ignite-extensions
Saikat Maitra created IGNITE-12359: -- Summary: Migrate RocketMQ module to ignite-extensions Key: IGNITE-12359 URL: https://issues.apache.org/jira/browse/IGNITE-12359 Project: Ignite Issue Type: Sub-task Components: streaming Affects Versions: 2.8 Reporter: Saikat Maitra Migrate RocketMQ module to ignite-extensions [https://github.com/apache/ignite-extensions] Details: [https://cwiki.apache.org/confluence/display/IGNITE/IEP-36%3A+Modularization#IEP-36:Modularization-IndependentIntegrations] Discussion : [http://apache-ignite-developers.2346864.n4.nabble.com/DISCUSS-Proposal-for-Ignite-Extensions-as-a-separate-Bahir-module-or-Incubator-project-td44064.html#a44107] -- This message was sent by Atlassian Jira (v8.3.4#803005)
