Re: IGNITE-3337

2016-06-29 Thread Saikat Maitra
Thank you Andrey!!

Saikat

On Wed, Jun 29, 2016 at 4:49 PM, Andrey Novikov <anovi...@apache.org> wrote:

> Hi Saikat!
>
> I’ve just reviewed and merged your pull request.
>
> Thank you for your contribution!
>
> —
> Andrey
>
> On Wed, Jun 29, 2016 at 3:25 AM, Saikat Maitra <saikat.mai...@gmail.com>
> wrote:
>
> > Hello Andrey,
> >
> > I have updated the PR. Please review and share feedback.
> >
> > https://github.com/apache/ignite/pull/816
> >
> > Regards
> > Saikat
> >
> > On Thu, Jun 23, 2016 at 8:41 PM, Saikat Maitra <saikat.mai...@gmail.com>
> > wrote:
> >
> > > Thank you Andrey
> > >
> > > I will update the PR accordingly.
> > >
> > > Regards
> > > Saikat
> > >
> > > On Thu, Jun 23, 2016 at 12:33 PM, Andrey Novikov <anovi...@apache.org>
> > > wrote:
> > >
> > >> Saint,
> > >>
> > >> I've reviewed your PR and left comments in the ticket.
> > >>
> > >>
> > >> On Tue, Jun 21, 2016 at 1:14 AM, Saikat Maitra <
> saikat.mai...@gmail.com
> > >
> > >> wrote:
> > >>
> > >> > Hi Alexey , Sergey
> > >> >
> > >> > Thank you for your time and reviewing the PR. I agree we can
> deprecate
> > >> > cacheName for metadata command. I have updated the files and request
> > >> you to
> > >> > review the changes.
> > >> >
> > >> > Also can you please share where the docs are hosted and I can then
> > >> update
> > >> > the rest api doc.
> > >> >
> > >> > Regards
> > >> > Saikat
> > >> >
> > >> > On Mon, Jun 20, 2016 at 3:08 PM, Sergey Kozlov <
> skoz...@gridgain.com>
> > >> > wrote:
> > >> >
> > >> > > Hi Saikat and Alexey.
> > >> > >
> > >> > > I think that the solution suggested by Alexey is simple one.
> > Actually
> > >> > > null-named cache is widely used for now and we can't remove it (or
> > at
> > >> > least
> > >> > > we should re-think the approach for such caches). On the other
> hand
> > >> the
> > >> > > size of metadata returned by REST command even for dozen caches is
> > not
> > >> > > large and can be filtered (iterated) on the client side. So I
> > suppose
> > >> the
> > >> > > ticket should be updated according suggested approach.
> > >> > >
> > >> > >
> > >> > >
> > >> > >
> > >> > > On Mon, Jun 20, 2016 at 12:28 PM, Alexey Kuznetsov <
> > >> > > akuznet...@gridgain.com>
> > >> > > wrote:
> > >> > >
> > >> > > > Hi, Saikat
> > >> > > >
> > >> > > > I reviewed you PR and I think we should deprecate "cacheName"
> > >> > parameter
> > >> > > > in metadata command.
> > >> > > >
> > >> > > > In current implementation when "cacheName" was not specified
> that
> > >> means
> > >> > > to
> > >> > > > get "default" cache (with name=null)
> > >> > > > And now it will be impossible to take metadata for such cache.
> > >> > > >
> > >> > > > But I think for this command there is a little sense to extract
> > >> > metadata
> > >> > > > for single cache,
> > >> > > >  because any way on server side they will be extracted for all
> > >> caches.
> > >> > > > See:
> > >> > > >
> > >> > >
> > >> >
> > >>
> >
> org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager#sqlMetadata
> > >> > > > line 999.
> > >> > > >
> > >> > > > Also for performance reason it is much faster to get all
> metadata
> > at
> > >> > > once.
> > >> > > >
> > >> > > > So, I suggest - to deprecate "cacheName" parameter and fix
> > >> > documentation.
> > >> > > >
> > >> > > > Thoughts?
> > >> > > >
> > >> > > >
> > >> > > > On Sun, Jun 19, 2016 at 10:42 PM, Saikat Maitra <
> > >> > saikat.mai...@gmail.com
> > >> > > >
> > >> > > > wrote:
> > >> > > >
> > >> > > > > Hello,
> > >> > > > >
> > >> > > > > I have raised the PR[1] for the following Jira ticket[2].
> > >> > > > >
> > >> > > > > Please review and let me know any feedback
> > >> > > > >
> > >> > > > > Regards
> > >> > > > > Saikat
> > >> > > > >
> > >> > > > > [1] https://github.com/apache/ignite/pull/816
> > >> > > > > [2] https://issues.apache.org/jira/browse/IGNITE-3337
> > >> > > > >
> > >> > > >
> > >> > > >
> > >> > > >
> > >> > > > --
> > >> > > > Alexey Kuznetsov
> > >> > > > GridGain Systems
> > >> > > > www.gridgain.com
> > >> > > >
> > >> > >
> > >> > >
> > >> > >
> > >> > > --
> > >> > > Sergey Kozlov
> > >> > > GridGain Systems
> > >> > > www.gridgain.com
> > >> > >
> > >> >
> > >>
> > >
> > >
> >
>


Re: IGNITE-3337

2016-06-29 Thread Andrey Novikov
Hi Saikat!

I’ve just reviewed and merged your pull request.

Thank you for your contribution!

—
Andrey

On Wed, Jun 29, 2016 at 3:25 AM, Saikat Maitra <saikat.mai...@gmail.com>
wrote:

> Hello Andrey,
>
> I have updated the PR. Please review and share feedback.
>
> https://github.com/apache/ignite/pull/816
>
> Regards
> Saikat
>
> On Thu, Jun 23, 2016 at 8:41 PM, Saikat Maitra <saikat.mai...@gmail.com>
> wrote:
>
> > Thank you Andrey
> >
> > I will update the PR accordingly.
> >
> > Regards
> > Saikat
> >
> > On Thu, Jun 23, 2016 at 12:33 PM, Andrey Novikov <anovi...@apache.org>
> > wrote:
> >
> >> Saint,
> >>
> >> I've reviewed your PR and left comments in the ticket.
> >>
> >>
> >> On Tue, Jun 21, 2016 at 1:14 AM, Saikat Maitra <saikat.mai...@gmail.com
> >
> >> wrote:
> >>
> >> > Hi Alexey , Sergey
> >> >
> >> > Thank you for your time and reviewing the PR. I agree we can deprecate
> >> > cacheName for metadata command. I have updated the files and request
> >> you to
> >> > review the changes.
> >> >
> >> > Also can you please share where the docs are hosted and I can then
> >> update
> >> > the rest api doc.
> >> >
> >> > Regards
> >> > Saikat
> >> >
> >> > On Mon, Jun 20, 2016 at 3:08 PM, Sergey Kozlov <skoz...@gridgain.com>
> >> > wrote:
> >> >
> >> > > Hi Saikat and Alexey.
> >> > >
> >> > > I think that the solution suggested by Alexey is simple one.
> Actually
> >> > > null-named cache is widely used for now and we can't remove it (or
> at
> >> > least
> >> > > we should re-think the approach for such caches). On the other hand
> >> the
> >> > > size of metadata returned by REST command even for dozen caches is
> not
> >> > > large and can be filtered (iterated) on the client side. So I
> suppose
> >> the
> >> > > ticket should be updated according suggested approach.
> >> > >
> >> > >
> >> > >
> >> > >
> >> > > On Mon, Jun 20, 2016 at 12:28 PM, Alexey Kuznetsov <
> >> > > akuznet...@gridgain.com>
> >> > > wrote:
> >> > >
> >> > > > Hi, Saikat
> >> > > >
> >> > > > I reviewed you PR and I think we should deprecate "cacheName"
> >> > parameter
> >> > > > in metadata command.
> >> > > >
> >> > > > In current implementation when "cacheName" was not specified that
> >> means
> >> > > to
> >> > > > get "default" cache (with name=null)
> >> > > > And now it will be impossible to take metadata for such cache.
> >> > > >
> >> > > > But I think for this command there is a little sense to extract
> >> > metadata
> >> > > > for single cache,
> >> > > >  because any way on server side they will be extracted for all
> >> caches.
> >> > > > See:
> >> > > >
> >> > >
> >> >
> >>
> org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager#sqlMetadata
> >> > > > line 999.
> >> > > >
> >> > > > Also for performance reason it is much faster to get all metadata
> at
> >> > > once.
> >> > > >
> >> > > > So, I suggest - to deprecate "cacheName" parameter and fix
> >> > documentation.
> >> > > >
> >> > > > Thoughts?
> >> > > >
> >> > > >
> >> > > > On Sun, Jun 19, 2016 at 10:42 PM, Saikat Maitra <
> >> > saikat.mai...@gmail.com
> >> > > >
> >> > > > wrote:
> >> > > >
> >> > > > > Hello,
> >> > > > >
> >> > > > > I have raised the PR[1] for the following Jira ticket[2].
> >> > > > >
> >> > > > > Please review and let me know any feedback
> >> > > > >
> >> > > > > Regards
> >> > > > > Saikat
> >> > > > >
> >> > > > > [1] https://github.com/apache/ignite/pull/816
> >> > > > > [2] https://issues.apache.org/jira/browse/IGNITE-3337
> >> > > > >
> >> > > >
> >> > > >
> >> > > >
> >> > > > --
> >> > > > Alexey Kuznetsov
> >> > > > GridGain Systems
> >> > > > www.gridgain.com
> >> > > >
> >> > >
> >> > >
> >> > >
> >> > > --
> >> > > Sergey Kozlov
> >> > > GridGain Systems
> >> > > www.gridgain.com
> >> > >
> >> >
> >>
> >
> >
>


[GitHub] ignite pull request #816: IGNITE-3337 REST HTTP: metadata command returns al...

2016-06-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/816


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: IGNITE-3337

2016-06-28 Thread Saikat Maitra
Hello Andrey,

I have updated the PR. Please review and share feedback.

https://github.com/apache/ignite/pull/816

Regards
Saikat

On Thu, Jun 23, 2016 at 8:41 PM, Saikat Maitra <saikat.mai...@gmail.com>
wrote:

> Thank you Andrey
>
> I will update the PR accordingly.
>
> Regards
> Saikat
>
> On Thu, Jun 23, 2016 at 12:33 PM, Andrey Novikov <anovi...@apache.org>
> wrote:
>
>> Saint,
>>
>> I've reviewed your PR and left comments in the ticket.
>>
>>
>> On Tue, Jun 21, 2016 at 1:14 AM, Saikat Maitra <saikat.mai...@gmail.com>
>> wrote:
>>
>> > Hi Alexey , Sergey
>> >
>> > Thank you for your time and reviewing the PR. I agree we can deprecate
>> > cacheName for metadata command. I have updated the files and request
>> you to
>> > review the changes.
>> >
>> > Also can you please share where the docs are hosted and I can then
>> update
>> > the rest api doc.
>> >
>> > Regards
>> > Saikat
>> >
>> > On Mon, Jun 20, 2016 at 3:08 PM, Sergey Kozlov <skoz...@gridgain.com>
>> > wrote:
>> >
>> > > Hi Saikat and Alexey.
>> > >
>> > > I think that the solution suggested by Alexey is simple one. Actually
>> > > null-named cache is widely used for now and we can't remove it (or at
>> > least
>> > > we should re-think the approach for such caches). On the other hand
>> the
>> > > size of metadata returned by REST command even for dozen caches is not
>> > > large and can be filtered (iterated) on the client side. So I suppose
>> the
>> > > ticket should be updated according suggested approach.
>> > >
>> > >
>> > >
>> > >
>> > > On Mon, Jun 20, 2016 at 12:28 PM, Alexey Kuznetsov <
>> > > akuznet...@gridgain.com>
>> > > wrote:
>> > >
>> > > > Hi, Saikat
>> > > >
>> > > > I reviewed you PR and I think we should deprecate "cacheName"
>> > parameter
>> > > > in metadata command.
>> > > >
>> > > > In current implementation when "cacheName" was not specified that
>> means
>> > > to
>> > > > get "default" cache (with name=null)
>> > > > And now it will be impossible to take metadata for such cache.
>> > > >
>> > > > But I think for this command there is a little sense to extract
>> > metadata
>> > > > for single cache,
>> > > >  because any way on server side they will be extracted for all
>> caches.
>> > > > See:
>> > > >
>> > >
>> >
>> org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager#sqlMetadata
>> > > > line 999.
>> > > >
>> > > > Also for performance reason it is much faster to get all metadata at
>> > > once.
>> > > >
>> > > > So, I suggest - to deprecate "cacheName" parameter and fix
>> > documentation.
>> > > >
>> > > > Thoughts?
>> > > >
>> > > >
>> > > > On Sun, Jun 19, 2016 at 10:42 PM, Saikat Maitra <
>> > saikat.mai...@gmail.com
>> > > >
>> > > > wrote:
>> > > >
>> > > > > Hello,
>> > > > >
>> > > > > I have raised the PR[1] for the following Jira ticket[2].
>> > > > >
>> > > > > Please review and let me know any feedback
>> > > > >
>> > > > > Regards
>> > > > > Saikat
>> > > > >
>> > > > > [1] https://github.com/apache/ignite/pull/816
>> > > > > [2] https://issues.apache.org/jira/browse/IGNITE-3337
>> > > > >
>> > > >
>> > > >
>> > > >
>> > > > --
>> > > > Alexey Kuznetsov
>> > > > GridGain Systems
>> > > > www.gridgain.com
>> > > >
>> > >
>> > >
>> > >
>> > > --
>> > > Sergey Kozlov
>> > > GridGain Systems
>> > > www.gridgain.com
>> > >
>> >
>>
>
>


Re: IGNITE-3337

2016-06-23 Thread Saikat Maitra
Thank you Andrey

I will update the PR accordingly.

Regards
Saikat

On Thu, Jun 23, 2016 at 12:33 PM, Andrey Novikov <anovi...@apache.org>
wrote:

> Saint,
>
> I've reviewed your PR and left comments in the ticket.
>
>
> On Tue, Jun 21, 2016 at 1:14 AM, Saikat Maitra <saikat.mai...@gmail.com>
> wrote:
>
> > Hi Alexey , Sergey
> >
> > Thank you for your time and reviewing the PR. I agree we can deprecate
> > cacheName for metadata command. I have updated the files and request you
> to
> > review the changes.
> >
> > Also can you please share where the docs are hosted and I can then update
> > the rest api doc.
> >
> > Regards
> > Saikat
> >
> > On Mon, Jun 20, 2016 at 3:08 PM, Sergey Kozlov <skoz...@gridgain.com>
> > wrote:
> >
> > > Hi Saikat and Alexey.
> > >
> > > I think that the solution suggested by Alexey is simple one. Actually
> > > null-named cache is widely used for now and we can't remove it (or at
> > least
> > > we should re-think the approach for such caches). On the other hand the
> > > size of metadata returned by REST command even for dozen caches is not
> > > large and can be filtered (iterated) on the client side. So I suppose
> the
> > > ticket should be updated according suggested approach.
> > >
> > >
> > >
> > >
> > > On Mon, Jun 20, 2016 at 12:28 PM, Alexey Kuznetsov <
> > > akuznet...@gridgain.com>
> > > wrote:
> > >
> > > > Hi, Saikat
> > > >
> > > > I reviewed you PR and I think we should deprecate "cacheName"
> > parameter
> > > > in metadata command.
> > > >
> > > > In current implementation when "cacheName" was not specified that
> means
> > > to
> > > > get "default" cache (with name=null)
> > > > And now it will be impossible to take metadata for such cache.
> > > >
> > > > But I think for this command there is a little sense to extract
> > metadata
> > > > for single cache,
> > > >  because any way on server side they will be extracted for all
> caches.
> > > > See:
> > > >
> > >
> >
> org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager#sqlMetadata
> > > > line 999.
> > > >
> > > > Also for performance reason it is much faster to get all metadata at
> > > once.
> > > >
> > > > So, I suggest - to deprecate "cacheName" parameter and fix
> > documentation.
> > > >
> > > > Thoughts?
> > > >
> > > >
> > > > On Sun, Jun 19, 2016 at 10:42 PM, Saikat Maitra <
> > saikat.mai...@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > Hello,
> > > > >
> > > > > I have raised the PR[1] for the following Jira ticket[2].
> > > > >
> > > > > Please review and let me know any feedback
> > > > >
> > > > > Regards
> > > > > Saikat
> > > > >
> > > > > [1] https://github.com/apache/ignite/pull/816
> > > > > [2] https://issues.apache.org/jira/browse/IGNITE-3337
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Alexey Kuznetsov
> > > > GridGain Systems
> > > > www.gridgain.com
> > > >
> > >
> > >
> > >
> > > --
> > > Sergey Kozlov
> > > GridGain Systems
> > > www.gridgain.com
> > >
> >
>


Re: IGNITE-3337

2016-06-23 Thread Andrey Novikov
Saint,

I've reviewed your PR and left comments in the ticket.


On Tue, Jun 21, 2016 at 1:14 AM, Saikat Maitra <saikat.mai...@gmail.com>
wrote:

> Hi Alexey , Sergey
>
> Thank you for your time and reviewing the PR. I agree we can deprecate
> cacheName for metadata command. I have updated the files and request you to
> review the changes.
>
> Also can you please share where the docs are hosted and I can then update
> the rest api doc.
>
> Regards
> Saikat
>
> On Mon, Jun 20, 2016 at 3:08 PM, Sergey Kozlov <skoz...@gridgain.com>
> wrote:
>
> > Hi Saikat and Alexey.
> >
> > I think that the solution suggested by Alexey is simple one. Actually
> > null-named cache is widely used for now and we can't remove it (or at
> least
> > we should re-think the approach for such caches). On the other hand the
> > size of metadata returned by REST command even for dozen caches is not
> > large and can be filtered (iterated) on the client side. So I suppose the
> > ticket should be updated according suggested approach.
> >
> >
> >
> >
> > On Mon, Jun 20, 2016 at 12:28 PM, Alexey Kuznetsov <
> > akuznet...@gridgain.com>
> > wrote:
> >
> > > Hi, Saikat
> > >
> > > I reviewed you PR and I think we should deprecate "cacheName"
> parameter
> > > in metadata command.
> > >
> > > In current implementation when "cacheName" was not specified that means
> > to
> > > get "default" cache (with name=null)
> > > And now it will be impossible to take metadata for such cache.
> > >
> > > But I think for this command there is a little sense to extract
> metadata
> > > for single cache,
> > >  because any way on server side they will be extracted for all caches.
> > > See:
> > >
> >
> org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager#sqlMetadata
> > > line 999.
> > >
> > > Also for performance reason it is much faster to get all metadata at
> > once.
> > >
> > > So, I suggest - to deprecate "cacheName" parameter and fix
> documentation.
> > >
> > > Thoughts?
> > >
> > >
> > > On Sun, Jun 19, 2016 at 10:42 PM, Saikat Maitra <
> saikat.mai...@gmail.com
> > >
> > > wrote:
> > >
> > > > Hello,
> > > >
> > > > I have raised the PR[1] for the following Jira ticket[2].
> > > >
> > > > Please review and let me know any feedback
> > > >
> > > > Regards
> > > > Saikat
> > > >
> > > > [1] https://github.com/apache/ignite/pull/816
> > > > [2] https://issues.apache.org/jira/browse/IGNITE-3337
> > > >
> > >
> > >
> > >
> > > --
> > > Alexey Kuznetsov
> > > GridGain Systems
> > > www.gridgain.com
> > >
> >
> >
> >
> > --
> > Sergey Kozlov
> > GridGain Systems
> > www.gridgain.com
> >
>


Re: IGNITE-3337

2016-06-20 Thread Saikat Maitra
Hi Alexey , Sergey

Thank you for your time and reviewing the PR. I agree we can deprecate
cacheName for metadata command. I have updated the files and request you to
review the changes.

Also can you please share where the docs are hosted and I can then update
the rest api doc.

Regards
Saikat

On Mon, Jun 20, 2016 at 3:08 PM, Sergey Kozlov <skoz...@gridgain.com> wrote:

> Hi Saikat and Alexey.
>
> I think that the solution suggested by Alexey is simple one. Actually
> null-named cache is widely used for now and we can't remove it (or at least
> we should re-think the approach for such caches). On the other hand the
> size of metadata returned by REST command even for dozen caches is not
> large and can be filtered (iterated) on the client side. So I suppose the
> ticket should be updated according suggested approach.
>
>
>
>
> On Mon, Jun 20, 2016 at 12:28 PM, Alexey Kuznetsov <
> akuznet...@gridgain.com>
> wrote:
>
> > Hi, Saikat
> >
> > I reviewed you PR and I think we should deprecate "cacheName"  parameter
> > in metadata command.
> >
> > In current implementation when "cacheName" was not specified that means
> to
> > get "default" cache (with name=null)
> > And now it will be impossible to take metadata for such cache.
> >
> > But I think for this command there is a little sense to extract metadata
> > for single cache,
> >  because any way on server side they will be extracted for all caches.
> > See:
> >
> org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager#sqlMetadata
> > line 999.
> >
> > Also for performance reason it is much faster to get all metadata at
> once.
> >
> > So, I suggest - to deprecate "cacheName" parameter and fix documentation.
> >
> > Thoughts?
> >
> >
> > On Sun, Jun 19, 2016 at 10:42 PM, Saikat Maitra <saikat.mai...@gmail.com
> >
> > wrote:
> >
> > > Hello,
> > >
> > > I have raised the PR[1] for the following Jira ticket[2].
> > >
> > > Please review and let me know any feedback
> > >
> > > Regards
> > > Saikat
> > >
> > > [1] https://github.com/apache/ignite/pull/816
> > > [2] https://issues.apache.org/jira/browse/IGNITE-3337
> > >
> >
> >
> >
> > --
> > Alexey Kuznetsov
> > GridGain Systems
> > www.gridgain.com
> >
>
>
>
> --
> Sergey Kozlov
> GridGain Systems
> www.gridgain.com
>


Re: IGNITE-3337

2016-06-20 Thread Sergey Kozlov
Hi Saikat and Alexey.

I think that the solution suggested by Alexey is simple one. Actually
null-named cache is widely used for now and we can't remove it (or at least
we should re-think the approach for such caches). On the other hand the
size of metadata returned by REST command even for dozen caches is not
large and can be filtered (iterated) on the client side. So I suppose the
ticket should be updated according suggested approach.




On Mon, Jun 20, 2016 at 12:28 PM, Alexey Kuznetsov <akuznet...@gridgain.com>
wrote:

> Hi, Saikat
>
> I reviewed you PR and I think we should deprecate "cacheName"  parameter
> in metadata command.
>
> In current implementation when "cacheName" was not specified that means to
> get "default" cache (with name=null)
> And now it will be impossible to take metadata for such cache.
>
> But I think for this command there is a little sense to extract metadata
> for single cache,
>  because any way on server side they will be extracted for all caches.
> See:
> org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager#sqlMetadata
> line 999.
>
> Also for performance reason it is much faster to get all metadata at once.
>
> So, I suggest - to deprecate "cacheName" parameter and fix documentation.
>
> Thoughts?
>
>
> On Sun, Jun 19, 2016 at 10:42 PM, Saikat Maitra <saikat.mai...@gmail.com>
> wrote:
>
> > Hello,
> >
> > I have raised the PR[1] for the following Jira ticket[2].
> >
> > Please review and let me know any feedback
> >
> > Regards
> > Saikat
> >
> > [1] https://github.com/apache/ignite/pull/816
> > [2] https://issues.apache.org/jira/browse/IGNITE-3337
> >
>
>
>
> --
> Alexey Kuznetsov
> GridGain Systems
> www.gridgain.com
>



-- 
Sergey Kozlov
GridGain Systems
www.gridgain.com


Re: IGNITE-3337

2016-06-20 Thread Alexey Kuznetsov
Hi, Saikat

I reviewed you PR and I think we should deprecate "cacheName"  parameter
in metadata command.

In current implementation when "cacheName" was not specified that means to
get "default" cache (with name=null)
And now it will be impossible to take metadata for such cache.

But I think for this command there is a little sense to extract metadata
for single cache,
 because any way on server side they will be extracted for all caches.
See: 
org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager#sqlMetadata
line 999.

Also for performance reason it is much faster to get all metadata at once.

So, I suggest - to deprecate "cacheName" parameter and fix documentation.

Thoughts?


On Sun, Jun 19, 2016 at 10:42 PM, Saikat Maitra <saikat.mai...@gmail.com>
wrote:

> Hello,
>
> I have raised the PR[1] for the following Jira ticket[2].
>
> Please review and let me know any feedback
>
> Regards
> Saikat
>
> [1] https://github.com/apache/ignite/pull/816
> [2] https://issues.apache.org/jira/browse/IGNITE-3337
>



-- 
Alexey Kuznetsov
GridGain Systems
www.gridgain.com


IGNITE-3337

2016-06-19 Thread Saikat Maitra
Hello,

I have raised the PR[1] for the following Jira ticket[2].

Please review and let me know any feedback

Regards
Saikat

[1] https://github.com/apache/ignite/pull/816
[2] https://issues.apache.org/jira/browse/IGNITE-3337


[GitHub] ignite pull request #816: IGNITE-3337 REST HTTP: metadata command returns al...

2016-06-19 Thread samaitra
GitHub user samaitra opened a pull request:

https://github.com/apache/ignite/pull/816

IGNITE-3337 REST HTTP: metadata command returns all caches even if a cache 
name is passed to request



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/samaitra/ignite IGNITE-3337

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/816.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #816


commit ab37ea39cc862338b09bb82d99a34e64ada1f1a5
Author: samaitra <saikat.mai...@gmail.com>
Date:   2016-06-19T12:44:49Z

IGNITE-3337 REST HTTP: metadata command returns all caches even if a cache 
name is passed to request

commit d0fd29ffb06c3fe46232221ed3e07c4ab5cceb89
Author: samaitra <saikat.mai...@gmail.com>
Date:   2016-06-19T15:19:17Z

    IGNITE-3337 REST HTTP: metadata command returns all caches even if a cache 
name is passed to request

commit 3543270900331dd10beee8140dff6bbd4a21f700
Author: samaitra <saikat.mai...@gmail.com>
Date:   2016-06-19T15:20:41Z

IGNITE-3337 REST HTTP: metadata command returns all caches even if a cache 
name is passed to request




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (IGNITE-3337) REST HTTP: metadata command returns all caches even if cache name is passed to request

2016-06-17 Thread Sergey Kozlov (JIRA)
Sergey Kozlov created IGNITE-3337:
-

 Summary: REST HTTP: metadata command returns all caches even if 
cache name is passed to request
 Key: IGNITE-3337
 URL: https://issues.apache.org/jira/browse/IGNITE-3337
 Project: Ignite
  Issue Type: Bug
Reporter: Sergey Kozlov


Request: 
{{http://localhost:8080/ignite?cmd=metadata=replicated_cache}}

Reply:
{noformat}
{
  "error": "",
  "response": [
{
  "cacheName": "partitioned_cache",
  "fields": {},
  "indexes": {},
  "keyClasses": {},
  "types": [],
  "valClasses": {}
},
{
  "cacheName": "replicated_cache",
  "fields": {},
  "indexes": {},
  "keyClasses": {},
  "types": [],
  "valClasses": {}
}
  ],
  "sessionToken": "",
  "successStatus": 0
}
{noformat}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)