Re: Docker image for Ignite 1.6.0 release pull request
Hi Aliaksandr! I've reviewed and merge your changes to master. Thank you for your contribution! On Tue, Jun 7, 2016 at 5:31 PM, Denis Magda wrote: > Nikolay, > > As a maintainer of this component please do the review. > > — > Denis > > > On Jun 5, 2016, at 3:18 PM, zshamrock > wrote: > > > > Hi, guys, what about the following > https://github.com/apache/ignite/pull/757? > > > > Is already someone from DataGrid/Ignite working on official docker image > for > > 1.6.0 release, or you can take a look into the pull request above I've > > submitted. > > > > > > > > > > -- > > View this message in context: > http://apache-ignite-developers.2346864.n4.nabble.com/Docker-image-for-Ignite-1-6-0-release-pull-request-tp9276.html > > Sent from the Apache Ignite Developers mailing list archive at > Nabble.com. > >
Re: Docker image for Ignite 1.6.0 release pull request
Nikolay, As a maintainer of this component please do the review. — Denis > On Jun 5, 2016, at 3:18 PM, zshamrock wrote: > > Hi, guys, what about the following https://github.com/apache/ignite/pull/757? > > Is already someone from DataGrid/Ignite working on official docker image for > 1.6.0 release, or you can take a look into the pull request above I've > submitted. > > > > > -- > View this message in context: > http://apache-ignite-developers.2346864.n4.nabble.com/Docker-image-for-Ignite-1-6-0-release-pull-request-tp9276.html > Sent from the Apache Ignite Developers mailing list archive at Nabble.com.
Re: Docker image for Ignite 1.6.0 release pull request
Updated Dockerfile/PR - reduce the generated Docker image size from 1.061GB to 885MB. -- View this message in context: http://apache-ignite-developers.2346864.n4.nabble.com/Docker-image-for-Ignite-1-6-0-release-pull-request-tp9276p9282.html Sent from the Apache Ignite Developers mailing list archive at Nabble.com.
Re: Docker image
Thanks, Nikolay! On Fri, Jan 29, 2016 at 12:43 AM, Nikolay Tikhonov wrote: > Val, > > Our docker repo contains not only the latest version or 1.0.0-incubating, > there all versions. List of versions here [1]. I've updated "Dockerfile" > tab, now it shows dockerfile from "1.5.0.final" tag. > > [1] https://hub.docker.com/r/apacheignite/ignite/tags > > On Fri, Jan 29, 2016 at 9:34 AM, Valentin Kulichenko < > valentin.kuliche...@gmail.com> wrote: > > > Nikolay, > > > > As far as I know you were creating Docker images for Ignite. > > > > I just opened it [1] and noticed that the version is 1.0.0 there. Is > there > > a reason for this? Can we switch it to the latest? > > > > [1] https://hub.docker.com/r/apacheignite/ignite/~/dockerfile/ > > > > -Val > > >
Re: Docker image
Val, Our docker repo contains not only the latest version or 1.0.0-incubating, there all versions. List of versions here [1]. I've updated "Dockerfile" tab, now it shows dockerfile from "1.5.0.final" tag. [1] https://hub.docker.com/r/apacheignite/ignite/tags On Fri, Jan 29, 2016 at 9:34 AM, Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > Nikolay, > > As far as I know you were creating Docker images for Ignite. > > I just opened it [1] and noticed that the version is 1.0.0 there. Is there > a reason for this? Can we switch it to the latest? > > [1] https://hub.docker.com/r/apacheignite/ignite/~/dockerfile/ > > -Val >
Re: docker image
On Thu, Sep 17, 2015 at 7:06 PM, Sergi Vladykin wrote: > Looks a bit strange for me if most of development and testing happens on > Oracle JDK but > we distribute with OpenJDK. I believe if something works under OpenJDK most > probably > it will under Oracle JDK as well, but not the reverse. > I don't mind, but I still think we should test on both JDKs. I would also add IBM JDK for testing. > > Sergi > > 2015-09-17 17:13 GMT+03:00 Dmitriy Setrakyan : > > > On Thu, Sep 17, 2015 at 1:39 PM, Sergi Vladykin < > sergi.vlady...@gmail.com> > > wrote: > > > > > Probably it means that we should use openjdk by default for development > > and > > > testing as well? > > > > > > > We can, but I am not sure why we have to. Can you explain? > > > > > > > > > > Sergi > > > > > > 2015-09-17 7:39 GMT+03:00 Dmitriy Setrakyan : > > > > > > > Ignters, > > > > > > > > Can we change our docker image to download the OpenJDK? We should not > > > > automatically download Oracle JDK in the docker image - it is against > > the > > > > license. > > > > > > > > My preference would be to fix it for 1.4 release. > > > > > > > > Thanks, > > > > D. > > > > > > > > > >
Re: docker image
Looks a bit strange for me if most of development and testing happens on Oracle JDK but we distribute with OpenJDK. I believe if something works under OpenJDK most probably it will under Oracle JDK as well, but not the reverse. Sergi 2015-09-17 17:13 GMT+03:00 Dmitriy Setrakyan : > On Thu, Sep 17, 2015 at 1:39 PM, Sergi Vladykin > wrote: > > > Probably it means that we should use openjdk by default for development > and > > testing as well? > > > > We can, but I am not sure why we have to. Can you explain? > > > > > > Sergi > > > > 2015-09-17 7:39 GMT+03:00 Dmitriy Setrakyan : > > > > > Ignters, > > > > > > Can we change our docker image to download the OpenJDK? We should not > > > automatically download Oracle JDK in the docker image - it is against > the > > > license. > > > > > > My preference would be to fix it for 1.4 release. > > > > > > Thanks, > > > D. > > > > > >
Re: docker image
On Thu, Sep 17, 2015 at 1:39 PM, Sergi Vladykin wrote: > Probably it means that we should use openjdk by default for development and > testing as well? > We can, but I am not sure why we have to. Can you explain? > > Sergi > > 2015-09-17 7:39 GMT+03:00 Dmitriy Setrakyan : > > > Ignters, > > > > Can we change our docker image to download the OpenJDK? We should not > > automatically download Oracle JDK in the docker image - it is against the > > license. > > > > My preference would be to fix it for 1.4 release. > > > > Thanks, > > D. > > >
Re: docker image
Probably it means that we should use openjdk by default for development and testing as well? Sergi 2015-09-17 7:39 GMT+03:00 Dmitriy Setrakyan : > Ignters, > > Can we change our docker image to download the OpenJDK? We should not > automatically download Oracle JDK in the docker image - it is against the > license. > > My preference would be to fix it for 1.4 release. > > Thanks, > D. >
