Re: IGNITE-1144
Here is the list of newbie tickets: https://issues.apache.org/jira/issues/?jql=project%20%3D%20IGNITE%20AND%20(component%20in%20(newbie)%20OR%20labels%20in%20(newbie)) You can pick one of them and start working. -Val On Tue, Feb 23, 2016 at 5:38 PM, Dood@ODDO wrote: > On 2/23/2016 7:05 PM, Valentin Kulichenko wrote: > >> I added couple more tests and merged your changes into master. Thanks for >> the contribution! >> > > Thanks! What other ticket do you think I could/should tackle? >
Re: IGNITE-1144
On 2/23/2016 7:05 PM, Valentin Kulichenko wrote: I added couple more tests and merged your changes into master. Thanks for the contribution! Thanks! What other ticket do you think I could/should tackle?
Re: IGNITE-1144
I added couple more tests and merged your changes into master. Thanks for the contribution! -Val On Mon, Feb 22, 2016 at 9:13 PM, Dood@ODDO wrote: > Val, > > All the test passed on TC - you can look at the PR at any time. Thanks! > > > On 2/22/2016 8:13 PM, Valentin Kulichenko wrote: > >> Hi, >> >> Thanks for the pull request! I will take a look as soon as possible. >> >> -Val >> >> On Mon, Feb 22, 2016 at 9:14 AM, Dood@ODDO wrote: >> >> Hello all, >>> >>> I was wondering if anyone can take a look at the PR I submitted for >>> IGNITE-1144 [1]. It compiles and I think the code is good but the tests I >>> submitted are failing - specifically, one test: I am using assertThrows() >>> to make sure that an exception is thrown if affinityRun() is invoked on a >>> queue that is not collocated. In the tests I basically set up a queue >>> that >>> has a configuration that invokes setCollocated(false) and then I invoke >>> an >>> affinityRun() with an "empty" job. For some reason the tests are failing >>> with an error that the exception wasn't thrown. However, in this case I >>> actually think that my test is bad and the PR code is good ;-). Can >>> someone >>> with more Java experience take a quick look? >>> >>> Thanks! >>> >>> [1] https://issues.apache.org/jira/browse/IGNITE-1144 >>> >>> >
Re: IGNITE-1144
Val, All the test passed on TC - you can look at the PR at any time. Thanks! On 2/22/2016 8:13 PM, Valentin Kulichenko wrote: Hi, Thanks for the pull request! I will take a look as soon as possible. -Val On Mon, Feb 22, 2016 at 9:14 AM, Dood@ODDO wrote: Hello all, I was wondering if anyone can take a look at the PR I submitted for IGNITE-1144 [1]. It compiles and I think the code is good but the tests I submitted are failing - specifically, one test: I am using assertThrows() to make sure that an exception is thrown if affinityRun() is invoked on a queue that is not collocated. In the tests I basically set up a queue that has a configuration that invokes setCollocated(false) and then I invoke an affinityRun() with an "empty" job. For some reason the tests are failing with an error that the exception wasn't thrown. However, in this case I actually think that my test is bad and the PR code is good ;-). Can someone with more Java experience take a quick look? Thanks! [1] https://issues.apache.org/jira/browse/IGNITE-1144
Re: IGNITE-1144
Hi, Thanks for the pull request! I will take a look as soon as possible. -Val On Mon, Feb 22, 2016 at 9:14 AM, Dood@ODDO wrote: > Hello all, > > I was wondering if anyone can take a look at the PR I submitted for > IGNITE-1144 [1]. It compiles and I think the code is good but the tests I > submitted are failing - specifically, one test: I am using assertThrows() > to make sure that an exception is thrown if affinityRun() is invoked on a > queue that is not collocated. In the tests I basically set up a queue that > has a configuration that invokes setCollocated(false) and then I invoke an > affinityRun() with an "empty" job. For some reason the tests are failing > with an error that the exception wasn't thrown. However, in this case I > actually think that my test is bad and the PR code is good ;-). Can someone > with more Java experience take a quick look? > > Thanks! > > [1] https://issues.apache.org/jira/browse/IGNITE-1144 >