Re: Switching Java language level to 8

[Sergey Kozlov]

Hi Denis

Filed the ticket [1]

1. IGNITE-7216 Refactor examples project


On Fri, Dec 15, 2017 at 8:45 PM, Denis Magda  wrote:

> Yuri, Sergey,
>
> These are all good points! Please create sub-tasks fro this umbrella
> tickets (one for ML and the other for examples):
> https://issues.apache.org/jira/browse/IGNITE-7203 <
> https://issues.apache.org/jira/browse/IGNITE-7203>
>
> Don’t want this to be missed in the discussion.
>
> —
> Denis
>
> > On Dec 15, 2017, at 6:03 AM, Sergey Kozlov  wrote:
> >
> > Hi
> >
> > The examples project should be refactored.
> >
> > Now we have regular and Java8 examples  and I suppose to replace regular
> > examples by corresponding Java8 examples if any.
> >
> > On Fri, Dec 15, 2017 at 3:14 PM, vveider  wrote:
> >
> >> Very good. I came to the same thoughts.
> >>
> >> Yet, there is a situation that some classes in *.java.* and .*java8.*
> >> packages that share the name and policy of merging them is not quite
> clear.
> >> Should *.java.* classes be replace by .*java8.*?
> >>
> >>
> >>
> >> --
> >> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> >>
> >
> >
> >
> > --
> > Sergey Kozlov
> > GridGain Systems
> > www.gridgain.com
>
>


-- 
Sergey Kozlov
GridGain Systems
www.gridgain.com

Re: Switching Java language level to 8

[Denis Magda]

Yuri, Sergey,

These are all good points! Please create sub-tasks fro this umbrella tickets 
(one for ML and the other for examples):
https://issues.apache.org/jira/browse/IGNITE-7203 


Don’t want this to be missed in the discussion.

—
Denis

> On Dec 15, 2017, at 6:03 AM, Sergey Kozlov  wrote:
> 
> Hi
> 
> The examples project should be refactored.
> 
> Now we have regular and Java8 examples  and I suppose to replace regular
> examples by corresponding Java8 examples if any.
> 
> On Fri, Dec 15, 2017 at 3:14 PM, vveider  wrote:
> 
>> Very good. I came to the same thoughts.
>> 
>> Yet, there is a situation that some classes in *.java.* and .*java8.*
>> packages that share the name and policy of merging them is not quite clear.
>> Should *.java.* classes be replace by .*java8.*?
>> 
>> 
>> 
>> --
>> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>> 
> 
> 
> 
> -- 
> Sergey Kozlov
> GridGain Systems
> www.gridgain.com

Re: Switching Java language level to 8

[Sergey Kozlov]

Hi

The examples project should be refactored.

Now we have regular and Java8 examples  and I suppose to replace regular
examples by corresponding Java8 examples if any.

On Fri, Dec 15, 2017 at 3:14 PM, vveider  wrote:

> Very good. I came to the same thoughts.
>
> Yet, there is a situation that some classes in *.java.* and .*java8.*
> packages that share the name and policy of merging them is not quite clear.
> Should *.java.* classes be replace by .*java8.*?
>
>
>
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>



-- 
Sergey Kozlov
GridGain Systems
www.gridgain.com

Re: Switching Java language level to 8

[vveider]

Very good. I came to the same thoughts.

Yet, there is a situation that some classes in *.java.* and .*java8.*
packages that share the name and policy of merging them is not quite clear.
Should *.java.* classes be replace by .*java8.*?



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Re: Switching Java language level to 8

[Yury Babak]

Hi,

currently we use maven profile "ml" for all ML sources. So during this
switching we could remove this profile and add ML module to the normal build
chain.

NB: we use this hack in example and yardstick modules. Also in examples we
have the separate source folder(and profile) for non-ml java 8 examples.
>From my point of view we dont need the separete source folders any more, so
all sources must be moved into "normal" folder(/src/main/java).

Regards,
Yury



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Re: Switching Java language level to 8

[Denis Magda]

Yury,

As a ML component maintainer, please join this conversation.

Now there are some hacks in our build system because of ML that was always JDK 
8 dependent. What needs to be done to obliterate the hacks and simplify the ML 
assembly? This should be done as a part of the activity initiated by Petr.

—
Denis

> On Dec 14, 2017, at 6:31 AM, Anton Vinogradov  
> wrote:
> 
> Correct :)
> 
> Url is https://issues.apache.org/jira/browse/IGNITE-7203
> 
> On Thu, Dec 14, 2017 at 5:28 PM, Petr Ivanov  wrote:
> 
>> Sorry, I meant IGNITE-7203.
>> 
>>> On 14 Dec 2017, at 17:26, vveider  wrote:
>>> 
>>> Got task IGNITE-7209. Started work on switching to java-1.8.
>>> 
>>> 
>>> 
>>> --
>>> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>> 
>> 

Re: Switching Java language level to 8

[Anton Vinogradov]

Correct :)

Url is https://issues.apache.org/jira/browse/IGNITE-7203

On Thu, Dec 14, 2017 at 5:28 PM, Petr Ivanov  wrote:

> Sorry, I meant IGNITE-7203.
>
> > On 14 Dec 2017, at 17:26, vveider  wrote:
> >
> > Got task IGNITE-7209. Started work on switching to java-1.8.
> >
> >
> >
> > --
> > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>
>

Re: Switching Java language level to 8

[Petr Ivanov]

Sorry, I meant IGNITE-7203.

> On 14 Dec 2017, at 17:26, vveider  wrote:
> 
> Got task IGNITE-7209. Started work on switching to java-1.8.
> 
> 
> 
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Re: Switching Java language level to 8

[vveider]

Got task IGNITE-7209. Started work on switching to java-1.8.



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Re: Switching Java language level to 8

[Dmitry Pavlov]

+1 Java 8 has a lot of APIs, we sometimes need it to improve our
performance.

чт, 14 дек. 2017 г. в 15:16, Дмитрий Рябов :

> +1
> Agree, I think changes will be less difficult if we go through 7/8 ->
> 8 -> 8/9 than 7/8 -> 7/8/9 ( -> possible 7/8/9/10 huh?) -> 8/9.
>
> 2017-12-14 14:18 GMT+03:00 Anton Vinogradov :
> > +1
> > Can we switch to Java8 right now and then support Java9?
> > That's the easiest way I think.
> >
> > On Thu, Dec 14, 2017 at 1:50 PM, Andrey Kuznetsov 
> wrote:
> >
> >> Hi Igniters,
> >>
> >> As far as I know, we planned to get the project compilable/runnable on
> Java
> >> 9 and then switch to Java 8 language features. But some tickets like [1]
> >> require Java 8 to be fixed. It seems we are to switch source level of
> the
> >> project to 1.8 first.
> >>
> >> Thoughts?
> >>
> >> [1] https://issues.apache.org/jira/browse/IGNITE-6734
> >>
> >> --
> >> Best regards,
> >>   Andrey Kuznetsov.
> >>
>

Re: Switching Java language level to 8

[Дмитрий Рябов]

+1
Agree, I think changes will be less difficult if we go through 7/8 ->
8 -> 8/9 than 7/8 -> 7/8/9 ( -> possible 7/8/9/10 huh?) -> 8/9.

2017-12-14 14:18 GMT+03:00 Anton Vinogradov :
> +1
> Can we switch to Java8 right now and then support Java9?
> That's the easiest way I think.
>
> On Thu, Dec 14, 2017 at 1:50 PM, Andrey Kuznetsov  wrote:
>
>> Hi Igniters,
>>
>> As far as I know, we planned to get the project compilable/runnable on Java
>> 9 and then switch to Java 8 language features. But some tickets like [1]
>> require Java 8 to be fixed. It seems we are to switch source level of the
>> project to 1.8 first.
>>
>> Thoughts?
>>
>> [1] https://issues.apache.org/jira/browse/IGNITE-6734
>>
>> --
>> Best regards,
>>   Andrey Kuznetsov.
>>

Re: Switching Java language level to 8

[Anton Vinogradov]

+1
Can we switch to Java8 right now and then support Java9?
That's the easiest way I think.

On Thu, Dec 14, 2017 at 1:50 PM, Andrey Kuznetsov  wrote:

> Hi Igniters,
>
> As far as I know, we planned to get the project compilable/runnable on Java
> 9 and then switch to Java 8 language features. But some tickets like [1]
> require Java 8 to be fixed. It seems we are to switch source level of the
> project to 1.8 first.
>
> Thoughts?
>
> [1] https://issues.apache.org/jira/browse/IGNITE-6734
>
> --
> Best regards,
>   Andrey Kuznetsov.
>