Re: Thin Clients: Renaming of AffinityAwareness to PartitionAwareness

2019-12-31 Thread Pavel Tupitsyn
Rename is merged to master (reviewed by Igor).

I'm working on ignite-2.8 cherrypick - there were some conflicts,
so I've created a branch and will run TC before merging.

On Mon, Dec 23, 2019 at 11:56 PM Denis Magda  wrote:

> Pavel,
>
> Thanks for taking over!
>
> -
> Denis
>
>
> On Mon, Dec 23, 2019 at 12:21 AM Pavel Tupitsyn 
> wrote:
>
> > Since there are no objections, I'm doing the rename:
> > https://issues.apache.org/jira/browse/IGNITE-12458
> >
> > On Fri, Dec 20, 2019 at 1:12 PM Igor Sapego  wrote:
> >
> > > +1, sounds reasonable to me.
> > >
> > > Best Regards,
> > > Igor
> > >
> > >
> > > On Fri, Dec 20, 2019 at 10:25 AM Pavel Tupitsyn 
> > > wrote:
> > >
> > > > +1, let's rename while we have a chance before 2.8 is released.
> > > >
> > >
> >
>


Re: Thin Clients: Renaming of AffinityAwareness to PartitionAwareness

2019-12-23 Thread Denis Magda
Pavel,

Thanks for taking over!

-
Denis


On Mon, Dec 23, 2019 at 12:21 AM Pavel Tupitsyn 
wrote:

> Since there are no objections, I'm doing the rename:
> https://issues.apache.org/jira/browse/IGNITE-12458
>
> On Fri, Dec 20, 2019 at 1:12 PM Igor Sapego  wrote:
>
> > +1, sounds reasonable to me.
> >
> > Best Regards,
> > Igor
> >
> >
> > On Fri, Dec 20, 2019 at 10:25 AM Pavel Tupitsyn 
> > wrote:
> >
> > > +1, let's rename while we have a chance before 2.8 is released.
> > >
> >
>


Re: Thin Clients: Renaming of AffinityAwareness to PartitionAwareness

2019-12-23 Thread Pavel Tupitsyn
Since there are no objections, I'm doing the rename:
https://issues.apache.org/jira/browse/IGNITE-12458

On Fri, Dec 20, 2019 at 1:12 PM Igor Sapego  wrote:

> +1, sounds reasonable to me.
>
> Best Regards,
> Igor
>
>
> On Fri, Dec 20, 2019 at 10:25 AM Pavel Tupitsyn 
> wrote:
>
> > +1, let's rename while we have a chance before 2.8 is released.
> >
>


Re: Thin Clients: Renaming of AffinityAwareness to PartitionAwareness

2019-12-20 Thread Igor Sapego
+1, sounds reasonable to me.

Best Regards,
Igor


On Fri, Dec 20, 2019 at 10:25 AM Pavel Tupitsyn 
wrote:

> +1, let's rename while we have a chance before 2.8 is released.
>


Re: Thin Clients: Renaming of AffinityAwareness to PartitionAwareness

2019-12-19 Thread Pavel Tupitsyn
+1, let's rename while we have a chance before 2.8 is released.


Thin Clients: Renaming of AffinityAwareness to PartitionAwareness

2019-12-19 Thread Denis Magda
Igniters,

I'd like to have an open discussion about this IEP in relation to the name
of the parameter that activates the feature:
https://cwiki.apache.org/confluence/display/IGNITE/IEP-23%3A+Best+Effort+Affinity+for+thin+clients

Presently selected term ("affinityAwareness") is not accurate and will
cause a lot of confusion. (sorry not starting this discussion earlier, I
came across the method name recently).

The goal of the improvement was to make our thin clients *aware of the
partitions' distribution* so that requests can be directed straight to the
nodes that keep a copy of the data avoiding the proxy node. Thick clients
are partition-aware by nature and get a partitions distribution map with
the help of the partition-map exchange process. So, partitioning/sharding
are coined terms among distributed systems and the purpose is understood.
Partitioning and partition-awareness are linked together logically. With
this feature in place, our thin clients become partition-aware as well as
the thick ones (even though there are still some limitations and
implementation differences).

Now, for some reason and keeping the goal of the IEP in mind (make the thin
clients aware of the distribution of the partitions), we named the
parameter that activates this capability as "affinityAwareness" and that
puzzled me a lot as long as "affinity" capabilities of Ignite are
understood by users and communicated differently. Affinity implies
*relations.* That's a relation between data sets stored in the cluster
(account and transactions, device and temperature reported by it, etc.) and
the relationship is established with the help of affinity keys in order to
avoid data shuffling over the network for various operations.

So, the proposal, before this improvement goes mainstream let's rename
"affinityAwareness" to *"partitionAwareness"* for the public APIs. Let's
not complicate the lifes of application developers (there are already many
improperly named methods in the API), don't complicate the life of those
who explain and introduce Ignite to the developer audience.

Thoughts? We have briefly discussed this with Pavel and Igor and see no
major obstacles for the renaming on the .NET, Python, C++, Node.JS clients
end. However, the same needs to be done for the Java side as well.

-
Denis