Re: Workaround for possible NPE in Selector.open()
Merged to master. Best regards, Ivan Pavlukhin ср, 18 мар. 2020 г. в 00:53, Ivan Pavlukhin : > > Igniters, > > Please review PR for the subject > https://issues.apache.org/jira/browse/IGNITE-12787 > > Best regards, > Ivan Pavlukhin > > пн, 16 мар. 2020 г. в 00:38, Ivan Pavlukhin : > > > > Folks, > > > > I created a ticket [1] and raised PR. TC is in progress. > > > > [1] https://issues.apache.org/jira/browse/IGNITE-12787 > > > > Best regards, > > Ivan Pavlukhin > > > > вт, 10 мар. 2020 г. в 16:56, Ilya Kasnacheev : > > > > > > Hello! > > > > > > Feel free to file a ticket, contribute a fix. > > > > > > Regards, > > > -- > > > Ilya Kasnacheev > > > > > > > > > вт, 10 мар. 2020 г. в 16:38, Seliverstov Igor : > > > > > > > Hi Igniters, > > > > > > > > Today I noticed quite old code aimed to workaround an old bug in 1.5 JDK > > > > revision which was fixed in rev 1.7 > > > > > > > > org/apache/ignite/internal/util/nio/GridNioServer.java:161 > > > > > > > > Since we widely use lambdas now (so Ignite requires at least Java 1.8) > > > > do > > > > we really need it now? > > > > > > > > I would like to remove it. > > > > > > > > Regards, > > > > Igor
Re: Workaround for possible NPE in Selector.open()
Igniters, Please review PR for the subject https://issues.apache.org/jira/browse/IGNITE-12787 Best regards, Ivan Pavlukhin пн, 16 мар. 2020 г. в 00:38, Ivan Pavlukhin : > > Folks, > > I created a ticket [1] and raised PR. TC is in progress. > > [1] https://issues.apache.org/jira/browse/IGNITE-12787 > > Best regards, > Ivan Pavlukhin > > вт, 10 мар. 2020 г. в 16:56, Ilya Kasnacheev : > > > > Hello! > > > > Feel free to file a ticket, contribute a fix. > > > > Regards, > > -- > > Ilya Kasnacheev > > > > > > вт, 10 мар. 2020 г. в 16:38, Seliverstov Igor : > > > > > Hi Igniters, > > > > > > Today I noticed quite old code aimed to workaround an old bug in 1.5 JDK > > > revision which was fixed in rev 1.7 > > > > > > org/apache/ignite/internal/util/nio/GridNioServer.java:161 > > > > > > Since we widely use lambdas now (so Ignite requires at least Java 1.8) do > > > we really need it now? > > > > > > I would like to remove it. > > > > > > Regards, > > > Igor
Re: Workaround for possible NPE in Selector.open()
Folks, I created a ticket [1] and raised PR. TC is in progress. [1] https://issues.apache.org/jira/browse/IGNITE-12787 Best regards, Ivan Pavlukhin вт, 10 мар. 2020 г. в 16:56, Ilya Kasnacheev : > > Hello! > > Feel free to file a ticket, contribute a fix. > > Regards, > -- > Ilya Kasnacheev > > > вт, 10 мар. 2020 г. в 16:38, Seliverstov Igor : > > > Hi Igniters, > > > > Today I noticed quite old code aimed to workaround an old bug in 1.5 JDK > > revision which was fixed in rev 1.7 > > > > org/apache/ignite/internal/util/nio/GridNioServer.java:161 > > > > Since we widely use lambdas now (so Ignite requires at least Java 1.8) do > > we really need it now? > > > > I would like to remove it. > > > > Regards, > > Igor
Re: Workaround for possible NPE in Selector.open()
Hello! Feel free to file a ticket, contribute a fix. Regards, -- Ilya Kasnacheev вт, 10 мар. 2020 г. в 16:38, Seliverstov Igor : > Hi Igniters, > > Today I noticed quite old code aimed to workaround an old bug in 1.5 JDK > revision which was fixed in rev 1.7 > > org/apache/ignite/internal/util/nio/GridNioServer.java:161 > > Since we widely use lambdas now (so Ignite requires at least Java 1.8) do > we really need it now? > > I would like to remove it. > > Regards, > Igor
Workaround for possible NPE in Selector.open()
Hi Igniters, Today I noticed quite old code aimed to workaround an old bug in 1.5 JDK revision which was fixed in rev 1.7 org/apache/ignite/internal/util/nio/GridNioServer.java:161 Since we widely use lambdas now (so Ignite requires at least Java 1.8) do we really need it now? I would like to remove it. Regards, Igor
