Re: 2.x branch divergence, its implications and what you can do.

[Sailesh Mukil]

On Thu, May 3, 2018 at 12:17 PM, Lars Volker  wrote:

> Should we add a check to the master GVO that makes sure that a change
> either applies to 2.x, or has a "not for 2.x" label?
>
>
I like this idea. Let me open a JIRA for it.


> On Thu, May 3, 2018 at 12:12 PM, Sailesh Mukil 
> wrote:
>
> > It's been a while since we started maintaining 2 active branches, master
> > and 2.x, and the divergence between them has grown quite a bit.
> >
> > The implications of this (as Michael Brown brought to my attention) are
> > that a patch that goes into 'master' may not cleanly apply to '2.x',
> which
> > would fail the cherrypick-2.x-and-test(
> > https://jenkins.impala.io/job/cherrypick-2.x-and-test/) job, and if
> > unnoticed, can hold up all future cherry-picks from 'master' to '2.x'
> until
> > this is resolved.
> >
> > If this does happen, the original author of the patch needs to manually
> > cherry-pick the patch from 'master' to '2.x', resolve the conflicts and
> > push a change for review to the '2.x' branch with the same Change-Id.
> >
> > To avoid these types of failures, I advise authors to locally cherry pick
> > their patch to '2.x' to see if it applies cleanly before running GVO.
> >
> > Lastly, if a patch is meant only for 'master', and not for '2.x', please
> > remember to add the "Cherry-picks: not for 2.x" line to your commit
> > message. There have been a few patches in which this was not included,
> > which unfortunately requires manual work to resolve later on.
> >
> > Thank you for your time!
> >
> > - Sailesh
> >
>

Re: [VOTE] 3.0.0 release candidate 1

[Philip Zeyliger]

+1 (Binding)

I checked the hashes and the GPG signatures. Checked the tree hash. Diffed
the tarball with the git RC tag.

I also ran tests via docker/test-with-docker successfully.

-- Philip



On Tue, May 1, 2018 at 4:33 PM, Sailesh Mukil  wrote:

> This is a vote to release Impala 3.0.0
>
> The artifacts for testing can be downloaded from:
> https://dist.apache.org/repos/dist/dev/impala/3.0.0/RC1/
> Git tag: 3.0.0-rc1
> Tree hash: d5bf1fdeb20ac332ce48c6a2b0588bcaf7ac9cb0
>
> Please vote +1 or -1. -1 votes should be accompanied by an explanation of
> the reason. Only PMC members have binding votes, but other
> community members are encouraged to cast non-binding votes. This vote will
> pass if there are 3 binding +1 votes and more binding +1 votes than -1
> votes.
>
> Please also note that this release is a new major release, and does not
> override the recently released 2.12.0 as the latest release. Rather, 2.12.0
> is the latest release from the 2.x branch and 3.0.0 is the first and latest
> release from the 3.x branch.
>
> This wiki page describes how to check the release before you vote:
> https://cwiki.apache.org/confluence/display/IMPALA/How+to+Release#
>
> The vote will be open until 04:30 PM PST on Friday, May 4
>

Re: [VOTE] 3.0.0 release candidate 1

[Lars Volker]

+1 (binding)

* Downloaded the files and validated the sha512 signature and GPG checksum
* Built Impala from the tarball on the machine under my desk
* Started impala, ran some queries
* Observed that the shell reports a valid git hash in its version: Server
version: impalad version 3.0.0-RELEASE DEBUG (build
671de258f29d31d280defe989af261fdbd9182ae)
* Convinced myself that the git hash reported by impalad is correct

Thanks for putting up the RC, Sailesh!


On Wed, May 2, 2018 at 9:17 PM, Jim Apple  wrote:

> +1, binding
>
> I looked at the output of the release testing job that Sailesh appears to
> have run on jenkins.impala.io.
>
> On Tue, May 1, 2018 at 4:34 PM Sailesh Mukil  wrote:
>
> > This is a vote to release Impala 3.0.0
> >
> > The artifacts for testing can be downloaded from:
> > https://dist.apache.org/repos/dist/dev/impala/3.0.0/RC1/
> > Git tag: 3.0.0-rc1
> > Tree hash: d5bf1fdeb20ac332ce48c6a2b0588bcaf7ac9cb0
> >
> > Please vote +1 or -1. -1 votes should be accompanied by an explanation of
> > the reason. Only PMC members have binding votes, but other
> > community members are encouraged to cast non-binding votes. This vote
> will
> > pass if there are 3 binding +1 votes and more binding +1 votes than -1
> > votes.
> >
> > Please also note that this release is a new major release, and does not
> > override the recently released 2.12.0 as the latest release. Rather,
> 2.12.0
> > is the latest release from the 2.x branch and 3.0.0 is the first and
> latest
> > release from the 3.x branch.
> >
> > This wiki page describes how to check the release before you vote:
> > https://cwiki.apache.org/confluence/display/IMPALA/How+to+Release#
> >
> > The vote will be open until 04:30 PM PST on Friday, May 4
> >
>

Re: [VOTE] 3.0.0 release candidate 1

[Sailesh Mukil]

+1 (binding)

- Validated the sha512 file
- Validated the GPG signature
- Ran the release test job:
https://jenkins.impala.io/view/Utility/job/release-test-ub1604/12/

On Wed, May 2, 2018 at 9:17 PM, Jim Apple  wrote:

> +1, binding
>
> I looked at the output of the release testing job that Sailesh appears to
> have run on jenkins.impala.io.
>
> On Tue, May 1, 2018 at 4:34 PM Sailesh Mukil  wrote:
>
> > This is a vote to release Impala 3.0.0
> >
> > The artifacts for testing can be downloaded from:
> > https://dist.apache.org/repos/dist/dev/impala/3.0.0/RC1/
> > Git tag: 3.0.0-rc1
> > Tree hash: d5bf1fdeb20ac332ce48c6a2b0588bcaf7ac9cb0
> >
> > Please vote +1 or -1. -1 votes should be accompanied by an explanation of
> > the reason. Only PMC members have binding votes, but other
> > community members are encouraged to cast non-binding votes. This vote
> will
> > pass if there are 3 binding +1 votes and more binding +1 votes than -1
> > votes.
> >
> > Please also note that this release is a new major release, and does not
> > override the recently released 2.12.0 as the latest release. Rather,
> 2.12.0
> > is the latest release from the 2.x branch and 3.0.0 is the first and
> latest
> > release from the 3.x branch.
> >
> > This wiki page describes how to check the release before you vote:
> > https://cwiki.apache.org/confluence/display/IMPALA/How+to+Release#
> >
> > The vote will be open until 04:30 PM PST on Friday, May 4
> >
>

Re: [VOTE] 3.0.0 release candidate 1

[Thomas Tauber-Marshall]

+1 binding

Ran the release test job:
https://jenkins.impala.io/job/release-test-ub1604/13/

On Wed, May 2, 2018 at 9:17 PM Jim Apple  wrote:

> +1, binding
>
> I looked at the output of the release testing job that Sailesh appears to
> have run on jenkins.impala.io.
>
> On Tue, May 1, 2018 at 4:34 PM Sailesh Mukil  wrote:
>
> > This is a vote to release Impala 3.0.0
> >
> > The artifacts for testing can be downloaded from:
> > https://dist.apache.org/repos/dist/dev/impala/3.0.0/RC1/
> > Git tag: 3.0.0-rc1
> > Tree hash: d5bf1fdeb20ac332ce48c6a2b0588bcaf7ac9cb0
> >
> > Please vote +1 or -1. -1 votes should be accompanied by an explanation of
> > the reason. Only PMC members have binding votes, but other
> > community members are encouraged to cast non-binding votes. This vote
> will
> > pass if there are 3 binding +1 votes and more binding +1 votes than -1
> > votes.
> >
> > Please also note that this release is a new major release, and does not
> > override the recently released 2.12.0 as the latest release. Rather,
> 2.12.0
> > is the latest release from the 2.x branch and 3.0.0 is the first and
> latest
> > release from the 3.x branch.
> >
> > This wiki page describes how to check the release before you vote:
> > https://cwiki.apache.org/confluence/display/IMPALA/How+to+Release#
> >
> > The vote will be open until 04:30 PM PST on Friday, May 4
> >
>