Re: Sending Code Review emails to a different list
This now works. dev@ should no longer see CR comments, reviews@ is the new list. You can subscribe via reviews-subscribe@. See also: https://lists.apache.org/list.html?revi...@impala.apache.org And maybe eventually: http://mail-archives.apache.org/mod_mbox/incubator-impala-reviews/ Here is how I did it: 1. I sent mail from my moderator account for reviews@ to reviews-allow-subscribe-gerrit=cloudera@impala.incubator.apache.org 2. I replied to the email that generated, again using my moderator account. 3. I checked that it worked by mailing reviews-allow-l...@impala.incubator.apache.org. 4. Following the instructions on https://gerrit-review.googlesource.com/Documentation/user-notify.html, I changed the gerrit project's refs/meta/config branch to have [notify "team"] email = revi...@impala.incubator.apache.org rather than [notify "team"] email = dev@impala.incubator.apache.org 5. Updated the incubating status website (http://incubator.apache.org/projects/impala.html) by following the instructions on http://incubator.apache.org/guides/website.html Still TODO (lower priority for now): update wiki where appropriate, get issues@ to actually work, update http://impala.incubator.apache.org/ where appropriate On Fri, Sep 9, 2016 at 4:58 PM, Todd Lipconwrote: > OK, I submitted the request. For Kudu this took a week or so to show up, but > I think they were dealing with a backlog at that time, and hopefully will go > faster this time around. > > On Fri, Sep 9, 2016 at 4:53 PM, Henry Robinson wrote: >> >> Sure thing. I already moderate dev@. >> >> On 9 September 2016 at 16:51, Todd Lipcon wrote: >> >> > How about another volunteer to be a moderator? >> > >> > -Todd >> > >> > On Fri, Sep 9, 2016 at 1:55 PM, Jim Apple wrote: >> > >> > > reviews@ WFM. >> > > >> > > On Fri, Sep 9, 2016 at 1:43 PM, Todd Lipcon wrote: >> > > >> > >> Sorry, I'd accidentally muted this thread and didn't see my name >> > >> called >> > >> out :) >> > >> >> > >> The form requests a second moderator. Who can I add in addition to >> > >> Jim? >> > >> Also, I think more projects are using 'reviews@' than >> > >> 'code-reviews@'. >> > >> Any preference for the latter or can I use the shorter for more >> > consistency >> > >> with kudu lists, etc? >> > >> >> > >> -Todd >> > >> >> > >> On Fri, Sep 2, 2016 at 10:15 AM, Jim Apple >> > wrote: >> > >> >> > >>> Forgot to CC todd. >> > >>> >> > >>> On Fri, Sep 2, 2016 at 9:54 AM, Jim Apple >> > wrote: >> > >>> > Tried to set it up here: https://infra.apache.org/offic >> > >>> ers/mlreq/incubator >> > >>> > >> > >>> > But it turns out "Only Members and Officers (this includes all PMC >> > >>> > chairs) can submit the form." >> > >>> > >> > >>> > Todd, I think you are an officer - could you submit this for us? >> > >>> > >> > >>> > List name: code-review >> > >>> > Set Reply-To list header?: no >> > >>> > Moderation: allow subscribers to post, moderate all others [n.b.: >> > >>> > we'll need a workaround to allow posting by gerrit, but the >> > >>> > Hipchat >> > >>> > ASF infra room just told me that a moderator can send mail to >> > >>> > code-review-allow-foo=b...@impala.incubator.apache.org to subscribe >> > >>> > foo@bar to code-rev...@impala.incubator.apache.org] >> > >>> > Moderators' addresses: jbap...@apache.org >> > >>> > Notes: The impala code review tool forwards patches for code >> > >>> > review >> > >>> > and the comments on those patches to this list. >> > >>> > >> > >>> > On Thu, Sep 1, 2016 at 5:21 PM, Harrison Sheinblatt >> > >>> > wrote: >> > >>> >> +1 (nonbinding) >> > >>> >> >> > >>> >> On Thu, Sep 1, 2016 at 5:18 PM, Matthew Jacobs >> > >>> wrote: >> > >>> >> >> > >>> >>> +1 >> > >>> >>> >> > >>> >>> On Thu, Sep 1, 2016 at 4:18 PM, Henry Robinson >> > >>> >>> > > > >> > >>> wrote: >> > >>> >>> > Sounds good. >> > >>> >>> > >> > >>> >>> > On 1 September 2016 at 16:14, Sailesh Mukil < >> > sail...@cloudera.com> >> > >>> >>> wrote: >> > >>> >>> > >> > >>> >>> >> +1 >> > >>> >>> >> >> > >>> >>> >> On Thu, Sep 1, 2016 at 4:11 PM, Daniel Hecht < >> > dhe...@cloudera.com >> > >>> > >> > >>> >>> wrote: >> > >>> >>> >> >> > >>> >>> >> > Sounds good to me. >> > >>> >>> >> > >> > >>> >>> >> > On Thu, Sep 1, 2016 at 4:04 PM, Alex Behm < >> > >>> alex.b...@cloudera.com> >> > >>> >>> >> wrote: >> > >>> >>> >> > >> > >>> >>> >> > > Feels much better to have a separate cr list. +1 for this >> > idea >> > >>> >>> >> > > >> > >>> >>> >> > > On Thu, Sep 1, 2016 at 3:57 PM, Jim Apple < >> > >>> jbap...@cloudera.com> >> > >>> >>> >> wrote: >> > >>> >>> >> > > >> > >>> >>> >> > > > Today, all code reviews get send to dev@, causing it to >> > >>> have a >> > >>> >>> huge >> > >>> >>> >> > > > mail volume (1777 messages in August). I feel dev@ >> > >>> >>> >> >
Re: Sending Code Review emails to a different list
OK, I submitted the request. For Kudu this took a week or so to show up, but I think they were dealing with a backlog at that time, and hopefully will go faster this time around. On Fri, Sep 9, 2016 at 4:53 PM, Henry Robinsonwrote: > Sure thing. I already moderate dev@. > > On 9 September 2016 at 16:51, Todd Lipcon wrote: > > > How about another volunteer to be a moderator? > > > > -Todd > > > > On Fri, Sep 9, 2016 at 1:55 PM, Jim Apple wrote: > > > > > reviews@ WFM. > > > > > > On Fri, Sep 9, 2016 at 1:43 PM, Todd Lipcon wrote: > > > > > >> Sorry, I'd accidentally muted this thread and didn't see my name > called > > >> out :) > > >> > > >> The form requests a second moderator. Who can I add in addition to > Jim? > > >> Also, I think more projects are using 'reviews@' than 'code-reviews@ > '. > > >> Any preference for the latter or can I use the shorter for more > > consistency > > >> with kudu lists, etc? > > >> > > >> -Todd > > >> > > >> On Fri, Sep 2, 2016 at 10:15 AM, Jim Apple > > wrote: > > >> > > >>> Forgot to CC todd. > > >>> > > >>> On Fri, Sep 2, 2016 at 9:54 AM, Jim Apple > > wrote: > > >>> > Tried to set it up here: https://infra.apache.org/offic > > >>> ers/mlreq/incubator > > >>> > > > >>> > But it turns out "Only Members and Officers (this includes all PMC > > >>> > chairs) can submit the form." > > >>> > > > >>> > Todd, I think you are an officer - could you submit this for us? > > >>> > > > >>> > List name: code-review > > >>> > Set Reply-To list header?: no > > >>> > Moderation: allow subscribers to post, moderate all others [n.b.: > > >>> > we'll need a workaround to allow posting by gerrit, but the Hipchat > > >>> > ASF infra room just told me that a moderator can send mail to > > >>> > code-review-allow-foo=b...@impala.incubator.apache.org to subscribe > > >>> > foo@bar to code-rev...@impala.incubator.apache.org] > > >>> > Moderators' addresses: jbap...@apache.org > > >>> > Notes: The impala code review tool forwards patches for code review > > >>> > and the comments on those patches to this list. > > >>> > > > >>> > On Thu, Sep 1, 2016 at 5:21 PM, Harrison Sheinblatt > > >>> > wrote: > > >>> >> +1 (nonbinding) > > >>> >> > > >>> >> On Thu, Sep 1, 2016 at 5:18 PM, Matthew Jacobs > > >>> wrote: > > >>> >> > > >>> >>> +1 > > >>> >>> > > >>> >>> On Thu, Sep 1, 2016 at 4:18 PM, Henry Robinson < > he...@cloudera.com > > > > > >>> wrote: > > >>> >>> > Sounds good. > > >>> >>> > > > >>> >>> > On 1 September 2016 at 16:14, Sailesh Mukil < > > sail...@cloudera.com> > > >>> >>> wrote: > > >>> >>> > > > >>> >>> >> +1 > > >>> >>> >> > > >>> >>> >> On Thu, Sep 1, 2016 at 4:11 PM, Daniel Hecht < > > dhe...@cloudera.com > > >>> > > > >>> >>> wrote: > > >>> >>> >> > > >>> >>> >> > Sounds good to me. > > >>> >>> >> > > > >>> >>> >> > On Thu, Sep 1, 2016 at 4:04 PM, Alex Behm < > > >>> alex.b...@cloudera.com> > > >>> >>> >> wrote: > > >>> >>> >> > > > >>> >>> >> > > Feels much better to have a separate cr list. +1 for this > > idea > > >>> >>> >> > > > > >>> >>> >> > > On Thu, Sep 1, 2016 at 3:57 PM, Jim Apple < > > >>> jbap...@cloudera.com> > > >>> >>> >> wrote: > > >>> >>> >> > > > > >>> >>> >> > > > Today, all code reviews get send to dev@, causing it to > > >>> have a > > >>> >>> huge > > >>> >>> >> > > > mail volume (1777 messages in August). I feel dev@ > might > > >>> be more > > >>> >>> >> > > > welcoming if it only included mails sent by humans; that > > >>> way, new > > >>> >>> >> > > > contributors don't have to worry about setting up > filters > > >>> right > > >>> >>> away. > > >>> >>> >> > > > CR emails could go to code-review@impala.incubator.a > > >>> pache.org or > > >>> >>> >> > > > something else that the Apache infra people are willing > to > > >>> set up. > > >>> >>> >> > > > > > >>> >>> >> > > > What does everyone else think? > > >>> >>> >> > > > > > >>> >>> >> > > > > >>> >>> >> > > > >>> >>> >> > > >>> >>> > > > >>> >>> > > > >>> >>> > > > >>> >>> > -- > > >>> >>> > Henry Robinson > > >>> >>> > Software Engineer > > >>> >>> > Cloudera > > >>> >>> > 415-994-6679 > > >>> >>> > > >>> > > >> > > >> > > >> > > >> -- > > >> Todd Lipcon > > >> Software Engineer, Cloudera > > >> > > > > > > > > > > > > -- > > Todd Lipcon > > Software Engineer, Cloudera > > > > > > -- > Henry Robinson > Software Engineer > Cloudera > 415-994-6679 > -- Todd Lipcon Software Engineer, Cloudera
Re: Sending Code Review emails to a different list
Sure thing. I already moderate dev@. On 9 September 2016 at 16:51, Todd Lipconwrote: > How about another volunteer to be a moderator? > > -Todd > > On Fri, Sep 9, 2016 at 1:55 PM, Jim Apple wrote: > > > reviews@ WFM. > > > > On Fri, Sep 9, 2016 at 1:43 PM, Todd Lipcon wrote: > > > >> Sorry, I'd accidentally muted this thread and didn't see my name called > >> out :) > >> > >> The form requests a second moderator. Who can I add in addition to Jim? > >> Also, I think more projects are using 'reviews@' than 'code-reviews@'. > >> Any preference for the latter or can I use the shorter for more > consistency > >> with kudu lists, etc? > >> > >> -Todd > >> > >> On Fri, Sep 2, 2016 at 10:15 AM, Jim Apple > wrote: > >> > >>> Forgot to CC todd. > >>> > >>> On Fri, Sep 2, 2016 at 9:54 AM, Jim Apple > wrote: > >>> > Tried to set it up here: https://infra.apache.org/offic > >>> ers/mlreq/incubator > >>> > > >>> > But it turns out "Only Members and Officers (this includes all PMC > >>> > chairs) can submit the form." > >>> > > >>> > Todd, I think you are an officer - could you submit this for us? > >>> > > >>> > List name: code-review > >>> > Set Reply-To list header?: no > >>> > Moderation: allow subscribers to post, moderate all others [n.b.: > >>> > we'll need a workaround to allow posting by gerrit, but the Hipchat > >>> > ASF infra room just told me that a moderator can send mail to > >>> > code-review-allow-foo=b...@impala.incubator.apache.org to subscribe > >>> > foo@bar to code-rev...@impala.incubator.apache.org] > >>> > Moderators' addresses: jbap...@apache.org > >>> > Notes: The impala code review tool forwards patches for code review > >>> > and the comments on those patches to this list. > >>> > > >>> > On Thu, Sep 1, 2016 at 5:21 PM, Harrison Sheinblatt > >>> > wrote: > >>> >> +1 (nonbinding) > >>> >> > >>> >> On Thu, Sep 1, 2016 at 5:18 PM, Matthew Jacobs > >>> wrote: > >>> >> > >>> >>> +1 > >>> >>> > >>> >>> On Thu, Sep 1, 2016 at 4:18 PM, Henry Robinson > > >>> wrote: > >>> >>> > Sounds good. > >>> >>> > > >>> >>> > On 1 September 2016 at 16:14, Sailesh Mukil < > sail...@cloudera.com> > >>> >>> wrote: > >>> >>> > > >>> >>> >> +1 > >>> >>> >> > >>> >>> >> On Thu, Sep 1, 2016 at 4:11 PM, Daniel Hecht < > dhe...@cloudera.com > >>> > > >>> >>> wrote: > >>> >>> >> > >>> >>> >> > Sounds good to me. > >>> >>> >> > > >>> >>> >> > On Thu, Sep 1, 2016 at 4:04 PM, Alex Behm < > >>> alex.b...@cloudera.com> > >>> >>> >> wrote: > >>> >>> >> > > >>> >>> >> > > Feels much better to have a separate cr list. +1 for this > idea > >>> >>> >> > > > >>> >>> >> > > On Thu, Sep 1, 2016 at 3:57 PM, Jim Apple < > >>> jbap...@cloudera.com> > >>> >>> >> wrote: > >>> >>> >> > > > >>> >>> >> > > > Today, all code reviews get send to dev@, causing it to > >>> have a > >>> >>> huge > >>> >>> >> > > > mail volume (1777 messages in August). I feel dev@ might > >>> be more > >>> >>> >> > > > welcoming if it only included mails sent by humans; that > >>> way, new > >>> >>> >> > > > contributors don't have to worry about setting up filters > >>> right > >>> >>> away. > >>> >>> >> > > > CR emails could go to code-review@impala.incubator.a > >>> pache.org or > >>> >>> >> > > > something else that the Apache infra people are willing to > >>> set up. > >>> >>> >> > > > > >>> >>> >> > > > What does everyone else think? > >>> >>> >> > > > > >>> >>> >> > > > >>> >>> >> > > >>> >>> >> > >>> >>> > > >>> >>> > > >>> >>> > > >>> >>> > -- > >>> >>> > Henry Robinson > >>> >>> > Software Engineer > >>> >>> > Cloudera > >>> >>> > 415-994-6679 > >>> >>> > >>> > >> > >> > >> > >> -- > >> Todd Lipcon > >> Software Engineer, Cloudera > >> > > > > > > > -- > Todd Lipcon > Software Engineer, Cloudera > -- Henry Robinson Software Engineer Cloudera 415-994-6679
Re: Sending Code Review emails to a different list
How about another volunteer to be a moderator? -Todd On Fri, Sep 9, 2016 at 1:55 PM, Jim Applewrote: > reviews@ WFM. > > On Fri, Sep 9, 2016 at 1:43 PM, Todd Lipcon wrote: > >> Sorry, I'd accidentally muted this thread and didn't see my name called >> out :) >> >> The form requests a second moderator. Who can I add in addition to Jim? >> Also, I think more projects are using 'reviews@' than 'code-reviews@'. >> Any preference for the latter or can I use the shorter for more consistency >> with kudu lists, etc? >> >> -Todd >> >> On Fri, Sep 2, 2016 at 10:15 AM, Jim Apple wrote: >> >>> Forgot to CC todd. >>> >>> On Fri, Sep 2, 2016 at 9:54 AM, Jim Apple wrote: >>> > Tried to set it up here: https://infra.apache.org/offic >>> ers/mlreq/incubator >>> > >>> > But it turns out "Only Members and Officers (this includes all PMC >>> > chairs) can submit the form." >>> > >>> > Todd, I think you are an officer - could you submit this for us? >>> > >>> > List name: code-review >>> > Set Reply-To list header?: no >>> > Moderation: allow subscribers to post, moderate all others [n.b.: >>> > we'll need a workaround to allow posting by gerrit, but the Hipchat >>> > ASF infra room just told me that a moderator can send mail to >>> > code-review-allow-foo=b...@impala.incubator.apache.org to subscribe >>> > foo@bar to code-rev...@impala.incubator.apache.org] >>> > Moderators' addresses: jbap...@apache.org >>> > Notes: The impala code review tool forwards patches for code review >>> > and the comments on those patches to this list. >>> > >>> > On Thu, Sep 1, 2016 at 5:21 PM, Harrison Sheinblatt >>> > wrote: >>> >> +1 (nonbinding) >>> >> >>> >> On Thu, Sep 1, 2016 at 5:18 PM, Matthew Jacobs >>> wrote: >>> >> >>> >>> +1 >>> >>> >>> >>> On Thu, Sep 1, 2016 at 4:18 PM, Henry Robinson >>> wrote: >>> >>> > Sounds good. >>> >>> > >>> >>> > On 1 September 2016 at 16:14, Sailesh Mukil >>> >>> wrote: >>> >>> > >>> >>> >> +1 >>> >>> >> >>> >>> >> On Thu, Sep 1, 2016 at 4:11 PM, Daniel Hecht >> > >>> >>> wrote: >>> >>> >> >>> >>> >> > Sounds good to me. >>> >>> >> > >>> >>> >> > On Thu, Sep 1, 2016 at 4:04 PM, Alex Behm < >>> alex.b...@cloudera.com> >>> >>> >> wrote: >>> >>> >> > >>> >>> >> > > Feels much better to have a separate cr list. +1 for this idea >>> >>> >> > > >>> >>> >> > > On Thu, Sep 1, 2016 at 3:57 PM, Jim Apple < >>> jbap...@cloudera.com> >>> >>> >> wrote: >>> >>> >> > > >>> >>> >> > > > Today, all code reviews get send to dev@, causing it to >>> have a >>> >>> huge >>> >>> >> > > > mail volume (1777 messages in August). I feel dev@ might >>> be more >>> >>> >> > > > welcoming if it only included mails sent by humans; that >>> way, new >>> >>> >> > > > contributors don't have to worry about setting up filters >>> right >>> >>> away. >>> >>> >> > > > CR emails could go to code-review@impala.incubator.a >>> pache.org or >>> >>> >> > > > something else that the Apache infra people are willing to >>> set up. >>> >>> >> > > > >>> >>> >> > > > What does everyone else think? >>> >>> >> > > > >>> >>> >> > > >>> >>> >> > >>> >>> >> >>> >>> > >>> >>> > >>> >>> > >>> >>> > -- >>> >>> > Henry Robinson >>> >>> > Software Engineer >>> >>> > Cloudera >>> >>> > 415-994-6679 >>> >>> >>> >> >> >> >> -- >> Todd Lipcon >> Software Engineer, Cloudera >> > > -- Todd Lipcon Software Engineer, Cloudera
Re: Sending Code Review emails to a different list
reviews@ WFM. On Fri, Sep 9, 2016 at 1:43 PM, Todd Lipconwrote: > Sorry, I'd accidentally muted this thread and didn't see my name called > out :) > > The form requests a second moderator. Who can I add in addition to Jim? > Also, I think more projects are using 'reviews@' than 'code-reviews@'. > Any preference for the latter or can I use the shorter for more consistency > with kudu lists, etc? > > -Todd > > On Fri, Sep 2, 2016 at 10:15 AM, Jim Apple wrote: > >> Forgot to CC todd. >> >> On Fri, Sep 2, 2016 at 9:54 AM, Jim Apple wrote: >> > Tried to set it up here: https://infra.apache.org/offic >> ers/mlreq/incubator >> > >> > But it turns out "Only Members and Officers (this includes all PMC >> > chairs) can submit the form." >> > >> > Todd, I think you are an officer - could you submit this for us? >> > >> > List name: code-review >> > Set Reply-To list header?: no >> > Moderation: allow subscribers to post, moderate all others [n.b.: >> > we'll need a workaround to allow posting by gerrit, but the Hipchat >> > ASF infra room just told me that a moderator can send mail to >> > code-review-allow-foo=b...@impala.incubator.apache.org to subscribe >> > foo@bar to code-rev...@impala.incubator.apache.org] >> > Moderators' addresses: jbap...@apache.org >> > Notes: The impala code review tool forwards patches for code review >> > and the comments on those patches to this list. >> > >> > On Thu, Sep 1, 2016 at 5:21 PM, Harrison Sheinblatt >> > wrote: >> >> +1 (nonbinding) >> >> >> >> On Thu, Sep 1, 2016 at 5:18 PM, Matthew Jacobs >> wrote: >> >> >> >>> +1 >> >>> >> >>> On Thu, Sep 1, 2016 at 4:18 PM, Henry Robinson >> wrote: >> >>> > Sounds good. >> >>> > >> >>> > On 1 September 2016 at 16:14, Sailesh Mukil >> >>> wrote: >> >>> > >> >>> >> +1 >> >>> >> >> >>> >> On Thu, Sep 1, 2016 at 4:11 PM, Daniel Hecht >> >>> wrote: >> >>> >> >> >>> >> > Sounds good to me. >> >>> >> > >> >>> >> > On Thu, Sep 1, 2016 at 4:04 PM, Alex Behm < >> alex.b...@cloudera.com> >> >>> >> wrote: >> >>> >> > >> >>> >> > > Feels much better to have a separate cr list. +1 for this idea >> >>> >> > > >> >>> >> > > On Thu, Sep 1, 2016 at 3:57 PM, Jim Apple < >> jbap...@cloudera.com> >> >>> >> wrote: >> >>> >> > > >> >>> >> > > > Today, all code reviews get send to dev@, causing it to >> have a >> >>> huge >> >>> >> > > > mail volume (1777 messages in August). I feel dev@ might be >> more >> >>> >> > > > welcoming if it only included mails sent by humans; that >> way, new >> >>> >> > > > contributors don't have to worry about setting up filters >> right >> >>> away. >> >>> >> > > > CR emails could go to code-review@impala.incubator.a >> pache.org or >> >>> >> > > > something else that the Apache infra people are willing to >> set up. >> >>> >> > > > >> >>> >> > > > What does everyone else think? >> >>> >> > > > >> >>> >> > > >> >>> >> > >> >>> >> >> >>> > >> >>> > >> >>> > >> >>> > -- >> >>> > Henry Robinson >> >>> > Software Engineer >> >>> > Cloudera >> >>> > 415-994-6679 >> >>> >> > > > > -- > Todd Lipcon > Software Engineer, Cloudera >
Re: Sending Code Review emails to a different list
Sorry, I'd accidentally muted this thread and didn't see my name called out :) The form requests a second moderator. Who can I add in addition to Jim? Also, I think more projects are using 'reviews@' than 'code-reviews@'. Any preference for the latter or can I use the shorter for more consistency with kudu lists, etc? -Todd On Fri, Sep 2, 2016 at 10:15 AM, Jim Applewrote: > Forgot to CC todd. > > On Fri, Sep 2, 2016 at 9:54 AM, Jim Apple wrote: > > Tried to set it up here: https://infra.apache.org/ > officers/mlreq/incubator > > > > But it turns out "Only Members and Officers (this includes all PMC > > chairs) can submit the form." > > > > Todd, I think you are an officer - could you submit this for us? > > > > List name: code-review > > Set Reply-To list header?: no > > Moderation: allow subscribers to post, moderate all others [n.b.: > > we'll need a workaround to allow posting by gerrit, but the Hipchat > > ASF infra room just told me that a moderator can send mail to > > code-review-allow-foo=b...@impala.incubator.apache.org to subscribe > > foo@bar to code-rev...@impala.incubator.apache.org] > > Moderators' addresses: jbap...@apache.org > > Notes: The impala code review tool forwards patches for code review > > and the comments on those patches to this list. > > > > On Thu, Sep 1, 2016 at 5:21 PM, Harrison Sheinblatt > > wrote: > >> +1 (nonbinding) > >> > >> On Thu, Sep 1, 2016 at 5:18 PM, Matthew Jacobs wrote: > >> > >>> +1 > >>> > >>> On Thu, Sep 1, 2016 at 4:18 PM, Henry Robinson > wrote: > >>> > Sounds good. > >>> > > >>> > On 1 September 2016 at 16:14, Sailesh Mukil > >>> wrote: > >>> > > >>> >> +1 > >>> >> > >>> >> On Thu, Sep 1, 2016 at 4:11 PM, Daniel Hecht > >>> wrote: > >>> >> > >>> >> > Sounds good to me. > >>> >> > > >>> >> > On Thu, Sep 1, 2016 at 4:04 PM, Alex Behm > > >>> >> wrote: > >>> >> > > >>> >> > > Feels much better to have a separate cr list. +1 for this idea > >>> >> > > > >>> >> > > On Thu, Sep 1, 2016 at 3:57 PM, Jim Apple > > >>> >> wrote: > >>> >> > > > >>> >> > > > Today, all code reviews get send to dev@, causing it to have > a > >>> huge > >>> >> > > > mail volume (1777 messages in August). I feel dev@ might be > more > >>> >> > > > welcoming if it only included mails sent by humans; that way, > new > >>> >> > > > contributors don't have to worry about setting up filters > right > >>> away. > >>> >> > > > CR emails could go to code-rev...@impala.incubator.apache.org > or > >>> >> > > > something else that the Apache infra people are willing to > set up. > >>> >> > > > > >>> >> > > > What does everyone else think? > >>> >> > > > > >>> >> > > > >>> >> > > >>> >> > >>> > > >>> > > >>> > > >>> > -- > >>> > Henry Robinson > >>> > Software Engineer > >>> > Cloudera > >>> > 415-994-6679 > >>> > -- Todd Lipcon Software Engineer, Cloudera
Re: Sending Code Review emails to a different list
Forgot to CC todd. On Fri, Sep 2, 2016 at 9:54 AM, Jim Applewrote: > Tried to set it up here: https://infra.apache.org/officers/mlreq/incubator > > But it turns out "Only Members and Officers (this includes all PMC > chairs) can submit the form." > > Todd, I think you are an officer - could you submit this for us? > > List name: code-review > Set Reply-To list header?: no > Moderation: allow subscribers to post, moderate all others [n.b.: > we'll need a workaround to allow posting by gerrit, but the Hipchat > ASF infra room just told me that a moderator can send mail to > code-review-allow-foo=b...@impala.incubator.apache.org to subscribe > foo@bar to code-rev...@impala.incubator.apache.org] > Moderators' addresses: jbap...@apache.org > Notes: The impala code review tool forwards patches for code review > and the comments on those patches to this list. > > On Thu, Sep 1, 2016 at 5:21 PM, Harrison Sheinblatt > wrote: >> +1 (nonbinding) >> >> On Thu, Sep 1, 2016 at 5:18 PM, Matthew Jacobs wrote: >> >>> +1 >>> >>> On Thu, Sep 1, 2016 at 4:18 PM, Henry Robinson wrote: >>> > Sounds good. >>> > >>> > On 1 September 2016 at 16:14, Sailesh Mukil >>> wrote: >>> > >>> >> +1 >>> >> >>> >> On Thu, Sep 1, 2016 at 4:11 PM, Daniel Hecht >>> wrote: >>> >> >>> >> > Sounds good to me. >>> >> > >>> >> > On Thu, Sep 1, 2016 at 4:04 PM, Alex Behm >>> >> wrote: >>> >> > >>> >> > > Feels much better to have a separate cr list. +1 for this idea >>> >> > > >>> >> > > On Thu, Sep 1, 2016 at 3:57 PM, Jim Apple >>> >> wrote: >>> >> > > >>> >> > > > Today, all code reviews get send to dev@, causing it to have a >>> huge >>> >> > > > mail volume (1777 messages in August). I feel dev@ might be more >>> >> > > > welcoming if it only included mails sent by humans; that way, new >>> >> > > > contributors don't have to worry about setting up filters right >>> away. >>> >> > > > CR emails could go to code-rev...@impala.incubator.apache.org or >>> >> > > > something else that the Apache infra people are willing to set up. >>> >> > > > >>> >> > > > What does everyone else think? >>> >> > > > >>> >> > > >>> >> > >>> >> >>> > >>> > >>> > >>> > -- >>> > Henry Robinson >>> > Software Engineer >>> > Cloudera >>> > 415-994-6679 >>>
Re: Sending Code Review emails to a different list
Tried to set it up here: https://infra.apache.org/officers/mlreq/incubator But it turns out "Only Members and Officers (this includes all PMC chairs) can submit the form." Todd, I think you are an officer - could you submit this for us? List name: code-review Set Reply-To list header?: no Moderation: allow subscribers to post, moderate all others [n.b.: we'll need a workaround to allow posting by gerrit, but the Hipchat ASF infra room just told me that a moderator can send mail to code-review-allow-foo=b...@impala.incubator.apache.org to subscribe foo@bar to code-rev...@impala.incubator.apache.org] Moderators' addresses: jbap...@apache.org Notes: The impala code review tool forwards patches for code review and the comments on those patches to this list. On Thu, Sep 1, 2016 at 5:21 PM, Harrison Sheinblattwrote: > +1 (nonbinding) > > On Thu, Sep 1, 2016 at 5:18 PM, Matthew Jacobs wrote: > >> +1 >> >> On Thu, Sep 1, 2016 at 4:18 PM, Henry Robinson wrote: >> > Sounds good. >> > >> > On 1 September 2016 at 16:14, Sailesh Mukil >> wrote: >> > >> >> +1 >> >> >> >> On Thu, Sep 1, 2016 at 4:11 PM, Daniel Hecht >> wrote: >> >> >> >> > Sounds good to me. >> >> > >> >> > On Thu, Sep 1, 2016 at 4:04 PM, Alex Behm >> >> wrote: >> >> > >> >> > > Feels much better to have a separate cr list. +1 for this idea >> >> > > >> >> > > On Thu, Sep 1, 2016 at 3:57 PM, Jim Apple >> >> wrote: >> >> > > >> >> > > > Today, all code reviews get send to dev@, causing it to have a >> huge >> >> > > > mail volume (1777 messages in August). I feel dev@ might be more >> >> > > > welcoming if it only included mails sent by humans; that way, new >> >> > > > contributors don't have to worry about setting up filters right >> away. >> >> > > > CR emails could go to code-rev...@impala.incubator.apache.org or >> >> > > > something else that the Apache infra people are willing to set up. >> >> > > > >> >> > > > What does everyone else think? >> >> > > > >> >> > > >> >> > >> >> >> > >> > >> > >> > -- >> > Henry Robinson >> > Software Engineer >> > Cloudera >> > 415-994-6679 >>
Re: Sending Code Review emails to a different list
+1 (nonbinding) On Thu, Sep 1, 2016 at 5:18 PM, Matthew Jacobswrote: > +1 > > On Thu, Sep 1, 2016 at 4:18 PM, Henry Robinson wrote: > > Sounds good. > > > > On 1 September 2016 at 16:14, Sailesh Mukil > wrote: > > > >> +1 > >> > >> On Thu, Sep 1, 2016 at 4:11 PM, Daniel Hecht > wrote: > >> > >> > Sounds good to me. > >> > > >> > On Thu, Sep 1, 2016 at 4:04 PM, Alex Behm > >> wrote: > >> > > >> > > Feels much better to have a separate cr list. +1 for this idea > >> > > > >> > > On Thu, Sep 1, 2016 at 3:57 PM, Jim Apple > >> wrote: > >> > > > >> > > > Today, all code reviews get send to dev@, causing it to have a > huge > >> > > > mail volume (1777 messages in August). I feel dev@ might be more > >> > > > welcoming if it only included mails sent by humans; that way, new > >> > > > contributors don't have to worry about setting up filters right > away. > >> > > > CR emails could go to code-rev...@impala.incubator.apache.org or > >> > > > something else that the Apache infra people are willing to set up. > >> > > > > >> > > > What does everyone else think? > >> > > > > >> > > > >> > > >> > > > > > > > > -- > > Henry Robinson > > Software Engineer > > Cloudera > > 415-994-6679 >
Re: Sending Code Review emails to a different list
+1 On Thu, Sep 1, 2016 at 4:18 PM, Henry Robinsonwrote: > Sounds good. > > On 1 September 2016 at 16:14, Sailesh Mukil wrote: > >> +1 >> >> On Thu, Sep 1, 2016 at 4:11 PM, Daniel Hecht wrote: >> >> > Sounds good to me. >> > >> > On Thu, Sep 1, 2016 at 4:04 PM, Alex Behm >> wrote: >> > >> > > Feels much better to have a separate cr list. +1 for this idea >> > > >> > > On Thu, Sep 1, 2016 at 3:57 PM, Jim Apple >> wrote: >> > > >> > > > Today, all code reviews get send to dev@, causing it to have a huge >> > > > mail volume (1777 messages in August). I feel dev@ might be more >> > > > welcoming if it only included mails sent by humans; that way, new >> > > > contributors don't have to worry about setting up filters right away. >> > > > CR emails could go to code-rev...@impala.incubator.apache.org or >> > > > something else that the Apache infra people are willing to set up. >> > > > >> > > > What does everyone else think? >> > > > >> > > >> > >> > > > > -- > Henry Robinson > Software Engineer > Cloudera > 415-994-6679
Re: Sending Code Review emails to a different list
Sounds good. On 1 September 2016 at 16:14, Sailesh Mukilwrote: > +1 > > On Thu, Sep 1, 2016 at 4:11 PM, Daniel Hecht wrote: > > > Sounds good to me. > > > > On Thu, Sep 1, 2016 at 4:04 PM, Alex Behm > wrote: > > > > > Feels much better to have a separate cr list. +1 for this idea > > > > > > On Thu, Sep 1, 2016 at 3:57 PM, Jim Apple > wrote: > > > > > > > Today, all code reviews get send to dev@, causing it to have a huge > > > > mail volume (1777 messages in August). I feel dev@ might be more > > > > welcoming if it only included mails sent by humans; that way, new > > > > contributors don't have to worry about setting up filters right away. > > > > CR emails could go to code-rev...@impala.incubator.apache.org or > > > > something else that the Apache infra people are willing to set up. > > > > > > > > What does everyone else think? > > > > > > > > > > -- Henry Robinson Software Engineer Cloudera 415-994-6679
Re: Sending Code Review emails to a different list
+1 On Thu, Sep 1, 2016 at 4:11 PM, Daniel Hechtwrote: > Sounds good to me. > > On Thu, Sep 1, 2016 at 4:04 PM, Alex Behm wrote: > > > Feels much better to have a separate cr list. +1 for this idea > > > > On Thu, Sep 1, 2016 at 3:57 PM, Jim Apple wrote: > > > > > Today, all code reviews get send to dev@, causing it to have a huge > > > mail volume (1777 messages in August). I feel dev@ might be more > > > welcoming if it only included mails sent by humans; that way, new > > > contributors don't have to worry about setting up filters right away. > > > CR emails could go to code-rev...@impala.incubator.apache.org or > > > something else that the Apache infra people are willing to set up. > > > > > > What does everyone else think? > > > > > >
Re: Sending Code Review emails to a different list
Sounds good to me. On Thu, Sep 1, 2016 at 4:04 PM, Alex Behmwrote: > Feels much better to have a separate cr list. +1 for this idea > > On Thu, Sep 1, 2016 at 3:57 PM, Jim Apple wrote: > > > Today, all code reviews get send to dev@, causing it to have a huge > > mail volume (1777 messages in August). I feel dev@ might be more > > welcoming if it only included mails sent by humans; that way, new > > contributors don't have to worry about setting up filters right away. > > CR emails could go to code-rev...@impala.incubator.apache.org or > > something else that the Apache infra people are willing to set up. > > > > What does everyone else think? > > >
Re: Sending Code Review emails to a different list
Feels much better to have a separate cr list. +1 for this idea On Thu, Sep 1, 2016 at 3:57 PM, Jim Applewrote: > Today, all code reviews get send to dev@, causing it to have a huge > mail volume (1777 messages in August). I feel dev@ might be more > welcoming if it only included mails sent by humans; that way, new > contributors don't have to worry about setting up filters right away. > CR emails could go to code-rev...@impala.incubator.apache.org or > something else that the Apache infra people are willing to set up. > > What does everyone else think? >