Re: The structure of distribution

2022-10-22 Thread Chao Wang
+1




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/22/2022 15:15,Jialin Qiao wrote:
Hi,

In the new distribution folder, we move all these scripts into sbin folder.
Move the remove-datanode.sh into tools is also ok, we could rename it
to node-tool (support removing confignode and datanode).

node-tool.sh -r nodeid

What do you think?

Thanks,
—
Jialin Qiao
Apache IoTDB PMC

Chao Wang  于2022年10月22日周六 15:07写道:

Hi,


yes, it's a tool now,  sorry for my mistake.  And, move it to tools directory 
seems more suitable.




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/22/2022 14:49,Jialin Qiao wrote:
Hi,

If I don't misremember, the remove-datanode.sh is indeed a tool with
which we can remove any datanode in the cluster...

Thanks,
—
Jialin Qiao
Apache IoTDB PMC

Chao Wang  于2022年10月22日周六 14:43写道:

Hi,
I think "start-datanode.sh -r"  is ok, means start with remove mode.  The 
remove-datanode.sh seems more like a tool with which we can remove any datanode 
in the cluster.




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/22/2022 11:45,Jialin Qiao wrote:
Hi,

If we use one script, what should we naming it, start-datanode.sh or others?

Just feel "start-datanode.sh -r" look strange, user may also need to
read the UserGuide to find the removing function.
If we put remove-datanode.sh in sbin, users could find it directly under sbin.

Thanks,
—
Jialin Qiao
Apache IoTDB PMC

Chao Wang  于2022年10月22日周六 10:56写道:

And, why do we need remove-datanode.sh and remove-confignode.sh scripts? I 
think those two scripts need to be merged into start-datanode.sh and 
start-confignode.sh, after all, they only have one parameter diffierence.




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/21/2022 17:52,Chao Wang wrote:
+1




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/21/2022 09:15,Houliang Qi wrote:
+1




Thanks,
---
Houliang Qi
BONC, Ltd


 Replied Message 
| From | Jialin Qiao |
| Date | 10/20/2022 23:56 |
| To |  |
| Subject | Re: The structure of distribution |
+1
—
Jialin Qiao
Apache IoTDB PMC

Haonan Hou  于2022年10月20日周四 18:32写道:

Hi all,

We will release v1.0 in the nearly future, it's time to decide the final version
of distribution structure. After investigate other projects, like Hadoop and
Spark. I think it will be better that remove the confignode and datanode folder,
and combine their script and configuration files into the conf and sbin under
IOTDB_HOME. The design document is in [1].

I also submitted a PR[2] to make such changes, in where you can find the
screenshot of new structure.

[1] https://apache-iotdb.feishu.cn/docx/doxcnFpCzjZadvMPQHUROW4mrTe
[2] https://github.com/apache/iotdb/pull/7672

Best,
—
Haonan Hou




Re: The structure of distribution

2022-10-22 Thread Jialin Qiao
Hi,

In the new distribution folder, we move all these scripts into sbin folder.
Move the remove-datanode.sh into tools is also ok, we could rename it
to node-tool (support removing confignode and datanode).

node-tool.sh -r nodeid

What do you think?

Thanks,
—
Jialin Qiao
Apache IoTDB PMC

Chao Wang  于2022年10月22日周六 15:07写道:
>
> Hi,
>
>
> yes, it's a tool now,  sorry for my mistake.  And, move it to tools 
> directory seems more suitable.
>
>
>
>
> Thanks!
>
>
> Chao Wang
> BONC ltd
> ccgow...@163.com
> On 10/22/2022 14:49,Jialin Qiao wrote:
> Hi,
>
> If I don't misremember, the remove-datanode.sh is indeed a tool with
> which we can remove any datanode in the cluster...
>
> Thanks,
> —
> Jialin Qiao
> Apache IoTDB PMC
>
> Chao Wang  于2022年10月22日周六 14:43写道:
>
> Hi,
> I think "start-datanode.sh -r"  is ok, means start with remove mode.  The 
> remove-datanode.sh seems more like a tool with which we can remove any 
> datanode in the cluster.
>
>
>
>
> Thanks!
>
>
> Chao Wang
> BONC ltd
> ccgow...@163.com
> On 10/22/2022 11:45,Jialin Qiao wrote:
> Hi,
>
> If we use one script, what should we naming it, start-datanode.sh or others?
>
> Just feel "start-datanode.sh -r" look strange, user may also need to
> read the UserGuide to find the removing function.
> If we put remove-datanode.sh in sbin, users could find it directly under sbin.
>
> Thanks,
> —
> Jialin Qiao
> Apache IoTDB PMC
>
> Chao Wang  于2022年10月22日周六 10:56写道:
>
> And, why do we need remove-datanode.sh and remove-confignode.sh scripts? I 
> think those two scripts need to be merged into start-datanode.sh and 
> start-confignode.sh, after all, they only have one parameter diffierence.
>
>
>
>
> Thanks!
>
>
> Chao Wang
> BONC ltd
> ccgow...@163.com
> On 10/21/2022 17:52,Chao Wang wrote:
> +1
>
>
>
>
> Thanks!
>
>
> Chao Wang
> BONC ltd
> ccgow...@163.com
> On 10/21/2022 09:15,Houliang Qi wrote:
> +1
>
>
>
>
> Thanks,
> ---
> Houliang Qi
> BONC, Ltd
>
>
>  Replied Message 
> | From | Jialin Qiao |
> | Date | 10/20/2022 23:56 |
> | To |  |
> | Subject | Re: The structure of distribution |
> +1
> —
> Jialin Qiao
> Apache IoTDB PMC
>
> Haonan Hou  于2022年10月20日周四 18:32写道:
>
> Hi all,
>
> We will release v1.0 in the nearly future, it's time to decide the final 
> version
> of distribution structure. After investigate other projects, like Hadoop and
> Spark. I think it will be better that remove the confignode and datanode 
> folder,
> and combine their script and configuration files into the conf and sbin under
> IOTDB_HOME. The design document is in [1].
>
> I also submitted a PR[2] to make such changes, in where you can find the
> screenshot of new structure.
>
> [1] https://apache-iotdb.feishu.cn/docx/doxcnFpCzjZadvMPQHUROW4mrTe
> [2] https://github.com/apache/iotdb/pull/7672
>
> Best,
> —
> Haonan Hou
>
>


Re: The structure of distribution

2022-10-22 Thread Chao Wang
Hi, 


yes, it's a tool now,  sorry for my mistake.  And, move it to tools 
directory seems more suitable.




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/22/2022 14:49,Jialin Qiao wrote:
Hi,

If I don't misremember, the remove-datanode.sh is indeed a tool with
which we can remove any datanode in the cluster...

Thanks,
—
Jialin Qiao
Apache IoTDB PMC

Chao Wang  于2022年10月22日周六 14:43写道:

Hi,
I think "start-datanode.sh -r"  is ok, means start with remove mode.  The 
remove-datanode.sh seems more like a tool with which we can remove any datanode 
in the cluster.




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/22/2022 11:45,Jialin Qiao wrote:
Hi,

If we use one script, what should we naming it, start-datanode.sh or others?

Just feel "start-datanode.sh -r" look strange, user may also need to
read the UserGuide to find the removing function.
If we put remove-datanode.sh in sbin, users could find it directly under sbin.

Thanks,
—
Jialin Qiao
Apache IoTDB PMC

Chao Wang  于2022年10月22日周六 10:56写道:

And, why do we need remove-datanode.sh and remove-confignode.sh scripts? I 
think those two scripts need to be merged into start-datanode.sh and 
start-confignode.sh, after all, they only have one parameter diffierence.




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/21/2022 17:52,Chao Wang wrote:
+1




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/21/2022 09:15,Houliang Qi wrote:
+1




Thanks,
---
Houliang Qi
BONC, Ltd


 Replied Message 
| From | Jialin Qiao |
| Date | 10/20/2022 23:56 |
| To |  |
| Subject | Re: The structure of distribution |
+1
—
Jialin Qiao
Apache IoTDB PMC

Haonan Hou  于2022年10月20日周四 18:32写道:

Hi all,

We will release v1.0 in the nearly future, it's time to decide the final version
of distribution structure. After investigate other projects, like Hadoop and
Spark. I think it will be better that remove the confignode and datanode folder,
and combine their script and configuration files into the conf and sbin under
IOTDB_HOME. The design document is in [1].

I also submitted a PR[2] to make such changes, in where you can find the
screenshot of new structure.

[1] https://apache-iotdb.feishu.cn/docx/doxcnFpCzjZadvMPQHUROW4mrTe
[2] https://github.com/apache/iotdb/pull/7672

Best,
—
Haonan Hou




Re: The structure of distribution

2022-10-22 Thread Jialin Qiao
Hi,

If I don't misremember, the remove-datanode.sh is indeed a tool with
which we can remove any datanode in the cluster...

Thanks,
—
Jialin Qiao
Apache IoTDB PMC

Chao Wang  于2022年10月22日周六 14:43写道:
>
> Hi,
>I think "start-datanode.sh -r"  is ok, means start with remove mode.  The 
> remove-datanode.sh seems more like a tool with which we can remove any 
> datanode in the cluster.
>
>
>
>
> Thanks!
>
>
> Chao Wang
> BONC ltd
> ccgow...@163.com
> On 10/22/2022 11:45,Jialin Qiao wrote:
> Hi,
>
> If we use one script, what should we naming it, start-datanode.sh or others?
>
> Just feel "start-datanode.sh -r" look strange, user may also need to
> read the UserGuide to find the removing function.
> If we put remove-datanode.sh in sbin, users could find it directly under sbin.
>
> Thanks,
> —
> Jialin Qiao
> Apache IoTDB PMC
>
> Chao Wang  于2022年10月22日周六 10:56写道:
>
> And, why do we need remove-datanode.sh and remove-confignode.sh scripts? I 
> think those two scripts need to be merged into start-datanode.sh and 
> start-confignode.sh, after all, they only have one parameter diffierence.
>
>
>
>
> Thanks!
>
>
> Chao Wang
> BONC ltd
> ccgow...@163.com
> On 10/21/2022 17:52,Chao Wang wrote:
> +1
>
>
>
>
> Thanks!
>
>
> Chao Wang
> BONC ltd
> ccgow...@163.com
> On 10/21/2022 09:15,Houliang Qi wrote:
> +1
>
>
>
>
> Thanks,
> ---
> Houliang Qi
> BONC, Ltd
>
>
>  Replied Message 
> | From | Jialin Qiao |
> | Date | 10/20/2022 23:56 |
> | To |  |
> | Subject | Re: The structure of distribution |
> +1
> —
> Jialin Qiao
> Apache IoTDB PMC
>
> Haonan Hou  于2022年10月20日周四 18:32写道:
>
> Hi all,
>
> We will release v1.0 in the nearly future, it's time to decide the final 
> version
> of distribution structure. After investigate other projects, like Hadoop and
> Spark. I think it will be better that remove the confignode and datanode 
> folder,
> and combine their script and configuration files into the conf and sbin under
> IOTDB_HOME. The design document is in [1].
>
> I also submitted a PR[2] to make such changes, in where you can find the
> screenshot of new structure.
>
> [1] https://apache-iotdb.feishu.cn/docx/doxcnFpCzjZadvMPQHUROW4mrTe
> [2] https://github.com/apache/iotdb/pull/7672
>
> Best,
> —
> Haonan Hou
>
>


Re: The structure of distribution

2022-10-22 Thread Chao Wang
Hi,
   I think "start-datanode.sh -r"  is ok, means start with remove mode.  The 
remove-datanode.sh seems more like a tool with which we can remove any datanode 
in the cluster.  




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/22/2022 11:45,Jialin Qiao wrote:
Hi,

If we use one script, what should we naming it, start-datanode.sh or others?

Just feel "start-datanode.sh -r" look strange, user may also need to
read the UserGuide to find the removing function.
If we put remove-datanode.sh in sbin, users could find it directly under sbin.

Thanks,
—
Jialin Qiao
Apache IoTDB PMC

Chao Wang  于2022年10月22日周六 10:56写道:

And, why do we need remove-datanode.sh and remove-confignode.sh scripts? I 
think those two scripts need to be merged into start-datanode.sh and 
start-confignode.sh, after all, they only have one parameter diffierence.




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/21/2022 17:52,Chao Wang wrote:
+1




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/21/2022 09:15,Houliang Qi wrote:
+1




Thanks,
---
Houliang Qi
BONC, Ltd


 Replied Message 
| From | Jialin Qiao |
| Date | 10/20/2022 23:56 |
| To |  |
| Subject | Re: The structure of distribution |
+1
—
Jialin Qiao
Apache IoTDB PMC

Haonan Hou  于2022年10月20日周四 18:32写道:

Hi all,

We will release v1.0 in the nearly future, it's time to decide the final version
of distribution structure. After investigate other projects, like Hadoop and
Spark. I think it will be better that remove the confignode and datanode folder,
and combine their script and configuration files into the conf and sbin under
IOTDB_HOME. The design document is in [1].

I also submitted a PR[2] to make such changes, in where you can find the
screenshot of new structure.

[1] https://apache-iotdb.feishu.cn/docx/doxcnFpCzjZadvMPQHUROW4mrTe
[2] https://github.com/apache/iotdb/pull/7672

Best,
—
Haonan Hou




Re: The structure of distribution

2022-10-21 Thread Jialin Qiao
Hi,

If we use one script, what should we naming it, start-datanode.sh or others?

Just feel "start-datanode.sh -r" look strange, user may also need to
read the UserGuide to find the removing function.
If we put remove-datanode.sh in sbin, users could find it directly under sbin.

Thanks,
—
Jialin Qiao
Apache IoTDB PMC

Chao Wang  于2022年10月22日周六 10:56写道:
>
> And, why do we need remove-datanode.sh and remove-confignode.sh scripts? I 
> think those two scripts need to be merged into start-datanode.sh and 
> start-confignode.sh, after all, they only have one parameter diffierence.
>
>
>
>
> Thanks!
>
>
> Chao Wang
> BONC ltd
> ccgow...@163.com
> On 10/21/2022 17:52,Chao Wang wrote:
> +1
>
>
>
>
> Thanks!
>
>
> Chao Wang
> BONC ltd
> ccgow...@163.com
> On 10/21/2022 09:15,Houliang Qi wrote:
> +1
>
>
>
>
> Thanks,
> ---
> Houliang Qi
> BONC, Ltd
>
>
> ---- Replied Message 
> | From | Jialin Qiao |
> | Date | 10/20/2022 23:56 |
> | To |  |
> | Subject | Re: The structure of distribution |
> +1
> —
> Jialin Qiao
> Apache IoTDB PMC
>
> Haonan Hou  于2022年10月20日周四 18:32写道:
>
> Hi all,
>
> We will release v1.0 in the nearly future, it's time to decide the final 
> version
> of distribution structure. After investigate other projects, like Hadoop and
> Spark. I think it will be better that remove the confignode and datanode 
> folder,
> and combine their script and configuration files into the conf and sbin under
> IOTDB_HOME. The design document is in [1].
>
> I also submitted a PR[2] to make such changes, in where you can find the
> screenshot of new structure.
>
> [1] https://apache-iotdb.feishu.cn/docx/doxcnFpCzjZadvMPQHUROW4mrTe
> [2] https://github.com/apache/iotdb/pull/7672
>
> Best,
> —
> Haonan Hou
>
>


Re: The structure of distribution

2022-10-21 Thread Chao Wang
And, why do we need remove-datanode.sh and remove-confignode.sh scripts? I 
think those two scripts need to be merged into start-datanode.sh and 
start-confignode.sh, after all, they only have one parameter diffierence.




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/21/2022 17:52,Chao Wang wrote:
+1




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/21/2022 09:15,Houliang Qi wrote:
+1




Thanks,
---
Houliang Qi
BONC, Ltd


 Replied Message 
| From | Jialin Qiao |
| Date | 10/20/2022 23:56 |
| To |  |
| Subject | Re: The structure of distribution |
+1
—
Jialin Qiao
Apache IoTDB PMC

Haonan Hou  于2022年10月20日周四 18:32写道:

Hi all,

We will release v1.0 in the nearly future, it's time to decide the final version
of distribution structure. After investigate other projects, like Hadoop and
Spark. I think it will be better that remove the confignode and datanode folder,
and combine their script and configuration files into the conf and sbin under
IOTDB_HOME. The design document is in [1].

I also submitted a PR[2] to make such changes, in where you can find the
screenshot of new structure.

[1] https://apache-iotdb.feishu.cn/docx/doxcnFpCzjZadvMPQHUROW4mrTe
[2] https://github.com/apache/iotdb/pull/7672

Best,
—
Haonan Hou




Re: The structure of distribution

2022-10-21 Thread Chao Wang
+1




Thanks!


Chao Wang
BONC ltd
ccgow...@163.com
On 10/21/2022 09:15,Houliang Qi wrote:
+1




Thanks,
---
Houliang Qi
BONC, Ltd


 Replied Message 
| From | Jialin Qiao |
| Date | 10/20/2022 23:56 |
| To |  |
| Subject | Re: The structure of distribution |
+1
—
Jialin Qiao
Apache IoTDB PMC

Haonan Hou  于2022年10月20日周四 18:32写道:

Hi all,

We will release v1.0 in the nearly future, it's time to decide the final version
of distribution structure. After investigate other projects, like Hadoop and
Spark. I think it will be better that remove the confignode and datanode folder,
and combine their script and configuration files into the conf and sbin under
IOTDB_HOME. The design document is in [1].

I also submitted a PR[2] to make such changes, in where you can find the
screenshot of new structure.

[1] https://apache-iotdb.feishu.cn/docx/doxcnFpCzjZadvMPQHUROW4mrTe
[2] https://github.com/apache/iotdb/pull/7672

Best,
—
Haonan Hou




Re: The structure of distribution

2022-10-20 Thread Houliang Qi
+1




Thanks,
---
Houliang Qi
BONC, Ltd


 Replied Message 
| From | Jialin Qiao |
| Date | 10/20/2022 23:56 |
| To |  |
| Subject | Re: The structure of distribution |
+1
—
Jialin Qiao
Apache IoTDB PMC

Haonan Hou  于2022年10月20日周四 18:32写道:

Hi all,

We will release v1.0 in the nearly future, it's time to decide the final version
of distribution structure. After investigate other projects, like Hadoop and
Spark. I think it will be better that remove the confignode and datanode folder,
and combine their script and configuration files into the conf and sbin under
IOTDB_HOME. The design document is in [1].

I also submitted a PR[2] to make such changes, in where you can find the
screenshot of new structure.

[1] https://apache-iotdb.feishu.cn/docx/doxcnFpCzjZadvMPQHUROW4mrTe
[2] https://github.com/apache/iotdb/pull/7672

Best,
—
Haonan Hou




Re: The structure of distribution

2022-10-20 Thread Jialin Qiao
+1
—
Jialin Qiao
Apache IoTDB PMC

Haonan Hou  于2022年10月20日周四 18:32写道:
>
> Hi all,
>
> We will release v1.0 in the nearly future, it's time to decide the final 
> version
> of distribution structure. After investigate other projects, like Hadoop and
> Spark. I think it will be better that remove the confignode and datanode 
> folder,
> and combine their script and configuration files into the conf and sbin under
> IOTDB_HOME. The design document is in [1].
>
> I also submitted a PR[2] to make such changes, in where you can find the
> screenshot of new structure.
>
> [1] https://apache-iotdb.feishu.cn/docx/doxcnFpCzjZadvMPQHUROW4mrTe
> [2] https://github.com/apache/iotdb/pull/7672
>
> Best,
> —
> Haonan Hou
>
>


The structure of distribution

2022-10-20 Thread Haonan Hou
Hi all,

We will release v1.0 in the nearly future, it's time to decide the final version
of distribution structure. After investigate other projects, like Hadoop and 
Spark. I think it will be better that remove the confignode and datanode folder,
and combine their script and configuration files into the conf and sbin under 
IOTDB_HOME. The design document is in [1]. 

I also submitted a PR[2] to make such changes, in where you can find the
screenshot of new structure.

[1] https://apache-iotdb.feishu.cn/docx/doxcnFpCzjZadvMPQHUROW4mrTe
[2] https://github.com/apache/iotdb/pull/7672

Best,
—
Haonan Hou




Re: The structure of distribution

2022-07-11 Thread Haonan Hou
Hi,
 
I have a question.

If users would like to extend a standalone IoTDB to cluster, is it a good idea 
that
separate standalone and datanode to different directories?

Best,
Haonan Hou

> On Jul 12, 2022, at 9:19 AM, SpriCoder  wrote:
> 
> Finally, From my perspective, one possible structure like below:
> 
> 
> .
> ├── LICENSE
> ├── NOTICE
> ├── README.md
> ├── README_ZH.md
> ├── RELEASE_NOTES.md
> ├── sbin
> │ ├── start-cli.bat
> │ └── start-cli.sh
> 
> ├── confignode
> │ ├── conf
> │ │ ├── confignode-env.bat
> │ │ ├── confignode-env.sh
> │ │ ├── iotdb-confignode.properties
> │ │ ├── iotdb-metric.yml
> │ │ ├── jmx.access
> │ │ ├── jmx.password
> │ │ ├── logback-tool.xml
> │ │ └── logback.xml
> │ └── sbin
> │   ├── remove-confignode.sh
> │   ├── start-confignode.bat
> │   ├── start-confignode.sh
> │   ├── stop-confignode.bat
> │   └── stop-confignode.sh
> ├── datanode
> │ ├── conf
> │ │ ├── datanode-env.bat
> │ │ ├── datanode-env.sh
> │ │ ├── iotdb-datanode.properties
> │ │ ├── iotdb-metric.yml
> │ │ ├── iotdb-rest.properties
> │ │ ├── jmx.access
> │ │ ├── jmx.password
> │ │ ├── logback-tool.xml
> │ │ └── logback.xml
> │ └── sbin
> │   ├── remove-datanode.bat
> │   ├── remove-datanode.sh
> │   ├── start-datanode.bat
> │   ├── start-datanode.sh
> │   ├── stop-datanode.bat
> │   └── stop-datanode.sh
> ├── standalone
> │ ├── conf
> │ │ ├── datanode-env.bat
> │ │ ├── datanode-env.sh
> │ │ ├── iotdb-datanode.properties
> │ │ ├── iotdb-metric.yml
> │ │ ├── iotdb-rest.properties
> │ │ ├── jmx.access
> │ │ ├── jmx.password
> │ │ ├── logback-tool.xml
> │ │ └── logback.xml
> │ └── sbin
> │   ├── start-new-server.bat
> │   ├── start-new-server.sh
> │   ├── start-server.bat
> │   ├── start-server.sh
> │   ├── stop-server.bat
> │   └── stop-server.sh
> 
> ├── docs
> ├── grafana-metrics-example
> ├── lib
> ├── licenses
> └── tools
> 
> 
> 
> 
> 
> 
> 
> --Original--
> From: 
>"SpriCoder"
> 
>  Date:Tue, Jul 5, 2022 05:54 PM
> To:"dev" 
> Subject:The structure of distribution
> 
> 
> 
> Hi all,
> 
> Currently, we have confignode and datanode folder in the distribution. Which 
> has conf, sbin, and will store the default folder of data and system. And 
> there is a need to refactor distribution structure.
> 
> I think there are two choices:
> 
> 1. remove the confignode and datanode folder, and combine their script and 
> configuration files into the conf and sbin under the root. In this way all 
> folder generated by confignode will be put into config folder, and all folder 
> generated by confignode will be put into data folder.
> 
> 2. use confignode and datanode folder to manage their script and 
> configuration files, like: confignode/sbin, confignode/conf, datanode/sbin, 
> datanode/conf, etc. In this way all folder generated by confignode will be 
> put into confignode folder and all folder generated by datanode will be put 
> into datanode folder.
> 
> 
> 
> 
> What's your opinion? Looking forward to your reply.
> 
> 
> Best,
> 
> ---
> 
> Hongyin Zhang



Re:The structure of distribution

2022-07-11 Thread SpriCoder
Finally, From my perspective, one possible structure like below:


.
?? LICENSE
?? NOTICE
?? README.md
?? README_ZH.md
?? RELEASE_NOTES.md
?? sbin
?? ?? start-cli.bat
?? ?? start-cli.sh

?? confignode
?? ?? conf
?? ?? ?? confignode-env.bat
?? ?? ?? confignode-env.sh
?? ?? ?? iotdb-confignode.properties
?? ?? ?? iotdb-metric.yml
?? ?? ?? jmx.access
?? ?? ?? jmx.password
?? ?? ?? logback-tool.xml
?? ?? ?? logback.xml
?? ?? sbin
??   ?? remove-confignode.sh
??   ?? start-confignode.bat
??   ?? start-confignode.sh
??   ?? stop-confignode.bat
??   ?? stop-confignode.sh
?? datanode
?? ?? conf
?? ?? ?? datanode-env.bat
?? ?? ?? datanode-env.sh
?? ?? ?? iotdb-datanode.properties
?? ?? ?? iotdb-metric.yml
?? ?? ?? iotdb-rest.properties
?? ?? ?? jmx.access
?? ?? ?? jmx.password
?? ?? ?? logback-tool.xml
?? ?? ?? logback.xml
?? ?? sbin
??   ?? remove-datanode.bat
??   ?? remove-datanode.sh
??   ?? start-datanode.bat
??   ?? start-datanode.sh
??   ?? stop-datanode.bat
??   ?? stop-datanode.sh
?? standalone
?? ?? conf
?? ?? ?? datanode-env.bat
?? ?? ?? datanode-env.sh
?? ?? ?? iotdb-datanode.properties
?? ?? ?? iotdb-metric.yml
?? ?? ?? iotdb-rest.properties
?? ?? ?? jmx.access
?? ?? ?? jmx.password
?? ?? ?? logback-tool.xml
?? ?? ?? logback.xml
?? ?? sbin
??   ?? start-new-server.bat
??   ?? start-new-server.sh
??   ?? start-server.bat
??   ?? start-server.sh
??   ?? stop-server.bat
??   ?? stop-server.sh

?? docs
?? grafana-metrics-example
?? lib
?? licenses
?? tools







--Original--
From:   
 "SpriCoder"



Re: The structure of distribution

2022-07-07 Thread Jialin Qiao
Hi,

Apart from the start-server.sh, The start-cli.sh is also weird in datanode 
folder.

Besides, we may have start-all.sh in the future. There may need a sbin in the 
parent folder.

Jialin Qiao

On 2022/07/05 09:54:25 SpriCoder wrote:
> Hi all,
> 
> Currently, we have confignode and datanode folder in the distribution. Which 
> has conf, sbin, and will store the default folder of data and system. And 
> there is a need to refactor distribution structure.
> 
> I think there are two choices:
> 
> 1. remove the confignode and datanode folder, and combine their script and 
> configuration files into the conf and sbin under the root. In this way all 
> folder generated by confignode will be put into config folder, and all folder 
> generated by confignode will be put into data folder.
> 
> 2. use confignode and datanode folder to manage their script and 
> configuration files, like: confignode/sbin, confignode/conf, datanode/sbin, 
> datanode/conf, etc. In this way all folder generated by confignode will be 
> put into confignode folder and all folder generated by datanode will be put 
> into datanode folder.
>  
> 
> 
> 
> What's your opinion? Looking forward to your reply.
> 
> 
> Best,
> 
> ---
> 
> Hongyin Zhang


Re:The structure of distribution

2022-07-07 Thread SpriCoder
I think maybe the binary name can still 
called"apache-iotdb-{version}-bin-all.zip" if we add standalone folder to 
store our singleton version?
?? confignode
   ?? conf
   ?? data
   ?? ext
   ?? logs
   ?? sbin ?? datanode
   ?? conf
   ?? data
   ?? logs
   ?? sbin
?? standalone
   ?? conf
   ?? data
   ?? logs
   ?? sbin

?? lib
As for the second question, I think maybe we can add sbin folder in root folder 
to hold cluster-related scripts like:
?? sbin
?? confignode
   ?? conf
   ?? data
   ?? ext
   ?? logs
   ?? sbin ?? datanode
   ?? conf
   ?? data
   ?? logs
   ?? sbin
?? standalone
   ?? conf
   ?? data
   ?? logs
   ?? sbin

?? lib


What's your opinion? Looking forward to your suggestion!



Best,

---

Hongyin Zhang



--Original--
From:   
 "SpriCoder"



Re: The structure of distribution

2022-07-07 Thread Xiangdong Huang
Hi,
if we use the structure 2, the binary release name
"apache-iotdb-{version}-bin-all.zip" should be changed
(to "apache-iotdb-{version}-bin-cluster.zip". As the structure does
not fit the singleton release version.

The start-server.sh (or start-new-server.sh) script should also be
removed. It will be confused that
why I need to use "datanode" or "confignode" if I want to just use a
start-new-server

Best,
---
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院

SpriCoder  于2022年7月6日周三 17:08写道:
>
> Get it!
>
>
>
>
> --Original--
> From: 
>"SpriCoder"
>     
>  Date:Tue, Jul 5, 2022 05:54 PM
> To:"dev"
> Subject:The structure of distribution
>
>
>
> Hi all,
>
> Currently, we have confignode and datanode folder in the distribution. Which 
> has conf, sbin, and will store the default folder of data and system. And 
> there is a need to refactor distribution structure.
>
> I think there are two choices:
>
> 1. remove the confignode and datanode folder, and combine their script and 
> configuration files into the conf and sbin under the root. In this way all 
> folder generated by confignode will be put into config folder, and all folder 
> generated by confignode will be put into data folder.
>
> 2. use confignode and datanode folder to manage their script and 
> configuration files, like: confignode/sbin, confignode/conf, datanode/sbin, 
> datanode/conf, etc. In this way all folder generated by confignode will be 
> put into confignode folder and all folder generated by datanode will be put 
> into datanode folder.
>
>
>
>
> What's your opinion? Looking forward to your reply.
>
>
> Best,
>
> ---
>
> Hongyin Zhang


Re:The structure of distribution

2022-07-06 Thread SpriCoder
Get it!




--Original--
From:   
 "SpriCoder"



Re: The structure of distribution

2022-07-06 Thread Eric Pai
Got it. And we can change xxx-env.sh and xxx-env.bat with a wildcard classpath 
parameter to simplify the command.

The original classpath param is like this: lib/a.jar:lib/b.jar
It can be replaced by: lib/*

And please remember to test well both in Unix and Windows~

在 2022/7/6 16:59,“SpriCoder” 写入:

lib folder is a single one under root folder like:
├── datanode
├── confignode


├── lib




--Original--
From:   
 "SpriCoder"



Re:The structure of distribution

2022-07-06 Thread SpriCoder
lib folder is a single one under root folder like:
?? datanode
?? confignode


?? lib




--Original--
From:   
 "SpriCoder"



Re: The structure of distribution

2022-07-06 Thread Eric Pai
Where's the lib folder? A single one to share or just duplicated for each 
other? 

在 2022/7/6 12:04,“SpriCoder” 写入:

To more specific:
In Choice 1, folders in apache-iotdb-0.14.0-SNAPSHOT-all-bin will like that:
├── sbin
├── conf
├── config
 ├── data
 ├── ext
 ├── logs

├── data
 ├── data
 ├── logs



In Choice2, folder in apache-iotdb-0.14.0-SNAPSHOT-all-bin will like that:
├── confignode
 ├── conf
 ├── data
 ├── ext
 ├── logs
 └── sbin
├── datanode
 ├── conf
 ├── data
 ├── logs
 └── sbin







--Original--
From:   
 "SpriCoder"



Re: Re: The structure of distribution

2022-07-06 Thread Guanfei Guo
+3 for Choice 2



Thanks.
Guanfei Guo
 
From: HW-Chao Wang
Date: 2022-07-06 15:57
To: dev
Subject: Re: The structure of distribution
choice 2
 
 
 
---Original---
From: "gaoyang"<453935...@qq.com.INVALID
Date: Wed, Jul 6, 2022 15:53 PM
To: "dev"

Re: The structure of distribution

2022-07-06 Thread HW-Chao Wang
choice 2



---Original---
From: "gaoyang"<453935...@qq.com.INVALID
Date: Wed, Jul 6, 2022 15:53 PM
To: "dev"

Re: The structure of distribution

2022-07-06 Thread gaoyang
+1 for Choice 2

> 2022年7月5日 下午5:54,SpriCoder  写道:
> 
> Hi all,
> 
> Currently, we have confignode and datanode folder in the distribution. Which 
> has conf, sbin, and will store the default folder of data and system. And 
> there is a need to refactor distribution structure.
> 
> I think there are two choices:
> 
> 1. remove the confignode and datanode folder, and combine their script and 
> configuration files into the conf and sbin under the root. In this way all 
> folder generated by confignode will be put into config folder, and all folder 
> generated by confignode will be put into data folder.
> 
> 2. use confignode and datanode folder to manage their script and 
> configuration files, like: confignode/sbin, confignode/conf, datanode/sbin, 
> datanode/conf, etc. In this way all folder generated by confignode will be 
> put into confignode folder and all folder generated by datanode will be put 
> into datanode folder.
> 
> 
> 
> 
> What's your opinion? Looking forward to your reply.
> 
> 
> Best,
> 
> ---
> 
> Hongyin Zhang



Re:The structure of distribution

2022-07-05 Thread Yongzao Dan
I think choices 2 might be better, because this helps distinguish ConfigNode 
from DataNode Best,

---
Yongzao Dan






--Original--
From: "SpriCoder"

Re: The structure of distribution

2022-07-05 Thread 周钰坤
I think the choice 2 is better, since configNode and dataNode will be
deployed separately and multi-replica means the dir will be copied.

SpriCoder  于2022年7月6日周三 12:04写道:
>
> To more specific:
> In Choice 1, folders in apache-iotdb-0.14.0-SNAPSHOT-all-bin will like that:
> ├── sbin
> ├── conf
> ├── config
>  ├── data
>  ├── ext
>  ├── logs
>
> ├── data
>  ├── data
>  ├── logs
>
>
>
> In Choice2, folder in apache-iotdb-0.14.0-SNAPSHOT-all-bin will like that:
> ├── confignode
>  ├── conf
>  ├── data
>  ├── ext
>  ├── logs
>  └── sbin
> ├── datanode
>  ├── conf
>  ├── data
>  ├── logs
>  └── sbin
>
>
>
>
>
>
>
> --Original--
> From: 
>"SpriCoder"
>     
>  Date:Tue, Jul 5, 2022 05:54 PM
> To:"dev"
> Subject:The structure of distribution
>
>
>
> Hi all,
>
> Currently, we have confignode and datanode folder in the distribution. Which 
> has conf, sbin, and will store the default folder of data and system. And 
> there is a need to refactor distribution structure.
>
> I think there are two choices:
>
> 1. remove the confignode and datanode folder, and combine their script and 
> configuration files into the conf and sbin under the root. In this way all 
> folder generated by confignode will be put into config folder, and all folder 
> generated by confignode will be put into data folder.
>
> 2. use confignode and datanode folder to manage their script and 
> configuration files, like: confignode/sbin, confignode/conf, datanode/sbin, 
> datanode/conf, etc. In this way all folder generated by confignode will be 
> put into confignode folder and all folder generated by datanode will be put 
> into datanode folder.
>
>
>
>
> What's your opinion? Looking forward to your reply.
>
>
> Best,
>
> ---
>
> Hongyin Zhang


Re:The structure of distribution

2022-07-05 Thread SpriCoder
To more specific:
In Choice 1, folders in apache-iotdb-0.14.0-SNAPSHOT-all-bin will like that:
?? sbin
?? conf
?? config
 ?? data
 ?? ext
 ?? logs

?? data
 ?? data
 ?? logs



In Choice2, folder in apache-iotdb-0.14.0-SNAPSHOT-all-bin will like that:
?? confignode
 ?? conf
 ?? data
 ?? ext
 ?? logs
 ?? sbin
?? datanode
 ?? conf
 ?? data
 ?? logs
 ?? sbin







--Original--
From:   
 "SpriCoder"



The structure of distribution

2022-07-05 Thread SpriCoder
Hi all,

Currently, we have confignode and datanode folder in the distribution. Which 
has conf, sbin, and will store the default folder of data and system. And there 
is a need to refactor distribution structure.

I think there are two choices:

1. remove the confignode and datanode folder, and combine their script and 
configuration files into the conf and sbin under the root. In this way all 
folder generated by confignode will be put into config folder, and all folder 
generated by confignode will be put into data folder.

2. use confignode and datanode folder to manage their script and configuration 
files, like: confignode/sbin, confignode/conf, datanode/sbin, datanode/conf, 
etc. In this way all folder generated by confignode will be put into confignode 
folder and all folder generated by datanode will be put into datanode folder.
 



What's your opinion? Looking forward to your reply.


Best,

---

Hongyin Zhang