[jira] [Commented] (ISIS-903) Improve i18n support (in NamedFacetDecorator etc) to honour client-side locale.
[ https://issues.apache.org/jira/browse/ISIS-903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152834#comment-14152834 ] Dan Haywood commented on ISIS-903: -- some notes on how to go about doing this ticket: ~ the first thing to do is to create a fork of our github repo [1], and then make sure you can build Isis locally from this [2]. Then, set up the todo app (in examples/application/todoapp) to run from your IDE... it's a useful playground. In the todoapp's WEB-INF/isis.properties you should see that there is the line: isis.reflector.facet-decorators=org.apache.isis.core.metamodel.facetdecorator.i18n.resourcebundle.I18nDecoratorUsingResourceBundleInstaller Set a breakpoint in I18nDecoratorUsingResourceBundleInstaller and then watch what it does: basically it's a factory that returns a NamedFacet (or DescribedAsFacet or HelpFacet) that decorates/wraps the original facet. Facets are the bits of metadata that we associate with the classes and class members. What you then could do is to copy I18nDecoratorUsingResourceBundleInstaller and related classes (eg NamedFacetWrapI18n), and then configure your copy in isis.properties. The main bit of the puzzle is to get hold of the locale. This will need to be in your (copy of) NamedFacetWrapI18n, so that it gets hold of the locale of the current user (eg using AuthenticatedWebSessionForIsis.get().getLocale() or similar) and uses that to lookup the correct resource bundle. [1] https://github.com/apache/isis [2] http://isis.apache.org/contributors/building-isis.html Improve i18n support (in NamedFacetDecorator etc) to honour client-side locale. --- Key: ISIS-903 URL: https://issues.apache.org/jira/browse/ISIS-903 Project: Isis Issue Type: Improvement Components: Core Affects Versions: core-1.6.0 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: core-1.8.0 from the mailing list: http://markmail.org/message/wifsrte2p2q6tces ok, here's the scoop. It *is* possible to add i18n for Isis apps, but the implementation we have reflects the locale of the server, rather than the client. If client-side i18n is what you require then it ought to be possible to implement a different implementation of I18nFacetDecoratorInstaller. You can get hold of the user's locale using: AuthenticatedWebSessionForIsis.get().getLocale() -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-899) Can't return a view model in Isis 1.6.0 over RO viewer.
[
https://issues.apache.org/jira/browse/ISIS-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153004#comment-14153004
]
Vladimir Nisevic commented on ISIS-899:
---
Hi Jeroen, Dan. I've just tested my two ViewModel classes with latest master
version - I've put my code into todoapp-dom project and recompiled.
Domain Service:
{code}
@Named(Address Search API)
@DomainService(menuOrder = 1.3)
public class AsePublicService {
@Render(Type.EAGERLY)
public Address getAddress(@Named(Source System) final String
sourceSystem, @Named(User) final String user, @Named(Agent) final String
agent, @Named(LKMS-ID) final String lkmsId, @Named(Valid Location) final
boolean validLocation) {
final Address address = new Address();
address.setHousenumber(12);
Street street = new Street();
street.setStreetname(5th Avenue);
address.setStreet(street);
return address;
}
{code}
package a1.ase.viewmodel;
import org.apache.isis.applib.annotation.MemberOrder;
import org.apache.isis.applib.annotation.ViewModel;
@ViewModel
public class Address {
public String title() {
return Address lkmsId: + lkmsId;
}
// {{ LkmsId (property)
private String lkmsId;
@MemberOrder(sequence = 1)
public String getLkmsId() {
return lkmsId;
}
public void setLkmsId(final String lkmsId) {
this.lkmsId = lkmsId;
}
// }}
// {{ Street (property)
private Street street;
@MemberOrder(sequence = 3)
public Street getStreet() {
return street;
}
public void setStreet(final Street street) {
this.street = street;
}
// }}
// {{ Housenumber (property)
private String housenumber;
@MemberOrder(sequence = 2)
public String getHousenumber() {
return housenumber;
}
public void setHousenumber(final String housenumber) {
this.housenumber = housenumber;
}
// }}
}
}
{code}
Street Model:
{code}
package a1.ase.viewmodel;
import org.apache.isis.applib.annotation.MemberOrder;
import org.apache.isis.applib.annotation.ViewModel;
@ViewModel
public class Street {
public String title() {
return Street lkmsId: + lkmsId;
}
// {{ LkmsId (property)
private String lkmsId;
@MemberOrder(sequence = 1)
public String getLkmsId() {
return lkmsId;
}
public void setLkmsId(final String lkmsId) {
this.lkmsId = lkmsId;
}
// }}
// {{ Streetname (property)
private String streetname;
@MemberOrder(sequence = 2)
public String getStreetname() {
return streetname;
}
public void setStreetname(final String aName) {
this.streetname = aName;
}
// }}
}
{code}
Here my feedback
1.) using wicket viewer and calling the method getAddress, I get next exception
{code}
Stack trace:
org.apache.isis.core.runtime.persistence.PojoRecreationException
Could not recreate pojo for oid oid
*a1.ase.viewmodel.Address:PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPG1lbWVudG8-PGhvdXNlbnVtYmVyPjEyPC9ob3VzZW51bWJlcj48c3RyZWV0LmJvb2ttYXJrPmExLmFzZS52aWV3bW9kZWwuU3RyZWV0OlBEOTRiV3dnZG1WeWMybHZiajBpTVM0d0lpQmxibU52WkdsdVp6MGlWVlJHTFRnaVB6NEtQRzFsYldWdWRHOC1QSE4wY21WbGRHNWhiV1UtTlhSb0lFRjJaVzUxWlR3dmMzUnlaV1YwYm1GdFpUNDhMMjFsYldWdWRHOC08L3N0cmVldC5ib29rbWFyaz48L21lbWVudG8-
org.apache.isis.core.runtime.persistence.adaptermanager.AdapterManagerDefault#adapterFor(AdapterManagerDefault.java:311)
org.apache.isis.viewer.wicket.model.mementos.ObjectAdapterMemento$Type$2#recreateAdapter(ObjectAdapterMemento.java:112)
org.apache.isis.viewer.wicket.model.mementos.ObjectAdapterMemento$Type#getAdapter(ObjectAdapterMemento.java:183)
org.apache.isis.viewer.wicket.model.m
{code}
2.) using restul viewer and calling
http://localhost:8080/restful/services/toDoItems/actions/newToDo/invoke with
parameters
{code}
{
sourceSystem: {value: CRM},
user: {value: user1},
agent: {value: agent1},
lKMS-ID: {value: 123},
validLocation: {value: true}
}
{code}
I get this result
{code}
STATUS 200 OK
TIME 118 ms
Pretty Raw Preview Copy
{code}
Can't return a view model in Isis 1.6.0 over RO viewer.
---
Key: ISIS-899
URL: https://issues.apache.org/jira/browse/ISIS-899
Project: Isis
Issue Type: Bug
Components: Core: Viewer: RestfulObjects
Affects Versions: core-1.6.0
Reporter: Dan Haywood
Assignee: Dan Haywood
Fix For: core-1.7.0
Attachments: Address.java, AsePublicService.java, Street.java,
Wicket.png
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (ISIS-899) Can't return a view model in Isis 1.6.0 over RO viewer.
[
https://issues.apache.org/jira/browse/ISIS-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153004#comment-14153004
]
Vladimir Nisevic edited comment on ISIS-899 at 9/30/14 9:21 AM:
Hi Jeroen, Dan. I've just tested my two ViewModel classes with latest master
version - I've put my code into todoapp-dom project and recompiled.
Domain Service:
{code}
@Named(Address Search API)
@DomainService(menuOrder = 1.3)
public class AsePublicService {
@Render(Type.EAGERLY)
public Address getAddress(@Named(Source System) final String
sourceSystem, @Named(User) final String user, @Named(Agent) final String
agent, @Named(LKMS-ID) final String lkmsId, @Named(Valid Location) final
boolean validLocation) {
final Address address = new Address();
address.setHousenumber(12);
Street street = new Street();
street.setStreetname(5th Avenue);
address.setStreet(street);
return address;
}
{code}
Address Model:
{code}
package a1.ase.viewmodel;
import org.apache.isis.applib.annotation.MemberOrder;
import org.apache.isis.applib.annotation.ViewModel;
@ViewModel
public class Address {
public String title() {
return Address lkmsId: + lkmsId;
}
// {{ LkmsId (property)
private String lkmsId;
@MemberOrder(sequence = 1)
public String getLkmsId() {
return lkmsId;
}
public void setLkmsId(final String lkmsId) {
this.lkmsId = lkmsId;
}
// }}
// {{ Street (property)
private Street street;
@MemberOrder(sequence = 3)
public Street getStreet() {
return street;
}
public void setStreet(final Street street) {
this.street = street;
}
// }}
// {{ Housenumber (property)
private String housenumber;
@MemberOrder(sequence = 2)
public String getHousenumber() {
return housenumber;
}
public void setHousenumber(final String housenumber) {
this.housenumber = housenumber;
}
// }}
}
}
{code}
Street Model:
{code}
package a1.ase.viewmodel;
import org.apache.isis.applib.annotation.MemberOrder;
import org.apache.isis.applib.annotation.ViewModel;
@ViewModel
public class Street {
public String title() {
return Street lkmsId: + lkmsId;
}
// {{ LkmsId (property)
private String lkmsId;
@MemberOrder(sequence = 1)
public String getLkmsId() {
return lkmsId;
}
public void setLkmsId(final String lkmsId) {
this.lkmsId = lkmsId;
}
// }}
// {{ Streetname (property)
private String streetname;
@MemberOrder(sequence = 2)
public String getStreetname() {
return streetname;
}
public void setStreetname(final String aName) {
this.streetname = aName;
}
// }}
}
{code}
Here my feedback
1.) using wicket viewer and calling the method getAddress, I get next exception
{code}
Stack trace:
org.apache.isis.core.runtime.persistence.PojoRecreationException
Could not recreate pojo for oid oid
*a1.ase.viewmodel.Address:PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPG1lbWVudG8-PGhvdXNlbnVtYmVyPjEyPC9ob3VzZW51bWJlcj48c3RyZWV0LmJvb2ttYXJrPmExLmFzZS52aWV3bW9kZWwuU3RyZWV0OlBEOTRiV3dnZG1WeWMybHZiajBpTVM0d0lpQmxibU52WkdsdVp6MGlWVlJHTFRnaVB6NEtQRzFsYldWdWRHOC1QSE4wY21WbGRHNWhiV1UtTlhSb0lFRjJaVzUxWlR3dmMzUnlaV1YwYm1GdFpUNDhMMjFsYldWdWRHOC08L3N0cmVldC5ib29rbWFyaz48L21lbWVudG8-
org.apache.isis.core.runtime.persistence.adaptermanager.AdapterManagerDefault#adapterFor(AdapterManagerDefault.java:311)
org.apache.isis.viewer.wicket.model.mementos.ObjectAdapterMemento$Type$2#recreateAdapter(ObjectAdapterMemento.java:112)
org.apache.isis.viewer.wicket.model.mementos.ObjectAdapterMemento$Type#getAdapter(ObjectAdapterMemento.java:183)
org.apache.isis.viewer.wicket.model.m
{code}
2.) using restul viewer and calling
http://localhost:8080/restful/services/toDoItems/actions/newToDo/invoke with
parameters
{code}
{
sourceSystem: {value: CRM},
user: {value: user1},
agent: {value: agent1},
lKMS-ID: {value: 123},
validLocation: {value: true}
}
{code}
I get this result
{code}
STATUS 200 OK
TIME 118 ms
Pretty Raw Preview Copy
{code}
was (Author: niv):
Hi Jeroen, Dan. I've just tested my two ViewModel classes with latest master
version - I've put my code into todoapp-dom project and recompiled.
Domain Service:
{code}
@Named(Address Search API)
@DomainService(menuOrder = 1.3)
public class AsePublicService {
@Render(Type.EAGERLY)
public Address getAddress(@Named(Source System) final String
sourceSystem, @Named(User) final String user, @Named(Agent) final String
agent, @Named(LKMS-ID) final String lkmsId, @Named(Valid Location) final
boolean validLocation) {
final Address address = new Address();
address.setHousenumber(12);
Street street = new Street();
street.setStreetname(5th Avenue);
[jira] [Comment Edited] (ISIS-899) Can't return a view model in Isis 1.6.0 over RO viewer.
[
https://issues.apache.org/jira/browse/ISIS-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153004#comment-14153004
]
Vladimir Nisevic edited comment on ISIS-899 at 9/30/14 9:22 AM:
Hi Jeroen, Dan. I've just tested my two ViewModel classes with latest master
version - I've put my code into todoapp-dom project and recompiled.
Domain Service:
{code}
@Named(Address Search API)
@DomainService(menuOrder = 1.3)
public class AsePublicService {
@Render(Type.EAGERLY)
public Address getAddress(@Named(Source System) final String
sourceSystem, @Named(User) final String user, @Named(Agent) final String
agent, @Named(LKMS-ID) final String lkmsId, @Named(Valid Location) final
boolean validLocation) {
final Address address = new Address();
address.setHousenumber(12);
Street street = new Street();
street.setStreetname(5th Avenue);
address.setStreet(street);
return address;
}
{code}
Address Model:
{code}
package a1.ase.viewmodel;
import org.apache.isis.applib.annotation.MemberOrder;
import org.apache.isis.applib.annotation.ViewModel;
@ViewModel
public class Address {
public String title() {
return Address lkmsId: + lkmsId;
}
// {{ LkmsId (property)
private String lkmsId;
@MemberOrder(sequence = 1)
public String getLkmsId() {
return lkmsId;
}
public void setLkmsId(final String lkmsId) {
this.lkmsId = lkmsId;
}
// }}
// {{ Street (property)
private Street street;
@MemberOrder(sequence = 3)
public Street getStreet() {
return street;
}
public void setStreet(final Street street) {
this.street = street;
}
// }}
// {{ Housenumber (property)
private String housenumber;
@MemberOrder(sequence = 2)
public String getHousenumber() {
return housenumber;
}
public void setHousenumber(final String housenumber) {
this.housenumber = housenumber;
}
// }}
}
}
{code}
Street Model:
{code}
package a1.ase.viewmodel;
import org.apache.isis.applib.annotation.MemberOrder;
import org.apache.isis.applib.annotation.ViewModel;
@ViewModel
public class Street {
public String title() {
return Street lkmsId: + lkmsId;
}
// {{ LkmsId (property)
private String lkmsId;
@MemberOrder(sequence = 1)
public String getLkmsId() {
return lkmsId;
}
public void setLkmsId(final String lkmsId) {
this.lkmsId = lkmsId;
}
// }}
// {{ Streetname (property)
private String streetname;
@MemberOrder(sequence = 2)
public String getStreetname() {
return streetname;
}
public void setStreetname(final String aName) {
this.streetname = aName;
}
// }}
}
{code}
Here my feedback
1.) using wicket viewer and calling the method getAddress, I get next exception
{code}
Stack trace:
org.apache.isis.core.runtime.persistence.PojoRecreationException
Could not recreate pojo for oid oid
*a1.ase.viewmodel.Address:PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPG1lbWVudG8-PGhvdXNlbnVtYmVyPjEyPC9ob3VzZW51bWJlcj48c3RyZWV0LmJvb2ttYXJrPmExLmFzZS52aWV3bW9kZWwuU3RyZWV0OlBEOTRiV3dnZG1WeWMybHZiajBpTVM0d0lpQmxibU52WkdsdVp6MGlWVlJHTFRnaVB6NEtQRzFsYldWdWRHOC1QSE4wY21WbGRHNWhiV1UtTlhSb0lFRjJaVzUxWlR3dmMzUnlaV1YwYm1GdFpUNDhMMjFsYldWdWRHOC08L3N0cmVldC5ib29rbWFyaz48L21lbWVudG8-
org.apache.isis.core.runtime.persistence.adaptermanager.AdapterManagerDefault#adapterFor(AdapterManagerDefault.java:311)
org.apache.isis.viewer.wicket.model.mementos.ObjectAdapterMemento$Type$2#recreateAdapter(ObjectAdapterMemento.java:112)
org.apache.isis.viewer.wicket.model.mementos.ObjectAdapterMemento$Type#getAdapter(ObjectAdapterMemento.java:183)
org.apache.isis.viewer.wicket.model.m
{code}
2.) using restul viewer and calling
http://localhost:8080/restful/services/toDoItems/actions/newToDo/invoke with
parameters
{code}
{
sourceSystem: {value: CRM},
user: {value: user1},
agent: {value: agent1},
lKMS-ID: {value: 123},
validLocation: {value: true}
}
{code}
I get this result
{code}
{
links : [ ],
resulttype : domainobject,
result : {
links : [ {
rel : self,
href :
http://localhost:8080/restful/objects/a1.ase.viewmodel.Address/PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPG1lbWVudG8-PGhvdXNlbnVtYmVyPjEyPC9ob3VzZW51bWJlcj48c3RyZWV0LmJvb2ttYXJrPmExLmFzZS52aWV3bW9kZWwuU3RyZWV0OlBEOTRiV3dnZG1WeWMybHZiajBpTVM0d0lpQmxibU52WkdsdVp6MGlWVlJHTFRnaVB6NEtQRzFsYldWdWRHOC1QSE4wY21WbGRHNWhiV1UtTlhSb0lFRjJaVzUxWlR3dmMzUnlaV1YwYm1GdFpUNDhMMjFsYldWdWRHOC08L3N0cmVldC5ib29rbWFyaz48L21lbWVudG8-;,
method : GET,
type :
application/json;profile=\urn:org.restfulobjects:repr-types/object\,
title : Address lkmsId:null
}, {
rel : describedby,
href :
[jira] [Comment Edited] (ISIS-899) Can't return a view model in Isis 1.6.0 over RO viewer.
[
https://issues.apache.org/jira/browse/ISIS-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153004#comment-14153004
]
Vladimir Nisevic edited comment on ISIS-899 at 9/30/14 9:23 AM:
Hi Jeroen, Dan. I've just tested my two ViewModel classes with latest master
version - I've put my code into todoapp-dom project and recompiled.
Restful viewer seems to work fine, but now I have an bug in wicket viewer!
Domain Service:
{code}
@Named(Address Search API)
@DomainService(menuOrder = 1.3)
public class AsePublicService {
@Render(Type.EAGERLY)
public Address getAddress(@Named(Source System) final String
sourceSystem, @Named(User) final String user, @Named(Agent) final String
agent, @Named(LKMS-ID) final String lkmsId, @Named(Valid Location) final
boolean validLocation) {
final Address address = new Address();
address.setHousenumber(12);
Street street = new Street();
street.setStreetname(5th Avenue);
address.setStreet(street);
return address;
}
{code}
Address Model:
{code}
package a1.ase.viewmodel;
import org.apache.isis.applib.annotation.MemberOrder;
import org.apache.isis.applib.annotation.ViewModel;
@ViewModel
public class Address {
public String title() {
return Address lkmsId: + lkmsId;
}
// {{ LkmsId (property)
private String lkmsId;
@MemberOrder(sequence = 1)
public String getLkmsId() {
return lkmsId;
}
public void setLkmsId(final String lkmsId) {
this.lkmsId = lkmsId;
}
// }}
// {{ Street (property)
private Street street;
@MemberOrder(sequence = 3)
public Street getStreet() {
return street;
}
public void setStreet(final Street street) {
this.street = street;
}
// }}
// {{ Housenumber (property)
private String housenumber;
@MemberOrder(sequence = 2)
public String getHousenumber() {
return housenumber;
}
public void setHousenumber(final String housenumber) {
this.housenumber = housenumber;
}
// }}
}
}
{code}
Street Model:
{code}
package a1.ase.viewmodel;
import org.apache.isis.applib.annotation.MemberOrder;
import org.apache.isis.applib.annotation.ViewModel;
@ViewModel
public class Street {
public String title() {
return Street lkmsId: + lkmsId;
}
// {{ LkmsId (property)
private String lkmsId;
@MemberOrder(sequence = 1)
public String getLkmsId() {
return lkmsId;
}
public void setLkmsId(final String lkmsId) {
this.lkmsId = lkmsId;
}
// }}
// {{ Streetname (property)
private String streetname;
@MemberOrder(sequence = 2)
public String getStreetname() {
return streetname;
}
public void setStreetname(final String aName) {
this.streetname = aName;
}
// }}
}
{code}
Here my feedback
1.) using wicket viewer and calling the method getAddress, I get next exception
{code}
Stack trace:
org.apache.isis.core.runtime.persistence.PojoRecreationException
Could not recreate pojo for oid oid
*a1.ase.viewmodel.Address:PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPG1lbWVudG8-PGhvdXNlbnVtYmVyPjEyPC9ob3VzZW51bWJlcj48c3RyZWV0LmJvb2ttYXJrPmExLmFzZS52aWV3bW9kZWwuU3RyZWV0OlBEOTRiV3dnZG1WeWMybHZiajBpTVM0d0lpQmxibU52WkdsdVp6MGlWVlJHTFRnaVB6NEtQRzFsYldWdWRHOC1QSE4wY21WbGRHNWhiV1UtTlhSb0lFRjJaVzUxWlR3dmMzUnlaV1YwYm1GdFpUNDhMMjFsYldWdWRHOC08L3N0cmVldC5ib29rbWFyaz48L21lbWVudG8-
org.apache.isis.core.runtime.persistence.adaptermanager.AdapterManagerDefault#adapterFor(AdapterManagerDefault.java:311)
org.apache.isis.viewer.wicket.model.mementos.ObjectAdapterMemento$Type$2#recreateAdapter(ObjectAdapterMemento.java:112)
org.apache.isis.viewer.wicket.model.mementos.ObjectAdapterMemento$Type#getAdapter(ObjectAdapterMemento.java:183)
org.apache.isis.viewer.wicket.model.m
{code}
2.) using restul viewer and calling
http://localhost:8080/restful/services/toDoItems/actions/newToDo/invoke with
parameters
{code}
{
sourceSystem: {value: CRM},
user: {value: user1},
agent: {value: agent1},
lKMS-ID: {value: 123},
validLocation: {value: true}
}
{code}
I get this result
{code}
{
links : [ ],
resulttype : domainobject,
result : {
links : [ {
rel : self,
href :
http://localhost:8080/restful/objects/a1.ase.viewmodel.Address/PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KPG1lbWVudG8-PGhvdXNlbnVtYmVyPjEyPC9ob3VzZW51bWJlcj48c3RyZWV0LmJvb2ttYXJrPmExLmFzZS52aWV3bW9kZWwuU3RyZWV0OlBEOTRiV3dnZG1WeWMybHZiajBpTVM0d0lpQmxibU52WkdsdVp6MGlWVlJHTFRnaVB6NEtQRzFsYldWdWRHOC1QSE4wY21WbGRHNWhiV1UtTlhSb0lFRjJaVzUxWlR3dmMzUnlaV1YwYm1GdFpUNDhMMjFsYldWdWRHOC08L3N0cmVldC5ib29rbWFyaz48L21lbWVudG8-;,
method : GET,
type :
application/json;profile=\urn:org.restfulobjects:repr-types/object\,
title : Address lkmsId:null
}, {
rel :
[jira] [Commented] (ISIS-789) Upgrade to DN 4.0
[ https://issues.apache.org/jira/browse/ISIS-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153150#comment-14153150 ] Marcel Baumann commented on ISIS-789: - It would be great to support DN 4.0. From the tests I did it is currently not possible to Java-8 due to ASM library version which does not support Java 8 class file format. Therefore we cannot use the current version of Java in academic projects or proof of concepts with ISIS. We are somewhat nervous to see that DN 4.0 support moved form 1.7 to 2.0 release. We would truly appreciate if support for DN 4.0 and Java 8 is scheduled for 2014. Upgrade to DN 4.0 - Key: ISIS-789 URL: https://issues.apache.org/jira/browse/ISIS-789 Project: Isis Issue Type: Improvement Components: Core: Objectstore: JDO Affects Versions: objectstore-jdo-1.4.1 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: core-2.0.0 NB: DN 4.0 only supports Java 7, so this is also dependent on our moving to Java 7 across board (see ISIS-568). NB: should also check ISIS-647 (fix for http://www.datanucleus.org/servlet/jira/browse/NUCCORE-1103). - will possibly want to enable to get better perf? NB: also know that there's a change to the way that polymorphism works, is mapped differently (in Estatio). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (ISIS-789) Upgrade to DN 4.0
[ https://issues.apache.org/jira/browse/ISIS-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153150#comment-14153150 ] Marcel Baumann edited comment on ISIS-789 at 9/30/14 1:22 PM: -- It would be great to support DN 4.0. From the tests I did it is currently not possible to use Java 8 due to the used ASM library which does not support Java 8 class file format. Therefore we cannot use the current version of Java in academic projects or proof of concepts with ISIS. We are somewhat nervous to see that DN 4.0 support moved form 1.7 to 2.0 release. We would truly appreciate if support for DN 4.0 and Java 8 is scheduled for 2014. was (Author: mbaumann): It would be great to support DN 4.0. From the tests I did it is currently not possible to Java-8 due to ASM library version which does not support Java 8 class file format. Therefore we cannot use the current version of Java in academic projects or proof of concepts with ISIS. We are somewhat nervous to see that DN 4.0 support moved form 1.7 to 2.0 release. We would truly appreciate if support for DN 4.0 and Java 8 is scheduled for 2014. Upgrade to DN 4.0 - Key: ISIS-789 URL: https://issues.apache.org/jira/browse/ISIS-789 Project: Isis Issue Type: Improvement Components: Core: Objectstore: JDO Affects Versions: objectstore-jdo-1.4.1 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: core-2.0.0 NB: DN 4.0 only supports Java 7, so this is also dependent on our moving to Java 7 across board (see ISIS-568). NB: should also check ISIS-647 (fix for http://www.datanucleus.org/servlet/jira/browse/NUCCORE-1103). - will possibly want to enable to get better perf? NB: also know that there's a change to the way that polymorphism works, is mapped differently (in Estatio). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-789) Upgrade to DN 4.0
[ https://issues.apache.org/jira/browse/ISIS-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153675#comment-14153675 ] Dan Haywood commented on ISIS-789: -- Hi Marcel, The upgrade to DN 4.0 will definitely happen; we recognize it's a blocker to anyone wanting to use Java 8 for their domain apps (we want to start using Java 8 for that purpose too). We moved DN 4.0 off the 1.7.0 release because (by request from others in the community) we are going to support Java 6 for one further release (there are some security fixes that it will require). I moved DN up to 2.0.0 just to move it up somewhere, but it didn't get too much consideration... it may well come back down to the 1.8.0 release. We are aware of one issue even in a newer release of the DN 3.x codebase, namely that it now maps certain polymorphic relationships differently. Not certain whether that was incorrect mapping in our domain app (Estatio) or an issue with DN, but since we had no immediate business reason to upgrade, we decided to defer the upgrade and stay on (what is now) quite an old version of DN. So, the move to DN 4.0 will need to address that issue for our app, and perhaps for others too. Thanks for taking the time to let us know that you want this; it helps us be responsive to the user community. Cheers Dan Upgrade to DN 4.0 - Key: ISIS-789 URL: https://issues.apache.org/jira/browse/ISIS-789 Project: Isis Issue Type: Improvement Components: Core: Objectstore: JDO Affects Versions: objectstore-jdo-1.4.1 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: core-2.0.0 NB: DN 4.0 only supports Java 7, so this is also dependent on our moving to Java 7 across board (see ISIS-568). NB: should also check ISIS-647 (fix for http://www.datanucleus.org/servlet/jira/browse/NUCCORE-1103). - will possibly want to enable to get better perf? NB: also know that there's a change to the way that polymorphism works, is mapped differently (in Estatio). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-789) Upgrade to DN 4.0
[ https://issues.apache.org/jira/browse/ISIS-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153687#comment-14153687 ] Martin Grigorov commented on ISIS-789: -- The problem with JMock (ISIS-568) looks like a blocker. I see there is a recent activity in the project but they do not rush to improve the state with the usage of usage old CGLIB/ASM. Upgrade to DN 4.0 - Key: ISIS-789 URL: https://issues.apache.org/jira/browse/ISIS-789 Project: Isis Issue Type: Improvement Components: Core: Objectstore: JDO Affects Versions: objectstore-jdo-1.4.1 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: core-2.0.0 NB: DN 4.0 only supports Java 7, so this is also dependent on our moving to Java 7 across board (see ISIS-568). NB: should also check ISIS-647 (fix for http://www.datanucleus.org/servlet/jira/browse/NUCCORE-1103). - will possibly want to enable to get better perf? NB: also know that there's a change to the way that polymorphism works, is mapped differently (in Estatio). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-568) Drop support for JDK 1.6, standardize on JDK 1.7.
[ https://issues.apache.org/jira/browse/ISIS-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153689#comment-14153689 ] Martin Grigorov commented on ISIS-568: -- Is switching to another mocking library an option ? E.g. https://code.google.com/p/mockito/. It is much better maintained - https://github.com/mockito/mockito/blob/master/doc/release-notes/official.md Drop support for JDK 1.6, standardize on JDK 1.7. - Key: ISIS-568 URL: https://issues.apache.org/jira/browse/ISIS-568 Project: Isis Issue Type: Improvement Components: Archetype: ToDoApp WRJ, Core, Core: Objectstore: JDO, Core: Viewer: RestfulObjects, Examples, Viewer: Wicket Affects Versions: archetype-wrj-1.0.3, viewer-wicket-1.2.0, viewer-restfulobjects-2.0.0, objectstore-jdo-1.1.0, core-1.2.0 Reporter: Dan Haywood Assignee: Dan Haywood Fix For: viewer-wicket-1.7.0, core-1.7.0 Discussion on mailing list: http://markmail.org/message/d66qufilwlluyguu -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-789) Upgrade to DN 4.0
[ https://issues.apache.org/jira/browse/ISIS-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153694#comment-14153694 ] Dan Haywood commented on ISIS-789: -- Not a blocker... I re-implemented Imposteriser to use Javassist, namely JavassistImposteriser [1] Looks like I co-opted ISIS-772 for this work [2] [1] https://github.com/apache/isis/blob/0af3219129076161143bd388e3fc3ec039cbed79/core/unittestsupport/src/main/java/org/apache/isis/core/unittestsupport/jmocking/JavassistImposteriser.java [2] https://issues.apache.org/jira/browse/ISIS-772 Upgrade to DN 4.0 - Key: ISIS-789 URL: https://issues.apache.org/jira/browse/ISIS-789 Project: Isis Issue Type: Improvement Components: Core: Objectstore: JDO Affects Versions: objectstore-jdo-1.4.1 Reporter: Dan Haywood Assignee: Dan Haywood Priority: Minor Fix For: core-2.0.0 NB: DN 4.0 only supports Java 7, so this is also dependent on our moving to Java 7 across board (see ISIS-568). NB: should also check ISIS-647 (fix for http://www.datanucleus.org/servlet/jira/browse/NUCCORE-1103). - will possibly want to enable to get better perf? NB: also know that there's a change to the way that polymorphism works, is mapped differently (in Estatio). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
