[jira] [Commented] (ISIS-1017) @PreDestroy annotated method is not called
[
https://issues.apache.org/jira/browse/ISIS-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304769#comment-14304769
]
Dan Haywood commented on ISIS-1017:
---
[~bruecp] - could you check 1.8.0-SNAPSHOT to see if this fixes the issue?
Also, in your comment you mentioned ElasticSearch. We currently have a ticket
[1] open to integrate Lucene. Was wondering if you've done any work in this
space that could either be shared, or at least add your design thoughts to that
ticket? Cheers, Dan
[1] https://issues.apache.org/jira/browse/ISIS-383
@PreDestroy annotated method is not called
--
Key: ISIS-1017
URL: https://issues.apache.org/jira/browse/ISIS-1017
Project: Isis
Issue Type: Bug
Components: Core
Affects Versions: core-1.7.0
Environment: Windows 7
Reporter: Peter Brückler
Assignee: Dan Haywood
Priority: Critical
Fix For: core-1.8.0
Attachments: Tracelog1_only_PostConstruct_called.txt,
Tracelog2_PostConstruct_and_PreDestroy_called_but_with_IsisWicketApplication_error.txt
When annotating the DomainService SimpleObjects with
...
@PostConstruct
@Programmatic
public void init() {
System.out.println( @PostConstruct init called );
}
@PreDestroy
@Programmatic
public void shutdown() {
System.out.println( @PreDestroy shutdown called );
}
...
only the @PostConstruct method will be called out of the box.
Unfortunately, the annotated @PreDestroy method not.
How to reproduce:
1) Checkout, build and check that Simpleapp 1.7.0 or 1.8.0-Snapshot is
running.
2) Introduce the mentioned @PostConstruct and @PreDestroy methods
an go sure, that a message will be logged when message is called.
3) build and deploy simpleapp-webapp.war to Tomcat v7.x or Tomcat v8.x
4) See log / use breakpoints to see that @PostConstruct method will be
successfully called.
15:40:18,311 [Schema Thread-2 DEBUG] Schema Transaction
closing with connection
org.datanucleus.store.rdbms.datasource.dbcp.PoolingDataSource$PoolGuardConnectionWrapper@74ce8acd
@PostConstruct init called
15:40:24,504 [Reflections Thread-2 INFO ] Reflections took 3181
ms to scan 125 urls, producing 9629 keys and 59986 values
5) Stop simpleapp-webapp or redeploy it or even stop tomcat
6) See log / breakpoints and realize that no @PreDestroy method was called.
Negativ side effect is, that every associated connection to JMS / Elastic
Search, ... in @PostConstruct cannot be disconnected easily and cleanly.
As a workaround I have tried to activate the section in web.xml:
!--
THE FOLLOWING CONFIGURATION IS NOT REQUIRED IF THE WICKET VIEWER IS IN
USE.
IF THE WICKET VIEWER CONFIGURATION IS REMOVED, THEN UNCOMMENT
--
listener
listener-classorg.apache.isis.core.webapp.IsisWebAppBootstrapper/listener-class
/listener
context-param
param-namedeploymentType/param-name
param-valueSERVER_EXPLORATION/param-value
/context-param
context-param
param-nameisis.viewers/param-name
param-valuerestfulobjects/param-value
/context-param
even this is not my scenario. Doing this the annotated methods gets called,
but I hit the IsisWicketApplication Error:
Failed to initialize
com.google.inject.ProvisionException: Guice provision errors:
1) Error in custom provider,
org.apache.isis.core.commons.exceptions.IsisException: Isis Context already
set up and cannot be replaced
at
org.apache.isis.core.runtime.runner.IsisInjectModule.provideIsisSystem(IsisInjectModule.java:132)
at
org.apache.isis.core.runtime.runner.IsisInjectModule.provideIsisSystem(IsisInjectModule.java:132)
while locating org.apache.isis.core.runtime.system.IsisSystem
for field at
org.apache.isis.viewer.wicket.viewer.IsisWicketApplication.system(IsisWicketApplication.java:140)
while locating webapp.SimpleApplication
The cool thing is, that this time both annotated method are called:
16:16:37,713 [Schema Thread-2 DEBUG] Schema Transaction
closing with connection
org.datanucleus.store.rdbms.datasource.dbcp.PoolingDataSource$PoolGuardConnectionWrapper@2339e31f
@PostConstruct init called
16:16:45,196 [Reflections Thread-2 INFO ] Reflections took 3259
ms to scan 125 urls, producing 9629 keys and 59986 values
...
INFORMATION: Cleaning up Shiro Environment
@PreDestroy shutdown called
16:16:53,198 [IsisContext main INFO ] closing all instances
16:16:53,198 [IsisWebAppBootstrapper main INFO ] server shut down
Please fix that issue or assist me in creating a workaround.
Thanks,
Peter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ISIS-1011) Select2 component doesn't filter the suggestions
[ https://issues.apache.org/jira/browse/ISIS-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14305178#comment-14305178 ] Martin Grigorov commented on ISIS-1011: --- There are several problems here. The problem is that it seems this is by design. E.g. https://github.com/apache/isis/blob/master/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/valuechoices/ValueChoicesSelect2Panel.java#L191 always returns all mementos. https://github.com/apache/isis/blob/master/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/reference/ReferencePanel.java#L416 does the same. And the problem is that we have a term (String) and a collection of ObjectAdapterMementos. It is not OK to use ObjectAdapterMemento#asString() because #asString() is not used for the rendering. For example: #asString() returns IsisSecurityApplicationRole:L_4, while we really need ApplicationRole#getName(). Select2 component doesn't filter the suggestions Key: ISIS-1011 URL: https://issues.apache.org/jira/browse/ISIS-1011 Project: Isis Issue Type: Bug Components: Viewer: Wicket Affects Versions: viewer-wicket-1.7.0 Reporter: Martin Grigorov Assignee: Martin Grigorov Priority: Minor Fix For: viewer-wicket-1.8.0 In Security module when trying to add a new package to a role if I type org the suggestions are not filtered. Additionally if I press ENTER with typed 'org' in the text field it still selects 'com' (because it is the first suggestion). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ISIS-1011) Select2 component doesn't filter the suggestions
[ https://issues.apache.org/jira/browse/ISIS-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov resolved ISIS-1011. --- Resolution: Fixed Select2 component doesn't filter the suggestions Key: ISIS-1011 URL: https://issues.apache.org/jira/browse/ISIS-1011 Project: Isis Issue Type: Bug Components: Viewer: Wicket Affects Versions: viewer-wicket-1.7.0 Reporter: Martin Grigorov Assignee: Martin Grigorov Priority: Minor Fix For: viewer-wicket-1.8.0 In Security module when trying to add a new package to a role if I type org the suggestions are not filtered. Additionally if I press ENTER with typed 'org' in the text field it still selects 'com' (because it is the first suggestion). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-983) Embedded Neo4J support
[ https://issues.apache.org/jira/browse/ISIS-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306199#comment-14306199 ] ASF subversion and git services commented on ISIS-983: -- Commit e4f77b6f975eb61e833aab9502dd249be9eb7630 in isis's branch refs/heads/master from [~danhaywood] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=e4f77b6 ] ISIS-983: comment out the fixture for the todoapp in isis.properties Embedded Neo4J support -- Key: ISIS-983 URL: https://issues.apache.org/jira/browse/ISIS-983 Project: Isis Issue Type: New Feature Components: Core Affects Versions: core-1.7.0, core-1.8.0 Reporter: Jeremy Branham Assignee: Dan Haywood Priority: Minor Labels: feature Fix For: core-1.8.0 Original Estimate: 1h Remaining Estimate: 1h -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: @PostsPropertyChangedEvent no longer working on latest SNAPSHOT
Hi Oscar, finally got around to looking at this. It's true, there were situations where @PostsPropertyChangedEvent might not fire. Even so, you should consider updating to using @Property(domainEvent=...), as this provides much richer support, for vetoing etc... see the ToDoItemSubscriptions class for an example [2] I've also updated the website [1] Cheers Dan [1] http://isis.apache.org/reference/services/event-bus-service.html http://isis.apache.org/reference/services/event-bus-service.html [2] https://github.com/apache/isis/blob/e37a6faa41ac7b791b57f2b3b5cbd9501615eaa8/example/application/todoapp/dom/src/main/java/dom/todo/ToDoItemSubscriptions.java#L243 On 10 January 2015 at 13:59, GESCONSULTOR - Óscar Bou o@gesconsultor.com wrote: Hi all. I’m testing against latest 1.8.0-SNAPSHOT and seems that @PostsPropertyChangedEvent support has been removed. In order to make it work again, it’s enough to just use the @PropertyInteraction annotation instead, passing the Event class to it (same way the @PostsPropertyChangedEvent worked). I think support for this is going to be included also on the new @Property annotation currently developing, but after that the current website might be updated [1]. HTH, Oscar [1] http://isis.apache.org/reference/services/event-bus-service.html http://isis.apache.org/reference/services/event-bus-service.html
[jira] [Created] (ISIS-1026) Upgrade jetty-console-maven-plugin to 1.56
Jörg Rade created ISIS-1026: --- Summary: Upgrade jetty-console-maven-plugin to 1.56 Key: ISIS-1026 URL: https://issues.apache.org/jira/browse/ISIS-1026 Project: Isis Issue Type: Improvement Components: Website/Other Environment: Java 8 Reporter: Jörg Rade Assignee: Dan Haywood Priority: Trivial Hi, I saw the comment in the (generated) pom.xml - for me (I'm on Java 8) 1.56 works and is ~50% faster in the build. Best regards Jörg [1] http://search.maven.org/#artifactdetails|org.simplericity.jettyconsole|jetty-console-maven-plugin|1.56|maven-plugin -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ISIS-1011) Select2 component doesn't filter the suggestions
[ https://issues.apache.org/jira/browse/ISIS-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14305231#comment-14305231 ] ASF subversion and git services commented on ISIS-1011: --- Commit 2c288581a506cc138df0ff9e53c3ab3ab948b0bd in isis's branch refs/heads/master from [~mgrigorov] [ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=2c28858 ] ISIS-1011 Filter list of ObjectAdapterMementos against a String term by using their titleString() Select2 component doesn't filter the suggestions Key: ISIS-1011 URL: https://issues.apache.org/jira/browse/ISIS-1011 Project: Isis Issue Type: Bug Components: Viewer: Wicket Affects Versions: viewer-wicket-1.7.0 Reporter: Martin Grigorov Assignee: Martin Grigorov Priority: Minor Fix For: viewer-wicket-1.8.0 In Security module when trying to add a new package to a role if I type org the suggestions are not filtered. Additionally if I press ENTER with typed 'org' in the text field it still selects 'com' (because it is the first suggestion). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jira] [Commented] (ISIS-1011) Select2 component doesn't filter the suggestions
Martin... dunno if it helps, but you could get a string representation by objectAdapterMemento.getObjectAdapter().titleString() or something similar, ie the TitleFacet of the underlying ObjectAdapter. On 4 February 2015 at 14:45, Martin Grigorov (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/ISIS-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14305178#comment-14305178 ] Martin Grigorov commented on ISIS-1011: --- There are several problems here. The problem is that it seems this is by design. E.g. https://github.com/apache/isis/blob/master/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/valuechoices/ValueChoicesSelect2Panel.java#L191 always returns all mementos. https://github.com/apache/isis/blob/master/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/reference/ReferencePanel.java#L416 does the same. And the problem is that we have a term (String) and a collection of ObjectAdapterMementos. It is not OK to use ObjectAdapterMemento#asString() because #asString() is not used for the rendering. For example: #asString() returns IsisSecurityApplicationRole:L_4, while we really need ApplicationRole#getName(). Select2 component doesn't filter the suggestions Key: ISIS-1011 URL: https://issues.apache.org/jira/browse/ISIS-1011 Project: Isis Issue Type: Bug Components: Viewer: Wicket Affects Versions: viewer-wicket-1.7.0 Reporter: Martin Grigorov Assignee: Martin Grigorov Priority: Minor Fix For: viewer-wicket-1.8.0 In Security module when trying to add a new package to a role if I type org the suggestions are not filtered. Additionally if I press ENTER with typed 'org' in the text field it still selects 'com' (because it is the first suggestion). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ISIS-1026) Upgrade jetty-console-maven-plugin to 1.56
[ https://issues.apache.org/jira/browse/ISIS-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jörg Rade updated ISIS-1026: Environment: Java 8 Maven 3.2.5 Eclipse 4.3.2 m2eclipse 1.5.0.20140606-0033 was:Java 8 Upgrade jetty-console-maven-plugin to 1.56 -- Key: ISIS-1026 URL: https://issues.apache.org/jira/browse/ISIS-1026 Project: Isis Issue Type: Improvement Components: Website/Other Environment: Java 8 Maven 3.2.5 Eclipse 4.3.2 m2eclipse 1.5.0.20140606-0033 Reporter: Jörg Rade Assignee: Dan Haywood Priority: Trivial Hi, I saw the comment in the (generated) pom.xml - for me (I'm on Java 8) 1.56 works and is ~50% faster in the build. Best regards Jörg [1] http://search.maven.org/#artifactdetails|org.simplericity.jettyconsole|jetty-console-maven-plugin|1.56|maven-plugin -- This message was sent by Atlassian JIRA (v6.3.4#6332)
